189844 2018-09-21 11:56:41 -0700 [GTK] ANGLE's eglplatform.h does not support Wayland-only builds 2022-03-30 12:45:12 -0700 1 1 1 Unclassified WebKit ANGLE Other Unspecified Unspecified RESOLVED FIXED https://bugs.chromium.org/p/angleproject/issues/detail?id=2839 InRadar P2 Normal --- 1 aperez aperez achristensen clopez commit-queue dino ews-watchlist graouts graouts kondapallykalyan mcatanzaro psaavedra webkit-bug-importer zan oldest_to_newest 1461976 0 aperez 2018-09-21 11:56:41 -0700 The latest ANGLE update (from r225340) is causing another instance of bug #163482 The upstream maintainers decided to apply their own version of the patch that I had attached in the upstream bug, which lacks one of the hunks from the patch I had uploaded. This is the upstream bug report: https://bugs.chromium.org/p/angleproject/issues/detail?id=2105 The missing bits *are* needed, so let's re-add them. I will give it a try to have also the changes upstream later on. 1461983 1 350399 aperez 2018-09-21 12:11:12 -0700 Created attachment 350399 Patch 1461985 2 ews-watchlist 2018-09-21 12:13:37 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1461986 3 aperez 2018-09-21 12:14:22 -0700 JFTR, I have successfully tested this using Buildroot to compile an image for the RaspberryPi 3 configured with Wayland, no X11, and WebKitGTK+ (both “trunk” and 2.22.1 — the patch applies cleanly on the stable release). 1461990 4 350399 mcatanzaro 2018-09-21 12:20:53 -0700 Comment on attachment 350399 Patch r=me provided you try again to upstream this. 1462021 5 350399 commit-queue 2018-09-21 13:00:02 -0700 Comment on attachment 350399 Patch Clearing flags on attachment: 350399 Committed r236349: <https://trac.webkit.org/changeset/236349> 1462022 6 commit-queue 2018-09-21 13:00:04 -0700 All reviewed patches have been landed. Closing bug. 1462025 7 webkit-bug-importer 2018-09-21 13:01:58 -0700 <rdar://problem/44689720> 1462340 8 aperez 2018-09-22 02:32:41 -0700 (In reply to Michael Catanzaro from comment #4) > Comment on attachment 350399 [details] > Patch > > r=me provided you try again to upstream this. Indeed! I had opened an issue upstream, but forgot to mentioned it here: https://bugs.chromium.org/p/angleproject/issues/detail?id=2839 Let's see if this time upstream adopts the full patch instead of merging a half-baked version (which is what happened last time). 1856431 9 psaavedra 2022-03-30 10:10:44 -0700 This change is not longer there (not at least in WebKitGTK/WPEWebKit 2.36.0). I think that was removed by a later ANGLE new version rollout. 1856532 10 aperez 2022-03-30 12:45:12 -0700 (In reply to Pablo Saavedra from comment #9) > This change is not longer there (not at least in WebKitGTK/WPEWebKit > 2.36.0). I think that was removed by a later ANGLE new version rollout. Right, nowadays we define USE_SYSTEM_EGL for building ANGLE, which gets us the same net result without needing to maintain changes to ANGLE :) 350399 2018-09-21 12:11:12 -0700 2018-09-21 13:00:02 -0700 Patch bug-189844-20180921220819.patch text/plain 3301 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggM2EyYjFkYmFmZGNmNTBjNGRjOTlmYTU1YzgzMzNlYzY2Y2U2MjczMS4uZGY1YTQ1OGU0YTI3 MGE5NjNmZWNlM2E4ZDBjYThiYjBhOTJlZTI2YiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA5LTIxICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8 YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gQU5HTEUncyBlZ2xwbGF0Zm9ybS5o IGRvZXMgbm90IHN1cHBvcnQgV2F5bGFuZC1vbmx5IGJ1aWxkcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5ODQ0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBtYWtlcyBpdCBwb3NzaWJsZSB0byBi dWlsZCBXZWJLaXRHVEsrIGFmdGVyIHIyMjUzNDAgd2hlbiB0aGUKKyAgICAgICAgYnVpbGQgaXMg Y29uZmlndXJlZCB0byBzdXBwb3J0IG9ubHkgV2F5bGFuZCwgYW5kIHRoZSBYMTEgaGVhZGVycwor ICAgICAgICBhcmUgbm90IHByZXNlbnQuCisKKyAgICAgICAgKiBjaGFuZ2VzLmRpZmY6IFVwZGF0 ZWQuCisgICAgICAgICogaW5jbHVkZS9FR0wvZWdscGxhdGZvcm0uaDogSW5jbHVkZSB0aGUgWDEx IGhlYWRlcnMgb25seSB3aGVuCisgICAgICAgIEFOR0xFX1VTRV9YMTEgaXMgZGVmaW5lZCBhbmQs IGZvciBjb25zaXN0ZW5jeSB3aXRoIE1lc2EncyB2ZXJzaW9uCisgICAgICAgIG9mIHRoZSBoZWFk ZXIsIHdoZW4gTUVTQV9FR0xfTk9fWDExX0hFQURFUlMgaXMgbm90IGRlZmluZWQuCisKIDIwMTgt MDgtMjkgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1v dmUgZW1wdHkgZGlyZWN0b3JpZXMgZnJvbSBmcm9tIHN2bi53ZWJraXQub3JnIHJlcG9zaXRvcnkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2NoYW5nZXMuZGlmZiBiL1NvdXJj ZS9UaGlyZFBhcnR5L0FOR0xFL2NoYW5nZXMuZGlmZgppbmRleCBlYWNmZWU5ZGY1NjMxY2UxYjAy NDllODMzNWM5YjIzNTMxZTA0MGI1Li5jM2FmYjc5ZTUxYWFhZjZmZjRkZDU3OGY0NGRkNmZkYzlh N2NiZGUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9jaGFuZ2VzLmRpZmYK KysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvY2hhbmdlcy5kaWZmCkBAIC04MDc5LDMgKzgw NzksMzEgQEAgaW5kZXggMzMzNDQ4YmUzNDguLjQ3ZDE4MDkzYzk2IDEwMDY0NAogIAogIHR5cGVk ZWYgaW50cHRyX3QgRUdMTmF0aXZlRGlzcGxheVR5cGU7CiAgdHlwZWRlZiBpbnRwdHJfdCBFR0xO YXRpdmVXaW5kb3dUeXBlOworZGlmZiAtLWdpdCBhL2luY2x1ZGUvRUdML2VnbHBsYXRmb3JtLmgg Yi9pbmNsdWRlL0VHTC9lZ2xwbGF0Zm9ybS5oCitpbmRleCA0N2QxODA5M2M5Ni4uZTc4MTU2NDg5 MWQgMTAwNjQ0CistLS0gYS9pbmNsdWRlL0VHTC9lZ2xwbGF0Zm9ybS5oCisrKysgYi9pbmNsdWRl L0VHTC9lZ2xwbGF0Zm9ybS5oCitAQCAtMTE0LDYgKzExNCw4IEBAIHR5cGVkZWYgc3RydWN0IHds X2VnbF93aW5kb3cgKkVHTE5hdGl2ZVdpbmRvd1R5cGU7CisgCisgI2VsaWYgZGVmaW5lZChfX3Vu aXhfXykKKyAKKysjaWYgZGVmaW5lZChBTkdMRV9VU0VfWDExKSAmJiAhZGVmaW5lZChNRVNBX0VH TF9OT19YMTFfSEVBREVSUykKKysKKyAvKiBYMTEgKHRlbnRhdGl2ZSkgICovCisgI2luY2x1ZGUg PFgxMS9YbGliLmg+CisgI2luY2x1ZGUgPFgxMS9YdXRpbC5oPgorQEAgLTEyMiw2ICsxMjQsMTQg QEAgdHlwZWRlZiBEaXNwbGF5ICpFR0xOYXRpdmVEaXNwbGF5VHlwZTsKKyB0eXBlZGVmIFBpeG1h cCAgIEVHTE5hdGl2ZVBpeG1hcFR5cGU7CisgdHlwZWRlZiBXaW5kb3cgICBFR0xOYXRpdmVXaW5k b3dUeXBlOworIAorKyNlbHNlCisrCisrdHlwZWRlZiB2b2lkICAgICAgICAgICAgICpFR0xOYXRp dmVEaXNwbGF5VHlwZTsKKyt0eXBlZGVmIGtocm9ub3NfdWludHB0cl90IEVHTE5hdGl2ZVBpeG1h cFR5cGU7CisrdHlwZWRlZiBraHJvbm9zX3VpbnRwdHJfdCBFR0xOYXRpdmVXaW5kb3dUeXBlOwor KworKyNlbmRpZiAvKiBBTkdMRV9VU0VfWDExICYmICFNRVNBX0VHTF9OT19YMTFfSEVBREVSUyAq LworKworICNlbHNlCisgI2Vycm9yICJQbGF0Zm9ybSBub3QgcmVjb2duaXplZCIKKyAjZW5kaWYK ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2luY2x1ZGUvRUdML2VnbHBsYXRm b3JtLmggYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9pbmNsdWRlL0VHTC9lZ2xwbGF0Zm9ybS5o CmluZGV4IDQ3ZDE4MDkzYzk2NmUzNTI3MWEzMWFjZjFhMWU5YTRlMmRhMGY5N2QuLmU3ODE1NjQ4 OTFkZDlmOTg0NDc5NWE1ZWJlMmIxOTg4MWQ0OWNiZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGly ZFBhcnR5L0FOR0xFL2luY2x1ZGUvRUdML2VnbHBsYXRmb3JtLmgKKysrIGIvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvaW5jbHVkZS9FR0wvZWdscGxhdGZvcm0uaApAQCAtMTE0LDYgKzExNCw4IEBA IHR5cGVkZWYgc3RydWN0IHdsX2VnbF93aW5kb3cgKkVHTE5hdGl2ZVdpbmRvd1R5cGU7CiAKICNl bGlmIGRlZmluZWQoX191bml4X18pCiAKKyNpZiBkZWZpbmVkKEFOR0xFX1VTRV9YMTEpICYmICFk ZWZpbmVkKE1FU0FfRUdMX05PX1gxMV9IRUFERVJTKQorCiAvKiBYMTEgKHRlbnRhdGl2ZSkgICov CiAjaW5jbHVkZSA8WDExL1hsaWIuaD4KICNpbmNsdWRlIDxYMTEvWHV0aWwuaD4KQEAgLTEyMiw2 ICsxMjQsMTQgQEAgdHlwZWRlZiBEaXNwbGF5ICpFR0xOYXRpdmVEaXNwbGF5VHlwZTsKIHR5cGVk ZWYgUGl4bWFwICAgRUdMTmF0aXZlUGl4bWFwVHlwZTsKIHR5cGVkZWYgV2luZG93ICAgRUdMTmF0 aXZlV2luZG93VHlwZTsKIAorI2Vsc2UKKwordHlwZWRlZiB2b2lkICAgICAgICAgICAgICpFR0xO YXRpdmVEaXNwbGF5VHlwZTsKK3R5cGVkZWYga2hyb25vc191aW50cHRyX3QgRUdMTmF0aXZlUGl4 bWFwVHlwZTsKK3R5cGVkZWYga2hyb25vc191aW50cHRyX3QgRUdMTmF0aXZlV2luZG93VHlwZTsK KworI2VuZGlmIC8qIEFOR0xFX1VTRV9YMTEgJiYgIU1FU0FfRUdMX05PX1gxMV9IRUFERVJTICov CisKICNlbHNlCiAjZXJyb3IgIlBsYXRmb3JtIG5vdCByZWNvZ25pemVkIgogI2VuZGlmCg==