18984 2008-05-10 03:16:40 -0700 [GTK] textarea height property works only if other property are defined 2009-07-07 08:53:10 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 0 a.renevier webkit-unassigned jmalonzo plaes oldest_to_newest 80059 0 a.renevier 2008-05-10 03:16:40 -0700 Hi, When you set height property to a textarea, it is not taken into account. To make height property work, you must set other properties, such as border, or background-color. 80060 1 21055 a.renevier 2008-05-10 03:17:50 -0700 Created attachment 21055 testcase 80064 2 krit 2008-05-10 03:58:55 -0700 The same here. But it is only related to WebKitGtk. Changed the report. 130210 3 32378 jmalonzo 2009-07-07 08:18:22 -0700 Created attachment 32378 patch 130213 4 32378 gustavo 2009-07-07 08:35:12 -0700 Comment on attachment 32378 patch Thanks for looking into this! It makes me sad =). I believe leaving this for webcore to do is not really what we want; we probably want to do the same as adjustTextFieldStyle, except for setting the height to auto. I'll say r- on that basis. 130218 5 32378 gustavo 2009-07-07 08:44:16 -0700 Comment on attachment 32378 patch After clarifying a few concerns with Jan regarding the effect this had in things such as dark themes, I now believe this is correct, so I'll say r=me. 130220 6 jmalonzo 2009-07-07 08:53:10 -0700 (In reply to comment #5) > (From update of attachment 32378 [details]) > After clarifying a few concerns with Jan regarding the effect this had in > things such as dark themes, I now believe this is correct, so I'll say r=me. Thanks. Landed in r45595. 21055 2008-05-10 03:17:50 -0700 2008-05-10 03:17:50 -0700 testcase 18984.html text/html 309 a.renevier PGJvZHk+Cjx0ZXh0YXJlYSBpZD0ib25lIiBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjogcmVkOyBo ZWlnaHQ6IDEwMHB4Ij5iYWNrZ3JvdW5kLWNvbG9yOiByZWQ7IGhlaWdodDogMTAwcHg8L3RleHRh cmVhPgo8dGV4dGFyZWEgaWQ9Im9uZSIgc3R5bGU9ImJvcmRlcjogMXB4IHNvbGlkIGdyZWVuOyBo ZWlnaHQ6IDEwMHB4Ij5ib3JkZXI6IDFweCBzb2xpZCBncmVlbjsgaGVpZ2h0OiAxMDBweDwvdGV4 dGFyZWE+Cjx0ZXh0YXJlYSBpZD0idHdvIiBzdHlsZT0iaGVpZ2h0OiAxMDBweCI+aGVpZ2h0OiAx MDBweDwvdGV4dGFyZWE+CjwvYm9keT4K 32378 2009-07-07 08:18:22 -0700 2009-07-07 08:44:16 -0700 patch textareafix.patch text/plain 3266 jmalonzo ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4YmE0NDJkLi4yMDJmNjE3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDct MDcgIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR1RLXSB0ZXh0YXJlYSBoZWln aHQgcHJvcGVydHkgd29ya3Mgb25seSBpZiBvdGhlciBwcm9wZXJ0eSBhcmUgZGVmaW5lZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5ODQKKworICAg ICAgICBMZXQgV2ViQ29yZSBoYW5kbGUgdGV4dGFyZWEncyBtZXRyaWNzIGluc3RlYWQgb2YgcmVh ZGp1c3RpbmcgaXQgUmVuZGVydGhlbWVHdGsuCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jtcy90 ZXh0YXJlYS1tZXRyaWNzLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOgor CiAyMDA5LTA3LTA3ICBCZW4gTXVyZG9jaCAgPGJlbm1AZ29vZ2xlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2d0ay9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKaW5kZXgg MjM5YjhmMy4uZjIxNjQ3MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Nr aXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKQEAgLTE3ODYsNyAr MTc4Niw2IEBAIGZhc3QvZm9ybXMvc2xpZGVyLXRyYW5zZm9ybWVkLmh0bWwKIGZhc3QvZm9ybXMv c2xpZGVyLXpvb21lZC5odG1sCiBmYXN0L2Zvcm1zL3RleHQtY29udHJvbC1pbnRyaW5zaWMtd2lk dGhzLmh0bWwKIGZhc3QvZm9ybXMvdGV4dGFyZWEtaW5wdXQtZXZlbnQuaHRtbAotZmFzdC9mb3Jt cy90ZXh0YXJlYS1tZXRyaWNzLmh0bWwKIGZhc3QvZm9ybXMvdGV4dGFyZWEtcGFzdGUtbmV3bGlu ZS5odG1sCiBmYXN0L2Zvcm1zL3RleHRhcmVhLXNjcm9sbGJhci1oZWlnaHQuaHRtbAogZmFzdC9m b3Jtcy90ZXh0YXJlYS1zY3JvbGxlZC1lbmRsaW5lLWNhcmV0Lmh0bWwKZGlmZiAtLWdpdCBhL1dl YkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGQ5NzE1Yi4uNzgyMWJm OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNy0wNyAgSmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9u em9Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBHVEtdIHRleHRhcmVhIGhlaWdodCBwcm9wZXJ0eSB3b3JrcyBvbmx5IGlmIG90aGVy IHByb3BlcnR5IGFyZSBkZWZpbmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODk4NAorCisgICAgICAgIExldCBXZWJDb3JlIGhhbmRsZSB0ZXh0YXJl YSdzIG1ldHJpY3MgaW5zdGVhZCBvZiByZWFkanVzdGluZyBpdCBSZW5kZXJ0aGVtZUd0ay4KKwor ICAgICAgICBUZXN0OiBmYXN0L2Zvcm1zL3RleHRhcmVhLW1ldHJpY3MuaHRtbAorCisgICAgICAg ICogcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9n dGsvUmVuZGVyVGhlbWVHdGsuaDoKKwogMjAwOS0wNy0wNyAgQmVuIE11cmRvY2ggIDxiZW5tQGdv b2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50dGkgS29pdmlzdG8uCmRpZmYgLS1n aXQgYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAgYi9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAKaW5kZXggMDk4NDk3Yy4uZmRlZjljMiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuY3BwCisrKyBiL1dl YkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcApAQCAtMzIwLDExICszMjAsNiBA QCBib29sIFJlbmRlclRoZW1lR3RrOjpwYWludFRleHRGaWVsZChSZW5kZXJPYmplY3QqIG8sIGNv bnN0IFJlbmRlck9iamVjdDo6UGFpbnRJbgogICAgIHJldHVybiBwYWludE1veldpZGdldCh0aGlz LCBNT1pfR1RLX0VOVFJZLCBvLCBpLCByZWN0KTsKIH0KIAotdm9pZCBSZW5kZXJUaGVtZUd0azo6 YWRqdXN0VGV4dEFyZWFTdHlsZShDU1NTdHlsZVNlbGVjdG9yKiBzZWxlY3RvciwgUmVuZGVyU3R5 bGUqIHN0eWxlLCBFbGVtZW50KiBlKSBjb25zdAotewotICAgIGFkanVzdFRleHRGaWVsZFN0eWxl KHNlbGVjdG9yLCBzdHlsZSwgZSk7Ci19Ci0KIGJvb2wgUmVuZGVyVGhlbWVHdGs6OnBhaW50VGV4 dEFyZWEoUmVuZGVyT2JqZWN0KiBvLCBjb25zdCBSZW5kZXJPYmplY3Q6OlBhaW50SW5mbyYgaSwg Y29uc3QgSW50UmVjdCYgcikKIHsKICAgICByZXR1cm4gcGFpbnRUZXh0RmllbGQobywgaSwgcik7 CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5oIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuaAppbmRleCA2NmY3YWUyLi4xM2RhYWEy IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5oCisrKyBi L1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmgKQEAgLTg5LDcgKzg5LDYgQEAg cHJvdGVjdGVkOgogICAgIHZpcnR1YWwgdm9pZCBhZGp1c3RUZXh0RmllbGRTdHlsZShDU1NTdHls ZVNlbGVjdG9yKiwgUmVuZGVyU3R5bGUqLCBFbGVtZW50KikgY29uc3Q7CiAgICAgdmlydHVhbCBi b29sIHBhaW50VGV4dEZpZWxkKFJlbmRlck9iamVjdCosIGNvbnN0IFJlbmRlck9iamVjdDo6UGFp bnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwogCi0gICAgdmlydHVhbCB2b2lkIGFkanVzdFRleHRB cmVhU3R5bGUoQ1NTU3R5bGVTZWxlY3RvciosIFJlbmRlclN0eWxlKiwgRWxlbWVudCopIGNvbnN0 OwogICAgIHZpcnR1YWwgYm9vbCBwYWludFRleHRBcmVhKFJlbmRlck9iamVjdCosIGNvbnN0IFJl bmRlck9iamVjdDo6UGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpOwogCiAgICAgdmlydHVhbCB2 b2lkIGFkanVzdE1lbnVMaXN0U3R5bGUoQ1NTU3R5bGVTZWxlY3RvciosIFJlbmRlclN0eWxlKiwg RWxlbWVudCopIGNvbnN0Owo=