189832 2018-09-21 08:25:35 -0700 Whitelist two additional plugins 2018-09-21 09:41:22 -0700 1 1 1 Unclassified WebKit Plug-ins WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf bfulgham commit-queue webkit-bug-importer oldest_to_newest 1461853 0 youennf 2018-09-21 08:25:35 -0700 Whitelist two additional plugins 1461854 1 youennf 2018-09-21 08:26:04 -0700 <rdar://problem/44628127> 1461855 2 350365 youennf 2018-09-21 08:27:57 -0700 Created attachment 350365 Patch 1461862 3 350368 youennf 2018-09-21 08:50:15 -0700 Created attachment 350368 Patch 1461870 4 350368 bfulgham 2018-09-21 08:59:20 -0700 Comment on attachment 350368 Patch r=me 1461871 5 350368 bfulgham 2018-09-21 08:59:56 -0700 Comment on attachment 350368 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350368&action=review > Source/WebKit/UIProcess/Plugins/mac/PluginInfoStoreMac.mm:98 > + || pluginBundleIdentifier == "com.cfca.npSecEditCtl.MAC.BOCO"_s Weird that they have two nearly identical names. Is one an older version? 1461874 6 youennf 2018-09-21 09:13:58 -0700 (In reply to Brent Fulgham from comment #5) > Comment on attachment 350368 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=350368&action=review > > > Source/WebKit/UIProcess/Plugins/mac/PluginInfoStoreMac.mm:98 > > + || pluginBundleIdentifier == "com.cfca.npSecEditCtl.MAC.BOCO"_s > > Weird that they have two nearly identical names. Is one an older version? Yep, several of these plugins are probably the same plugin, rebranded with various ids, like cfca.com.npCryptoKit. 1461890 7 350368 commit-queue 2018-09-21 09:41:21 -0700 Comment on attachment 350368 Patch Clearing flags on attachment: 350368 Committed r236322: <https://trac.webkit.org/changeset/236322> 1461891 8 commit-queue 2018-09-21 09:41:22 -0700 All reviewed patches have been landed. Closing bug. 350365 2018-09-21 08:27:57 -0700 2018-09-21 08:50:14 -0700 Patch bug-189832-20180921082756.patch text/plain 2259 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRkNzE3YTJlYjg2ODgwNTM2 Mzk1NmM5NDZiYWIwMGZkMTE4ZWNkMjYuLmUzNzlmNmUwOGMxNWM4YTUwYzc4N2UzMTU1NjMwM2Yw ZTNlNjgwZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDktMjEgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFdoaXRlbGlzdCB0d28gYWRkaXRp b25hbCBwbHVnaW5zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODk4MzIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ0NjI4MTI3PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1BsdWdp bnMvbWFjL1BsdWdpbkluZm9TdG9yZU1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6UGx1Z2luSW5m b1N0b3JlOjpzaG91bGRBbGxvd1BsdWdpblRvUnVuVW5zYW5kYm94ZWQpOgorCiAyMDE4LTA5LTIw ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHIyMzYyODkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9QbHVnaW5zL21hYy9QbHVnaW5JbmZvU3RvcmVNYWMubW0gYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9QbHVnaW5zL21hYy9QbHVnaW5JbmZvU3RvcmVNYWMubW0KaW5kZXggYzJhMzY5ZmYw ZjJjNjM1NTQ4MDI5NTcyNmY3MmU3ZmY5Y2IxZDkxNi4uNWVhOGRmNmZiYjc3ZDM5Y2U0NWFlMWQ5 N2M5ZDZkN2E5NDNmZmUzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUGx1 Z2lucy9tYWMvUGx1Z2luSW5mb1N0b3JlTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1BsdWdpbnMvbWFjL1BsdWdpbkluZm9TdG9yZU1hYy5tbQpAQCAtOTUsMTMgKzk1LDE1IEBA IGJvb2wgUGx1Z2luSW5mb1N0b3JlOjpzaG91bGRBbGxvd1BsdWdpblRvUnVuVW5zYW5kYm94ZWQo Y29uc3QgU3RyaW5nJiBwbHVnaW5CdW5kCiAgICAgICAgIHx8IHBsdWdpbkJ1bmRsZUlkZW50aWZp ZXIgPT0gImNvbS5hcHBsZS5Cb2NvbVN1Ym1pdEN0cmwiX3MKICAgICAgICAgfHwgcGx1Z2luQnVu ZGxlSWRlbnRpZmllciA9PSAiY29tLmZ0c2FmZS5OUEFQSS1Db3JlLVNhZmUtU29mdEtleWJhb3Jk LnBsdWdpbi5yZmMxMDM0aWRlbnRpZmllciJfcwogICAgICAgICB8fCBwbHVnaW5CdW5kbGVJZGVu dGlmaWVyID09ICJjb20uY2ZjYS5ucFNlY0VkaXRDdGwuTUFDLkJPQy5wbHVnaW4iX3MKKyAgICAg ICAgfHwgcGx1Z2luQnVuZGxlSWRlbnRpZmllciA9PSAiY29tLmNmY2EubnBTZWNFZGl0Q3RsLk1B Qy5CT0NPIl9zOwogICAgICAgICB8fCBwbHVnaW5CdW5kbGVJZGVudGlmaWVyID09ICJjZmNhLmNv bS5ucENyeXB0b0tpdC5NQUMuQk9DIl9zCiAgICAgICAgIHx8IHBsdWdpbkJ1bmRsZUlkZW50aWZp ZXIgPT0gImNmY2EuY29tLm5wUDExQ2VydEVucm9sbC5NQUMuQk9DIl9zCiAgICAgICAgIHx8IHBs dWdpbkJ1bmRsZUlkZW50aWZpZXIgPT0gImNmY2EuY29tLm5wQ3J5cHRvS2l0LlVuaW9uUGF5Lk1B QyJfcwogICAgICAgICB8fCBwbHVnaW5CdW5kbGVJZGVudGlmaWVyID09ICJjZmNhLmNvbS5ucFAx MUNlcnRFbnJvbGwuTUFDLlVuaW9uUGF5Il9zCiAgICAgICAgIHx8IHBsdWdpbkJ1bmRsZUlkZW50 aWZpZXIgPT0gIkJvY29tLm5ldHNpZ25wbHVnaW4iX3MKICAgICAgICAgfHwgcGx1Z2luQnVuZGxl SWRlbnRpZmllciA9PSAiY2ZjYS5jb20ubnBQMTFDZXJ0RW5yb2xsLk1BQy5DR0IiX3MKLSAgICAg ICAgfHwgcGx1Z2luQnVuZGxlSWRlbnRpZmllciA9PSAiY2ZjYS5jb20ubnBDcnlwdG9LaXQuQ0dC Lk1BQyJfczsKKyAgICAgICAgfHwgcGx1Z2luQnVuZGxlSWRlbnRpZmllciA9PSAiY2ZjYS5jb20u bnBDcnlwdG9LaXQuQ0dCLk1BQyJfcworICAgICAgICB8fCBwbHVnaW5CdW5kbGVJZGVudGlmaWVy ID09ICJtdy5pY2JjLXNhZmFyaS1NVyJfcwogfQogCiBib29sIFBsdWdpbkluZm9TdG9yZTo6c2hv dWxkVXNlUGx1Z2luKFZlY3RvcjxQbHVnaW5Nb2R1bGVJbmZvPiYgYWxyZWFkeUxvYWRlZFBsdWdp bnMsIGNvbnN0IFBsdWdpbk1vZHVsZUluZm8mIHBsdWdpbikK 350368 2018-09-21 08:50:15 -0700 2018-09-21 09:41:21 -0700 Patch bug-189832-20180921085015.patch text/plain 2259 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRkNzE3YTJlYjg2ODgwNTM2 Mzk1NmM5NDZiYWIwMGZkMTE4ZWNkMjYuLmUzNzlmNmUwOGMxNWM4YTUwYzc4N2UzMTU1NjMwM2Yw ZTNlNjgwZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDktMjEgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFdoaXRlbGlzdCB0d28gYWRkaXRp b25hbCBwbHVnaW5zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODk4MzIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ0NjI4MTI3PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1BsdWdp bnMvbWFjL1BsdWdpbkluZm9TdG9yZU1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6UGx1Z2luSW5m b1N0b3JlOjpzaG91bGRBbGxvd1BsdWdpblRvUnVuVW5zYW5kYm94ZWQpOgorCiAyMDE4LTA5LTIw ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHIyMzYyODkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9QbHVnaW5zL21hYy9QbHVnaW5JbmZvU3RvcmVNYWMubW0gYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9QbHVnaW5zL21hYy9QbHVnaW5JbmZvU3RvcmVNYWMubW0KaW5kZXggYzJhMzY5ZmYw ZjJjNjM1NTQ4MDI5NTcyNmY3MmU3ZmY5Y2IxZDkxNi4uYTI3MTNlNTJhYzQxZGQ4MzAwNzVjMDA3 ZjRlYWUyYzBjYjQ1NTcxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUGx1 Z2lucy9tYWMvUGx1Z2luSW5mb1N0b3JlTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1BsdWdpbnMvbWFjL1BsdWdpbkluZm9TdG9yZU1hYy5tbQpAQCAtOTUsMTMgKzk1LDE1IEBA IGJvb2wgUGx1Z2luSW5mb1N0b3JlOjpzaG91bGRBbGxvd1BsdWdpblRvUnVuVW5zYW5kYm94ZWQo Y29uc3QgU3RyaW5nJiBwbHVnaW5CdW5kCiAgICAgICAgIHx8IHBsdWdpbkJ1bmRsZUlkZW50aWZp ZXIgPT0gImNvbS5hcHBsZS5Cb2NvbVN1Ym1pdEN0cmwiX3MKICAgICAgICAgfHwgcGx1Z2luQnVu ZGxlSWRlbnRpZmllciA9PSAiY29tLmZ0c2FmZS5OUEFQSS1Db3JlLVNhZmUtU29mdEtleWJhb3Jk LnBsdWdpbi5yZmMxMDM0aWRlbnRpZmllciJfcwogICAgICAgICB8fCBwbHVnaW5CdW5kbGVJZGVu dGlmaWVyID09ICJjb20uY2ZjYS5ucFNlY0VkaXRDdGwuTUFDLkJPQy5wbHVnaW4iX3MKKyAgICAg ICAgfHwgcGx1Z2luQnVuZGxlSWRlbnRpZmllciA9PSAiY29tLmNmY2EubnBTZWNFZGl0Q3RsLk1B Qy5CT0NPIl9zCiAgICAgICAgIHx8IHBsdWdpbkJ1bmRsZUlkZW50aWZpZXIgPT0gImNmY2EuY29t Lm5wQ3J5cHRvS2l0Lk1BQy5CT0MiX3MKICAgICAgICAgfHwgcGx1Z2luQnVuZGxlSWRlbnRpZmll ciA9PSAiY2ZjYS5jb20ubnBQMTFDZXJ0RW5yb2xsLk1BQy5CT0MiX3MKICAgICAgICAgfHwgcGx1 Z2luQnVuZGxlSWRlbnRpZmllciA9PSAiY2ZjYS5jb20ubnBDcnlwdG9LaXQuVW5pb25QYXkuTUFD Il9zCiAgICAgICAgIHx8IHBsdWdpbkJ1bmRsZUlkZW50aWZpZXIgPT0gImNmY2EuY29tLm5wUDEx Q2VydEVucm9sbC5NQUMuVW5pb25QYXkiX3MKICAgICAgICAgfHwgcGx1Z2luQnVuZGxlSWRlbnRp ZmllciA9PSAiQm9jb20ubmV0c2lnbnBsdWdpbiJfcwogICAgICAgICB8fCBwbHVnaW5CdW5kbGVJ ZGVudGlmaWVyID09ICJjZmNhLmNvbS5ucFAxMUNlcnRFbnJvbGwuTUFDLkNHQiJfcwotICAgICAg ICB8fCBwbHVnaW5CdW5kbGVJZGVudGlmaWVyID09ICJjZmNhLmNvbS5ucENyeXB0b0tpdC5DR0Iu TUFDIl9zOworICAgICAgICB8fCBwbHVnaW5CdW5kbGVJZGVudGlmaWVyID09ICJjZmNhLmNvbS5u cENyeXB0b0tpdC5DR0IuTUFDIl9zCisgICAgICAgIHx8IHBsdWdpbkJ1bmRsZUlkZW50aWZpZXIg PT0gIm13LmljYmMtc2FmYXJpLU1XIl9zOwogfQogCiBib29sIFBsdWdpbkluZm9TdG9yZTo6c2hv dWxkVXNlUGx1Z2luKFZlY3RvcjxQbHVnaW5Nb2R1bGVJbmZvPiYgYWxyZWFkeUxvYWRlZFBsdWdp bnMsIGNvbnN0IFBsdWdpbk1vZHVsZUluZm8mIHBsdWdpbikK