189831 2018-09-21 07:25:55 -0700 [ARM] Build broken on armv7hl after r235517 2018-09-21 07:36:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tpopela tpopela ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1461833 0 tpopela 2018-09-21 07:25:55 -0700 It's broken because of the missing implementation of patchableBranch8(). Fro ARMV7 it was added by Mark in https://trac.webkit.org/r235557, but the implementation for traditional ARM is still missing. 1461834 1 350359 tpopela 2018-09-21 07:27:32 -0700 Created attachment 350359 Patch 1461837 2 350359 ysuzuki 2018-09-21 07:30:42 -0700 Comment on attachment 350359 Patch r=me as a build fix. 1461839 3 350359 tpopela 2018-09-21 07:35:45 -0700 Comment on attachment 350359 Patch Clearing flags on attachment: 350359 Committed r236315: <https://trac.webkit.org/changeset/236315> 1461840 4 tpopela 2018-09-21 07:35:50 -0700 All reviewed patches have been landed. Closing bug. 1461841 5 webkit-bug-importer 2018-09-21 07:36:20 -0700 <rdar://problem/44679245> 350359 2018-09-21 07:27:32 -0700 2018-09-21 07:35:45 -0700 Patch bug-189831-20180921162730.patch text/plain 1780 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MjQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy MWY1OTA5MWM1NTY1NzdmMmM4ZDYyOTJjMmU2YmRkN2UyZjA3MzUwLi44MGUwNDcxYWFlMjczYWU4 ODhkNDU4MGNhYTUyZThhMTBhNGUzMGYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0wOS0yMSAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29t PgorCisgICAgICAgIFtBUk1dIEJ1aWxkIGJyb2tlbiBvbiBhcm12N2hsIGFmdGVyIHIyMzU1MTcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTgzMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBtaXNz aW5nIGltcGxlbWVudGF0aW9uIG9mIHBhdGNoZWJsZUJyYW5jaDgoKSBmb3IgdHJhZGl0aW9uYWwg QVJNLgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmg6CisgICAgICAg IChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjpwYXRjaGFibGVCcmFuY2g4KToKKwogMjAxOC0wOS0y MCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBb V2luXVtDbGFuZ10gSklUTWF0aElDLmg6IGVycm9yOiBtaXNzaW5nICd0ZW1wbGF0ZScga2V5d29y ZCBwcmlvciB0byBkZXBlbmRlbnQgdGVtcGxhdGUgbmFtZSAncmV0YWdnZWQnCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmggYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKaW5kZXgg MjY2YTgxOGY1NzA5NDNiNGNkOWZmNWQzZTBjY2YyZWUyYTZhOTAxOC4uZmE0ZGY1MTczNGE2ZDgx ODljODMwZTc1MDM2Y2IwYjczYWM1ZjlmZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaApAQCAtOTgxLDYgKzk4MSwxMyBAQCBw dWJsaWM6CiAgICAgICAgIHJldHVybiBQYXRjaGFibGVKdW1wKG1fYXNzZW1ibGVyLmptcChBUk1B c3NlbWJsZXI6OkFMLCAxKSk7CiAgICAgfQogCisgICAgUGF0Y2hhYmxlSnVtcCBwYXRjaGFibGVC cmFuY2g4KFJlbGF0aW9uYWxDb25kaXRpb24gY29uZCwgQWRkcmVzcyBhZGRyZXNzLCBUcnVzdGVk SW1tMzIgaW1tKQorICAgIHsKKyAgICAgICAgVHJ1c3RlZEltbTMyIGltbTggPSBNYWNyb0Fzc2Vt YmxlckhlbHBlcnM6Om1hc2s4T25Db25kaXRpb24oKnRoaXMsIGNvbmQsIGltbSk7CisgICAgICAg IE1hY3JvQXNzZW1ibGVySGVscGVyczo6bG9hZDhPbkNvbmRpdGlvbigqdGhpcywgY29uZCwgYWRk cmVzcywgZGF0YVRlbXBSZWdpc3Rlcik7CisgICAgICAgIHJldHVybiBwYXRjaGFibGVCcmFuY2gz Mihjb25kLCBkYXRhVGVtcFJlZ2lzdGVyLCBpbW04KTsKKyAgICB9CisKICAgICBQYXRjaGFibGVK dW1wIHBhdGNoYWJsZUJyYW5jaDMyKFJlbGF0aW9uYWxDb25kaXRpb24gY29uZCwgUmVnaXN0ZXJJ RCByZWcsIFRydXN0ZWRJbW0zMiBpbW0pCiAgICAgewogICAgICAgICBpbnRlcm5hbENvbXBhcmUz MihyZWcsIGltbSk7Cg==