<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>189823</bug_id>
          
          <creation_ts>2018-09-21 03:09:42 -0700</creation_ts>
          <short_desc>TransformationMatrix::toColumnMajorFloatArray() should return a std::array&lt;&gt; object</short_desc>
          <delta_ts>2018-09-21 05:48:23 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zan Dobersek">zan</reporter>
          <assigned_to name="Zan Dobersek">zan</assigned_to>
          <cc>cmarcelo</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>luiz</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>noam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1461778</commentid>
    <comment_count>0</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2018-09-21 03:09:42 -0700</bug_when>
    <thetext>TransformationMatrix::toColumnMajorFloatArray() should return a std::array&lt;&gt; object</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1461779</commentid>
    <comment_count>1</comment_count>
      <attachid>350345</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2018-09-21 03:12:08 -0700</bug_when>
    <thetext>Created attachment 350345
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1461784</commentid>
    <comment_count>2</comment_count>
      <attachid>350348</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2018-09-21 04:05:35 -0700</bug_when>
    <thetext>Created attachment 350348
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1461788</commentid>
    <comment_count>3</comment_count>
      <attachid>350348</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-09-21 04:27:01 -0700</bug_when>
    <thetext>Comment on attachment 350348
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350348&amp;action=review

&gt; Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1727
&gt; -void TransformationMatrix::toColumnMajorFloatArray(FloatMatrix4&amp; result) const
&gt; +auto TransformationMatrix::toColumnMajorFloatArray() const -&gt; FloatMatrix4

Wow, a good use of the trailing return syntax...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1461796</commentid>
    <comment_count>4</comment_count>
      <attachid>350348</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2018-09-21 05:47:47 -0700</bug_when>
    <thetext>Comment on attachment 350348
Patch

Clearing flags on attachment: 350348

Committed r236311: &lt;https://trac.webkit.org/changeset/236311&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1461797</commentid>
    <comment_count>5</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2018-09-21 05:47:51 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1461798</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-09-21 05:48:23 -0700</bug_when>
    <thetext>&lt;rdar://problem/44677771&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>350345</attachid>
            <date>2018-09-21 03:12:08 -0700</date>
            <delta_ts>2018-09-21 04:05:32 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-189823-20180921121207.patch</filename>
            <type>text/plain</type>
            <size>6693</size>
            <attacher name="Zan Dobersek">zan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDQyOTY4ZWEzN2VlN2Qz
OTk3ZTk3YTEyZmY2YWRmNDdlMWYzMzIwYS4uODhjMjRiMzU0OTA5ZjFiYTJhOWExMjc4YjM0ODE0
NjE5OThkMmExMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE4LTA5LTIxICBaYW4g
RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBUcmFuc2Zvcm1hdGlv
bk1hdHJpeDo6dG9Db2x1bW5NYWpvckZsb2F0QXJyYXkoKSBzaG91bGQgcmV0dXJuIGEgc3RkOjph
cnJheTw+IG9iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTg5ODIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgQWxpYXMgdGhlIFRyYW5zZm9ybWF0aW9uTWF0cml4OjpGbG9hdE1hdHJpeDQgdHlwZSB0
bworICAgICAgICBzdGQ6OmFycmF5PGZsb2F0LCAxNj4uIEluc3RlYWQgb2YgZmlsbGluZyBvdXQg
dGhlIGFycmF5IG9iamVjdCB0aGF0J3MKKyAgICAgICAgcGFzc2VkIGluIHRocm91Z2ggYSByZWZl
cmVuY2UgcGFyYW1ldGVyLCByZXR1cm4gdGhlIHN0ZDo6YXJyYXk8PgorICAgICAgICBvYmplY3Qg
ZnJvbSB0aGUgZnVuY3Rpb24uCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYnZyL1ZSRnJhbWVEYXRh
LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om1hdHJpeFRvQXJyYXkpOgorICAgICAgICAqIE1vZHVs
ZXMvd2VidnIvVlJTdGFnZVBhcmFtZXRlcnMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VlJTdGFn
ZVBhcmFtZXRlcnM6OnNpdHRpbmdUb1N0YW5kaW5nVHJhbnNmb3JtIGNvbnN0KToKKyAgICAgICAg
KiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0uY3Bw
OgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW06OnNldE1hdHJp
eCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9UcmFuc2Zvcm1hdGlv
bk1hdHJpeC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUcmFuc2Zvcm1hdGlvbk1hdHJpeDo6dG9D
b2x1bW5NYWpvckZsb2F0QXJyYXkgY29uc3QpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz
L3RyYW5zZm9ybXMvVHJhbnNmb3JtYXRpb25NYXRyaXguaDoKKwogMjAxOC0wOS0yMCAgRGVhbiBK
YWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVzdHJpY3QgdGhlIHRvdGFsIGNv
bWJpbmVkIHNpemUgb2YgYmFja2Ryb3AgZmlsdGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv
cmUvTW9kdWxlcy93ZWJ2ci9WUkZyYW1lRGF0YS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz
L3dlYnZyL1ZSRnJhbWVEYXRhLmNwcAppbmRleCBhMTAwMjVmZTE2NzkzM2Q5ZDRkZWEwMWUwMDkw
MmYxZmQ4NTRmZmM1Li42NWMzZGJhZDY4ZGMyZTg0YTEzNjFjNjYwYTFmN2VlZTg5OGMxZmJkIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnZyL1ZSRnJhbWVEYXRhLmNwcAor
KysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnZyL1ZSRnJhbWVEYXRhLmNwcApAQCAtMzgs
OSArMzgsOCBAQCBWUkZyYW1lRGF0YTo6VlJGcmFtZURhdGEoKQogCiBzdGF0aWMgUmVmPEZsb2F0
MzJBcnJheT4gbWF0cml4VG9BcnJheShjb25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgbWF0cml4
KQogewotICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4OjpGbG9hdE1hdHJpeDQgY29sdW1uTWFqb3JN
YXRyaXg7Ci0gICAgbWF0cml4LnRvQ29sdW1uTWFqb3JGbG9hdEFycmF5KGNvbHVtbk1ham9yTWF0
cml4KTsKLSAgICByZXR1cm4gRmxvYXQzMkFycmF5OjpjcmVhdGUoY29sdW1uTWFqb3JNYXRyaXgs
IDE2KS5yZWxlYXNlTm9uTnVsbCgpOworICAgIGF1dG8gY29sdW1uTWFqb3JNYXRyaXggPSBtYXRy
aXgudG9Db2x1bW5NYWpvckZsb2F0QXJyYXkoKTsKKyAgICByZXR1cm4gRmxvYXQzMkFycmF5Ojpj
cmVhdGUoY29sdW1uTWFqb3JNYXRyaXguZGF0YSgpLCAxNikucmVsZWFzZU5vbk51bGwoKTsKIH0K
IAogUmVmPEZsb2F0MzJBcnJheT4gVlJGcmFtZURhdGE6OmxlZnRQcm9qZWN0aW9uTWF0cml4KCkg
Y29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2VidnIvVlJTdGFnZVBh
cmFtZXRlcnMuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJ2ci9WUlN0YWdlUGFyYW1l
dGVycy5jcHAKaW5kZXggM2U1ZTRiZGMyZTEwMWQ4MDNiYWUwMzc2ZjEwMjkxMGY0MjQ5YTViNy4u
MmRhMDc0M2I0NGM3ZWM4ZjgzMDkyNTliZjRkYTI1ODdhZGYyODZlMiAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJ2ci9WUlN0YWdlUGFyYW1ldGVycy5jcHAKKysrIGIvU291
cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJ2ci9WUlN0YWdlUGFyYW1ldGVycy5jcHAKQEAgLTQwLDkg
KzQwLDggQEAgVlJTdGFnZVBhcmFtZXRlcnM6OlZSU3RhZ2VQYXJhbWV0ZXJzKGNvbnN0IFRyYW5z
Zm9ybWF0aW9uTWF0cml4JiBzaXR0aW5nVG9TdGFuZGkKIAogUmVmPEZsb2F0MzJBcnJheT4gVlJT
dGFnZVBhcmFtZXRlcnM6OnNpdHRpbmdUb1N0YW5kaW5nVHJhbnNmb3JtKCkgY29uc3QKIHsKLSAg
ICBUcmFuc2Zvcm1hdGlvbk1hdHJpeDo6RmxvYXRNYXRyaXg0IGNvbHVtbk1ham9yTWF0cml4Owot
ICAgIG1fc2l0dGluZ1RvU3RhbmRpbmdUcmFuc2Zvcm0udG9Db2x1bW5NYWpvckZsb2F0QXJyYXko
Y29sdW1uTWFqb3JNYXRyaXgpOwotICAgIHJldHVybiBGbG9hdDMyQXJyYXk6OmNyZWF0ZShjb2x1
bW5NYWpvck1hdHJpeCwgMTYpLnJlbGVhc2VOb25OdWxsKCk7CisgICAgYXV0byBjb2x1bW5NYWpv
ck1hdHJpeCA9IG1fc2l0dGluZ1RvU3RhbmRpbmdUcmFuc2Zvcm0udG9Db2x1bW5NYWpvckZsb2F0
QXJyYXkoKTsKKyAgICByZXR1cm4gRmxvYXQzMkFycmF5OjpjcmVhdGUoY29sdW1uTWFqb3JNYXRy
aXguZGF0YSgpLCAxNikucmVsZWFzZU5vbk51bGwoKTsKIH0KIAogZmxvYXQgVlJTdGFnZVBhcmFt
ZXRlcnM6OnNpemVYKCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5jcHAgYi9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlclByb2dy
YW0uY3BwCmluZGV4IDJlNmM1MmM2MzQ4OTY2NDlhZjVjNmE0NDQ3Yjk4ZjEwYTNkMjQyOTUuLjJm
NmY1MTAyMWVjZjdiNjU5YTFiZDZjODdhYWVlZjRiNmU2YTE5ZTggMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJv
Z3JhbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1Rl
eHR1cmVNYXBwZXJTaGFkZXJQcm9ncmFtLmNwcApAQCAtNTIxLDkgKzUyMSw4IEBAIFRleHR1cmVN
YXBwZXJTaGFkZXJQcm9ncmFtOjp+VGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0oKQogCiB2b2lk
IFRleHR1cmVNYXBwZXJTaGFkZXJQcm9ncmFtOjpzZXRNYXRyaXgoR0x1aW50IGxvY2F0aW9uLCBj
b25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgbWF0cml4KQogewotICAgIFRyYW5zZm9ybWF0aW9u
TWF0cml4OjpGbG9hdE1hdHJpeDQgZmxvYXRNYXRyaXg7Ci0gICAgbWF0cml4LnRvQ29sdW1uTWFq
b3JGbG9hdEFycmF5KGZsb2F0TWF0cml4KTsKLSAgICBnbFVuaWZvcm1NYXRyaXg0ZnYobG9jYXRp
b24sIDEsIGZhbHNlLCBmbG9hdE1hdHJpeCk7CisgICAgYXV0byBmbG9hdE1hdHJpeCA9IG1hdHJp
eC50b0NvbHVtbk1ham9yRmxvYXRBcnJheSgpOworICAgIGdsVW5pZm9ybU1hdHJpeDRmdihsb2Nh
dGlvbiwgMSwgZmFsc2UsIGZsb2F0TWF0cml4LmRhdGEoKSk7CiB9CiAKIEdMdWludCBUZXh0dXJl
TWFwcGVyU2hhZGVyUHJvZ3JhbTo6Z2V0TG9jYXRpb24oY29uc3QgQXRvbWljU3RyaW5nJiBuYW1l
LCBWYXJpYWJsZVR5cGUgdHlwZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNmb3JtYXRpb25NYXRyaXguY3BwIGIvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5j
cHAKaW5kZXggN2MyNGRjMDQ3ZjhmMmJmOWIyNmJhODJlMzRmNzJmNmZjMjIzY2M2ZC4uZmJkYmI2
YzM0MjllOTA1ZDA5NDVjZjA3MWJlNTcxMDdjOWZiNTAzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5j
cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9UcmFu
c2Zvcm1hdGlvbk1hdHJpeC5jcHAKQEAgLTE3MjQsMjQgKzE3MjQsMTMgQEAgVHJhbnNmb3JtYXRp
b25NYXRyaXggVHJhbnNmb3JtYXRpb25NYXRyaXg6OnRvMmRUcmFuc2Zvcm0oKSBjb25zdAogICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtX21hdHJpeFszXVswXSwgbV9tYXRyaXhbM11b
MV0sIDAsIG1fbWF0cml4WzNdWzNdKTsKIH0KIAotdm9pZCBUcmFuc2Zvcm1hdGlvbk1hdHJpeDo6
dG9Db2x1bW5NYWpvckZsb2F0QXJyYXkoRmxvYXRNYXRyaXg0JiByZXN1bHQpIGNvbnN0CithdXRv
IFRyYW5zZm9ybWF0aW9uTWF0cml4Ojp0b0NvbHVtbk1ham9yRmxvYXRBcnJheSgpIGNvbnN0IC0+
IEZsb2F0TWF0cml4NAogewotICAgIHJlc3VsdFswXSA9IG0xMSgpOwotICAgIHJlc3VsdFsxXSA9
IG0xMigpOwotICAgIHJlc3VsdFsyXSA9IG0xMygpOwotICAgIHJlc3VsdFszXSA9IG0xNCgpOwot
ICAgIHJlc3VsdFs0XSA9IG0yMSgpOwotICAgIHJlc3VsdFs1XSA9IG0yMigpOwotICAgIHJlc3Vs
dFs2XSA9IG0yMygpOwotICAgIHJlc3VsdFs3XSA9IG0yNCgpOwotICAgIHJlc3VsdFs4XSA9IG0z
MSgpOwotICAgIHJlc3VsdFs5XSA9IG0zMigpOwotICAgIHJlc3VsdFsxMF0gPSBtMzMoKTsKLSAg
ICByZXN1bHRbMTFdID0gbTM0KCk7Ci0gICAgcmVzdWx0WzEyXSA9IG00MSgpOwotICAgIHJlc3Vs
dFsxM10gPSBtNDIoKTsKLSAgICByZXN1bHRbMTRdID0gbTQzKCk7Ci0gICAgcmVzdWx0WzE1XSA9
IG00NCgpOworICAgIHJldHVybiB7CisgICAgICAgIGZsb2F0KG0xMSgpKSwgZmxvYXQobTEyKCkp
LCBmbG9hdChtMTMoKSksIGZsb2F0KG0xNCgpKSwKKyAgICAgICAgZmxvYXQobTIxKCkpLCBmbG9h
dChtMjIoKSksIGZsb2F0KG0yMygpKSwgZmxvYXQobTI0KCkpLAorICAgICAgICBmbG9hdChtMzEo
KSksIGZsb2F0KG0zMigpKSwgZmxvYXQobTMzKCkpLCBmbG9hdChtMzQoKSksCisgICAgICAgIGZs
b2F0KG00MSgpKSwgZmxvYXQobTQyKCkpLCBmbG9hdChtNDMoKSksIGZsb2F0KG00NCgpKSB9Owog
fQogCiBib29sIFRyYW5zZm9ybWF0aW9uTWF0cml4Ojppc0JhY2tGYWNlVmlzaWJsZSgpIGNvbnN0
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1z
L1RyYW5zZm9ybWF0aW9uTWF0cml4LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj
cy90cmFuc2Zvcm1zL1RyYW5zZm9ybWF0aW9uTWF0cml4LmgKaW5kZXggNTc1YTFkNDUwOTc4Yzhh
ZmU0ZWIwYTI1MDhhYmE4MWQ5ODE0MTJkZC4uZmQyMWFlZTc0YmYzMGJlYzhlNzczYzI4NGZmYjk2
ODRkOTBkMjllYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv
dHJhbnNmb3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNmb3JtYXRpb25NYXRyaXguaApAQCAtMjgs
NiArMjgsNyBAQAogI2luY2x1ZGUgIkZsb2F0UG9pbnQuaCIKICNpbmNsdWRlICJGbG9hdFBvaW50
M0QuaCIKICNpbmNsdWRlICJJbnRQb2ludC5oIgorI2luY2x1ZGUgPGFycmF5PgogI2luY2x1ZGUg
PHN0cmluZy5oPiAvL2ZvciBtZW1jcHkKICNpbmNsdWRlIDx3dGYvRmFzdE1hbGxvYy5oPgogI2lu
Y2x1ZGUgPHd0Zi9PcHRpb25hbC5oPgpAQCAtNDA0LDggKzQwNSw4IEBAIHB1YmxpYzoKICAgICAv
LyBSZXR1cm5zIHRoZSBtYXRyaXggd2l0aG91dCAzRCBjb21wb25lbnRzLgogICAgIFRyYW5zZm9y
bWF0aW9uTWF0cml4IHRvMmRUcmFuc2Zvcm0oKSBjb25zdDsKICAgICAKLSAgICB0eXBlZGVmIGZs
b2F0IEZsb2F0TWF0cml4NFsxNl07Ci0gICAgdm9pZCB0b0NvbHVtbk1ham9yRmxvYXRBcnJheShG
bG9hdE1hdHJpeDQmIHJlc3VsdCkgY29uc3Q7CisgICAgdXNpbmcgRmxvYXRNYXRyaXg0ID0gc3Rk
OjphcnJheTxmbG9hdCwgMTY+OworICAgIEZsb2F0TWF0cml4NCB0b0NvbHVtbk1ham9yRmxvYXRB
cnJheSgpIGNvbnN0OwogCiAgICAgLy8gQSBsb2NhbC1zcGFjZSBsYXllciBpcyBpbXBsaWNpdGx5
IGRlZmluZWQgYXQgdGhlIHogPSAwIHBsYW5lLCB3aXRoIGl0cyBmcm9udCBzaWRlCiAgICAgLy8g
ZmFjaW5nIHRoZSBwb3NpdGl2ZSB6LWF4aXMgKGkuZS4gYSBjYW1lcmEgbG9va2luZyBhbG9uZyB0
aGUgbmVnYXRpdmUgei1heGlzIHNlZXMK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>350348</attachid>
            <date>2018-09-21 04:05:35 -0700</date>
            <delta_ts>2018-09-21 05:47:47 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-189823-20180921130534.patch</filename>
            <type>text/plain</type>
            <size>6697</size>
            <attacher name="Zan Dobersek">zan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDQyOTY4ZWEzN2VlN2Qz
OTk3ZTk3YTEyZmY2YWRmNDdlMWYzMzIwYS4uODhjMjRiMzU0OTA5ZjFiYTJhOWExMjc4YjM0ODE0
NjE5OThkMmExMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE4LTA5LTIxICBaYW4g
RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBUcmFuc2Zvcm1hdGlv
bk1hdHJpeDo6dG9Db2x1bW5NYWpvckZsb2F0QXJyYXkoKSBzaG91bGQgcmV0dXJuIGEgc3RkOjph
cnJheTw+IG9iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTg5ODIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgQWxpYXMgdGhlIFRyYW5zZm9ybWF0aW9uTWF0cml4OjpGbG9hdE1hdHJpeDQgdHlwZSB0
bworICAgICAgICBzdGQ6OmFycmF5PGZsb2F0LCAxNj4uIEluc3RlYWQgb2YgZmlsbGluZyBvdXQg
dGhlIGFycmF5IG9iamVjdCB0aGF0J3MKKyAgICAgICAgcGFzc2VkIGluIHRocm91Z2ggYSByZWZl
cmVuY2UgcGFyYW1ldGVyLCByZXR1cm4gdGhlIHN0ZDo6YXJyYXk8PgorICAgICAgICBvYmplY3Qg
ZnJvbSB0aGUgZnVuY3Rpb24uCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYnZyL1ZSRnJhbWVEYXRh
LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om1hdHJpeFRvQXJyYXkpOgorICAgICAgICAqIE1vZHVs
ZXMvd2VidnIvVlJTdGFnZVBhcmFtZXRlcnMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VlJTdGFn
ZVBhcmFtZXRlcnM6OnNpdHRpbmdUb1N0YW5kaW5nVHJhbnNmb3JtIGNvbnN0KToKKyAgICAgICAg
KiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0uY3Bw
OgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW06OnNldE1hdHJp
eCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9UcmFuc2Zvcm1hdGlv
bk1hdHJpeC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUcmFuc2Zvcm1hdGlvbk1hdHJpeDo6dG9D
b2x1bW5NYWpvckZsb2F0QXJyYXkgY29uc3QpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz
L3RyYW5zZm9ybXMvVHJhbnNmb3JtYXRpb25NYXRyaXguaDoKKwogMjAxOC0wOS0yMCAgRGVhbiBK
YWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVzdHJpY3QgdGhlIHRvdGFsIGNv
bWJpbmVkIHNpemUgb2YgYmFja2Ryb3AgZmlsdGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv
cmUvTW9kdWxlcy93ZWJ2ci9WUkZyYW1lRGF0YS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz
L3dlYnZyL1ZSRnJhbWVEYXRhLmNwcAppbmRleCBhMTAwMjVmZTE2NzkzM2Q5ZDRkZWEwMWUwMDkw
MmYxZmQ4NTRmZmM1Li42NWMzZGJhZDY4ZGMyZTg0YTEzNjFjNjYwYTFmN2VlZTg5OGMxZmJkIDEw
MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnZyL1ZSRnJhbWVEYXRhLmNwcAor
KysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnZyL1ZSRnJhbWVEYXRhLmNwcApAQCAtMzgs
OSArMzgsOCBAQCBWUkZyYW1lRGF0YTo6VlJGcmFtZURhdGEoKQogCiBzdGF0aWMgUmVmPEZsb2F0
MzJBcnJheT4gbWF0cml4VG9BcnJheShjb25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgbWF0cml4
KQogewotICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4OjpGbG9hdE1hdHJpeDQgY29sdW1uTWFqb3JN
YXRyaXg7Ci0gICAgbWF0cml4LnRvQ29sdW1uTWFqb3JGbG9hdEFycmF5KGNvbHVtbk1ham9yTWF0
cml4KTsKLSAgICByZXR1cm4gRmxvYXQzMkFycmF5OjpjcmVhdGUoY29sdW1uTWFqb3JNYXRyaXgs
IDE2KS5yZWxlYXNlTm9uTnVsbCgpOworICAgIGF1dG8gY29sdW1uTWFqb3JNYXRyaXggPSBtYXRy
aXgudG9Db2x1bW5NYWpvckZsb2F0QXJyYXkoKTsKKyAgICByZXR1cm4gRmxvYXQzMkFycmF5Ojpj
cmVhdGUoY29sdW1uTWFqb3JNYXRyaXguZGF0YSgpLCAxNikucmVsZWFzZU5vbk51bGwoKTsKIH0K
IAogUmVmPEZsb2F0MzJBcnJheT4gVlJGcmFtZURhdGE6OmxlZnRQcm9qZWN0aW9uTWF0cml4KCkg
Y29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2VidnIvVlJTdGFnZVBh
cmFtZXRlcnMuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJ2ci9WUlN0YWdlUGFyYW1l
dGVycy5jcHAKaW5kZXggM2U1ZTRiZGMyZTEwMWQ4MDNiYWUwMzc2ZjEwMjkxMGY0MjQ5YTViNy4u
MmRhMDc0M2I0NGM3ZWM4ZjgzMDkyNTliZjRkYTI1ODdhZGYyODZlMiAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJ2ci9WUlN0YWdlUGFyYW1ldGVycy5jcHAKKysrIGIvU291
cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJ2ci9WUlN0YWdlUGFyYW1ldGVycy5jcHAKQEAgLTQwLDkg
KzQwLDggQEAgVlJTdGFnZVBhcmFtZXRlcnM6OlZSU3RhZ2VQYXJhbWV0ZXJzKGNvbnN0IFRyYW5z
Zm9ybWF0aW9uTWF0cml4JiBzaXR0aW5nVG9TdGFuZGkKIAogUmVmPEZsb2F0MzJBcnJheT4gVlJT
dGFnZVBhcmFtZXRlcnM6OnNpdHRpbmdUb1N0YW5kaW5nVHJhbnNmb3JtKCkgY29uc3QKIHsKLSAg
ICBUcmFuc2Zvcm1hdGlvbk1hdHJpeDo6RmxvYXRNYXRyaXg0IGNvbHVtbk1ham9yTWF0cml4Owot
ICAgIG1fc2l0dGluZ1RvU3RhbmRpbmdUcmFuc2Zvcm0udG9Db2x1bW5NYWpvckZsb2F0QXJyYXko
Y29sdW1uTWFqb3JNYXRyaXgpOwotICAgIHJldHVybiBGbG9hdDMyQXJyYXk6OmNyZWF0ZShjb2x1
bW5NYWpvck1hdHJpeCwgMTYpLnJlbGVhc2VOb25OdWxsKCk7CisgICAgYXV0byBjb2x1bW5NYWpv
ck1hdHJpeCA9IG1fc2l0dGluZ1RvU3RhbmRpbmdUcmFuc2Zvcm0udG9Db2x1bW5NYWpvckZsb2F0
QXJyYXkoKTsKKyAgICByZXR1cm4gRmxvYXQzMkFycmF5OjpjcmVhdGUoY29sdW1uTWFqb3JNYXRy
aXguZGF0YSgpLCAxNikucmVsZWFzZU5vbk51bGwoKTsKIH0KIAogZmxvYXQgVlJTdGFnZVBhcmFt
ZXRlcnM6OnNpemVYKCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJvZ3JhbS5jcHAgYi9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlclByb2dy
YW0uY3BwCmluZGV4IDJlNmM1MmM2MzQ4OTY2NDlhZjVjNmE0NDQ3Yjk4ZjEwYTNkMjQyOTUuLjJm
NmY1MTAyMWVjZjdiNjU5YTFiZDZjODdhYWVlZjRiNmU2YTE5ZTggMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyU2hhZGVyUHJv
Z3JhbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1Rl
eHR1cmVNYXBwZXJTaGFkZXJQcm9ncmFtLmNwcApAQCAtNTIxLDkgKzUyMSw4IEBAIFRleHR1cmVN
YXBwZXJTaGFkZXJQcm9ncmFtOjp+VGV4dHVyZU1hcHBlclNoYWRlclByb2dyYW0oKQogCiB2b2lk
IFRleHR1cmVNYXBwZXJTaGFkZXJQcm9ncmFtOjpzZXRNYXRyaXgoR0x1aW50IGxvY2F0aW9uLCBj
b25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgbWF0cml4KQogewotICAgIFRyYW5zZm9ybWF0aW9u
TWF0cml4OjpGbG9hdE1hdHJpeDQgZmxvYXRNYXRyaXg7Ci0gICAgbWF0cml4LnRvQ29sdW1uTWFq
b3JGbG9hdEFycmF5KGZsb2F0TWF0cml4KTsKLSAgICBnbFVuaWZvcm1NYXRyaXg0ZnYobG9jYXRp
b24sIDEsIGZhbHNlLCBmbG9hdE1hdHJpeCk7CisgICAgYXV0byBmbG9hdE1hdHJpeCA9IG1hdHJp
eC50b0NvbHVtbk1ham9yRmxvYXRBcnJheSgpOworICAgIGdsVW5pZm9ybU1hdHJpeDRmdihsb2Nh
dGlvbiwgMSwgZmFsc2UsIGZsb2F0TWF0cml4LmRhdGEoKSk7CiB9CiAKIEdMdWludCBUZXh0dXJl
TWFwcGVyU2hhZGVyUHJvZ3JhbTo6Z2V0TG9jYXRpb24oY29uc3QgQXRvbWljU3RyaW5nJiBuYW1l
LCBWYXJpYWJsZVR5cGUgdHlwZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNmb3JtYXRpb25NYXRyaXguY3BwIGIvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5j
cHAKaW5kZXggN2MyNGRjMDQ3ZjhmMmJmOWIyNmJhODJlMzRmNzJmNmZjMjIzY2M2ZC4uZTUzNDhj
NDE3ZmM2MTlhNjM0MTMxYzMyZTdmYzVkNWNkM2ViNTY0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5j
cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9UcmFu
c2Zvcm1hdGlvbk1hdHJpeC5jcHAKQEAgLTE3MjQsMjQgKzE3MjQsMTMgQEAgVHJhbnNmb3JtYXRp
b25NYXRyaXggVHJhbnNmb3JtYXRpb25NYXRyaXg6OnRvMmRUcmFuc2Zvcm0oKSBjb25zdAogICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBtX21hdHJpeFszXVswXSwgbV9tYXRyaXhbM11b
MV0sIDAsIG1fbWF0cml4WzNdWzNdKTsKIH0KIAotdm9pZCBUcmFuc2Zvcm1hdGlvbk1hdHJpeDo6
dG9Db2x1bW5NYWpvckZsb2F0QXJyYXkoRmxvYXRNYXRyaXg0JiByZXN1bHQpIGNvbnN0CithdXRv
IFRyYW5zZm9ybWF0aW9uTWF0cml4Ojp0b0NvbHVtbk1ham9yRmxvYXRBcnJheSgpIGNvbnN0IC0+
IEZsb2F0TWF0cml4NAogewotICAgIHJlc3VsdFswXSA9IG0xMSgpOwotICAgIHJlc3VsdFsxXSA9
IG0xMigpOwotICAgIHJlc3VsdFsyXSA9IG0xMygpOwotICAgIHJlc3VsdFszXSA9IG0xNCgpOwot
ICAgIHJlc3VsdFs0XSA9IG0yMSgpOwotICAgIHJlc3VsdFs1XSA9IG0yMigpOwotICAgIHJlc3Vs
dFs2XSA9IG0yMygpOwotICAgIHJlc3VsdFs3XSA9IG0yNCgpOwotICAgIHJlc3VsdFs4XSA9IG0z
MSgpOwotICAgIHJlc3VsdFs5XSA9IG0zMigpOwotICAgIHJlc3VsdFsxMF0gPSBtMzMoKTsKLSAg
ICByZXN1bHRbMTFdID0gbTM0KCk7Ci0gICAgcmVzdWx0WzEyXSA9IG00MSgpOwotICAgIHJlc3Vs
dFsxM10gPSBtNDIoKTsKLSAgICByZXN1bHRbMTRdID0gbTQzKCk7Ci0gICAgcmVzdWx0WzE1XSA9
IG00NCgpOworICAgIHJldHVybiB7IHsKKyAgICAgICAgZmxvYXQobTExKCkpLCBmbG9hdChtMTIo
KSksIGZsb2F0KG0xMygpKSwgZmxvYXQobTE0KCkpLAorICAgICAgICBmbG9hdChtMjEoKSksIGZs
b2F0KG0yMigpKSwgZmxvYXQobTIzKCkpLCBmbG9hdChtMjQoKSksCisgICAgICAgIGZsb2F0KG0z
MSgpKSwgZmxvYXQobTMyKCkpLCBmbG9hdChtMzMoKSksIGZsb2F0KG0zNCgpKSwKKyAgICAgICAg
ZmxvYXQobTQxKCkpLCBmbG9hdChtNDIoKSksIGZsb2F0KG00MygpKSwgZmxvYXQobTQ0KCkpIH0g
fTsKIH0KIAogYm9vbCBUcmFuc2Zvcm1hdGlvbk1hdHJpeDo6aXNCYWNrRmFjZVZpc2libGUoKSBj
b25zdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNm
b3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh
cGhpY3MvdHJhbnNmb3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5oCmluZGV4IDU3NWExZDQ1MDk3
OGM4YWZlNGViMGEyNTA4YWJhODFkOTgxNDEyZGQuLmZkMjFhZWU3NGJmMzBiZWM4ZTc3M2MyODRm
ZmI5Njg0ZDkwZDI5ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo
aWNzL3RyYW5zZm9ybXMvVHJhbnNmb3JtYXRpb25NYXRyaXguaAorKysgYi9Tb3VyY2UvV2ViQ29y
ZS9wbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL1RyYW5zZm9ybWF0aW9uTWF0cml4LmgKQEAg
LTI4LDYgKzI4LDcgQEAKICNpbmNsdWRlICJGbG9hdFBvaW50LmgiCiAjaW5jbHVkZSAiRmxvYXRQ
b2ludDNELmgiCiAjaW5jbHVkZSAiSW50UG9pbnQuaCIKKyNpbmNsdWRlIDxhcnJheT4KICNpbmNs
dWRlIDxzdHJpbmcuaD4gLy9mb3IgbWVtY3B5CiAjaW5jbHVkZSA8d3RmL0Zhc3RNYWxsb2MuaD4K
ICNpbmNsdWRlIDx3dGYvT3B0aW9uYWwuaD4KQEAgLTQwNCw4ICs0MDUsOCBAQCBwdWJsaWM6CiAg
ICAgLy8gUmV0dXJucyB0aGUgbWF0cml4IHdpdGhvdXQgM0QgY29tcG9uZW50cy4KICAgICBUcmFu
c2Zvcm1hdGlvbk1hdHJpeCB0bzJkVHJhbnNmb3JtKCkgY29uc3Q7CiAgICAgCi0gICAgdHlwZWRl
ZiBmbG9hdCBGbG9hdE1hdHJpeDRbMTZdOwotICAgIHZvaWQgdG9Db2x1bW5NYWpvckZsb2F0QXJy
YXkoRmxvYXRNYXRyaXg0JiByZXN1bHQpIGNvbnN0OworICAgIHVzaW5nIEZsb2F0TWF0cml4NCA9
IHN0ZDo6YXJyYXk8ZmxvYXQsIDE2PjsKKyAgICBGbG9hdE1hdHJpeDQgdG9Db2x1bW5NYWpvckZs
b2F0QXJyYXkoKSBjb25zdDsKIAogICAgIC8vIEEgbG9jYWwtc3BhY2UgbGF5ZXIgaXMgaW1wbGlj
aXRseSBkZWZpbmVkIGF0IHRoZSB6ID0gMCBwbGFuZSwgd2l0aCBpdHMgZnJvbnQgc2lkZQogICAg
IC8vIGZhY2luZyB0aGUgcG9zaXRpdmUgei1heGlzIChpLmUuIGEgY2FtZXJhIGxvb2tpbmcgYWxv
bmcgdGhlIG5lZ2F0aXZlIHotYXhpcyBzZWVzCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>