18976 2008-05-09 14:15:48 -0700 REGRESSION (r26474): WebKit fails jQuery test 64 core module: text(String) subtest 1 Check escaped text (createTextNode) 2008-05-14 22:24:01 -0700 1 1 1 Unclassified WebKit DOM 525.x (Safari 3.1) Mac OS X 10.5 RESOLVED FIXED http://jquery.com/test/ InRadar, NeedsReduction, Regression P2 Normal --- 1 ddkilzer webkit-unassigned bill hausmann justin.garcia vestbo oldest_to_newest 80010 0 ddkilzer 2008-05-09 14:15:48 -0700 * SUMMARY When running the jQuery test suite, WebKit (in the form of Safari 3.1.1 on Leopard 10.5.x), fails one of the tests: 64. core module: text(String) (1, 3, 4) 1. Check escaped text This is either a real failure or an evangelism issue. * STEPS TO REPRODUCE 1. Launch Safari/WebKit. 2. Open URL: http://jquery.com/test/ 3. Wait for test to complete. * RESULTS WebKit fails 1 of 1157 tests (see SUMMARY for details). * REGRESSION Unknown. Only tested with Safari 3.1.1. 80011 1 ddkilzer 2008-05-09 14:20:59 -0700 <rdar://problem/5924793> 80044 2 ddkilzer 2008-05-09 18:40:37 -0700 The issue is how document.createTextNode() encodes text. 80045 3 21052 ddkilzer 2008-05-09 18:40:58 -0700 Created attachment 21052 Test case 80069 4 21052 ddkilzer 2008-05-10 06:28:45 -0700 Comment on attachment 21052 Test case This test case is bad. When the Expected and Actual lines match, the test still fails. 80070 5 ddkilzer 2008-05-10 06:31:58 -0700 (In reply to comment #0) > * REGRESSION > Unknown. Only tested with Safari 3.1.1. This is a regression as it works with Safari 3.0.4 (523.12.2) on Mac OS X 10.4.11 (8S165). I also have a fix. 80071 6 ddkilzer 2008-05-10 06:52:02 -0700 The bisect-builds script with Safari 2.0.4 reports: Works: r26359 Fails: r26570 80072 7 ddkilzer 2008-05-10 06:54:57 -0700 Regression occurred in r26474 (noted in comments): http://trac.webkit.org/projects/webkit/changeset/26474 80359 8 ddkilzer 2008-05-14 09:32:31 -0700 Qt developers: The following test results will likely need to be updated after this bug is fixed: LayoutTests/platform/qt/fast/dom/dom-parse-serialize-expected.txt LayoutTests/platform/qt/fast/xsl/xslt-text-expected.txt Note that LayoutTests/fast/xsl/xslt-text-expected.txt is a text dump, while LayoutTests/platform/qt/fast/xsl/xslt-text-expected.txt is a render tree dump. You may be able to use the common test results and remove the Qt-specific results. 80361 9 21127 ddkilzer 2008-05-14 09:45:14 -0700 Created attachment 21127 Patch v1 Proposed fix. 80362 10 21127 darin 2008-05-14 09:52:33 -0700 Comment on attachment 21127 Patch v1 Putting these strings into separate functions might make the code slightly slower unnecessarily. There's no particular reason these need to be shared globals, and I had originally used a C-style string because I thought that would be fast enough; widening the characters from 8-bit to 16-bit should be fast enough. And using globals at all (not new to this patch) creates unnecessary threading issues if we ever start tackling them the way we are in JavaScriptCore. But aside from that entirely-theoretical worry, looks perfect. r=me 80364 11 vestbo 2008-05-14 09:55:13 -0700 Thanks for the heads up David. 80397 12 ddkilzer 2008-05-14 13:38:36 -0700 Committed revision 33451. Removed unnecessary optimization per Comment #10. Tor/Simon: Please update Qt test results per Comment #8. Thanks! 80462 13 ap 2008-05-14 22:24:01 -0700 *** Bug 18101 has been marked as a duplicate of this bug. *** 21052 2008-05-09 18:40:58 -0700 2008-05-10 06:28:45 -0700 Test case bug-18976-test.html text/html 635 ddkilzer PGRpdiBpZD0iY29uc29sZSIgc3R5bGU9ImZvbnQtZmFtaWx5OiBtb25vc3BhY2U7IHdoaXRlLXNw YWNlOiBwcmU7Ij48L2Rpdj4KPHNjcmlwdD4KdmFyIHRleHQgPSAiPGRpdj48Yj5IZWxsbzwvYj4g Y3J1ZWwgd29ybGQhPC9kaXY+IjsKdmFyIGNvbnRhaW5lciA9IGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoImRpdiIpOwp2YXIgdGV4dE5vZGUgPSBkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSh0ZXh0KTsK dmFyIGV4cGVjdGVkID0gIiZsdDtkaXYmZ3Q7Jmx0O2ImZ3Q7SGVsbG8mbHQ7L2ImZ3Q7IGNydWVs IHdvcmxkISZsdDsvZGl2Jmd0OyIKY29udGFpbmVyLmFwcGVuZENoaWxkKHRleHROb2RlKTsKZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnNvbGUiKS50ZXh0Q29udGVudCA9ICJFeHBlY3RlZDog IiArIGV4cGVjdGVkICsgIlxuICBBY3R1YWw6ICIgKyBjb250YWluZXIuaW5uZXJIVE1MOwppZiAo dGV4dE5vZGUuaW5uZXJIVE1MID09IGV4cGVjdGVkKSB7CiAgICBkb2N1bWVudC53cml0ZSgiPGRp diBzdHlsZT1cImNvbG9yOiBncmVlbjtcIj5QQVNTPC9kaXY+Iik7Cn0gZWxzZSB7CiAgICBkb2N1 bWVudC53cml0ZSgiPGRpdiBzdHlsZT1cImNvbG9yOiByZWQ7XCI+RkFJTDwvZGl2PiIpOwp9Cjwv c2NyaXB0Pgo= 21127 2008-05-14 09:45:14 -0700 2008-05-14 09:52:33 -0700 Patch v1 bug-18976-v1.diff text/plain 11383 ddkilzer SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMzQ0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzMgQEAKKzIwMDgtMDUtMTQgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxl LmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjY0NzQpOiBXZWJLaXQgZmFpbHMgalF1ZXJ5 IHRlc3QgNjQgY29yZSBtb2R1bGU6IHRleHQoU3RyaW5nKSBzdWJ0ZXN0IDEgQ2hlY2sgZXNjYXBl ZCB0ZXh0IChjcmVhdGVUZXh0Tm9kZSkKKworICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4OTc2PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTkyNDc5 Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0 czogZmFzdC9kb20vZG9tLXBhcnNlLXNlcmlhbGl6ZS1leHBlY3RlZC50eHQ6CisgICAgICAgICAg ICAgICBmYXN0L3hzbC94c2x0LXByb2Nlc3Nvci1leHBlY3RlZC50eHQ6CisgICAgICAgICAgICAg ICBmYXN0L3hzbC94c2x0LXRleHQtZXhwZWN0ZWQudHh0OgorCisgICAgICAgIENvbW1pdCByMjY0 NzQgcmVtb3ZlZCBlc2NhcGluZyBvZiAnPicgY2hhcmFjdGVycyB0byAnJmd0OycgaW4gc2VyaWFs aXplZAorICAgICAgICBIVE1MIGNvbnRlbnQsIHdoaWNoIGJyb2tlIG9uZSBqUXVlcnkgdGVzdC4g IFRoaXMgY2hhbmdlIHJlc3RvcmVzIHRoYXQKKyAgICAgICAgc2VyaWFsaXphdGlvbiBiZWhhdmlv ciB0byBib3RoIGF0dHJpYnV0ZXMgYW5kIGNvbnRlbnQgZm9yIGNvbnNpc3RlbmN5LgorCisgICAg ICAgIEFsc28gZXh0cmFjdGVkIGR1cGxpY2F0ZSBzdGF0aWMgZW50aXR5IHZhcmlhYmxlcyBpbnRv IHN0YXRpYyBtZXRob2RzLgorCisgICAgICAgICogZWRpdGluZy9tYXJrdXAuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6YW1wRW50aXR5KTogQWRkZWQuCisgICAgICAgIChXZWJDb3JlOjpndEVudGl0 eSk6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6bHRFbnRpdHkpOiBBZGRlZC4KKyAgICAgICAg KFdlYkNvcmU6OnF1b3RFbnRpdHkpOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6Om5ic3BFbnRp dHkpOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OmFwcGVuZEF0dHJpYnV0ZVZhbHVlKTogRXNj YXBlICc+JyBhcyAnJmd0OycuCisgICAgICAgIChXZWJDb3JlOjplc2NhcGVDb250ZW50VGV4dCk6 IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6YXBwZW5kRXNjYXBlZENvbnRlbnQpOiBEaXR0by4g IFRoaXMgaXMgdGhlIGJ1ZyBmaXggZm9yIHRoZSBqUXVlcnkgdGVzdC4KKyAgICAgICAgKFdlYkNv cmU6OmFwcGVuZFF1b3RlZFVSTEF0dHJpYnV0ZVZhbHVlKTogVXNlIHF1b3RFbnRpdHkoKS4KKwog MjAwOC0wNS0xNCAgSnVsaWVuIENoYWZmcmFpeCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBFcmljLgpJbmRleDogV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAJKHJldmlzaW9uIDMz MDYzKQorKysgV2ViQ29yZS9lZGl0aW5nL21hcmt1cC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg4 LDM4ICs4OCw2OCBAQCBwcml2YXRlOgogICAgIFN0cmluZyBtX3ZhbHVlOwogfTsKIAorc3RhdGlj IGNvbnN0IFN0cmluZyYgYW1wRW50aXR5KCkKK3sKKyAgICBzdGF0aWMgY29uc3QgU3RyaW5nIGFt cEVudGl0eSgiJmFtcDsiKTsKKyAgICByZXR1cm4gYW1wRW50aXR5OworfQorCitzdGF0aWMgY29u c3QgU3RyaW5nJiBndEVudGl0eSgpCit7CisgICAgc3RhdGljIGNvbnN0IFN0cmluZyBndEVudGl0 eSgiJmd0OyIpOworICAgIHJldHVybiBndEVudGl0eTsKK30KKworc3RhdGljIGNvbnN0IFN0cmlu ZyYgbHRFbnRpdHkoKQoreworICAgIHN0YXRpYyBjb25zdCBTdHJpbmcgbHRFbnRpdHkoIiZsdDsi KTsKKyAgICByZXR1cm4gbHRFbnRpdHk7Cit9CisKK3N0YXRpYyBjb25zdCBTdHJpbmcmIHF1b3RF bnRpdHkoKQoreworICAgIHN0YXRpYyBjb25zdCBTdHJpbmcgcXVvdEVudGl0eSgiJnF1b3Q7Iik7 CisgICAgcmV0dXJuIHF1b3RFbnRpdHk7Cit9CisKK3N0YXRpYyBjb25zdCBTdHJpbmcmIG5ic3BF bnRpdHkoKQoreworICAgIHN0YXRpYyBjb25zdCBTdHJpbmcgbmJzcEVudGl0eSgiJm5ic3A7Iik7 CisgICAgcmV0dXJuIG5ic3BFbnRpdHk7Cit9CisKIHN0YXRpYyB2b2lkIGFwcGVuZEF0dHJpYnV0 ZVZhbHVlKFZlY3RvcjxVQ2hhcj4mIHJlc3VsdCwgY29uc3QgU3RyaW5nJiBhdHRyKQogewogICAg IGNvbnN0IFVDaGFyKiB1Y2hhcnMgPSBhdHRyLmNoYXJhY3RlcnMoKTsKICAgICB1bnNpZ25lZCBs ZW4gPSBhdHRyLmxlbmd0aCgpOwogICAgIHVuc2lnbmVkIGxhc3RDb3BpZWRGcm9tID0gMDsKIAot ICAgIHN0YXRpYyBjb25zdCBTdHJpbmcgYW1wRW50aXR5KCImYW1wOyIpOwotICAgIHN0YXRpYyBj b25zdCBTdHJpbmcgbHRFbnRpdHkoIiZsdDsiKTsKLSAgICBzdGF0aWMgY29uc3QgU3RyaW5nIHF1 b3RFbnRpdHkoIiZxdW90OyIpOwotICAgIHN0YXRpYyBjb25zdCBTdHJpbmcgbmJzcEVudGl0eSgi Jm5ic3A7Iik7Ci0gICAgCiAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGxlbjsgKytpKSB7 CiAgICAgICAgIFVDaGFyIGMgPSB1Y2hhcnNbaV07CiAgICAgICAgIHN3aXRjaCAoYykgewogICAg ICAgICAgICAgY2FzZSAnJic6CiAgICAgICAgICAgICAgICAgcmVzdWx0LmFwcGVuZCh1Y2hhcnMg KyBsYXN0Q29waWVkRnJvbSwgaSAtIGxhc3RDb3BpZWRGcm9tKTsKLSAgICAgICAgICAgICAgICBh cHBlbmQocmVzdWx0LCBhbXBFbnRpdHkpOworICAgICAgICAgICAgICAgIGFwcGVuZChyZXN1bHQs IGFtcEVudGl0eSgpKTsKICAgICAgICAgICAgICAgICBsYXN0Q29waWVkRnJvbSA9IGkgKyAxOwog ICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgY2FzZSAnPCc6CiAgICAgICAgICAg ICAgICAgcmVzdWx0LmFwcGVuZCh1Y2hhcnMgKyBsYXN0Q29waWVkRnJvbSwgaSAtIGxhc3RDb3Bp ZWRGcm9tKTsKLSAgICAgICAgICAgICAgICBhcHBlbmQocmVzdWx0LCBsdEVudGl0eSk7CisgICAg ICAgICAgICAgICAgYXBwZW5kKHJlc3VsdCwgbHRFbnRpdHkoKSk7CisgICAgICAgICAgICAgICAg bGFzdENvcGllZEZyb20gPSBpICsgMTsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAg ICAgIGNhc2UgJz4nOgorICAgICAgICAgICAgICAgIHJlc3VsdC5hcHBlbmQodWNoYXJzICsgbGFz dENvcGllZEZyb20sIGkgLSBsYXN0Q29waWVkRnJvbSk7CisgICAgICAgICAgICAgICAgYXBwZW5k KHJlc3VsdCwgZ3RFbnRpdHkoKSk7CiAgICAgICAgICAgICAgICAgbGFzdENvcGllZEZyb20gPSBp ICsgMTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIGNhc2UgJyInOgogICAg ICAgICAgICAgICAgIHJlc3VsdC5hcHBlbmQodWNoYXJzICsgbGFzdENvcGllZEZyb20sIGkgLSBs YXN0Q29waWVkRnJvbSk7Ci0gICAgICAgICAgICAgICAgYXBwZW5kKHJlc3VsdCwgcXVvdEVudGl0 eSk7CisgICAgICAgICAgICAgICAgYXBwZW5kKHJlc3VsdCwgcXVvdEVudGl0eSgpKTsKICAgICAg ICAgICAgICAgICBsYXN0Q29waWVkRnJvbSA9IGkgKyAxOwogICAgICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICAgICAgY2FzZSBub0JyZWFrU3BhY2U6CiAgICAgICAgICAgICAgICAgcmVzdWx0 LmFwcGVuZCh1Y2hhcnMgKyBsYXN0Q29waWVkRnJvbSwgaSAtIGxhc3RDb3BpZWRGcm9tKTsKLSAg ICAgICAgICAgICAgICBhcHBlbmQocmVzdWx0LCBuYnNwRW50aXR5KTsKKyAgICAgICAgICAgICAg ICBhcHBlbmQocmVzdWx0LCBuYnNwRW50aXR5KCkpOwogICAgICAgICAgICAgICAgIGxhc3RDb3Bp ZWRGcm9tID0gaSArIDE7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KQEAgLTEz NSwxMCArMTY1LDYgQEAgc3RhdGljIFN0cmluZyBlc2NhcGVDb250ZW50VGV4dChjb25zdCBTdAog ICAgIHVuc2lnbmVkIGxlbiA9IGluLmxlbmd0aCgpOwogICAgIHVuc2lnbmVkIGxhc3RDb3BpZWRG cm9tID0gMDsKIAotICAgIHN0YXRpYyBjb25zdCBTdHJpbmcgYW1wRW50aXR5KCImYW1wOyIpOwot ICAgIHN0YXRpYyBjb25zdCBTdHJpbmcgbHRFbnRpdHkoIiZsdDsiKTsKLSAgICBzdGF0aWMgY29u c3QgU3RyaW5nIG5ic3BFbnRpdHkoIiZuYnNwOyIpOwotCiAgICAgcy5yZXNlcnZlQ2FwYWNpdHko bGVuKTsKIAogICAgIGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzID0gaW4uY2hhcmFjdGVycygpOwpA QCAtMTQ4LDE3ICsxNzQsMjIgQEAgc3RhdGljIFN0cmluZyBlc2NhcGVDb250ZW50VGV4dChjb25z dCBTdAogICAgICAgICBzd2l0Y2ggKGMpIHsKICAgICAgICAgICAgIGNhc2UgJyYnOgogICAgICAg ICAgICAgICAgIHMuYXBwZW5kKGNoYXJhY3RlcnMgKyBsYXN0Q29waWVkRnJvbSwgaSAtIGxhc3RD b3BpZWRGcm9tKTsKLSAgICAgICAgICAgICAgICBhcHBlbmQocywgYW1wRW50aXR5KTsKKyAgICAg ICAgICAgICAgICBhcHBlbmQocywgYW1wRW50aXR5KCkpOwogICAgICAgICAgICAgICAgIGxhc3RD b3BpZWRGcm9tID0gaSArIDE7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBj YXNlICc8JzoKICAgICAgICAgICAgICAgICBzLmFwcGVuZChjaGFyYWN0ZXJzICsgbGFzdENvcGll ZEZyb20sIGkgLSBsYXN0Q29waWVkRnJvbSk7Ci0gICAgICAgICAgICAgICAgYXBwZW5kKHMsIGx0 RW50aXR5KTsKKyAgICAgICAgICAgICAgICBhcHBlbmQocywgbHRFbnRpdHkoKSk7CisgICAgICAg ICAgICAgICAgbGFzdENvcGllZEZyb20gPSBpICsgMTsKKyAgICAgICAgICAgICAgICBicmVhazsK KyAgICAgICAgICAgIGNhc2UgJz4nOgorICAgICAgICAgICAgICAgIHMuYXBwZW5kKGNoYXJhY3Rl cnMgKyBsYXN0Q29waWVkRnJvbSwgaSAtIGxhc3RDb3BpZWRGcm9tKTsKKyAgICAgICAgICAgICAg ICBhcHBlbmQocywgZ3RFbnRpdHkoKSk7CiAgICAgICAgICAgICAgICAgbGFzdENvcGllZEZyb20g PSBpICsgMTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIGNhc2Ugbm9CcmVh a1NwYWNlOgogICAgICAgICAgICAgICAgIHMuYXBwZW5kKGNoYXJhY3RlcnMgKyBsYXN0Q29waWVk RnJvbSwgaSAtIGxhc3RDb3BpZWRGcm9tKTsKLSAgICAgICAgICAgICAgICBhcHBlbmQocywgbmJz cEVudGl0eSk7CisgICAgICAgICAgICAgICAgYXBwZW5kKHMsIG5ic3BFbnRpdHkoKSk7CiAgICAg ICAgICAgICAgICAgbGFzdENvcGllZEZyb20gPSBpICsgMTsKICAgICAgICAgICAgICAgICBicmVh azsKICAgICAgICAgfQpAQCAtMTc1LDI2ICsyMDYsMjcgQEAgc3RhdGljIHZvaWQgYXBwZW5kRXNj YXBlZENvbnRlbnQoVmVjdG9yPAogICAgIHVuc2lnbmVkIGxlbiA9IHJhbmdlLnNlY29uZDsKICAg ICB1bnNpZ25lZCBsYXN0Q29waWVkRnJvbSA9IDA7CiAgICAgCi0gICAgc3RhdGljIGNvbnN0IFN0 cmluZyBhbXBFbnRpdHkoIiZhbXA7Iik7Ci0gICAgc3RhdGljIGNvbnN0IFN0cmluZyBsdEVudGl0 eSgiJmx0OyIpOwotICAgIHN0YXRpYyBjb25zdCBTdHJpbmcgbmJzcEVudGl0eSgiJm5ic3A7Iik7 Ci0KICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbGVuOyArK2kpIHsKICAgICAgICAgVUNo YXIgYyA9IHVjaGFyc1tpXTsKICAgICAgICAgc3dpdGNoIChjKSB7CiAgICAgICAgICAgICBjYXNl ICcmJzoKICAgICAgICAgICAgICAgICByZXN1bHQuYXBwZW5kKHVjaGFycyArIGxhc3RDb3BpZWRG cm9tLCBpIC0gbGFzdENvcGllZEZyb20pOwotICAgICAgICAgICAgICAgIGFwcGVuZChyZXN1bHQs IGFtcEVudGl0eSk7CisgICAgICAgICAgICAgICAgYXBwZW5kKHJlc3VsdCwgYW1wRW50aXR5KCkp OwogICAgICAgICAgICAgICAgIGxhc3RDb3BpZWRGcm9tID0gaSArIDE7CiAgICAgICAgICAgICAg ICAgYnJlYWs7CiAgICAgICAgICAgICBjYXNlICc8JzoKICAgICAgICAgICAgICAgICByZXN1bHQu YXBwZW5kKHVjaGFycyArIGxhc3RDb3BpZWRGcm9tLCBpIC0gbGFzdENvcGllZEZyb20pOwotICAg ICAgICAgICAgICAgIGFwcGVuZChyZXN1bHQsIGx0RW50aXR5KTsKKyAgICAgICAgICAgICAgICBh cHBlbmQocmVzdWx0LCBsdEVudGl0eSgpKTsKKyAgICAgICAgICAgICAgICBsYXN0Q29waWVkRnJv bSA9IGkgKyAxOworICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgY2FzZSAnPic6 CisgICAgICAgICAgICAgICAgcmVzdWx0LmFwcGVuZCh1Y2hhcnMgKyBsYXN0Q29waWVkRnJvbSwg aSAtIGxhc3RDb3BpZWRGcm9tKTsKKyAgICAgICAgICAgICAgICBhcHBlbmQocmVzdWx0LCBndEVu dGl0eSgpKTsKICAgICAgICAgICAgICAgICBsYXN0Q29waWVkRnJvbSA9IGkgKyAxOwogICAgICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgY2FzZSBub0JyZWFrU3BhY2U6CiAgICAgICAg ICAgICAgICAgcmVzdWx0LmFwcGVuZCh1Y2hhcnMgKyBsYXN0Q29waWVkRnJvbSwgaSAtIGxhc3RD b3BpZWRGcm9tKTsKLSAgICAgICAgICAgICAgICBhcHBlbmQocmVzdWx0LCBuYnNwRW50aXR5KTsK KyAgICAgICAgICAgICAgICBhcHBlbmQocmVzdWx0LCBuYnNwRW50aXR5KCkpOwogICAgICAgICAg ICAgICAgIGxhc3RDb3BpZWRGcm9tID0gaSArIDE7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgIH0KQEAgLTIxMSw3ICsyNDMsNyBAQCBzdGF0aWMgdm9pZCBhcHBlbmRRdW90ZWRVUkxB dHRyaWJ1dGVWYWx1CiAgICAgICAgIC8vIG1pbmltYWwgZXNjYXBpbmcgZm9yIGphdmFzY3JpcHQg dXJscwogICAgICAgICBpZiAoc3RyaXBwZWRVUkxTdHJpbmcuY29udGFpbnMoJyInKSkgewogICAg ICAgICAgICAgaWYgKHN0cmlwcGVkVVJMU3RyaW5nLmNvbnRhaW5zKCdcJycpKQotICAgICAgICAg ICAgICAgIHN0cmlwcGVkVVJMU3RyaW5nLnJlcGxhY2UoJ1wiJywgIiZxdW90OyIpOworICAgICAg ICAgICAgICAgIHN0cmlwcGVkVVJMU3RyaW5nLnJlcGxhY2UoJ1wiJywgcXVvdEVudGl0eSgpKTsK ICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICBxdW90ZUNoYXIgPSAnXCcnOwogICAg ICAgICB9CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAzMzQ0MSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDA4LTA1LTE0ICBEYXZpZCBLaWx6 ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI2NDc0KTog V2ViS2l0IGZhaWxzIGpRdWVyeSB0ZXN0IDY0IGNvcmUgbW9kdWxlOiB0ZXh0KFN0cmluZykgc3Vi dGVzdCAxIENoZWNrIGVzY2FwZWQgdGV4dCAoY3JlYXRlVGV4dE5vZGUpCisKKyAgICAgICAgPGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODk3Nj4KKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzU5MjQ3OTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVXBkYXRlZCB0ZXN0IHJlc3VsdHMgbm93IHRoYXQgJz4nIGlzIGVzY2Fw ZWQgdG8gJyZndDsnIGluIGJvdGgKKyAgICAgICAgYXR0cmlidXRlcyBhbmQgY29udGVudC4KKwor ICAgICAgICAqIGZhc3QveHNsL3hzbHQtcHJvY2Vzc29yLWV4cGVjdGVkLnR4dDoKKyAgICAgICAg KiBmYXN0L3hzbC94c2x0LXRleHQtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHBsYXRmb3JtL21h Yy9mYXN0L2RvbS9kb20tcGFyc2Utc2VyaWFsaXplLWV4cGVjdGVkLnR4dDoKKwogMjAwOC0wNS0x MyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEpvaG4gU3VsbGl2YW4uCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3hzbC94c2x0LXByb2Nlc3Nv ci1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC94c2wveHNsdC1w cm9jZXNzb3ItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAzMzA2MykKKysrIExheW91dFRlc3RzL2Zh c3QveHNsL3hzbHQtcHJvY2Vzc29yLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSwx MCArMSwxMCBAQAogMC4xIG9yaWdpbmFsIHhtbDoKLTw/eG1sLXN0eWxlc2hlZXQgdHlwZT0idGV4 dC94c2wiIGhyZWY9InhzbHQtdGV4dC54c2wiPz48VEVTVD5TT1VSQ0UgWE1MOiAmbHQ7Jmx0OyZs dDsmYW1wO9GC0LXRgdGCJmFtcDs+Pj48L1RFU1Q+Cis8P3htbC1zdHlsZXNoZWV0IHR5cGU9InRl eHQveHNsIiBocmVmPSJ4c2x0LXRleHQueHNsIj8+PFRFU1Q+U09VUkNFIFhNTDogJmx0OyZsdDsm bHQ7JmFtcDvRgtC10YHRgiZhbXA7Jmd0OyZndDsmZ3Q7PC9URVNUPgogMC4yIHhzbDE6CiA8eHNs OnN0eWxlc2hlZXQgeG1sbnM6eHNsPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L1hTTC9UcmFuc2Zv cm0iIHZlcnNpb249IjEuMCI+CiAKIDx4c2w6b3V0cHV0IG1ldGhvZD0idGV4dCIgZW5jb2Rpbmc9 IktPSTgtUiIvPgotPHhzbDp0ZW1wbGF0ZSBtYXRjaD0iVEVTVCI+Q0hBUkFDVEVSUyBJTiBYU0xU OiAmbHQ7Jmx0OyZsdDsmYW1wO9GC0LXRgdGCJmFtcDs+Pj4KKzx4c2w6dGVtcGxhdGUgbWF0Y2g9 IlRFU1QiPkNIQVJBQ1RFUlMgSU4gWFNMVDogJmx0OyZsdDsmbHQ7JmFtcDvRgtC10YHRgiZhbXA7 Jmd0OyZndDsmZ3Q7CiA8eHNsOmFwcGx5LXRlbXBsYXRlcy8+PHhzbDp0ZXh0PgogPC94c2w6dGV4 dD48L3hzbDp0ZW1wbGF0ZT4KIApAQCAtMzcsMTMgKzM3LDEzIEBACiAKIDEuMSBJbXBvcnQgdHdv IGRpZmZlcmVudCBzdHlsZXNoZWV0czoKIDxodG1sIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8x OTk5L3hodG1sIj48aGVhZD48bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9 InRleHQvaHRtbDsgY2hhcnNldD1VVEYtOCI+PC9oZWFkPjxib2R5PgotICAgICAgICAgICAgICBD SEFSQUNURVJTIElOIFhTTFQ6IMOpw6nDqcOpw6nDqcOpw6nDqcOpw6kgPGJyPjxicj5TT1VSQ0Ug WE1MOiAmbHQ7Jmx0OyZsdDsmYW1wO9GC0LXRgdGCJmFtcDs+Pj48L2JvZHk+PC9odG1sPgorICAg ICAgICAgICAgICBDSEFSQUNURVJTIElOIFhTTFQ6IMOpw6nDqcOpw6nDqcOpw6nDqcOpw6kgPGJy Pjxicj5TT1VSQ0UgWE1MOiAmbHQ7Jmx0OyZsdDsmYW1wO9GC0LXRgdGCJmFtcDsmZ3Q7Jmd0OyZn dDs8L2JvZHk+PC9odG1sPgogMS4yIEltcG9ydCBzYW1lIHN0eWxlc2hlZXQgdHdpY2U6CiA8IURP Q1RZUEUgaHRtbCBQVUJMSUMgIi0vL1czQy8vRFREIFhIVE1MIDEuMCBTdHJpY3QvL0VOIiAiaHR0 cDovL3d3dy53My5vcmcvVFIveGh0bWwxL0RURC94aHRtbDEtc3RyaWN0LmR0ZCI+PGh0bWwgeG1s bnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPgogPGhlYWQ+PHRpdGxlPjwvdGl0bGU+ PC9oZWFkPgogPGJvZHk+Ci08cHJlPkNIQVJBQ1RFUlMgSU4gWFNMVDogJmx0OyZsdDsmbHQ7JmFt cDvRgtC10YHRgiZhbXA7Pj4+Ci1TT1VSQ0UgWE1MOiAmbHQ7Jmx0OyZsdDsmYW1wO9GC0LXRgdGC JmFtcDs+Pj48L3ByZT4KKzxwcmU+Q0hBUkFDVEVSUyBJTiBYU0xUOiAmbHQ7Jmx0OyZsdDsmYW1w O9GC0LXRgdGCJmFtcDsmZ3Q7Jmd0OyZndDsKK1NPVVJDRSBYTUw6ICZsdDsmbHQ7Jmx0OyZhbXA7 0YLQtdGB0YImYW1wOyZndDsmZ3Q7Jmd0OzwvcHJlPgogPC9ib2R5PgogPC9odG1sPgogMS4zIElt cG9ydCB1bmRlZmluZWQgc3R5bGVzaGVldDoKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QveHNsL3hz bHQtdGV4dC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC94c2wv eHNsdC10ZXh0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMzMwNjMpCisrKyBMYXlvdXRUZXN0cy9m YXN0L3hzbC94c2x0LXRleHQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0yLDggKzIs OCBAQAogCiA8aGVhZCB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94aHRtbCI+PHRpdGxl PjwvdGl0bGU+PC9oZWFkPgogPGJvZHkgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0 bWwiPgotPHByZT5DSEFSQUNURVJTIElOIFhTTFQ6ICZsdDsmbHQ7Jmx0OyZhbXA70YLQtdGB0YIm YW1wOz4+PgotU09VUkNFIFhNTDogJmx0OyZsdDsmbHQ7JmFtcDvRgtC10YHRgiZhbXA7Pj4+PC9w cmU+Cis8cHJlPkNIQVJBQ1RFUlMgSU4gWFNMVDogJmx0OyZsdDsmbHQ7JmFtcDvRgtC10YHRgiZh bXA7Jmd0OyZndDsmZ3Q7CitTT1VSQ0UgWE1MOiAmbHQ7Jmx0OyZsdDsmYW1wO9GC0LXRgdGCJmFt cDsmZ3Q7Jmd0OyZndDs8L3ByZT4KIDwvYm9keT4KIAogCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvZmFzdC9kb20vZG9tLXBhcnNlLXNlcmlhbGl6ZS1leHBlY3RlZC50eHQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvZG9tL2RvbS1wYXJzZS1zZXJp YWxpemUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAzMzA2MykKKysrIExheW91dFRlc3RzL3BsYXRm b3JtL21hYy9mYXN0L2RvbS9kb20tcGFyc2Utc2VyaWFsaXplLWV4cGVjdGVkLnR4dAkod29ya2lu ZyBjb3B5KQpAQCAtNTcsNCArNTcsNCBAQCBsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKICAg ICAgICAgICAgIHRleHQgcnVuIGF0ICg1MzYsMTUpIHdpZHRoIDA6ICIgIgogICAgICAgICAgICAg dGV4dCBydW4gYXQgKDAsMzApIHdpZHRoIDE4NDogIiAgPGQgaWQ9XCJpZDNcIj5UaHJlZTwvZD4i CiAgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMTg0LDMwKSB3aWR0aCAwOiAiICIKLSAgICAgICAg ICAgIHRleHQgcnVuIGF0ICgwLDQ1KSB3aWR0aCA0NzI6ICI8ZiBpZD1cIiZhbXA7Jmx0Oz5cIj5G b3VyJmFtcDsmbHQ7PjwvZj48ZW1wdHkvPjxlbXB0eS8+PC9kb2M+IgorICAgICAgICAgICAgdGV4 dCBydW4gYXQgKDAsNDUpIHdpZHRoIDUyMDogIjxmIGlkPVwiJmFtcDsmbHQ7Jmd0O1wiPkZvdXIm YW1wOyZsdDsmZ3Q7PC9mPjxlbXB0eS8+PGVtcHR5Lz48L2RvYz4iCg==