189738 2018-09-19 02:09:20 -0700 REGRESSION(r235917): 2% regression in Dromaeo CSS selector on MacBookPro11,4 2018-09-19 22:39:45 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 166748 1 rniwa rniwa cdumez koivisto webkit-bug-importer ysuzuki oldest_to_newest 1460888 0 rniwa 2018-09-19 02:09:20 -0700 https://trac.webkit.org/changeset/235917 introduced ~27% regression in nth-child(~) tests and 2% regression for the total Dromaeo css selector tests. 1460889 1 webkit-bug-importer 2018-09-19 02:09:45 -0700 <rdar://problem/44595527> 1460890 2 350099 rniwa 2018-09-19 02:14:47 -0700 Created attachment 350099 Fixes the bug 1460893 3 350099 ysuzuki 2018-09-19 02:40:26 -0700 Comment on attachment 350099 Fixes the bug r=me with one more fix. I think generateNthLastChildParentCheckAndRelationUpdate has the same issue too. 1461083 4 rniwa 2018-09-19 12:37:31 -0700 (In reply to Yusuke Suzuki from comment #3) > Comment on attachment 350099 [details] > Fixes the bug > > r=me with one more fix. > I think generateNthLastChildParentCheckAndRelationUpdate has the same issue > too. Good catch! Thanks for the review. 1461084 5 350143 rniwa 2018-09-19 12:37:52 -0700 Created attachment 350143 Patch for landing 1461085 6 350143 rniwa 2018-09-19 12:38:09 -0700 Comment on attachment 350143 Patch for landing Wait for EWS. 1461144 7 rniwa 2018-09-19 15:31:20 -0700 Committed r236228: <https://trac.webkit.org/changeset/236228> 1461234 8 ysuzuki 2018-09-19 22:39:45 -0700 Nice, it seems the regression is recovered. https://perf.webkit.org/v3/#/charts?since=1536816937999&paneList=((19-31)-(19-39)-(19-36)) 350099 2018-09-19 02:14:47 -0700 2018-09-19 12:37:50 -0700 Fixes the bug bug-189738-20180919021447.patch text/plain 1590 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNjE2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA5LTE5ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIzNTkxNyk6 IDIlIHJlZ3Jlc3Npb24gaW4gRHJvbWFlbyBDU1Mgc2VsZWN0b3Igb24gTWFjQm9va1BybzExLDQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTczOAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSByZWdy ZXNzaW9uIHdhcyBjYXVzZWQgYnkgdGhlIHJlZ3VuZGFudCB3YWxrIHRvIHRoZSBwYXJlbnQgZWxl bWVudC4gUmVtb3ZlZCBpdCB0byBmaXggdGhlIHJlZ3Jlc3Npb24uCisKKyAgICAgICAgKiBjc3Nq aXQvU2VsZWN0b3JDb21waWxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3RvckNvbXBp bGVyOjpTZWxlY3RvckNvZGVHZW5lcmF0b3I6OmdlbmVyYXRlTnRoQ2hpbGRQYXJlbnRDaGVja0Fu ZFJlbGF0aW9uVXBkYXRlKToKKwogMjAxOC0wOS0xOSAgUGhpbGlwcGUgTm9ybWFuZCA8cG5vcm1h bmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBBZGQgc3VwcG9ydCBmb3IgQVYx IGRlY29kaW5nCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3NqaXQvU2VsZWN0b3JDb21waWxlci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3Nzaml0L1NlbGVjdG9yQ29tcGlsZXIu Y3BwCShyZXZpc2lvbiAyMzYxNjUpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3NqaXQvU2VsZWN0b3JD b21waWxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1NTEsNyArMzU1MSw2IEBAIHZvaWQgU2Vs ZWN0b3JDb2RlR2VuZXJhdG9yOjpnZW5lcmF0ZU50aEMKICAgICBmYWlsdXJlQ2FzZXMuYXBwZW5k KG1fYXNzZW1ibGVyLmJyYW5jaFRlc3RQdHIoQXNzZW1ibGVyOjpaZXJvLCBwYXJlbnROb2RlKSk7 CiAgICAgQXNzZW1ibGVyOjpKdW1wIG5vdEVsZW1lbnQgPSBET01KSVQ6OmJyYW5jaFRlc3RJc0Vs ZW1lbnRGbGFnT25Ob2RlKG1fYXNzZW1ibGVyLCBBc3NlbWJsZXI6Olplcm8sIHBhcmVudE5vZGUp OwogCi0gICAgZ2VuZXJhdGVXYWxrVG9QYXJlbnRFbGVtZW50KGZhaWx1cmVDYXNlcywgcGFyZW50 Tm9kZSk7CiAgICAgYXV0byByZWxhdGlvbiA9IGZyYWdtZW50TWF0Y2hlc1JpZ2h0bW9zdE9yQWRq YWNlbnRFbGVtZW50KGZyYWdtZW50KQogICAgICAgICA/IFN0eWxlOjpSZWxhdGlvbjo6Q2hpbGRy ZW5BZmZlY3RlZEJ5Rm9yd2FyZFBvc2l0aW9uYWxSdWxlcwogICAgICAgICA6IFN0eWxlOjpSZWxh dGlvbjo6RGVzY2VuZGFudHNBZmZlY3RlZEJ5Rm9yd2FyZFBvc2l0aW9uYWxSdWxlczsK 350143 2018-09-19 12:37:52 -0700 2018-09-19 12:38:09 -0700 Patch for landing bug-189738-20180919123751.patch text/plain 2239 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNjE2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA5LTE5ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIzNTkxNyk6 IDIlIHJlZ3Jlc3Npb24gaW4gRHJvbWFlbyBDU1Mgc2VsZWN0b3Igb24gTWFjQm9va1BybzExLDQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTczOAor CisgICAgICAgIFJldmlld2VkIGJ5IFl1c3VrZSBTdXp1a2kuCisKKyAgICAgICAgVGhlIHJlZ3Jl c3Npb24gd2FzIGNhdXNlZCBieSB0aGUgcmVndW5kYW50IHdhbGsgdG8gdGhlIHBhcmVudCBlbGVt ZW50LiBSZW1vdmVkIGl0IHRvIGZpeCB0aGUgcmVncmVzc2lvbi4KKworICAgICAgICAqIGNzc2pp dC9TZWxlY3RvckNvbXBpbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdG9yQ29tcGls ZXI6OlNlbGVjdG9yQ29kZUdlbmVyYXRvcjo6Z2VuZXJhdGVOdGhDaGlsZFBhcmVudENoZWNrQW5k UmVsYXRpb25VcGRhdGUpOgorICAgICAgICAoV2ViQ29yZTo6U2VsZWN0b3JDb21waWxlcjo6U2Vs ZWN0b3JDb2RlR2VuZXJhdG9yOjpnZW5lcmF0ZU50aExhc3RDaGlsZFBhcmVudENoZWNrQW5kUmVs YXRpb25VcGRhdGUpOgorCiAyMDE4LTA5LTE5ICBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIEFkZCBzdXBwb3J0IGZvciBBVjEgZGVj b2RpbmcKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzc2ppdC9TZWxlY3RvckNvbXBpbGVyLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3NqaXQvU2VsZWN0b3JDb21waWxlci5jcHAJ KHJldmlzaW9uIDIzNjE2NSkKKysrIFNvdXJjZS9XZWJDb3JlL2Nzc2ppdC9TZWxlY3RvckNvbXBp bGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzU1MSw3ICszNTUxLDYgQEAgdm9pZCBTZWxlY3Rv ckNvZGVHZW5lcmF0b3I6OmdlbmVyYXRlTnRoQwogICAgIGZhaWx1cmVDYXNlcy5hcHBlbmQobV9h c3NlbWJsZXIuYnJhbmNoVGVzdFB0cihBc3NlbWJsZXI6Olplcm8sIHBhcmVudE5vZGUpKTsKICAg ICBBc3NlbWJsZXI6Okp1bXAgbm90RWxlbWVudCA9IERPTUpJVDo6YnJhbmNoVGVzdElzRWxlbWVu dEZsYWdPbk5vZGUobV9hc3NlbWJsZXIsIEFzc2VtYmxlcjo6WmVybywgcGFyZW50Tm9kZSk7CiAK LSAgICBnZW5lcmF0ZVdhbGtUb1BhcmVudEVsZW1lbnQoZmFpbHVyZUNhc2VzLCBwYXJlbnROb2Rl KTsKICAgICBhdXRvIHJlbGF0aW9uID0gZnJhZ21lbnRNYXRjaGVzUmlnaHRtb3N0T3JBZGphY2Vu dEVsZW1lbnQoZnJhZ21lbnQpCiAgICAgICAgID8gU3R5bGU6OlJlbGF0aW9uOjpDaGlsZHJlbkFm ZmVjdGVkQnlGb3J3YXJkUG9zaXRpb25hbFJ1bGVzCiAgICAgICAgIDogU3R5bGU6OlJlbGF0aW9u OjpEZXNjZW5kYW50c0FmZmVjdGVkQnlGb3J3YXJkUG9zaXRpb25hbFJ1bGVzOwpAQCAtMzY3Myw3 ICszNjcyLDYgQEAgdm9pZCBTZWxlY3RvckNvZGVHZW5lcmF0b3I6OmdlbmVyYXRlTnRoTAogICAg IGZhaWx1cmVDYXNlcy5hcHBlbmQobV9hc3NlbWJsZXIuYnJhbmNoVGVzdFB0cihBc3NlbWJsZXI6 Olplcm8sIHBhcmVudE5vZGUpKTsKICAgICBBc3NlbWJsZXI6Okp1bXAgbm90RWxlbWVudCA9IERP TUpJVDo6YnJhbmNoVGVzdElzRWxlbWVudEZsYWdPbk5vZGUobV9hc3NlbWJsZXIsIEFzc2VtYmxl cjo6WmVybywgcGFyZW50Tm9kZSk7CiAKLSAgICBnZW5lcmF0ZVdhbGtUb1BhcmVudEVsZW1lbnQo ZmFpbHVyZUNhc2VzLCBwYXJlbnROb2RlKTsKICAgICBhdXRvIHJlbGF0aW9uID0gZnJhZ21lbnRN YXRjaGVzUmlnaHRtb3N0T3JBZGphY2VudEVsZW1lbnQoZnJhZ21lbnQpCiAgICAgICAgID8gU3R5 bGU6OlJlbGF0aW9uOjpDaGlsZHJlbkFmZmVjdGVkQnlCYWNrd2FyZFBvc2l0aW9uYWxSdWxlcwog ICAgICAgICA6IFN0eWxlOjpSZWxhdGlvbjo6RGVzY2VuZGFudHNBZmZlY3RlZEJ5QmFja3dhcmRQ b3NpdGlvbmFsUnVsZXM7Cg==