189720 2018-09-18 15:39:50 -0700 REGRESSION (r236006): New waitingForKey() requirement breaks Modern EME tests. 2018-09-19 06:58:36 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 189616 1 jer.noble jer.noble calvaris commit-queue eric.carlson ryanhaddad webkit-bug-importer oldest_to_newest 1460785 0 jer.noble 2018-09-18 15:39:50 -0700 REGRESSION (r236006): New waitingForKey() requirement breaks Modern EME tests. 1460786 1 jer.noble 2018-09-18 15:40:21 -0700 <rdar://problem/44572140> 1460787 2 350069 jer.noble 2018-09-18 15:41:41 -0700 Created attachment 350069 Patch 1460860 3 350069 calvaris 2018-09-18 23:55:08 -0700 Comment on attachment 350069 Patch Reading your analysis of bug 189616, this will fix your regression if you consider that you're waiting for a key just when you fire the initialization data and will allow to not bail out in step 2 of https://www.w3.org/TR/encrypted-media/#resume-playback . rs=me 1460940 4 350069 commit-queue 2018-09-19 06:58:34 -0700 Comment on attachment 350069 Patch Clearing flags on attachment: 350069 Committed r236204: <https://trac.webkit.org/changeset/236204> 1460941 5 commit-queue 2018-09-19 06:58:36 -0700 All reviewed patches have been landed. Closing bug. 350069 2018-09-18 15:41:41 -0700 2018-09-19 06:58:34 -0700 Patch bug-189720-20180918154140.patch text/plain 2871 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDI2ZTEyOGNjYmYxNDQ5 ZGEyMWM1YTZiMTI0MTZjMzRmNjJhMzhjZC4uYTk5YTVlNGI1Yzg0YTRmNmI4NDMwODM3YjNhNWMz MWU3MDkwOGYwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA5LTE4ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMzYw MDYpOiBOZXcgd2FpdGluZ0ZvcktleSgpIHJlcXVpcmVtZW50IGJyZWFrcyBNb2Rlcm4gRU1FIHRl c3RzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5 NzIwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NDU3MjE0MD4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbHdheXMgY2FsbCB3YWl0aW5nRm9yS2V5 KCkgYWZ0ZXIgY2FsbGluZyBpbml0aWFsaXphdGlvbkRhdGFFbmNvdW50ZXJlZCgpLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2 YXRlQVZGb3VuZGF0aW9uT2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJp dmF0ZUFWRm91bmRhdGlvbk9iakM6OnNob3VsZFdhaXRGb3JMb2FkaW5nT2ZSZXNvdXJjZSk6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQ cml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDLm1tOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5 ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDOjppbml0aWFsaXphdGlvbkRhdGFFbmNvdW50ZXJl ZCk6CisKIDIwMTgtMDktMTIgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAg ICAgICAgQWRkIHN1cHBvcnQgZm9yIEhFVkMgY29kZWMgdHlwZXMgaW4gTWVkaWEgQ2FwYWJpbGl0 aWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5k YXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQ cml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbQppbmRleCAwZmIxMzA4ZDlhOGExMTcwNjk0ZDJiMzIx Njk0NmQ0NDMyYWMwNmVlLi5hZDI2ZTU4OWNjMDA3NjI1ODdmMTQzM2Y2ZjBiMWExMzc5OTE2ZmEx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRp b24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVy UHJpdmF0ZUFWRm91bmRhdGlvbk9iakMubW0KQEAgLTE3ODgsNiArMTc4OCw3IEBAIGJvb2wgTWVk aWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6c2hvdWxkV2FpdEZvckxvYWRpbmdPZlJl c291cmNlKEFWQXNzZXRSCiAgICAgICAgIFJldGFpblB0cjxOU0RhdGE+IGtleVVSSURhdGEgPSBb a2V5VVJJIGRhdGFVc2luZ0VuY29kaW5nOk5TVVRGOFN0cmluZ0VuY29kaW5nIGFsbG93TG9zc3lD b252ZXJzaW9uOllFU107CiAgICAgICAgIGF1dG8ga2V5VVJJQnVmZmVyID0gU2hhcmVkQnVmZmVy OjpjcmVhdGUoa2V5VVJJRGF0YS5nZXQoKSk7CiAgICAgICAgIHBsYXllcigpLT5pbml0aWFsaXph dGlvbkRhdGFFbmNvdW50ZXJlZCgic2tkIl9zLCBrZXlVUklCdWZmZXItPnRyeUNyZWF0ZUFycmF5 QnVmZmVyKCkpOworICAgICAgICBwbGF5ZXIoKS0+d2FpdGluZ0ZvcktleSgpOwogI2VuZGlmCiAg ICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlh U291cmNlQVZGT2JqQy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91 bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU291cmNlQVZGT2JqQy5tbQppbmRl eCBiMDJjNjIzMmMwMTJjNmQ3MmVjMjc2NTczZDdiOGFlOGUwZTM4NTk4Li40YzEwODczNWVlMzY5 YzEzY2M1MDg2ZjJjMTM0YjdlMDQ0ZDIzMzM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRp YVNvdXJjZUFWRk9iakMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv YXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDLm1t CkBAIC05NjksNiArOTY5LDcgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVNZWRpYVNvdXJjZUFW Rk9iakM6OmF0dGVtcHRUb0RlY3J5cHRXaXRoSW5zdGFuY2UoQ0RNSW5zdGEKIHZvaWQgTWVkaWFQ bGF5ZXJQcml2YXRlTWVkaWFTb3VyY2VBVkZPYmpDOjppbml0aWFsaXphdGlvbkRhdGFFbmNvdW50 ZXJlZChjb25zdCBTdHJpbmcmIGluaXREYXRhVHlwZSwgUmVmUHRyPEFycmF5QnVmZmVyPiYmIGlu aXREYXRhKQogewogICAgIG1fcGxheWVyLT5pbml0aWFsaXphdGlvbkRhdGFFbmNvdW50ZXJlZChp bml0RGF0YVR5cGUsIFdURk1vdmUoaW5pdERhdGEpKTsKKyAgICBtX3BsYXllci0+d2FpdGluZ0Zv cktleSgpOwogfQogI2VuZGlmCiAK