189697 2018-09-18 05:01:51 -0700 [WPE] Implement mouse event modifiers 2018-09-18 06:44:38 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 189664 1 csaavedra csaavedra bugs-noreply cgarcia commit-queue oldest_to_newest 1460556 0 csaavedra 2018-09-18 05:01:51 -0700 [WPE] Implement mouse event modifiers 1460557 1 350015 csaavedra 2018-09-18 05:03:25 -0700 Created attachment 350015 Patch 1460570 2 350015 commit-queue 2018-09-18 06:44:37 -0700 Comment on attachment 350015 Patch Clearing flags on attachment: 350015 Committed r236124: <https://trac.webkit.org/changeset/236124> 1460571 3 commit-queue 2018-09-18 06:44:38 -0700 All reviewed patches have been landed. Closing bug. 350015 2018-09-18 05:03:25 -0700 2018-09-18 06:44:37 -0700 Patch bug-189697-20180918150324.patch text/plain 7268 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDllZWNhZjRkOTg4MDY0NWFk MGIxYTdmZGU5MjhkNmY4YWMyY2M1MGQuLmFmNTU3ODFkY2ZiMWE1MDRjMTRhODQ3NThkY2QxZDc5 YjkwODljOTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDktMTggIENsYXVkaW8g U2FhdmVkcmEgIDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBJbXBsZW1l bnQgbW91c2UgZXZlbnQgbW9kaWZpZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODk2OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBPbmx5ICJDYXBzTG9ja3MiIGlzIG1pc3NpbmcsIGFzIFdQRSBkb2Vz bid0IHN1cHBvcnQgdGhhdCBtb2RpZmllci4KKyAgICAgICAgKiBTaGFyZWQvd3BlL1dlYkV2ZW50 RmFjdG9yeS5jcHA6CisgICAgICAgIChXZWJLaXQ6Om1vZGlmaWVyc0ZvckV2ZW50TW9kaWZpZXJz KToKKyAgICAgICAgKFdlYktpdDo6V2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWJLZXlib2FyZEV2 ZW50KToKKyAgICAgICAgKFdlYktpdDo6V2ViRXZlbnRGYWN0b3J5OjpjcmVhdGVXZWJNb3VzZUV2 ZW50KToKKyAgICAgICAgKFdlYktpdDo6bW9kaWZpZXJzRm9yRXZlbnQpOiBEZWxldGVkLgorCiAy MDE4LTA5LTE3ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCBmaXggaW5jb3JyZWN0IFdQRSBidWlsZCBmaXggbWFkZSBpbiBy MjM2MDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC93cGUvV2ViRXZlbnRGYWN0 b3J5LmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL3dwZS9XZWJFdmVudEZhY3RvcnkuY3BwCmlu ZGV4IDJhMmY1MTlmODc4YmQ2YzJjYmQ2NGY3NGE4NjdhODZjOGU0ZWYwYTIuLmI3MThjOTAxYzc0 YmMwODc4YTJjYWIzMGI2Zjg1ZWNiMjNiYTgyODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv U2hhcmVkL3dwZS9XZWJFdmVudEZhY3RvcnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVk L3dwZS9XZWJFdmVudEZhY3RvcnkuY3BwCkBAIC0zOCwxMCArMzgsOSBAQCBzdGF0aWMgaW5saW5l IGJvb2wgaXNXUEVLZXlDb2RlRnJvbUtleVBhZCh1bnNpZ25lZCBrZXlDb2RlKQogICAgIHJldHVy biBrZXlDb2RlID49IFdQRV9LRVlfS1BfU3BhY2UgJiYga2V5Q29kZSA8PSBXUEVfS0VZX0tQXzk7 CiB9CiAKLXN0YXRpYyBXZWJFdmVudDo6TW9kaWZpZXJzIG1vZGlmaWVyc0ZvckV2ZW50KHN0cnVj dCB3cGVfaW5wdXRfa2V5Ym9hcmRfZXZlbnQqIGV2ZW50KQorc3RhdGljIFdlYkV2ZW50OjpNb2Rp ZmllcnMgbW9kaWZpZXJzRm9yRXZlbnRNb2RpZmllcnModW5zaWduZWQgZXZlbnRNb2RpZmllcnMp CiB7CiAgICAgdW5zaWduZWQgbW9kaWZpZXJzID0gMDsKLSAgICB1bnNpZ25lZCBldmVudE1vZGlm aWVycyA9IGV2ZW50LT5tb2RpZmllcnM7CiAKICAgICBpZiAoZXZlbnRNb2RpZmllcnMgJiB3cGVf aW5wdXRfa2V5Ym9hcmRfbW9kaWZpZXJfY29udHJvbCkKICAgICAgICAgbW9kaWZpZXJzIHw9IFdl YkV2ZW50OjpDb250cm9sS2V5OwpAQCAtNzcsNyArNzYsNyBAQCBXZWJLZXlib2FyZEV2ZW50IFdl YkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViS2V5Ym9hcmRFdmVudChzdHJ1Y3Qgd3BlX2lucHV0X2tl eWJvYQogICAgICAgICBXZWJDb3JlOjpQbGF0Zm9ybUtleWJvYXJkRXZlbnQ6OndpbmRvd3NLZXlD b2RlRm9yV1BFS2V5Q29kZShldmVudC0+a2V5X2NvZGUpLAogICAgICAgICBldmVudC0+a2V5X2Nv ZGUsCiAgICAgICAgIGlzV1BFS2V5Q29kZUZyb21LZXlQYWQoZXZlbnQtPmtleV9jb2RlKSwKLSAg ICAgICAgbW9kaWZpZXJzRm9yRXZlbnQoZXZlbnQpLAorICAgICAgICBtb2RpZmllcnNGb3JFdmVu dE1vZGlmaWVycyhldmVudC0+bW9kaWZpZXJzKSwKICAgICAgICAgd2FsbFRpbWVGb3JFdmVudFRp bWUoZXZlbnQtPnRpbWUpKTsKIH0KIApAQCAtMTM3LDExICsxMzYsMTEgQEAgV2ViTW91c2VFdmVu dCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYk1vdXNlRXZlbnQoc3RydWN0IHdwZV9pbnB1dF9w b2ludGVyX2V2ZW4KIAogICAgIHVuc2lnbmVkIGNsaWNrQ291bnQgPSAodHlwZSA9PSBXZWJFdmVu dDo6TW91c2VEb3duKSA/IDEgOiAwOwogCi0gICAgLy8gRklYTUU6IFByb3BlciBidXR0b24gc3Vw cG9ydC4gTW9kaWZpZXJzLiBkZWx0YVgvWS9aLiBDbGljayBjb3VudC4KKyAgICAvLyBGSVhNRTog UHJvcGVyIGJ1dHRvbiBzdXBwb3J0LiBkZWx0YVgvWS9aLiBDbGljayBjb3VudC4KICAgICBXZWJD b3JlOjpJbnRQb2ludCBwb3NpdGlvbihldmVudC0+eCwgZXZlbnQtPnkpOwogICAgIHBvc2l0aW9u LnNjYWxlKDEgLyBkZXZpY2VTY2FsZUZhY3Rvcik7CiAgICAgcmV0dXJuIFdlYk1vdXNlRXZlbnQo dHlwZSwgYnV0dG9uLCBwcmVzc2VkTW91c2VCdXR0b25zKGV2ZW50LT5tb2RpZmllcnMpLCBwb3Np dGlvbiwgcG9zaXRpb24sCi0gICAgICAgIDAsIDAsIDAsIGNsaWNrQ291bnQsIHN0YXRpY19jYXN0 PFdlYkV2ZW50OjpNb2RpZmllcnM+KDApLCB3YWxsVGltZUZvckV2ZW50VGltZShldmVudC0+dGlt ZSkpOworICAgICAgICAwLCAwLCAwLCBjbGlja0NvdW50LCBtb2RpZmllcnNGb3JFdmVudE1vZGlm aWVycyhldmVudC0+bW9kaWZpZXJzKSwgd2FsbFRpbWVGb3JFdmVudFRpbWUoZXZlbnQtPnRpbWUp KTsKIH0KIAogV2ViV2hlZWxFdmVudCBXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYldoZWVsRXZl bnQoc3RydWN0IHdwZV9pbnB1dF9heGlzX2V2ZW50KiBldmVudCwgZmxvYXQgZGV2aWNlU2NhbGVG YWN0b3IpCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5k ZXggNWZlMDY0ZWU4ODE5OGZkM2M1M2I0MzM2NmQxMTk3ZDE2NmIxMmEwMy4uNzE4YmY3NzM3NjBh ODFhY2VkYjY2MWMxNjQwMWUzZDIxMWRiZDJjMCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9n CisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA5LTE4ICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gSW1w bGVtZW50IG1vdXNlIGV2ZW50IG1vZGlmaWVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5Njk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL3dwZS9FdmVudFNlbmRlclBy b3h5V1BFLmNwcDoKKyAgICAgICAgKFdUUjo6d2tFdmVudE1vZGlmaWVyc1RvV1BFKToKKyAgICAg ICAgKFdUUjo6RXZlbnRTZW5kZXJQcm94eTo6bW91c2VEb3duKToKKyAgICAgICAgKFdUUjo6RXZl bnRTZW5kZXJQcm94eTo6bW91c2VVcCk6CisKIDIwMTgtMDktMTcgIFBoaWxpcHBlIE5vcm1hbmQg IDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtKSEJ1aWxkXSBVcGRhdGUgdG8gR1N0 cmVhbWVyIDEuMTQuMwpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci93cGUvRXZl bnRTZW5kZXJQcm94eVdQRS5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3dwZS9FdmVudFNl bmRlclByb3h5V1BFLmNwcAppbmRleCA5MmEzZTQ0NzA3Y2Q1YzU2YmVkMGY5YWJhODQ1Yzg3MmFm MDAzYjcyLi5hODBkMTZiMWE5ZDZhOTkwYzBhYTE0OWFjMjNiMDQ1ZWUzYjE1OTk5IDEwMDY0NAot LS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3dwZS9FdmVudFNlbmRlclByb3h5V1BFLmNwcAor KysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3dwZS9FdmVudFNlbmRlclByb3h5V1BFLmNwcApA QCAtMTA0LDYgKzEwNCwyMSBAQCBzdGF0aWMgdWludDMyX3QgbW9kaWZpZXJGb3JCdXR0b24odW5z aWduZWQgYnV0dG9uKQogICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CiB9CiAKK3N0 YXRpYyB1aW50MzJfdCB3a0V2ZW50TW9kaWZpZXJzVG9XUEUoV0tFdmVudE1vZGlmaWVycyB3a01v ZGlmaWVycykKK3sKKyAgICB1aW50MzJfdCBtb2RpZmllcnMgPSAwOworICAgIGlmICh3a01vZGlm aWVycyAmIGtXS0V2ZW50TW9kaWZpZXJzU2hpZnRLZXkpCisgICAgICAgIG1vZGlmaWVycyB8PSAg d3BlX2lucHV0X2tleWJvYXJkX21vZGlmaWVyX3NoaWZ0OworICAgIGlmICh3a01vZGlmaWVycyAm IGtXS0V2ZW50TW9kaWZpZXJzQ29udHJvbEtleSkKKyAgICAgICAgbW9kaWZpZXJzIHw9IHdwZV9p bnB1dF9rZXlib2FyZF9tb2RpZmllcl9jb250cm9sOworICAgIGlmICh3a01vZGlmaWVycyAmIGtX S0V2ZW50TW9kaWZpZXJzQWx0S2V5KQorICAgICAgICBtb2RpZmllcnMgfD0gd3BlX2lucHV0X2tl eWJvYXJkX21vZGlmaWVyX2FsdDsKKyAgICBpZiAod2tNb2RpZmllcnMgJiBrV0tFdmVudE1vZGlm aWVyc01ldGFLZXkpCisgICAgICAgIG1vZGlmaWVycyB8PSB3cGVfaW5wdXRfa2V5Ym9hcmRfbW9k aWZpZXJfbWV0YTsKKworICAgIHJldHVybiBtb2RpZmllcnM7Cit9CisKIHZvaWQgRXZlbnRTZW5k ZXJQcm94eTo6bW91c2VEb3duKHVuc2lnbmVkIGJ1dHRvbiwgV0tFdmVudE1vZGlmaWVycyB3a01v ZGlmaWVycykKIHsKICAgICBtX2NsaWNrQnV0dG9uID0gYnV0dG9uOwpAQCAtMTEzLDggKzEyOCw5 IEBAIHZvaWQgRXZlbnRTZW5kZXJQcm94eTo6bW91c2VEb3duKHVuc2lnbmVkIGJ1dHRvbiwgV0tF dmVudE1vZGlmaWVycyB3a01vZGlmaWVycykKIAogICAgIGF1dG8gd3BlQnV0dG9uID0gc2VuZGVy QnV0dG9uVG9XUEVCdXR0b24oYnV0dG9uKTsKICAgICBtX21vdXNlQnV0dG9uc0N1cnJlbnRseURv d24gfD0gbW9kaWZpZXJGb3JCdXR0b24od3BlQnV0dG9uKTsKKyAgICB1aW50MzJfdCBtb2RpZmll cnMgPSB3a0V2ZW50TW9kaWZpZXJzVG9XUEUod2tNb2RpZmllcnMpOwogCi0gICAgc3RydWN0IHdw ZV9pbnB1dF9wb2ludGVyX2V2ZW50IGV2ZW50IHsgd3BlX2lucHV0X3BvaW50ZXJfZXZlbnRfdHlw ZV9idXR0b24sIHN0YXRpY19jYXN0PHVpbnQzMl90PihtX3RpbWUpLCBzdGF0aWNfY2FzdDxpbnQ+ KG1fcG9zaXRpb24ueCksIHN0YXRpY19jYXN0PGludD4obV9wb3NpdGlvbi55KSwgd3BlQnV0dG9u LCBtX2J1dHRvblN0YXRlLCBtX21vdXNlQnV0dG9uc0N1cnJlbnRseURvd24gfTsKKyAgICBzdHJ1 Y3Qgd3BlX2lucHV0X3BvaW50ZXJfZXZlbnQgZXZlbnQgeyB3cGVfaW5wdXRfcG9pbnRlcl9ldmVu dF90eXBlX2J1dHRvbiwgc3RhdGljX2Nhc3Q8dWludDMyX3Q+KG1fdGltZSksIHN0YXRpY19jYXN0 PGludD4obV9wb3NpdGlvbi54KSwgc3RhdGljX2Nhc3Q8aW50PihtX3Bvc2l0aW9uLnkpLCB3cGVC dXR0b24sIG1fYnV0dG9uU3RhdGUsIG1fbW91c2VCdXR0b25zQ3VycmVudGx5RG93biB8IG1vZGlm aWVycyB9OwogICAgIHdwZV92aWV3X2JhY2tlbmRfZGlzcGF0Y2hfcG9pbnRlcl9ldmVudChtX3Zp ZXdCYWNrZW5kLCAmZXZlbnQpOwogfQogCkBAIC0xMjUsOCArMTQxLDkgQEAgdm9pZCBFdmVudFNl bmRlclByb3h5Ojptb3VzZVVwKHVuc2lnbmVkIGJ1dHRvbiwgV0tFdmVudE1vZGlmaWVycyB3a01v ZGlmaWVycykKIAogICAgIGF1dG8gd3BlQnV0dG9uID0gc2VuZGVyQnV0dG9uVG9XUEVCdXR0b24o YnV0dG9uKTsKICAgICBtX21vdXNlQnV0dG9uc0N1cnJlbnRseURvd24gJj0gfm1vZGlmaWVyRm9y QnV0dG9uKHdwZUJ1dHRvbik7CisgICAgdWludDMyX3QgbW9kaWZpZXJzID0gd2tFdmVudE1vZGlm aWVyc1RvV1BFKHdrTW9kaWZpZXJzKTsKIAotICAgIHN0cnVjdCB3cGVfaW5wdXRfcG9pbnRlcl9l dmVudCBldmVudCB7IHdwZV9pbnB1dF9wb2ludGVyX2V2ZW50X3R5cGVfYnV0dG9uLCBzdGF0aWNf Y2FzdDx1aW50MzJfdD4obV90aW1lKSwgc3RhdGljX2Nhc3Q8aW50PihtX3Bvc2l0aW9uLngpLCBz dGF0aWNfY2FzdDxpbnQ+KG1fcG9zaXRpb24ueSksIHdwZUJ1dHRvbiwgbV9idXR0b25TdGF0ZSwg bV9tb3VzZUJ1dHRvbnNDdXJyZW50bHlEb3duIH07CisgICAgc3RydWN0IHdwZV9pbnB1dF9wb2lu dGVyX2V2ZW50IGV2ZW50IHsgd3BlX2lucHV0X3BvaW50ZXJfZXZlbnRfdHlwZV9idXR0b24sIHN0 YXRpY19jYXN0PHVpbnQzMl90PihtX3RpbWUpLCBzdGF0aWNfY2FzdDxpbnQ+KG1fcG9zaXRpb24u eCksIHN0YXRpY19jYXN0PGludD4obV9wb3NpdGlvbi55KSwgd3BlQnV0dG9uLCBtX2J1dHRvblN0 YXRlLCBtX21vdXNlQnV0dG9uc0N1cnJlbnRseURvd24gfCBtb2RpZmllcnMgfTsKICAgICB3cGVf dmlld19iYWNrZW5kX2Rpc3BhdGNoX3BvaW50ZXJfZXZlbnQobV92aWV3QmFja2VuZCwgJmV2ZW50 KTsKIH0KIApAQCAtMTY5LDIxICsxODYsNiBAQCB2b2lkIEV2ZW50U2VuZGVyUHJveHk6OmxlYXBG b3J3YXJkKGludCBtaWxsaXNlY29uZHMpCiAgICAgbV90aW1lICs9IG1pbGxpc2Vjb25kcyAvIDEw MDAuMDsKIH0KIAotc3RhdGljIHVpbnQzMl90IHdrRXZlbnRNb2RpZmllcnNUb1dQRShXS0V2ZW50 TW9kaWZpZXJzIHdrTW9kaWZpZXJzKQotewotICAgIHVpbnQzMl90IG1vZGlmaWVycyA9IDA7Ci0g ICAgaWYgKHdrTW9kaWZpZXJzICYga1dLRXZlbnRNb2RpZmllcnNTaGlmdEtleSkKLSAgICAgICAg bW9kaWZpZXJzIHw9ICB3cGVfaW5wdXRfa2V5Ym9hcmRfbW9kaWZpZXJfc2hpZnQ7Ci0gICAgaWYg KHdrTW9kaWZpZXJzICYga1dLRXZlbnRNb2RpZmllcnNDb250cm9sS2V5KQotICAgICAgICBtb2Rp ZmllcnMgfD0gd3BlX2lucHV0X2tleWJvYXJkX21vZGlmaWVyX2NvbnRyb2w7Ci0gICAgaWYgKHdr TW9kaWZpZXJzICYga1dLRXZlbnRNb2RpZmllcnNBbHRLZXkpCi0gICAgICAgIG1vZGlmaWVycyB8 PSB3cGVfaW5wdXRfa2V5Ym9hcmRfbW9kaWZpZXJfYWx0OwotICAgIGlmICh3a01vZGlmaWVycyAm IGtXS0V2ZW50TW9kaWZpZXJzTWV0YUtleSkKLSAgICAgICAgbW9kaWZpZXJzIHw9IHdwZV9pbnB1 dF9rZXlib2FyZF9tb2RpZmllcl9tZXRhOwotCi0gICAgcmV0dXJuIG1vZGlmaWVyczsKLX0KLQog c3RhdGljIHVpbnQzMl90IHdwZUtleVN5bUZvcktleVJlZihXS1N0cmluZ1JlZiBrZXlSZWYsIHVu c2lnbmVkIGxvY2F0aW9uLCB1aW50MzJfdCogbW9kaWZpZXJzKQogewogICAgIGlmIChsb2NhdGlv biA9PSBET01LZXlMb2NhdGlvbk51bXBhZCkgewo=