189685 2018-09-17 18:02:06 -0700 [macOS] Frequent leaks seen under WebCore::gpuIDForDisplayMask 2018-09-18 20:18:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue darin ews-watchlist joepeck justin_fan pvollan simon.fraser webkit-bug-importer oldest_to_newest 1460445 0 joepeck 2018-09-17 18:02:06 -0700 I'm seeing leaks in Safari Technology Preview under WebCore::gpuIDForDisplayMask: STACK OF 1 INSTANCE OF 'ROOT LEAK: <0x7f91804bee50>': 58 libdyld.dylib 0x7fff5b67a085 start + 1 57 com.apple.AppKit 0x7fff2b99ee97 NSApplicationMain + 780 ... 5 com.apple.WebKit 0x1088c2a0f WebKit::WebProcessPool::platformInitializeWebProcess(WebKit::WebProcessCreationParameters&) + 1359 4 com.apple.WebCore 0x109aa9064 WebCore::collectScreenProperties() + 900 3 com.apple.WebCore 0x109aa9335 WebCore::gpuIDForDisplayMask(unsigned int) + 37 2 com.apple.opengl 0x7fff3857fb2d CGLQueryRendererInfo + 529 1 libsystem_malloc.dylib 0x7fff5b827783 malloc + 24 0 libsystem_malloc.dylib 0x7fff5b82782b malloc_zone_malloc + 139 ==== 24 (6.75K) << TOTAL >> 1 (288 bytes) ROOT LEAK: 0x7f9164707d40 [288] 1 (288 bytes) ROOT LEAK: 0x7f9164713e60 [288] 1 (288 bytes) ROOT LEAK: 0x7f91647272c0 [288] 1 (288 bytes) ROOT LEAK: 0x7f9164739010 [288] We should be calling CGLDestroyRendererInfo at some point on the renderer we got from CGLQueryRendererInfo. 1460447 1 349982 joepeck 2018-09-17 18:03:59 -0700 Created attachment 349982 [PATCH] Proposed Fix 1460448 2 webkit-bug-importer 2018-09-17 18:04:20 -0700 <rdar://problem/44541974> 1460449 3 ews-watchlist 2018-09-17 18:06:17 -0700 Attachment 349982 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1460468 4 349990 joepeck 2018-09-17 19:11:47 -0700 Created attachment 349990 [PATCH] Proposed Fix 1460473 5 349990 pvollan 2018-09-17 19:52:28 -0700 Comment on attachment 349990 [PATCH] Proposed Fix r=me. 1460659 6 349990 commit-queue 2018-09-18 11:30:12 -0700 Comment on attachment 349990 [PATCH] Proposed Fix Clearing flags on attachment: 349990 Committed r236148: <https://trac.webkit.org/changeset/236148> 1460660 7 commit-queue 2018-09-18 11:30:14 -0700 All reviewed patches have been landed. Closing bug. 1460843 8 darin 2018-09-18 20:18:04 -0700 Joe, for cases like this we might also want to consider a std::unique_ptr with a custom deleter. This is one way to avoid repeating the destruction code so many times. 349982 2018-09-17 18:03:59 -0700 2018-09-17 19:11:47 -0700 [PATCH] Proposed Fix leaks-1.patch text/plain 1983 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3MTU2NzViMGZmMy4uZmIwMjg0YTUzMmEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0wOS0xNyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFttYWNPU10gRnJlcXVlbnQgbGVha3Mgc2VlbiB1bmRlciBXZWJDb3Jl OjpncHVJREZvckRpc3BsYXlNYXNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODk2ODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3Jt L21hYy9QbGF0Zm9ybVNjcmVlbk1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OmdwdUlERm9yRGlz cGxheU1hc2spOgorCiAyMDE4LTA5LTE3ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29t PgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBIRVZDIGNvZGVjIHR5cGVzIGluIE1lZGlhIENh cGFiaWxpdGllcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1BsYXRm b3JtU2NyZWVuTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1BsYXRmb3JtU2Ny ZWVuTWFjLm1tCmluZGV4IDhlNzI2NTdkZTFkLi4wNDAyMzE5MDIzYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1BsYXRmb3JtU2NyZWVuTWFjLm1tCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9QbGF0Zm9ybVNjcmVlbk1hYy5tbQpAQCAtMjA5LDIwICsy MDksMjcgQEAgSU9SZWdpc3RyeUdQVUlEIGdwdUlERm9yRGlzcGxheU1hc2soR0x1aW50IGRpc3Bs YXlNYXNrKQogICAgIC8vIFRoZSAwdGggcmVuZGVyZXIgc2hvdWxkIG5vdCBiZSB0aGUgc29mdHdh cmUgcmVuZGVyZXIuCiAgICAgR0xpbnQgaXNBY2NlbGVyYXRlZDsKICAgICBlcnJvciA9IENHTERl c2NyaWJlUmVuZGVyZXIocmVuZGVyZXJJbmZvLCAwLCBrQ0dMUlBBY2NlbGVyYXRlZCwgJmlzQWNj ZWxlcmF0ZWQpOwotICAgIGlmICghaXNBY2NlbGVyYXRlZCB8fCBlcnJvciAhPSBrQ0dMTm9FcnJv cikKKyAgICBpZiAoIWlzQWNjZWxlcmF0ZWQgfHwgZXJyb3IgIT0ga0NHTE5vRXJyb3IpIHsKKyAg ICAgICAgQ0dMRGVzdHJveVJlbmRlcmVySW5mbyhyZW5kZXJlckluZm8pOwogICAgICAgICByZXR1 cm4gMDsKKyAgICB9CiAKICAgICBHTGludCBncHVJRExvdyA9IDA7CiAgICAgR0xpbnQgZ3B1SURI aWdoID0gMDsKIAogICAgIGVycm9yID0gQ0dMRGVzY3JpYmVSZW5kZXJlcihyZW5kZXJlckluZm8s IDAsIGtDR0xSUFJlZ2lzdHJ5SURMb3csICZncHVJRExvdyk7Ci0gICAgaWYgKGVycm9yICE9IGtD R0xOb0Vycm9yKQorICAgIGlmIChlcnJvciAhPSBrQ0dMTm9FcnJvcikgeworICAgICAgICBDR0xE ZXN0cm95UmVuZGVyZXJJbmZvKHJlbmRlcmVySW5mbyk7CiAgICAgICAgIHJldHVybiAwOworICAg IH0KIAogICAgIGVycm9yID0gQ0dMRGVzY3JpYmVSZW5kZXJlcihyZW5kZXJlckluZm8sIDAsIGtD R0xSUFJlZ2lzdHJ5SURIaWdoLCAmZ3B1SURIaWdoKTsKLSAgICBpZiAoZXJyb3IgIT0ga0NHTE5v RXJyb3IpCisgICAgaWYgKGVycm9yICE9IGtDR0xOb0Vycm9yKSB7CisgICAgICAgIENHTERlc3Ry b3lSZW5kZXJlckluZm8ocmVuZGVyZXJJbmZvKTsKICAgICAgICAgcmV0dXJuIDA7CisgICAgfQog CisgICAgQ0dMRGVzdHJveVJlbmRlcmVySW5mbyhyZW5kZXJlckluZm8pOwogICAgIHJldHVybiAo SU9SZWdpc3RyeUdQVUlEKSBncHVJREhpZ2ggPDwgMzIgfCBncHVJRExvdzsKIH0KICNlbmRpZiAv LyAhX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDEzMDAK 349990 2018-09-17 19:11:47 -0700 2018-09-18 11:30:12 -0700 [PATCH] Proposed Fix leakas-2.patch text/plain 1985 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3MTU2NzViMGZmMy4uNGYwZDVmM2VjMzEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOC0wOS0xNyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFttYWNPU10gRnJlcXVlbnQgbGVha3Mgc2VlbiB1bmRlciBXZWJDb3Jl OjpncHVJREZvckRpc3BsYXlNYXNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODk2ODUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ0NTQxOTc0Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZv cm0vbWFjL1BsYXRmb3JtU2NyZWVuTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6Z3B1SURGb3JE aXNwbGF5TWFzayk6CisKIDIwMTgtMDktMTcgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5j b20+CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIEhFVkMgY29kZWMgdHlwZXMgaW4gTWVkaWEg Q2FwYWJpbGl0aWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUGxh dGZvcm1TY3JlZW5NYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUGxhdGZvcm1T Y3JlZW5NYWMubW0KaW5kZXggOGU3MjY1N2RlMWQuLjA0MDIzMTkwMjNiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUGxhdGZvcm1TY3JlZW5NYWMubW0KKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1BsYXRmb3JtU2NyZWVuTWFjLm1tCkBAIC0yMDksMjAg KzIwOSwyNyBAQCBJT1JlZ2lzdHJ5R1BVSUQgZ3B1SURGb3JEaXNwbGF5TWFzayhHTHVpbnQgZGlz cGxheU1hc2spCiAgICAgLy8gVGhlIDB0aCByZW5kZXJlciBzaG91bGQgbm90IGJlIHRoZSBzb2Z0 d2FyZSByZW5kZXJlci4KICAgICBHTGludCBpc0FjY2VsZXJhdGVkOwogICAgIGVycm9yID0gQ0dM RGVzY3JpYmVSZW5kZXJlcihyZW5kZXJlckluZm8sIDAsIGtDR0xSUEFjY2VsZXJhdGVkLCAmaXNB Y2NlbGVyYXRlZCk7Ci0gICAgaWYgKCFpc0FjY2VsZXJhdGVkIHx8IGVycm9yICE9IGtDR0xOb0Vy cm9yKQorICAgIGlmICghaXNBY2NlbGVyYXRlZCB8fCBlcnJvciAhPSBrQ0dMTm9FcnJvcikgewor ICAgICAgICBDR0xEZXN0cm95UmVuZGVyZXJJbmZvKHJlbmRlcmVySW5mbyk7CiAgICAgICAgIHJl dHVybiAwOworICAgIH0KIAogICAgIEdMaW50IGdwdUlETG93ID0gMDsKICAgICBHTGludCBncHVJ REhpZ2ggPSAwOwogCiAgICAgZXJyb3IgPSBDR0xEZXNjcmliZVJlbmRlcmVyKHJlbmRlcmVySW5m bywgMCwga0NHTFJQUmVnaXN0cnlJRExvdywgJmdwdUlETG93KTsKLSAgICBpZiAoZXJyb3IgIT0g a0NHTE5vRXJyb3IpCisgICAgaWYgKGVycm9yICE9IGtDR0xOb0Vycm9yKSB7CisgICAgICAgIENH TERlc3Ryb3lSZW5kZXJlckluZm8ocmVuZGVyZXJJbmZvKTsKICAgICAgICAgcmV0dXJuIDA7Cisg ICAgfQogCiAgICAgZXJyb3IgPSBDR0xEZXNjcmliZVJlbmRlcmVyKHJlbmRlcmVySW5mbywgMCwg a0NHTFJQUmVnaXN0cnlJREhpZ2gsICZncHVJREhpZ2gpOwotICAgIGlmIChlcnJvciAhPSBrQ0dM Tm9FcnJvcikKKyAgICBpZiAoZXJyb3IgIT0ga0NHTE5vRXJyb3IpIHsKKyAgICAgICAgQ0dMRGVz dHJveVJlbmRlcmVySW5mbyhyZW5kZXJlckluZm8pOwogICAgICAgICByZXR1cm4gMDsKKyAgICB9 CiAKKyAgICBDR0xEZXN0cm95UmVuZGVyZXJJbmZvKHJlbmRlcmVySW5mbyk7CiAgICAgcmV0dXJu IChJT1JlZ2lzdHJ5R1BVSUQpIGdwdUlESGlnaCA8PCAzMiB8IGdwdUlETG93OwogfQogI2VuZGlm IC8vICFfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTMwMAo=