189676 2018-09-17 13:19:42 -0700 We must convert ProfileType to CheckStructureOrEmpty instead of CheckStructure 2018-09-17 15:21:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1460295 0 saam 2018-09-17 13:19:42 -0700 Because the incoming value may be TDZ. Since the TypeProfiler doesn't currently record TDZ values in any of its data structures, this is not a semantic change in how it will show you data. It just fixes crashes. 1460296 1 saam 2018-09-17 13:20:13 -0700 <rdar://problem/39682897> 1460300 2 349931 saam 2018-09-17 13:25:57 -0700 Created attachment 349931 patch 1460301 3 349931 msaboff 2018-09-17 13:27:41 -0700 Comment on attachment 349931 patch r=me 1460358 4 349931 commit-queue 2018-09-17 15:21:42 -0700 Comment on attachment 349931 patch Clearing flags on attachment: 349931 Committed r236089: <https://trac.webkit.org/changeset/236089> 1460359 5 commit-queue 2018-09-17 15:21:44 -0700 All reviewed patches have been landed. Closing bug. 349931 2018-09-17 13:25:57 -0700 2018-09-17 15:21:42 -0700 patch a-backup.diff text/plain 3750 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzYwNzgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE2IEBACisyMDE4LTA5LTE3ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIFdlIG11c3QgY29udmVydCBQcm9maWxlVHlwZSB0byBDaGVja1N0cnVj dHVyZU9yRW1wdHkgaW5zdGVhZCBvZiBDaGVja1N0cnVjdHVyZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5Njc2CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8zOTY4Mjg5Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHR5cGVQcm9maWxlci9jaGVjay1zdHJ1Y3R1cmUtb3ItZW1wdHktaW4tZml4dXAu anM6IEFkZGVkLgorICAgICAgICAoQSk6CisgICAgICAgIChLKToKKyAgICAgICAgKGkuY2F0Y2gp OgorCiAyMDE4LTA5LTE0ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAg ICAgIERvbid0IGR1bXAgT1NSQXZhaWxhYmlsaXR5RGF0YSBpbiBHcmFwaDo6ZHVtcCBiZWNhdXNl IGEgc3RhbGUgQXZhaWxhYmlsaXR5IG1heSBwb2ludCB0byBhIE5vZGUgdGhhdCBpcyBhbHJlYWR5 IGZyZWVkCkluZGV4OiBKU1Rlc3RzL3R5cGVQcm9maWxlci9jaGVjay1zdHJ1Y3R1cmUtb3ItZW1w dHktaW4tZml4dXAuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy90eXBlUHJvZmlsZXIvY2hlY2st c3RydWN0dXJlLW9yLWVtcHR5LWluLWZpeHVwLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMv dHlwZVByb2ZpbGVyL2NoZWNrLXN0cnVjdHVyZS1vci1lbXB0eS1pbi1maXh1cC5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMCwwICsxLDE2IEBACitjbGFzcyBBIHsKK30KK2NsYXNzIEsgZXh0ZW5kcyBB IHsKKyAgICBjb25zdHJ1Y3RvcihpKSB7CisgICAgICAgIGlmIChpICUgMiAhPT0gMCkKKyAgICAg ICAgICAgIHN1cGVyKCk7CisgICAgICAgIGlmIChpICUgMiA9PT0gMCAmJiBtYXhDb3VudCAhPT0g aSkKKyAgICAgICAgICAgIHN1cGVyKCk7CisgICAgfQorfQorbGV0IG1heENvdW50ID0gMTUwMDAw OworZm9yICh2YXIgaSA9IDA7IGkgPD0gbWF4Q291bnQ7IGkrKykgeworICAgIHRyeSB7CisgICAg ICAgIG5ldyBLKGkpOworICAgIH0gY2F0Y2goZSkgeyB9Cit9CkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cJKHJldmlzaW9uIDIzNjA3OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMiBAQAorMjAxOC0wOS0xNyAgU2FhbSBi YXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAgICAgICBXZSBtdXN0IGNvbnZlcnQgUHJv ZmlsZVR5cGUgdG8gQ2hlY2tTdHJ1Y3R1cmVPckVtcHR5IGluc3RlYWQgb2YgQ2hlY2tTdHJ1Y3R1 cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTY3 NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzk2ODI4OTc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmVjYXVzZSB0aGUgaW5jb21pbmcgdmFsdWUg bWF5IGJlIFREWiwgQ2hlY2tTdHJ1Y3R1cmUgbWF5IGVuZCB1cCBjcmFzaGluZy4KKyAgICAgICAg U2luY2UgdGhlIFR5cGUgUHJvZmlsZSBkb2VzIG5vdCBjdXJyZW50bHkgcmVjb3JkIFREWiB2YWx1 ZXMgaW4gYW55IG9mIGl0cworICAgICAgICBkYXRhIHN0cnVjdHVyZXMsIHRoaXMgaXMgbm90IGEg c2VtYW50aWMgY2hhbmdlIGluIGhvdyBpdCB3aWxsIHNob3cgeW91IGRhdGEuCisgICAgICAgIEl0 IGp1c3QgZml4ZXMgY3Jhc2hlcyB3aGVuIHdlIGVtaXQgYSBDaGVja1N0cnVjdHVyZSBhbmQgdGhl IGluY29taW5nIHZhbHVlCisgICAgICAgIGlzIFREWi4KKworICAgICAgICAqIGRmZy9ERkdGaXh1 cFBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpGaXh1cFBoYXNlOjpmaXh1cE5vZGUpOgor ICAgICAgICAqIGRmZy9ERkdOb2RlLmg6CisgICAgICAgIChKU0M6OkRGRzo6Tm9kZTo6Y29udmVy dFRvQ2hlY2tTdHJ1Y3R1cmVPckVtcHR5KToKKwogMjAxOC0wOS0xNyAgRGFyaW4gQWRsZXIgIDxk YXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIE9wYXF1ZUpTU3RyaW5nIHJhdGhlciB0aGFu IEpTUmV0YWluUHRyIGluc2lkZSBXZWJLaXQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZmcvREZHRml4dXBQaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdGaXh1cFBoYXNlLmNwcAkocmV2aXNpb24gMjM2MDc4KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTc4Myw3 ICsxNzgzLDcgQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAg aWYgKCFzZXQuaXNFbXB0eSgpKSB7CiAgICAgICAgICAgICAgICAgICAgIGZpeEVkZ2U8Q2VsbFVz ZT4obm9kZS0+Y2hpbGQxKCkpOwotICAgICAgICAgICAgICAgICAgICBub2RlLT5jb252ZXJ0VG9D aGVja1N0cnVjdHVyZShtX2dyYXBoLmFkZFN0cnVjdHVyZVNldChzZXQpKTsKKyAgICAgICAgICAg ICAgICAgICAgbm9kZS0+Y29udmVydFRvQ2hlY2tTdHJ1Y3R1cmVPckVtcHR5KG1fZ3JhcGguYWRk U3RydWN0dXJlU2V0KHNldCkpOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KIApJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdOb2RlLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdOb2RlLmgJKHJldmlzaW9uIDIzNjA3OCkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00 NjEsNiArNDYxLDE1IEBAIHB1YmxpYzoKICAgICAgICAgbV9vcEluZm8gPSBzZXQ7CiAgICAgfQog CisgICAgdm9pZCBjb252ZXJ0VG9DaGVja1N0cnVjdHVyZU9yRW1wdHkoUmVnaXN0ZXJlZFN0cnVj dHVyZVNldCogc2V0KQorICAgIHsKKyAgICAgICAgaWYgKFNwZWNDZWxsQ2hlY2sgJiBTcGVjRW1w dHkpCisgICAgICAgICAgICBzZXRPcEFuZERlZmF1bHRGbGFncyhDaGVja1N0cnVjdHVyZU9yRW1w dHkpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBzZXRPcEFuZERlZmF1bHRGbGFncyhDaGVj a1N0cnVjdHVyZSk7CisgICAgICAgIG1fb3BJbmZvID0gc2V0OworICAgIH0KKwogICAgIHZvaWQg Y29udmVydENoZWNrU3RydWN0dXJlT3JFbXB0eVRvQ2hlY2tTdHJ1Y3R1cmUoKQogICAgIHsKICAg ICAgICAgQVNTRVJUKG9wKCkgPT0gQ2hlY2tTdHJ1Y3R1cmVPckVtcHR5KTsK