189638 2018-09-14 16:50:29 -0700 Web Inspector: Source View doesn't scroll to show line when breakpoint is hit inside of <script> in HTML resource 2018-09-14 17:40:10 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker simon.fraser webkit-bug-importer oldest_to_newest 1459959 0 349829 joepeck 2018-09-14 16:50:29 -0700 Created attachment 349829 [TEST PAGE] test.html Source View doesn't scroll to show line when breakpoint is hit inside of <script> in HTML resource Steps to Reproduce: 1. Open test page 2. Set a breakpoint on line test.html:100 3. Reload the page => Triggers breakpoint, should scroll to show line 100, but doesn't appear to Notes: • Works if this was test.js script resource, but does not work in test.html document resource pausing on page load • The test.html TextEditor content loads multiple times (inline script content, then full resource content). The act of re-setting the TextEditor content string with full content wipes out the revealed position. 1459960 1 joepeck 2018-09-14 16:50:49 -0700 <rdar://problem/43359278> 1459962 2 349830 joepeck 2018-09-14 16:55:01 -0700 Created attachment 349830 [PATCH] Proposed Fix 1459970 3 349830 mattbaker 2018-09-14 17:14:38 -0700 Comment on attachment 349830 [PATCH] Proposed Fix r=me, works as advertised! 1459988 4 349830 commit-queue 2018-09-14 17:40:09 -0700 Comment on attachment 349830 [PATCH] Proposed Fix Clearing flags on attachment: 349830 Committed r236028: <https://trac.webkit.org/changeset/236028> 1459989 5 commit-queue 2018-09-14 17:40:10 -0700 All reviewed patches have been landed. Closing bug. 349829 2018-09-14 16:50:29 -0700 2018-09-14 16:50:29 -0700 [TEST PAGE] test.html test.html text/html 1830 joepeck PHA+VGVzdDwvcD4KPHA+VGVzdDwvcD4KPHA+VGVzdDwvcD4KPHA+VGVzdDwvcD4KPHA+VGVzdDwv cD4KPHA+VGVzdDwvcD4KPHA+VGVzdDwvcD4KPHA+VGVzdDwvcD4KPHA+VGVzdDwvcD4KPHA+VGVz dDwvcD4KPHNjcmlwdD4KY29uc29sZS5sb2coMSk7CmNvbnNvbGUubG9nKDIpOwpjb25zb2xlLmxv ZygzKTsKY29uc29sZS5sb2coNCk7CmNvbnNvbGUubG9nKDUpOwpjb25zb2xlLmxvZyg2KTsKY29u c29sZS5sb2coNyk7CmNvbnNvbGUubG9nKDgpOwpjb25zb2xlLmxvZyg5KTsKY29uc29sZS5sb2co MTApOwpjb25zb2xlLmxvZygxMSk7CmNvbnNvbGUubG9nKDEyKTsKY29uc29sZS5sb2coMTMpOwpj b25zb2xlLmxvZygxNCk7CmNvbnNvbGUubG9nKDE1KTsKY29uc29sZS5sb2coMTYpOwpjb25zb2xl LmxvZygxNyk7CmNvbnNvbGUubG9nKDE4KTsKY29uc29sZS5sb2coMTkpOwpjb25zb2xlLmxvZygy MCk7CmNvbnNvbGUubG9nKDIxKTsKY29uc29sZS5sb2coMjIpOwpjb25zb2xlLmxvZygyMyk7CmNv bnNvbGUubG9nKDI0KTsKY29uc29sZS5sb2coMjUpOwpjb25zb2xlLmxvZygyNik7CmNvbnNvbGUu bG9nKDI3KTsKY29uc29sZS5sb2coMjgpOwpjb25zb2xlLmxvZygyOSk7CmNvbnNvbGUubG9nKDMw KTsKY29uc29sZS5sb2coMzEpOwpjb25zb2xlLmxvZygzMik7CmNvbnNvbGUubG9nKDMzKTsKY29u c29sZS5sb2coMzQpOwpjb25zb2xlLmxvZygzNSk7CmNvbnNvbGUubG9nKDM2KTsKY29uc29sZS5s b2coMzcpOwpjb25zb2xlLmxvZygzOCk7CmNvbnNvbGUubG9nKDM5KTsKY29uc29sZS5sb2coNDAp Owpjb25zb2xlLmxvZyg0MSk7CmNvbnNvbGUubG9nKDQyKTsKY29uc29sZS5sb2coNDMpOwpjb25z b2xlLmxvZyg0NCk7CmNvbnNvbGUubG9nKDQ1KTsKY29uc29sZS5sb2coNDYpOwpjb25zb2xlLmxv Zyg0Nyk7CmNvbnNvbGUubG9nKDQ4KTsKY29uc29sZS5sb2coNDkpOwpjb25zb2xlLmxvZyg1MCk7 CmNvbnNvbGUubG9nKDUxKTsKY29uc29sZS5sb2coNTIpOwpjb25zb2xlLmxvZyg1Myk7CmNvbnNv bGUubG9nKDU0KTsKY29uc29sZS5sb2coNTUpOwpjb25zb2xlLmxvZyg1Nik7CmNvbnNvbGUubG9n KDU3KTsKY29uc29sZS5sb2coNTgpOwpjb25zb2xlLmxvZyg1OSk7CmNvbnNvbGUubG9nKDYwKTsK Y29uc29sZS5sb2coNjEpOwpjb25zb2xlLmxvZyg2Mik7CmNvbnNvbGUubG9nKDYzKTsKY29uc29s ZS5sb2coNjQpOwpjb25zb2xlLmxvZyg2NSk7CmNvbnNvbGUubG9nKDY2KTsKY29uc29sZS5sb2co NjcpOwpjb25zb2xlLmxvZyg2OCk7CmNvbnNvbGUubG9nKDY5KTsKY29uc29sZS5sb2coNzApOwpj b25zb2xlLmxvZyg3MSk7CmNvbnNvbGUubG9nKDcyKTsKY29uc29sZS5sb2coNzMpOwpjb25zb2xl LmxvZyg3NCk7CmNvbnNvbGUubG9nKDc1KTsKY29uc29sZS5sb2coNzYpOwpjb25zb2xlLmxvZyg3 Nyk7CmNvbnNvbGUubG9nKDc4KTsKY29uc29sZS5sb2coNzkpOwpjb25zb2xlLmxvZyg4MCk7CmNv bnNvbGUubG9nKDgxKTsKY29uc29sZS5sb2coODIpOwpjb25zb2xlLmxvZyg4Myk7CmNvbnNvbGUu bG9nKDg0KTsKY29uc29sZS5sb2coODUpOwpjb25zb2xlLmxvZyg4Nik7CmNvbnNvbGUubG9nKDg3 KTsKY29uc29sZS5sb2coODgpOwpjb25zb2xlLmxvZyg4OSk7CmNvbnNvbGUubG9nKDkwKTsKY29u c29sZS5sb2coOTEpOwpjb25zb2xlLmxvZyg5Mik7CmNvbnNvbGUubG9nKDkzKTsKY29uc29sZS5s b2coOTQpOwpjb25zb2xlLmxvZyg5NSk7CmNvbnNvbGUubG9nKDk2KTsKY29uc29sZS5sb2coOTcp Owpjb25zb2xlLmxvZyg5OCk7CmNvbnNvbGUubG9nKDk5KTsKY29uc29sZS5sb2coMTAwKTsKPC9z Y3JpcHQ+ 349830 2018-09-14 16:55:01 -0700 2018-09-14 17:40:09 -0700 [PATCH] Proposed Fix reveal-1.patch text/plain 4818 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDJhM2IzYjM5YTYyLi42MGI3Y2QwMGUzZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzMgQEAKKzIwMTgtMDktMTQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBTb3VyY2UgVmlldyBkb2Vzbid0IHNjcm9sbCB0byBzaG93IGxpbmUgd2hlbiBicmVha3BvaW50 IGlzIGhpdCBpbnNpZGUgb2YgPHNjcmlwdD4gaW4gSFRNTCByZXNvdXJjZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5NjM4CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS80MzM1OTI3OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBQYXVzaW5nIGluIERvY3VtZW50IHJlc291cmNlcyBvbiBwYWdlIGxvYWQg aGF2ZSBzcGVjaWFsIGNvbnNpZGVyYXRpb25zIHdoZXJlIHdlCisgICAgICAgIG1heSBub3QgcmVj ZWl2ZSB0aGVpciBmdWxsIGNvbnRlbnQgaW1tZWRpYXRlbHksIHNvIHdlIG1heSBzeW50aGVzaXpl IGlubGluZSBzY3JpcHQKKyAgICAgICAgY29udGVudCBmb3IgdGhlIHJlc291cmNlIHVudGlsIHdl IGhhdmUgZnVsbCBjb250ZW50LiBVbmZvcnR1bmF0ZWx5LCB3aGVuIHdlIGdldAorICAgICAgICBm dWxsIGNvbnRlbnQgYW5kIHVwZGF0ZSB0aGUgVGV4dEVkaXRvciB3ZSB3ZXJlIGxvc2luZyB0aGUg cmV2ZWFsZWQgcG9zaXRpb24gYW5kCisgICAgICAgIG90aGVyIGVkaXRvciBpbmZvcm1hdGlvbi4g VGhpcyBjaGFuZ2Ugc3BlY2lmaWNhbGx5IHRhcmdldHMgdGhvc2UgY2FzZXMsIGJ5CisgICAgICAg IHJlLWFwcGx5aW5nIGVkaXRvciBzdGF0ZSB3aGVuIHVwZGF0aW5nIHN1Y2ggYSByZXNvdXJjZSBm cm9tIHBhcnRpYWwgdG8gZnVsbCBjb250ZW50LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9W aWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdJLlNvdXJjZUNvZGVUZXh0 RWRpdG9yLnByb3RvdHlwZS5fY29udGVudEF2YWlsYWJsZSk6CisgICAgICAgIFNpZ25hbCB0byB0 aGUgZWRpdG9yIHRoYXQgd2hlbiB1cGRhdGluZyB0aGUgY29udGVudCBpdCBzaG91bGQgY2FycnkK KyAgICAgICAgb3ZlciBlZGl0b3Igc3RhdGUuIE9ubHkgZG8gdGhpcyBpZiB3ZSBoYWQgcGFydGlh bCBjb250ZW50IGJlZm9yZS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVk aXRvci5qczoKKyAgICAgICAgKFdJLlRleHRFZGl0b3IpOgorICAgICAgICAoV0kuVGV4dEVkaXRv ci5wcm90b3R5cGUuc2V0IHJlcGVhdFJldmVhbCk6CisgICAgICAgIFByb3ZpZGUgYSB3YXkgdG8g c2lnbmFsIHdlIHNob3VsZCByZXN0b3JlIHN0YXRlIHdoZW4gdXBkYXRlIHRoZSBjb250ZW50Lgor CisgICAgICAgIChXSS5UZXh0RWRpdG9yLnNldCBzdHJpbmcudXBkYXRlKToKKyAgICAgICAgKFdJ LlRleHRFZGl0b3IucHJvdG90eXBlLnNldCBzdHJpbmcpOgorICAgICAgICBXaGVuIHJlcGVhdFJl dmVhbCB3YXMgZW5hYmxlZCwgcmVzdG9yZSBlZGl0b3Igc3RhdGUgc3VjaCBhcyB0aGUKKyAgICAg ICAgcmV2ZWFsZWQgbG9jYXRpb24gYW5kIHRleHQgc2VsZWN0aW9uLgorCiAyMDE4LTA5LTEzICBK b3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogT3BlbmluZyBpbnNwZWN0b3Igd2l0aCBhIHNlbGVjdGVkIGVsZW1lbnQgbWlnaHQgaW1t ZWRpYXRlbHkgc2Nyb2xsIHRoYXQgZWxlbWVudCBvZmYgc2NyZWVuIGluIHRoZSBET00gVHJlZSBv dXRsaW5lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzCmluZGV4IDEyZTVkZTJkNTEx Li45M2IzYjlhMzU1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMKQEAgLTU0 Nyw3ICs1NDcsMTMgQEAgV0kuU291cmNlQ29kZVRleHRFZGl0b3IgPSBjbGFzcyBTb3VyY2VDb2Rl VGV4dEVkaXRvciBleHRlbmRzIFdJLlRleHRFZGl0b3IKICAgICAgICAgdGhpcy5fZnVsbENvbnRl bnRQb3B1bGF0ZWQgPSB0cnVlOwogICAgICAgICB0aGlzLl9pbnZhbGlkTGluZU51bWJlcnMgPSB7 fTsKIAorICAgICAgICAvLyBJZiB3ZSBoYWQgcGFydGlhbCBjb250ZW50IChzdWNoIGFzIGlubGlu ZSBzY3JpcHQgY29udGVudCkgYmVmb3JlIHdlIGhhZCBmdWxsIGNvbnRlbnQsIHdlCisgICAgICAg IC8vIHdpbGwgd2FudCB0byByZS1yZXN0b3JlIHRoZSByZXZlYWxlZCBwb3NpdGlvbiBub3cgdGhh dCB3ZSBhcmUgcG9wdWxhdGluZyB3aXRoIGZ1bGwgY29udGVudC4KKyAgICAgICAgdGhpcy5yZXBl YXRSZXZlYWwgPSAhIXRoaXMuc3RyaW5nOworCiAgICAgICAgIHRoaXMuX3BvcHVsYXRlV2l0aENv bnRlbnQoY29udGVudCk7CisKKyAgICAgICAgdGhpcy5yZXBlYXRSZXZlYWwgPSBmYWxzZTsKICAg ICB9CiAKICAgICBfYnJlYWtwb2ludFN0YXR1c0RpZENoYW5nZShldmVudCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpz CmluZGV4IGFkMDBkZGU2ZDA5Li4yNWVhNGExODVkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzCkBAIC05NCw2 ICs5NCw3IEBAIFdJLlRleHRFZGl0b3IgPSBjbGFzcyBUZXh0RWRpdG9yIGV4dGVuZHMgV0kuVmll dwogICAgICAgICB0aGlzLl9mb3JtYXR0aW5nUHJvbWlzZSA9IG51bGw7CiAgICAgICAgIHRoaXMu X2Zvcm1hdHRlclNvdXJjZU1hcCA9IG51bGw7CiAgICAgICAgIHRoaXMuX2RlZmVyUmV2ZWFsID0g ZmFsc2U7CisgICAgICAgIHRoaXMuX3JlcGVhdFJldmVhbCA9IGZhbHNlOwogCiAgICAgICAgIHRo aXMuX2RlbGVnYXRlID0gZGVsZWdhdGUgfHwgbnVsbDsKICAgICB9CkBAIC0xMTIsNiArMTEzLDgg QEAgV0kuVGV4dEVkaXRvciA9IGNsYXNzIFRleHRFZGl0b3IgZXh0ZW5kcyBXSS5WaWV3CiAKICAg ICBzZXQgc3RyaW5nKG5ld1N0cmluZykKICAgICB7CisgICAgICAgIGxldCBwcmV2aW91c1NlbGVj dGVkVGV4dFJhbmdlID0gdGhpcy5fcmVwZWF0UmV2ZWFsID8gdGhpcy5zZWxlY3RlZFRleHRSYW5n ZSA6IG51bGw7CisKICAgICAgICAgZnVuY3Rpb24gdXBkYXRlKCkKICAgICAgICAgewogICAgICAg ICAgICAgLy8gQ2xlYXIgYW55IHN0eWxlcyB0aGF0IG1heSBoYXZlIGJlZW4gc2V0IG9uIHRoZSBl bXB0eSBsaW5lIGJlZm9yZSBjb250ZW50IGxvYWRlZC4KQEAgLTE0Nyw4ICsxNTAsMTMgQEAgV0ku VGV4dEVkaXRvciA9IGNsYXNzIFRleHRFZGl0b3IgZXh0ZW5kcyBXSS5WaWV3CiAgICAgICAgICAg ICBmb3IgKHZhciBsaW5lTnVtYmVyIGluIHRoaXMuX2JyZWFrcG9pbnRzKQogICAgICAgICAgICAg ICAgIHRoaXMuX3NldEJyZWFrcG9pbnRTdHlsZXNPbkxpbmUobGluZU51bWJlcik7CiAKLSAgICAg ICAgICAgIC8vIFRyeSByZXZlYWxpbmcgdGhlIHBlbmRpbmcgbGluZSBub3cgdGhhdCB3ZSBtaWdo dCBoYXZlIGNvbnRlbnQgd2l0aCBlbm91Z2ggbGluZXMuCisgICAgICAgICAgICAvLyBUcnkgcmV2 ZWFsaW5nIHRoZSBwZW5kaW5nIGxpbmUsIG9yIHByZXZpb3VzIHBvc2l0aW9uLCBub3cgdGhhdCB3 ZSBtaWdodCBoYXZlIG5ldyBjb250ZW50LgogICAgICAgICAgICAgdGhpcy5fcmV2ZWFsUGVuZGlu Z1Bvc2l0aW9uSWZQb3NzaWJsZSgpOworICAgICAgICAgICAgaWYgKHByZXZpb3VzU2VsZWN0ZWRU ZXh0UmFuZ2UpIHsKKyAgICAgICAgICAgICAgICB0aGlzLnNlbGVjdGVkVGV4dFJhbmdlID0gcHJl dmlvdXNTZWxlY3RlZFRleHRSYW5nZTsKKyAgICAgICAgICAgICAgICBsZXQgcG9zaXRpb24gPSB0 aGlzLl9jb2RlTWlycm9yUG9zaXRpb25Gcm9tVGV4dFJhbmdlKHByZXZpb3VzU2VsZWN0ZWRUZXh0 UmFuZ2UpOworICAgICAgICAgICAgICAgIHRoaXMuX3Njcm9sbEludG9WaWV3Q2VudGVyZWQocG9z aXRpb24uc3RhcnQpOworICAgICAgICAgICAgfQogICAgICAgICB9CiAKICAgICAgICAgdGhpcy5f aWdub3JlQ29kZU1pcnJvckNvbnRlbnREaWRDaGFuZ2VFdmVudCsrOwpAQCAtMjkyLDYgKzMwMCwx MSBAQCBXSS5UZXh0RWRpdG9yID0gY2xhc3MgVGV4dEVkaXRvciBleHRlbmRzIFdJLlZpZXcKICAg ICAgICAgdGhpcy5fZGVmZXJSZXZlYWwgPSBkZWZlcjsKICAgICB9CiAKKyAgICBzZXQgcmVwZWF0 UmV2ZWFsKHJlcGVhdCkKKyAgICB7CisgICAgICAgIHRoaXMuX3JlcGVhdFJldmVhbCA9IHJlcGVh dDsKKyAgICB9CisKICAgICBwZXJmb3JtU2VhcmNoKHF1ZXJ5KQogICAgIHsKICAgICAgICAgaWYg KHRoaXMuX3NlYXJjaFF1ZXJ5ID09PSBxdWVyeSkK