189603 2018-09-13 14:14:12 -0700 Web Inspector: Timelines: clicking a row in Script > Events grid triggers Location popover when column is hidden 2018-09-13 17:03:14 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1459525 0 mattbaker 2018-09-13 14:14:12 -0700 Summary: Clicking a row in Script > Events grid triggers Location popover when column is hidden. The Layout timeline view has the same issue. Test Page: <script> console.profile("Test"); console.profileEnd("Test"); </script> Steps to Reproduce: 1. Inspect test page > Timelines 2. Reload page to record a timeline 3. Select JavaScript & Events timeline > Events 4. Hide Location column 5. Click the row '"Test" Profile Recorded' => Popover with location stack trace appears 1459526 1 webkit-bug-importer 2018-09-13 14:14:36 -0700 <rdar://problem/44431403> 1459527 2 349704 mattbaker 2018-09-13 14:19:09 -0700 Created attachment 349704 Patch 1459529 3 349704 mattbaker 2018-09-13 14:21:35 -0700 Comment on attachment 349704 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349704&action=review > Source/WebInspectorUI/UserInterface/Views/DataGrid.js:897 > + isColumnVisible(columnIdentifier) This class is old and mixes its public/private members, so I chose not to move this method after making it public. > Source/WebInspectorUI/UserInterface/Views/LayoutTimelineDataGrid.js:38 > + } An alternative approach would be to eliminate these subclasses, and instead specify the call frames column in TimelineDataGrid's constructor. I chose not too, since all of this code is old and didn't want to rock the boat. 1459572 4 349704 joepeck 2018-09-13 16:36:53 -0700 Comment on attachment 349704 Patch r=me 1459591 5 349704 commit-queue 2018-09-13 17:03:12 -0700 Comment on attachment 349704 Patch Clearing flags on attachment: 349704 Committed r235997: <https://trac.webkit.org/changeset/235997> 1459592 6 commit-queue 2018-09-13 17:03:14 -0700 All reviewed patches have been landed. Closing bug. 349704 2018-09-13 14:19:09 -0700 2018-09-13 17:03:12 -0700 Patch bug-189603-20180913141906.patch text/plain 6816 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1OTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj MDcxYzY1NDZjYjUwNzA0MTMwNmEzYjYzMThmNWVkYzZjMDk2ZTRmLi5iOTJjNzIyNTg0NTI4NTZl MTA2MDFmYWQzZTQ2MDI4N2Y5YjJjMTYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzMyBAQAorMjAxOC0wOS0xMyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxpbmVzOiBjbGlja2luZyBhIHJvdyBpbiBT Y3JpcHQgPiBFdmVudHMgZ3JpZCB0cmlnZ2VycyBMb2NhdGlvbiBwb3BvdmVyIHdoZW4gY29sdW1u IGlzIGhpZGRlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTg5NjAzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NDQzMTQwMz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaW1lbGluZURhdGFHcmlkIGNv bnRyb2xzIHNob3dpbmcvaGlkaW5nIHRoZSBjYWxsIGZyYW1lIHBvcG92ZXIsIHdpdGggc3ViY2xh c3NlcworICAgICAgICBvdmVycmlkaW5nIGNhbGxGcmFtZVBvcG92ZXJBbmNob3JFbGVtZW50IHRv IHBvc2l0aW9uIGl0LiBUaGlzIHBhdGNoIGFkZHMKKyAgICAgICAgYW5vdGhlciBvdmVycmlkYWJs ZSBiYXNlIGNsYXNzIG1ldGhvZCwgc2hvdWxkU2hvd0NhbGxGcmFtZVBvcG92ZXIsIHdoaWNoIHN1 YmNsYXNzZXMKKyAgICAgICAgY2FuIHVzZSB0byBibG9jayB0aGUgcG9wb3ZlciB3aGVuIHRoZSBM b2NhdGlvbiBjb2x1bW4gaXMgaGlkZGVuLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9EYXRhR3JpZC5qczoKKyAgICAgICAgKFdJLkRhdGFHcmlkLnByb3RvdHlwZS5sYXlvdXQpOgor ICAgICAgICAoV0kuRGF0YUdyaWQucHJvdG90eXBlLl9wb3NpdGlvblJlc2l6ZXJFbGVtZW50cyk6 CisgICAgICAgIChXSS5EYXRhR3JpZC5wcm90b3R5cGUuX2lzQ29sdW1uVmlzaWJsZSk6IERlbGV0 ZWQuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0xheW91dFRpbWVsaW5lRGF0YUdy aWQuanM6CisgICAgICAgIChXSS5MYXlvdXRUaW1lbGluZURhdGFHcmlkLnByb3RvdHlwZS5zaG91 bGRTaG93Q2FsbEZyYW1lUG9wb3Zlcik6CisgICAgICAgIChXSS5MYXlvdXRUaW1lbGluZURhdGFH cmlkKToKKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU2NyaXB0VGltZWxpbmVEYXRh R3JpZC5qczoKKyAgICAgICAgKFdJLlNjcmlwdFRpbWVsaW5lRGF0YUdyaWQucHJvdG90eXBlLnNo b3VsZFNob3dDYWxsRnJhbWVQb3BvdmVyKToKKyAgICAgICAgKFdJLlNjcmlwdFRpbWVsaW5lRGF0 YUdyaWQpOgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZURhdGFHcmlk LmpzOgorICAgICAgICAoV0kuVGltZWxpbmVEYXRhR3JpZC5wcm90b3R5cGUuc2hvdWxkU2hvd0Nh bGxGcmFtZVBvcG92ZXIpOgorICAgICAgICAoV0kuVGltZWxpbmVEYXRhR3JpZC5wcm90b3R5cGUu X2RhdGFHcmlkU2VsZWN0ZWROb2RlQ2hhbmdlZCk6CisKIDIwMTgtMDktMTIgIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBmaXgg dGVzdCBjYXNlIGZhaWx1cmVzIGluIGpzLWlzTGlrZWx5U3RhY2tUcmFjZS5odG1sCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpz CmluZGV4IDJlNjQyMWMxZWRjNTU5ODg3YTZmZWUyYjRiNTc1ZDE4MGRhNDAxMDQuLjlmYTE1NDU4 YWFhMTljZjZiMmJmMTk3NTAyZDJhOGFhODVmY2UwMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCkBAIC04NTcsNyAr ODU3LDcgQEAgV0kuRGF0YUdyaWQgPSBjbGFzcyBEYXRhR3JpZCBleHRlbmRzIFdJLlZpZXcKICAg ICAgICAgICAgIGxldCBjb2x1bW5XaWR0aHMgPSBbXTsKICAgICAgICAgICAgIGZvciAobGV0IGkg PSAwOyBpIDwgbnVtQ29sdW1uczsgKytpKSB7CiAgICAgICAgICAgICAgICAgbGV0IGhlYWRlckNl bGxFbGVtZW50ID0gY2VsbHNbaV07Ci0gICAgICAgICAgICAgICAgaWYgKHRoaXMuX2lzQ29sdW1u VmlzaWJsZShoZWFkZXJDZWxsRWxlbWVudC5jb2x1bW5JZGVudGlmaWVyKSkgeworICAgICAgICAg ICAgICAgIGlmICh0aGlzLmlzQ29sdW1uVmlzaWJsZShoZWFkZXJDZWxsRWxlbWVudC5jb2x1bW5J ZGVudGlmaWVyKSkgewogICAgICAgICAgICAgICAgICAgICBsZXQgY29sdW1uV2lkdGggPSBoZWFk ZXJDZWxsRWxlbWVudC5vZmZzZXRXaWR0aDsKICAgICAgICAgICAgICAgICAgICAgbGV0IHBlcmNl bnRXaWR0aCA9ICgoY29sdW1uV2lkdGggLyB0YWJsZVdpZHRoKSAqIDEwMCkgKyAiJSI7CiAgICAg ICAgICAgICAgICAgICAgIGNvbHVtbldpZHRocy5wdXNoKHBlcmNlbnRXaWR0aCk7CkBAIC04OTQs NyArODk0LDcgQEAgV0kuRGF0YUdyaWQgPSBjbGFzcyBEYXRhR3JpZCBleHRlbmRzIFdJLlZpZXcK ICAgICAgICAgdGhpcy5fY2FjaGVkU2Nyb2xsYWJsZU9mZnNldEhlaWdodCA9IE5hTjsKICAgICB9 CiAKLSAgICBfaXNDb2x1bW5WaXNpYmxlKGNvbHVtbklkZW50aWZpZXIpCisgICAgaXNDb2x1bW5W aXNpYmxlKGNvbHVtbklkZW50aWZpZXIpCiAgICAgewogICAgICAgICByZXR1cm4gIXRoaXMuY29s dW1ucy5nZXQoY29sdW1uSWRlbnRpZmllcilbImhpZGRlbiJdOwogICAgIH0KQEAgLTk2OSw3ICs5 NjksNyBAQCBXSS5EYXRhR3JpZCA9IGNsYXNzIERhdGFHcmlkIGV4dGVuZHMgV0kuVmlldwogCiAg ICAgICAgICAgICBsZWFkaW5nT2Zmc2V0ID0gY29sdW1uV2lkdGhzW2ldOwogCi0gICAgICAgICAg ICBpZiAodGhpcy5faXNDb2x1bW5WaXNpYmxlKHRoaXMub3JkZXJlZENvbHVtbnNbaV0pKSB7Cisg ICAgICAgICAgICBpZiAodGhpcy5pc0NvbHVtblZpc2libGUodGhpcy5vcmRlcmVkQ29sdW1uc1tp XSkpIHsKICAgICAgICAgICAgICAgICByZXNpemVyLmVsZW1lbnQuc3R5bGUucmVtb3ZlUHJvcGVy dHkoImRpc3BsYXkiKTsKICAgICAgICAgICAgICAgICByZXNpemVyLmVsZW1lbnQuc3R5bGUuc2V0 UHJvcGVydHkoV0kucmVzb2x2ZWRMYXlvdXREaXJlY3Rpb24oKSA9PT0gV0kuTGF5b3V0RGlyZWN0 aW9uLlJUTCA/ICJyaWdodCIgOiAibGVmdCIsIGAke2xlYWRpbmdPZmZzZXR9cHhgKTsKICAgICAg ICAgICAgICAgICByZXNpemVyW1dJLkRhdGFHcmlkLlByZXZpb3VzQ29sdW1uT3JkaW5hbFN5bWJv bF0gPSBpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvTGF5b3V0VGltZWxpbmVEYXRhR3JpZC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0xheW91dFRpbWVsaW5lRGF0YUdyaWQuanMKaW5kZXggYzQ5YWI1 ZWMzNGNkMWU0MWYyZTRmODYxMGFhNzU2ODgzNGQ0MWFjYi4uNGYzZTA1MjlmZmIzN2QzMjI5YTA4 YTZhNjYzODMzZjgzZDI2MDQzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0VGltZWxpbmVEYXRhR3JpZC5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9MYXlvdXRUaW1lbGluZURhdGFHcmlk LmpzCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAxMywgMjAxNSBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTMtMjAxOCBB cHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5k IHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2Rp ZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRp dGlvbnMKQEAgLTMxLDQgKzMxLDkgQEAgV0kuTGF5b3V0VGltZWxpbmVEYXRhR3JpZCA9IGNsYXNz IExheW91dFRpbWVsaW5lRGF0YUdyaWQgZXh0ZW5kcyBXSS5UaW1lbGluZURhdGEKICAgICB7CiAg ICAgICAgIHJldHVybiB0aGlzLnNlbGVjdGVkTm9kZS5lbGVtZW50V2l0aENvbHVtbklkZW50aWZp ZXIoImxvY2F0aW9uIik7CiAgICAgfQorCisgICAgc2hvdWxkU2hvd0NhbGxGcmFtZVBvcG92ZXIo KQorICAgIHsKKyAgICAgICAgcmV0dXJuIHRoaXMuaXNDb2x1bW5WaXNpYmxlKCJsb2NhdGlvbiIp OworICAgIH0KIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9TY3JpcHRUaW1lbGluZURhdGFHcmlkLmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2NyaXB0VGltZWxpbmVEYXRhR3JpZC5qcwppbmRleCAz NTk3YWQ0YTQyZGNiZWRhMjBjYzA4Y2YzOTgxNmNiZjkwZDNmZjA2Li4wNWY5MTFlMTgyYWMzM2E3 OGQ4Nzc4Y2YwNjE5OTIwNDFmODNmYmQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9TY3JpcHRUaW1lbGluZURhdGFHcmlkLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NjcmlwdFRpbWVsaW5lRGF0 YUdyaWQuanMKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDEzLCAyMDE1 IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMy0y MDE4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlv biBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAq IG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcg Y29uZGl0aW9ucwpAQCAtMzEsNCArMzEsOSBAQCBXSS5TY3JpcHRUaW1lbGluZURhdGFHcmlkID0g Y2xhc3MgU2NyaXB0VGltZWxpbmVEYXRhR3JpZCBleHRlbmRzIFdJLlRpbWVsaW5lRGF0YQogICAg IHsKICAgICAgICAgcmV0dXJuIHRoaXMuc2VsZWN0ZWROb2RlLmVsZW1lbnRXaXRoQ29sdW1uSWRl bnRpZmllcigibG9jYXRpb24iKTsKICAgICB9CisKKyAgICBzaG91bGRTaG93Q2FsbEZyYW1lUG9w b3ZlcigpCisgICAgeworICAgICAgICByZXR1cm4gdGhpcy5pc0NvbHVtblZpc2libGUoImxvY2F0 aW9uIik7CisgICAgfQogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lRGF0YUdyaWQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZURhdGFHcmlkLmpzCmluZGV4IDYzZWRhYzZj OTRlYTU5NmExOGQ3NGFmMDIwYzRhM2FjZTUyYTFmZTcuLmY4ZTQ2ZDg3NjRkYjYxNDU2ZWYzMzk2 NDg2ZjljZGZlZTYxYjUwYTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lRGF0YUdyaWQuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVEYXRhR3JpZC5qcwpAQCAtMSw1ICsx LDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTMsIDIwMTUgQXBwbGUgSW5jLiBBbGwgcmln aHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDEzLTIwMTggQXBwbGUgSW5jLiBBbGwg cmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNl IGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUg cGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0xMjEs NiArMTIxLDEyIEBAIFdJLlRpbWVsaW5lRGF0YUdyaWQgPSBjbGFzcyBUaW1lbGluZURhdGFHcmlk IGV4dGVuZHMgV0kuRGF0YUdyaWQKICAgICAgICAgcmV0dXJuIG51bGw7CiAgICAgfQogCisgICAg c2hvdWxkU2hvd0NhbGxGcmFtZVBvcG92ZXIoKQorICAgIHsKKyAgICAgICAgLy8gSW1wbGVtZW50 ZWQgYnkgc3ViY2xhc3Nlcy4KKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKwogICAgIGFk ZFJvd0luU29ydE9yZGVyKGRhdGFHcmlkTm9kZSwgcGFyZW50RGF0YUdyaWROb2RlKQogICAgIHsK ICAgICAgICAgcGFyZW50RGF0YUdyaWROb2RlID0gcGFyZW50RGF0YUdyaWROb2RlIHx8IHRoaXM7 CkBAIC0zMjAsNyArMzI2LDggQEAgV0kuVGltZWxpbmVEYXRhR3JpZCA9IGNsYXNzIFRpbWVsaW5l RGF0YUdyaWQgZXh0ZW5kcyBXSS5EYXRhR3JpZAogICAgICAgICAgICAgcmV0dXJuOwogICAgICAg ICB9CiAKLSAgICAgICAgdGhpcy5fc2hvd1BvcG92ZXJGb3JTZWxlY3RlZE5vZGVTb29uKCk7Cisg ICAgICAgIGlmICh0aGlzLnNob3VsZFNob3dDYWxsRnJhbWVQb3BvdmVyKCkpCisgICAgICAgICAg ICB0aGlzLl9zaG93UG9wb3ZlckZvclNlbGVjdGVkTm9kZVNvb24oKTsKICAgICB9CiAKICAgICBf c2hvd1BvcG92ZXJGb3JTZWxlY3RlZE5vZGVTb29uKCkK