189601 2018-09-13 13:22:37 -0700 [Curl][WebKit] Bug fix for continuously retrying with empty credentials. 2018-09-14 11:29:28 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 189318 1 basuke basuke achristensen basuke commit-queue darin webkit-bug-importer youennf oldest_to_newest 1459494 0 basuke 2018-09-13 13:22:37 -0700 Found by http/tests/xmlhttprequest/logout.html . When NDT receive authentication challenge and client returns empty credentials, current implementation keep sending empty credentials infinitely. 1459495 1 349693 basuke 2018-09-13 13:25:59 -0700 Created attachment 349693 PATCH 1459800 2 349693 basuke 2018-09-14 11:03:04 -0700 Comment on attachment 349693 PATCH Thanks for r+ 1459815 3 349693 commit-queue 2018-09-14 11:28:37 -0700 Comment on attachment 349693 PATCH Clearing flags on attachment: 349693 Committed r236012: <https://trac.webkit.org/changeset/236012> 1459816 4 commit-queue 2018-09-14 11:28:39 -0700 All reviewed patches have been landed. Closing bug. 1459817 5 webkit-bug-importer 2018-09-14 11:29:28 -0700 <rdar://problem/44463323> 349693 2018-09-13 13:25:59 -0700 2018-09-14 11:28:37 -0700 PATCH 189601.diff text/plain 6432 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYjMzNDA0YzBmYmEuLjdmYmJmNmIyNDc3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE5IEBACisyMDE4LTA5LTEzICBCYXN1a2UgU3V6dWtpICA8QmFzdWtlLlN1enVraUBzb255LmNv bT4KKworICAgICAgICBbQ3VybF1bV2ViS2l0XSBCdWcgZml4IGZvciBjb250aW51b3VzbHkgcmV0 cnlpbmcgd2l0aCBlbXB0eSBjcmVkZW50aWFscy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTYwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIHN0b3AgY29uZGl0aW9uIGZvciBlbXB0eSBjcmVk ZW50aWFscyBwYXNzZWQgYnkgY2xpZW50LgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY3Vy bC9OZXR3b3JrRGF0YVRhc2tDdXJsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0RhdGFU YXNrQ3VybDo6Y3VybERpZFJlY2VpdmVSZXNwb25zZSk6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdv cmtEYXRhVGFza0N1cmw6Omludm9rZURpZFJlY2VpdmVSZXNwb25zZSk6CisgICAgICAgIChXZWJL aXQ6Ok5ldHdvcmtEYXRhVGFza0N1cmw6OnRyeUh0dHBBdXRoZW50aWNhdGlvbik6CisgICAgICAg IChXZWJLaXQ6Ok5ldHdvcmtEYXRhVGFza0N1cmw6OnRyeVByb3h5QXV0aGVudGljYXRpb24pOgor ICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2N1cmwvTmV0d29ya0RhdGFUYXNrQ3VybC5oOgorCiAy MDE4LTA5LTEwICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAg ICAgIFRyeSB0byBmaXggdGhlIGJ1aWxkIGFmdGVyIHIyMzU4NTAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY3VybC9OZXR3b3JrRGF0YVRhc2tDdXJsLmNwcCBiL1Nv dXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY3VybC9OZXR3b3JrRGF0YVRhc2tDdXJsLmNwcApp bmRleCBmN2Q0OWMyODJiMS4uYTE0ZGQxMjYxYmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvY3VybC9OZXR3b3JrRGF0YVRhc2tDdXJsLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L05ldHdvcmtQcm9jZXNzL2N1cmwvTmV0d29ya0RhdGFUYXNrQ3VybC5jcHAKQEAgLTE3 MiwyMiArMTcyLDcgQEAgdm9pZCBOZXR3b3JrRGF0YVRhc2tDdXJsOjpjdXJsRGlkUmVjZWl2ZVJl c3BvbnNlKEN1cmxSZXF1ZXN0JiByZXF1ZXN0LCBjb25zdCBDdXIKICAgICAgICAgcmV0dXJuOwog ICAgIH0KIAotICAgIGRpZFJlY2VpdmVSZXNwb25zZShSZXNvdXJjZVJlc3BvbnNlKG1fcmVzcG9u c2UpLCBbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpXShQb2xpY3lBY3Rpb24g cG9saWN5QWN0aW9uKSB7Ci0gICAgICAgIGlmIChtX3N0YXRlID09IFN0YXRlOjpDYW5jZWxpbmcg fHwgbV9zdGF0ZSA9PSBTdGF0ZTo6Q29tcGxldGVkKQotICAgICAgICAgICAgcmV0dXJuOwotCi0g ICAgICAgIHN3aXRjaCAocG9saWN5QWN0aW9uKSB7Ci0gICAgICAgIGNhc2UgUG9saWN5QWN0aW9u OjpVc2U6Ci0gICAgICAgICAgICBpZiAobV9jdXJsUmVxdWVzdCkKLSAgICAgICAgICAgICAgICBt X2N1cmxSZXF1ZXN0LT5jb21wbGV0ZURpZFJlY2VpdmVSZXNwb25zZSgpOwotICAgICAgICAgICAg YnJlYWs7Ci0gICAgICAgIGNhc2UgUG9saWN5QWN0aW9uOjpJZ25vcmU6Ci0gICAgICAgICAgICBi cmVhazsKLSAgICAgICAgY2FzZSBQb2xpY3lBY3Rpb246OkRvd25sb2FkOgotICAgICAgICAgICAg bm90SW1wbGVtZW50ZWQoKTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9Ci0gICAgfSk7 CisgICAgaW52b2tlRGlkUmVjZWl2ZVJlc3BvbnNlKCk7CiB9CiAKIHZvaWQgTmV0d29ya0RhdGFU YXNrQ3VybDo6Y3VybERpZFJlY2VpdmVCdWZmZXIoQ3VybFJlcXVlc3QmLCBSZWY8U2hhcmVkQnVm ZmVyPiYmIGJ1ZmZlcikKQEAgLTIzNyw2ICsyMjIsMjYgQEAgYm9vbCBOZXR3b3JrRGF0YVRhc2tD dXJsOjpzaG91bGRSZWRpcmVjdEFzR0VUKGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwg Ym8KICAgICByZXR1cm4gZmFsc2U7CiB9CiAKK3ZvaWQgTmV0d29ya0RhdGFUYXNrQ3VybDo6aW52 b2tlRGlkUmVjZWl2ZVJlc3BvbnNlKCkKK3sKKyAgICBkaWRSZWNlaXZlUmVzcG9uc2UoUmVzb3Vy Y2VSZXNwb25zZShtX3Jlc3BvbnNlKSwgW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0 aGlzKV0oUG9saWN5QWN0aW9uIHBvbGljeUFjdGlvbikgeworICAgICAgICBpZiAobV9zdGF0ZSA9 PSBTdGF0ZTo6Q2FuY2VsaW5nIHx8IG1fc3RhdGUgPT0gU3RhdGU6OkNvbXBsZXRlZCkKKyAgICAg ICAgICAgIHJldHVybjsKKworICAgICAgICBzd2l0Y2ggKHBvbGljeUFjdGlvbikgeworICAgICAg ICBjYXNlIFBvbGljeUFjdGlvbjo6VXNlOgorICAgICAgICAgICAgaWYgKG1fY3VybFJlcXVlc3Qp CisgICAgICAgICAgICAgICAgbV9jdXJsUmVxdWVzdC0+Y29tcGxldGVEaWRSZWNlaXZlUmVzcG9u c2UoKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIFBvbGljeUFjdGlvbjo6SWdu b3JlOgorICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgUG9saWN5QWN0aW9uOjpEb3du bG9hZDoKKyAgICAgICAgICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgICAgICAgICBicmVhazsK KyAgICAgICAgfQorICAgIH0pOworfQorCiB2b2lkIE5ldHdvcmtEYXRhVGFza0N1cmw6OndpbGxQ ZXJmb3JtSFRUUFJlZGlyZWN0aW9uKCkKIHsKICAgICBzdGF0aWMgY29uc3QgaW50IG1heFJlZGly ZWN0cyA9IDIwOwpAQCAtMzUzLDE0ICszNTgsMjMgQEAgdm9pZCBOZXR3b3JrRGF0YVRhc2tDdXJs Ojp0cnlIdHRwQXV0aGVudGljYXRpb24oQXV0aGVudGljYXRpb25DaGFsbGVuZ2UmJiBjaGFsbGUK ICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogCi0gICAgICAgIGlmIChkaXNwb3NpdGlv biA9PSBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZURpc3Bvc2l0aW9uOjpVc2VDcmVkZW50aWFsICYm ICFjcmVkZW50aWFsLmlzRW1wdHkoKSkgeworICAgICAgICBpZiAoZGlzcG9zaXRpb24gPT0gQXV0 aGVudGljYXRpb25DaGFsbGVuZ2VEaXNwb3NpdGlvbjo6VXNlQ3JlZGVudGlhbCAmJiAoIWNyZWRl bnRpYWwuaXNFbXB0eSgpIHx8ICFtX2RpZENoYWxsZW5nZUVtcHR5Q3JlZGVudGlhbEZvckF1dGgp KSB7CisgICAgICAgICAgICAvLyBXaGVuICJpc0FsbG93ZWRUb0Fza1VzZXJGb3JDcmVkZW50aWFs cyIgaXMgZmFsc2UsIGFuIGVtcHR5IGNyZWRlbnRpYWwsIHdoaWNoIG1pZ2h0IGNhdXNlCisgICAg ICAgICAgICAvLyBhbiBpbmZpbml0ZSBhdXRoZW50aWNhdGlvbiBsb29wLiBUbyBhdm9pZCBzdWNo IGluZmluaXRlIGxvb3AsIGEgSFRUUCBhdXRoZW50aWNhdGlvbiB3aXRoIGVtcHR5CisgICAgICAg ICAgICAvLyB1c2VyIGFuZCBwYXNzd29yZCBpcyBwcm9jZXNzZWQgb25seSBvbmNlLgorICAgICAg ICAgICAgaWYgKGNyZWRlbnRpYWwuaXNFbXB0eSgpKQorICAgICAgICAgICAgICAgIG1fZGlkQ2hh bGxlbmdlRW1wdHlDcmVkZW50aWFsRm9yQXV0aCA9IHRydWU7CisKICAgICAgICAgICAgIGlmICht X3N0b3JlZENyZWRlbnRpYWxzUG9saWN5ID09IFN0b3JlZENyZWRlbnRpYWxzUG9saWN5OjpVc2Up IHsKICAgICAgICAgICAgICAgICBpZiAoY3JlZGVudGlhbC5wZXJzaXN0ZW5jZSgpID09IENyZWRl bnRpYWxQZXJzaXN0ZW5jZUZvclNlc3Npb24gfHwgY3JlZGVudGlhbC5wZXJzaXN0ZW5jZSgpID09 IENyZWRlbnRpYWxQZXJzaXN0ZW5jZVBlcm1hbmVudCkKICAgICAgICAgICAgICAgICAgICAgbV9z ZXNzaW9uLT5uZXR3b3JrU3RvcmFnZVNlc3Npb24oKS5jcmVkZW50aWFsU3RvcmFnZSgpLnNldCht X3BhcnRpdGlvbiwgY3JlZGVudGlhbCwgY2hhbGxlbmdlLnByb3RlY3Rpb25TcGFjZSgpLCBjaGFs bGVuZ2UuZmFpbHVyZVJlc3BvbnNlKCkudXJsKCkpOwogICAgICAgICAgICAgfQorCisgICAgICAg ICAgICByZXN0YXJ0V2l0aENyZWRlbnRpYWwoY3JlZGVudGlhbCk7CisgICAgICAgICAgICByZXR1 cm47CiAgICAgICAgIH0KIAotICAgICAgICByZXN0YXJ0V2l0aENyZWRlbnRpYWwoY3JlZGVudGlh bCk7CisgICAgICAgIGludm9rZURpZFJlY2VpdmVSZXNwb25zZSgpOwogICAgIH0pOwogfQogCkBA IC0zNzYsMTEgKzM5MCwxOSBAQCB2b2lkIE5ldHdvcmtEYXRhVGFza0N1cmw6OnRyeVByb3h5QXV0 aGVudGljYXRpb24oV2ViQ29yZTo6QXV0aGVudGljYXRpb25DaGFsbGVuZwogICAgICAgICAgICAg cmV0dXJuOwogICAgICAgICB9CiAKLSAgICAgICAgQ3VybENvbnRleHQ6OnNpbmdsZXRvbigpLnNl dFByb3h5VXNlclBhc3MoY3JlZGVudGlhbC51c2VyKCksIGNyZWRlbnRpYWwucGFzc3dvcmQoKSk7 Ci0gICAgICAgIEN1cmxDb250ZXh0OjpzaW5nbGV0b24oKS5zZXREZWZhdWx0UHJveHlBdXRoTWV0 aG9kKCk7CisgICAgICAgIGlmIChkaXNwb3NpdGlvbiA9PSBBdXRoZW50aWNhdGlvbkNoYWxsZW5n ZURpc3Bvc2l0aW9uOjpVc2VDcmVkZW50aWFsICYmICghY3JlZGVudGlhbC5pc0VtcHR5KCkgfHwg IW1fZGlkQ2hhbGxlbmdlRW1wdHlDcmVkZW50aWFsRm9yUHJveHlBdXRoKSkgeworICAgICAgICAg ICAgaWYgKGNyZWRlbnRpYWwuaXNFbXB0eSgpKQorICAgICAgICAgICAgICAgIG1fZGlkQ2hhbGxl bmdlRW1wdHlDcmVkZW50aWFsRm9yUHJveHlBdXRoID0gdHJ1ZTsKKworICAgICAgICAgICAgQ3Vy bENvbnRleHQ6OnNpbmdsZXRvbigpLnNldFByb3h5VXNlclBhc3MoY3JlZGVudGlhbC51c2VyKCks IGNyZWRlbnRpYWwucGFzc3dvcmQoKSk7CisgICAgICAgICAgICBDdXJsQ29udGV4dDo6c2luZ2xl dG9uKCkuc2V0RGVmYXVsdFByb3h5QXV0aE1ldGhvZCgpOworCisgICAgICAgICAgICBhdXRvIHJl cXVlc3RDcmVkZW50aWFsID0gbV9jdXJsUmVxdWVzdCA/IENyZWRlbnRpYWwobV9jdXJsUmVxdWVz dC0+dXNlcigpLCBtX2N1cmxSZXF1ZXN0LT5wYXNzd29yZCgpLCBDcmVkZW50aWFsUGVyc2lzdGVu Y2VOb25lKSA6IENyZWRlbnRpYWwoKTsKKyAgICAgICAgICAgIHJlc3RhcnRXaXRoQ3JlZGVudGlh bChyZXF1ZXN0Q3JlZGVudGlhbCk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KIAot ICAgICAgICBhdXRvIHJlcXVlc3RDcmVkZW50aWFsID0gbV9jdXJsUmVxdWVzdCA/IENyZWRlbnRp YWwobV9jdXJsUmVxdWVzdC0+dXNlcigpLCBtX2N1cmxSZXF1ZXN0LT5wYXNzd29yZCgpLCBDcmVk ZW50aWFsUGVyc2lzdGVuY2VOb25lKSA6IENyZWRlbnRpYWwoKTsKLSAgICAgICAgcmVzdGFydFdp dGhDcmVkZW50aWFsKHJlcXVlc3RDcmVkZW50aWFsKTsKKyAgICAgICAgaW52b2tlRGlkUmVjZWl2 ZVJlc3BvbnNlKCk7CiAgICAgfSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3MvY3VybC9OZXR3b3JrRGF0YVRhc2tDdXJsLmggYi9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL2N1cmwvTmV0d29ya0RhdGFUYXNrQ3VybC5oCmluZGV4IGZjYzRkMzRlNGQ2 Li5hYTBiYTZjZmRlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9j dXJsL05ldHdvcmtEYXRhVGFza0N1cmwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL2N1cmwvTmV0d29ya0RhdGFUYXNrQ3VybC5oCkBAIC02OSw2ICs2OSw4IEBAIHByaXZhdGU6 CiAgICAgdm9pZCBjdXJsRGlkQ29tcGxldGUoV2ViQ29yZTo6Q3VybFJlcXVlc3QmKSBvdmVycmlk ZTsKICAgICB2b2lkIGN1cmxEaWRGYWlsV2l0aEVycm9yKFdlYkNvcmU6OkN1cmxSZXF1ZXN0Jiwg Y29uc3QgV2ViQ29yZTo6UmVzb3VyY2VFcnJvciYpIG92ZXJyaWRlOwogCisgICAgdm9pZCBpbnZv a2VEaWRSZWNlaXZlUmVzcG9uc2UoKTsKKwogICAgIGJvb2wgc2hvdWxkUmVkaXJlY3RBc0dFVChj b25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmLCBib29sIGNyb3NzT3JpZ2luKTsKICAgICB2 b2lkIHdpbGxQZXJmb3JtSFRUUFJlZGlyZWN0aW9uKCk7CiAKQEAgLTg1LDYgKzg3LDggQEAgcHJp dmF0ZToKICAgICBXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlIG1fcmVzcG9uc2U7CiAgICAgdW5z aWduZWQgbV9yZWRpcmVjdENvdW50IHsgMCB9OwogICAgIHVuc2lnbmVkIG1fYXV0aEZhaWx1cmVD b3VudCB7IDAgfTsKKyAgICBib29sIG1fZGlkQ2hhbGxlbmdlRW1wdHlDcmVkZW50aWFsRm9yQXV0 aCB7IGZhbHNlIH07CisgICAgYm9vbCBtX2RpZENoYWxsZW5nZUVtcHR5Q3JlZGVudGlhbEZvclBy b3h5QXV0aCB7IGZhbHNlIH07CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK