<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>189596</bug_id>
          
          <creation_ts>2018-09-13 11:39:04 -0700</creation_ts>
          <short_desc>[WHLSL] Implement f16tof32, isnormal, and f32tof16</short_desc>
          <delta_ts>2018-10-13 14:54:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGPU</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>MOVED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>176199</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Thomas Denney">tdenney</reporter>
          <assigned_to name="Thomas Denney">tdenney</assigned_to>
          <cc>dino</cc>
    
    <cc>mmaxfield</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1459457</commentid>
    <comment_count>0</comment_count>
    <who name="Thomas Denney">tdenney</who>
    <bug_when>2018-09-13 11:39:04 -0700</bug_when>
    <thetext>These functions are currently unimplemented in Intrinsics.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1462126</commentid>
    <comment_count>1</comment_count>
      <attachid>350443</attachid>
    <who name="Thomas Denney">tdenney</who>
    <bug_when>2018-09-21 15:33:25 -0700</bug_when>
    <thetext>Created attachment 350443
WIP</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1462127</commentid>
    <comment_count>2</comment_count>
      <attachid>350444</attachid>
    <who name="Thomas Denney">tdenney</who>
    <bug_when>2018-09-21 15:35:01 -0700</bug_when>
    <thetext>Created attachment 350444
WIP</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1462329</commentid>
    <comment_count>3</comment_count>
      <attachid>350444</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2018-09-22 01:55:37 -0700</bug_when>
    <thetext>Comment on attachment 350444
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=350444&amp;action=review

&gt; Tools/WebGPUShadingLanguageRI/Intrinsics.js:757
&gt; +                    EPtr.box(!Number.isNaN(value.loadValue()));

Nope. &quot;normal&quot; means both not nan and not denormalized

&gt; Tools/WebGPUShadingLanguageRI/Intrinsics.js:808
&gt; +                    EPtr.box(castToFloat(bitwiseCast(Float32Array, Uint32Array, value.loadValue() &amp; 0xFF)));

We have to do more bit twiddling for this one.

&gt; Tools/WebGPUShadingLanguageRI/Intrinsics.js:815
&gt; +                    EPtr.box(bitwiseCast(Uint32Array, Float32Array, castToHalf(value.loadValue())) &amp; 0xFF);

Ditto</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1468811</commentid>
    <comment_count>4</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2018-10-13 14:30:42 -0700</bug_when>
    <thetext>Migrated to https://api.github.com/repos/gpuweb/WHLSL/issues/35</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1468857</commentid>
    <comment_count>5</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2018-10-13 14:54:18 -0700</bug_when>
    <thetext>https://github.com/gpuweb/WHLSL/issues/35</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>350443</attachid>
            <date>2018-09-21 15:33:25 -0700</date>
            <delta_ts>2018-09-21 15:35:00 -0700</delta_ts>
            <desc>WIP</desc>
            <filename>bug-189596-20180921153318.patch</filename>
            <type>text/plain</type>
            <size>6784</size>
            <attacher name="Thomas Denney">tdenney</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MzYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2ExZmEyMzljNDU1ODk5ZTY4OGMyMjNmZmJmZTlhZGQy
OTliMTliNy4uMDc1MGIwYWE1MDc2MmM1ZWQxNjkxYzllODI2ZmYxN2Y4ZTAzNGU4MyAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1
IEBACisyMDE4LTA5LTIxICBUaG9tYXMgRGVubmV5ICA8dGRlbm5leUBhcHBsZS5jb20+CisKKyAg
ICAgICAgW1dITFNMXSBJbXBsZW1lbnQgZjE2dG9mMzIsIGlzbm9ybWFsLCBhbmQgZjMydG9mMTYK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTU5Ngor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViR1BV
U2hhZGluZ0xhbmd1YWdlUkkvSW50cmluc2ljcy5qczogSW1wbGVtZW50IGlzbm9ybWFsIGYzMnRv
ZjE2LAorICAgICAgICBmMTZ0b2YzMgorICAgICAgICAqIFdlYkdQVVNoYWRpbmdMYW5ndWFnZVJJ
L1Rlc3QuanM6IEFkZCB0ZXN0IHRvIHZlcmlmeSBmdW5jdGlvbnMgYXJlIHRoZQorICAgICAgICBp
bnZlcnNlIG9mIGVhY2ggb3RoZXIuCisKIDIwMTgtMDktMjEgIFRob21hcyBEZW5uZXkgIDx0ZGVu
bmV5QGFwcGxlLmNvbT4KIAogICAgICAgICBbV0hMU0xdIExvY2FsIHZhcmlhYmxlcyBzaG91bGQg
YmUgc3RhdGljYWxseSBhbGxvY2F0ZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYkdQVVNoYWRpbmdM
YW5ndWFnZVJJL0ludHJpbnNpY3MuanMgYi9Ub29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9J
bnRyaW5zaWNzLmpzCmluZGV4IDY4YjBkZDU3M2ZjMDJlYTM4NTE3OTU1ZDgzODhhNjQ2YWE5MGE1
OTYuLjBkNzdiYTJkOGE0YmI2NzcwNjZhZWQ0NjI0MzgwNDExM2Q0NzM5ZGYgMTAwNjQ0Ci0tLSBh
L1Rvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL0ludHJpbnNpY3MuanMKKysrIGIvVG9vbHMv
V2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvSW50cmluc2ljcy5qcwpAQCAtNzUwLDIwICs3NTAsMTgg
QEAgY2xhc3MgSW50cmluc2ljcyB7CiAgICAgICAgICAgICAgICAgICAgIEVQdHIuYm94KE51bWJl
ci5pc05hTih2YWx1ZS5sb2FkVmFsdWUoKSkpOwogICAgICAgICAgICAgfSk7CiAKLSAgICAgICAg
Ly8gRklYTUU6IEltcGxlbWVudCB0aGlzLgogICAgICAgICB0aGlzLl9tYXAuc2V0KAogICAgICAg
ICAgICAgIm5hdGl2ZSBib29sIGlzbm9ybWFsKGhhbGYpIiwKICAgICAgICAgICAgIGZ1bmMgPT4g
ewogICAgICAgICAgICAgICAgIGZ1bmMuaW1wbGVtZW50YXRpb24gPSAoW3ZhbHVlXSkgPT4KLSAg
ICAgICAgICAgICAgICAgICAgRVB0ci5ib3goaXNOYU4odmFsdWUubG9hZFZhbHVlKCkpKTsKKyAg
ICAgICAgICAgICAgICAgICAgRVB0ci5ib3goIU51bWJlci5pc05hTih2YWx1ZS5sb2FkVmFsdWUo
KSkpOwogICAgICAgICAgICAgfSk7CiAKLSAgICAgICAgLy8gRklYTUU6IEltcGxlbWVudCB0aGlz
LgogICAgICAgICB0aGlzLl9tYXAuc2V0KAogICAgICAgICAgICAgIm5hdGl2ZSBib29sIGlzbm9y
bWFsKGZsb2F0KSIsCiAgICAgICAgICAgICBmdW5jID0+IHsKICAgICAgICAgICAgICAgICBmdW5j
LmltcGxlbWVudGF0aW9uID0gKFt2YWx1ZV0pID0+Ci0gICAgICAgICAgICAgICAgICAgIEVQdHIu
Ym94KGlzTmFOKHZhbHVlLmxvYWRWYWx1ZSgpKSk7CisgICAgICAgICAgICAgICAgICAgIEVQdHIu
Ym94KCFOdW1iZXIuaXNOYU4odmFsdWUubG9hZFZhbHVlKCkpKTsKICAgICAgICAgICAgIH0pOwog
CiAgICAgICAgIHRoaXMuX21hcC5zZXQoCkBAIC04MDAsMjEgKzc5OCwyMSBAQCBjbGFzcyBJbnRy
aW5zaWNzIHsKICAgICAgICAgICAgICAgICBmdW5jLmltcGxlbWVudGF0aW9uID0gKFt2YWx1ZV0p
ID0+CiAgICAgICAgICAgICAgICAgICAgIEVQdHIuYm94KGJpdHdpc2VDYXN0KFVpbnQzMkFycmF5
LCBGbG9hdDMyQXJyYXksIHZhbHVlLmxvYWRWYWx1ZSgpKSk7CiAgICAgICAgICAgICB9KTsKKyAg
ICAgICAgICAgIAorICAgICAgICAvLyBGSVhNRTogSSBoYXZlIG5vIGlkZWEgaG93IHRvIGNvcnJl
Y3RseSBpbXBsZW1lbnQgdGhlc2UgaW4gSlMuCiAKLSAgICAgICAgLy8gRklYTUU6IEltcGxlbWVu
dCB0aGlzLgogICAgICAgICB0aGlzLl9tYXAuc2V0KAogICAgICAgICAgICAgIm5hdGl2ZSBmbG9h
dCBmMTZ0b2YzMih1aW50KSIsCiAgICAgICAgICAgICBmdW5jID0+IHsKICAgICAgICAgICAgICAg
ICBmdW5jLmltcGxlbWVudGF0aW9uID0gKFt2YWx1ZV0pID0+Ci0gICAgICAgICAgICAgICAgICAg
IEVQdHIuYm94KDApOworICAgICAgICAgICAgICAgICAgICBFUHRyLmJveChjYXN0VG9GbG9hdChi
aXR3aXNlQ2FzdChGbG9hdDMyQXJyYXksIFVpbnQzMkFycmF5LCB2YWx1ZS5sb2FkVmFsdWUoKSAm
IDB4RkYpKSk7CiAgICAgICAgICAgICB9KTsKIAotICAgICAgICAvLyBGSVhNRTogSW1wbGVtZW50
IHRoaXMuCiAgICAgICAgIHRoaXMuX21hcC5zZXQoCiAgICAgICAgICAgICAibmF0aXZlIHVpbnQg
ZjMydG9mMTYoZmxvYXQpIiwKICAgICAgICAgICAgIGZ1bmMgPT4gewogICAgICAgICAgICAgICAg
IGZ1bmMuaW1wbGVtZW50YXRpb24gPSAoW3ZhbHVlXSkgPT4KLSAgICAgICAgICAgICAgICAgICAg
RVB0ci5ib3goMCk7CisgICAgICAgICAgICAgICAgICAgIEVQdHIuYm94KGJpdHdpc2VDYXN0KFVp
bnQzMkFycmF5LCBGbG9hdDMyQXJyYXksIGNhc3RUb0hhbGYodmFsdWUubG9hZFZhbHVlKCkpKSAm
IDB4RkYpOwogICAgICAgICAgICAgfSk7CiAKICAgICAgICAgdGhpcy5fbWFwLnNldCgKZGlmZiAt
LWdpdCBhL1Rvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Rlc3QuanMgYi9Ub29scy9XZWJH
UFVTaGFkaW5nTGFuZ3VhZ2VSSS9UZXN0LmpzCmluZGV4IGJmOWY1NWUzMTUzNzg0YjZkMDA3NGJl
MWI5YTkxNDhiYTJlNDI0OWUuLjhhZjQ5OTNiNzYyOTA5OGQ5YmY5NzU2NmVmNTE3OTAxYmZkMDhh
OTMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Rlc3QuanMKKysr
IGIvVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvVGVzdC5qcwpAQCAtODA4MSwxNTIgKzgw
ODEsMTUgQEAgdGVzdHMuaW5saW5pbmdEb2VzbnRQcm9kdWNlQWxpYXNpbmdJc3N1ZXMgPSAoKSA9
PiB7CiAgICAgY2hlY2tJbnQocHJvZ3JhbSwgY2FsbEZ1bmN0aW9uKHByb2dyYW0sICJmb28iLCBb
XSksIDIwKTsKIH0KIAotdGVzdHMucmV0dXJuUmVmZXJlbmNlVG9QYXJhbWV0ZXIgPSAoKSA9PiB7
Ci0gICAgbGV0IHByb2dyYW0gPSBkb1ByZXAoYAotICAgICAgICB0ZXN0IGludCBmb28oYm9vbCBj
b25kaXRpb24pCi0gICAgICAgIHsKLSAgICAgICAgICAgIHJldHVybiAqYmFyKGNvbmRpdGlvbiwg
MSwgMik7Ci0gICAgICAgIH0KLQotICAgICAgICB0aHJlYWQgaW50KiBiYXIoYm9vbCBjb25kaXRp
b24sIGludCBhLCBpbnQgYikKLSAgICAgICAgewotICAgICAgICAgICAgcmV0dXJuIGNvbmRpdGlv
biA/ICZhIDogJmI7Ci0gICAgICAgIH0KLSAgICBgKTsKLQotICAgIGNoZWNrSW50KHByb2dyYW0s
IGNhbGxGdW5jdGlvbihwcm9ncmFtLCAiZm9vIiwgWyBtYWtlQm9vbChwcm9ncmFtLCB0cnVlKSBd
KSwgMSk7Ci0gICAgY2hlY2tJbnQocHJvZ3JhbSwgY2FsbEZ1bmN0aW9uKHByb2dyYW0sICJmb28i
LCBbIG1ha2VCb29sKHByb2dyYW0sIGZhbHNlKSBdKSwgMik7Ci19Ci0KLXRlc3RzLnJldHVyblJl
ZmVyZW5jZVRvUGFyYW1ldGVyV2l0aERpZmZlcmVudEZ1bmN0aW9ucyA9ICgpID0+IHsKLSAgICBs
ZXQgcHJvZ3JhbSA9IGRvUHJlcChgCi0gICAgICAgIHRlc3QgaW50IGZvbygpCi0gICAgICAgIHsK
LSAgICAgICAgICAgIHJldHVybiAqYmFyKDEwKSArICpiYXooMjApOwotICAgICAgICB9Ci0KLSAg
ICAgICAgdGhyZWFkIGludCogYmFyKGludCB4KQotICAgICAgICB7Ci0gICAgICAgICAgICByZXR1
cm4gJng7Ci0gICAgICAgIH0KLQotICAgICAgICB0aHJlYWQgaW50KiBiYXooaW50IHkpCi0gICAg
ICAgIHsKLSAgICAgICAgICAgIHJldHVybiAmeTsKLSAgICAgICAgfQotICAgIGApOwotCi0gICAg
Y2hlY2tJbnQocHJvZ3JhbSwgY2FsbEZ1bmN0aW9uKHByb2dyYW0sICJmb28iLCBbXSksIDMwKTsK
LX0KLQotdGVzdHMucmV0dXJuUmVmZXJlbmNlVG9TYW1lUGFyYW1ldGVyID0gKCkgPT4gewotICAg
IGxldCBwcm9ncmFtID0gZG9QcmVwKGAKLSAgICAgICAgdGVzdCBpbnQgZm9vKCkKLSAgICAgICAg
ewotICAgICAgICAgICAgcmV0dXJuIHBsdXMoYmFyKDUpLCBiYXIoNykpOwotICAgICAgICB9Ci0K
LSAgICAgICAgaW50IHBsdXModGhyZWFkIGludCogeCwgdGhyZWFkIGludCogeSkKLSAgICAgICAg
ewotICAgICAgICAgICAgcmV0dXJuICp4ICsgKnk7Ci0gICAgICAgIH0KLQotICAgICAgICB0aHJl
YWQgaW50KiBiYXIoaW50IHgpCi0gICAgICAgIHsKLSAgICAgICAgICAgIHJldHVybiAmeDsKLSAg
ICAgICAgfQotICAgIGApOwotCi0gICAgY2hlY2tJbnQocHJvZ3JhbSwgY2FsbEZ1bmN0aW9uKHBy
b2dyYW0sICJmb28iLCBbXSksIDEwKTsKLX0KLQotdGVzdHMucmV0dXJuUmVmZXJlbmNlVG9Mb2Nh
bFZhcmlhYmxlID0gKCkgPT4gewotICAgIGxldCBwcm9ncmFtID0gZG9QcmVwKGAKLSAgICAgICAg
dGVzdCBpbnQgZm9vKCkKLSAgICAgICAgewotICAgICAgICAgICAgcmV0dXJuICpiYXIoKTsKLSAg
ICAgICAgfQotCi0gICAgICAgIHRocmVhZCBpbnQqIGJhcigpCi0gICAgICAgIHsKLSAgICAgICAg
ICAgIGludCBhID0gNDI7Ci0gICAgICAgICAgICByZXR1cm4gJmE7Ci0gICAgICAgIH0KLSAgICBg
KTsKLQotICAgIGNoZWNrSW50KHByb2dyYW0sIGNhbGxGdW5jdGlvbihwcm9ncmFtLCAiZm9vIiwg
W10pLCA0Mik7Ci19Ci0KLXRlc3RzLnJldHVyblJlZmVyZW5jZVRvTG9jYWxWYXJpYWJsZVdpdGhO
ZXN0aW5nID0gKCkgPT4gewotICAgIGxldCBwcm9ncmFtID0gZG9QcmVwKGAKLSAgICAgICAgdGVz
dCBpbnQgZm9vKCkKLSAgICAgICAgewotICAgICAgICAgICAgcmV0dXJuICpiYXIoKSArICpiYXoo
KTsKLSAgICAgICAgfQotCi0gICAgICAgIHRocmVhZCBpbnQqIGJhcigpCi0gICAgICAgIHsKLSAg
ICAgICAgICAgIGludCBhID0gMjA7Ci0gICAgICAgICAgICByZXR1cm4gJmE7Ci0gICAgICAgIH0K
LQotICAgICAgICB0aHJlYWQgaW50KiBiYXooKQotICAgICAgICB7Ci0gICAgICAgICAgICBpbnQg
YSA9IDIyOwotICAgICAgICAgICAgcmV0dXJuICZhOwotICAgICAgICB9Ci0gICAgYCk7Ci0KLSAg
ICBjaGVja0ludChwcm9ncmFtLCBjYWxsRnVuY3Rpb24ocHJvZ3JhbSwgImZvbyIsIFtdKSwgNDIp
OwotfQotCi10ZXN0cy5jb252ZXJ0UHRyVG9BcnJheVJlZiA9ICgpID0+IHsKLSAgICBsZXQgcHJv
Z3JhbSA9IGRvUHJlcChgCi0gICAgICAgIHRlc3QgaW50IGZvbygpCi0gICAgICAgIHsKLSAgICAg
ICAgICAgIHJldHVybiBiYXIoKVswXTsKLSAgICAgICAgfQotCi0gICAgICAgIHRocmVhZCBpbnRb
XSBiYXIoKQotICAgICAgICB7Ci0gICAgICAgICAgICBpbnQgeCA9IDQyOwotICAgICAgICAgICAg
cmV0dXJuIEAoJngpOwotICAgICAgICB9Ci0gICAgYCk7Ci0KLSAgICBjaGVja0ludChwcm9ncmFt
LCBjYWxsRnVuY3Rpb24ocHJvZ3JhbSwgImZvbyIsIFtdKSwgNDIpOwotfQotCi10ZXN0cy5jb252
ZXJ0TG9jYWxWYXJpYWJsZVRvQXJyYXlSZWYgPSAoKSA9PiB7Ci0gICAgbGV0IHByb2dyYW0gPSBk
b1ByZXAoYAotICAgICAgICB0ZXN0IGludCBmb28oKQotICAgICAgICB7Ci0gICAgICAgICAgICBy
ZXR1cm4gYmFyKClbMF07Ci0gICAgICAgIH0KLQotICAgICAgICB0aHJlYWQgaW50W10gYmFyKCkK
LSAgICAgICAgewotICAgICAgICAgICAgaW50IHggPSA0MjsKLSAgICAgICAgICAgIHJldHVybiBA
eDsKLSAgICAgICAgfQordGVzdHMuaGFsZlRvVWludENvbnZlcnNpb25zID0gZnVuY3Rpb24gKCkg
eworICAgIGNvbnN0IHByb2dyYW0gPSBkb1ByZXAoYAorICAgICAgICB0ZXN0IGZsb2F0IGZvbyhm
bG9hdCB4KSB7IHJldHVybiBmMTZ0b2YzMihmMzJ0b2YxNih4KSk7IH0KKyAgICAgICAgdGVzdCB1
aW50IGJhcihmbG9hdCB4KSB7IHJldHVybiBmMzJ0b2YxNih4KTsgfQogICAgIGApOwotCi0gICAg
Y2hlY2tJbnQocHJvZ3JhbSwgY2FsbEZ1bmN0aW9uKHByb2dyYW0sICJmb28iLCBbXSksIDQyKTsK
KyAgICAvLyBjaGVja0Zsb2F0KHByb2dyYW0sIGNhbGxGdW5jdGlvbihwcm9ncmFtLCAiZm9vIiwg
WyBtYWtlRmxvYXQocHJvZ3JhbSwgNDIgKV0pLCA0Mik7CisgICAgY2hlY2tGbG9hdChwcm9ncmFt
LCBjYWxsRnVuY3Rpb24ocHJvZ3JhbSwgImZvbyIsIFsgbWFrZUZsb2F0KHByb2dyYW0sIDQyICld
KSwgNDIpOwogfQogCi10ZXN0cy5yZWZlcmVuY2VUYWtlblRvTG9jYWxWYXJpYWJsZUluRW50cnlQ
b2ludFNob3VsZG50TW92ZUFueXRoaW5nID0gKCkgPT4gewotICAgIGxldCBwcm9ncmFtID0gZG9Q
cmVwKGAKLSAgICAgICAgdGVzdCBpbnQgZm9vKCkKLSAgICAgICAgewotICAgICAgICAgICAgaW50
IGEgPSA0MjsKLSAgICAgICAgICAgIHRocmVhZCBpbnQqIGIgPSAmYTsKLSAgICAgICAgICAgIHJl
dHVybiAqYjsKLSAgICAgICAgfQotICAgIGApOwotCi0gICAgY2hlY2tJbnQocHJvZ3JhbSwgY2Fs
bEZ1bmN0aW9uKHByb2dyYW0sICJmb28iLCBbXSksIDQyKTsKLX07Ci0KIG9rVG9UZXN0ID0gdHJ1
ZTsKIAogbGV0IHRlc3RGaWx0ZXIgPSAvLiovOyAvLyBydW4gZXZlcnl0aGluZyBieSBkZWZhdWx0
Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>350444</attachid>
            <date>2018-09-21 15:35:01 -0700</date>
            <delta_ts>2018-09-21 15:35:01 -0700</delta_ts>
            <desc>WIP</desc>
            <filename>bug-189596-20180921153454.patch</filename>
            <type>text/plain</type>
            <size>3752</size>
            <attacher name="Thomas Denney">tdenney</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MzYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2ExZmEyMzljNDU1ODk5ZTY4OGMyMjNmZmJmZTlhZGQy
OTliMTliNy4uMDc1MGIwYWE1MDc2MmM1ZWQxNjkxYzllODI2ZmYxN2Y4ZTAzNGU4MyAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1
IEBACisyMDE4LTA5LTIxICBUaG9tYXMgRGVubmV5ICA8dGRlbm5leUBhcHBsZS5jb20+CisKKyAg
ICAgICAgW1dITFNMXSBJbXBsZW1lbnQgZjE2dG9mMzIsIGlzbm9ybWFsLCBhbmQgZjMydG9mMTYK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTU5Ngor
CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViR1BV
U2hhZGluZ0xhbmd1YWdlUkkvSW50cmluc2ljcy5qczogSW1wbGVtZW50IGlzbm9ybWFsIGYzMnRv
ZjE2LAorICAgICAgICBmMTZ0b2YzMgorICAgICAgICAqIFdlYkdQVVNoYWRpbmdMYW5ndWFnZVJJ
L1Rlc3QuanM6IEFkZCB0ZXN0IHRvIHZlcmlmeSBmdW5jdGlvbnMgYXJlIHRoZQorICAgICAgICBp
bnZlcnNlIG9mIGVhY2ggb3RoZXIuCisKIDIwMTgtMDktMjEgIFRob21hcyBEZW5uZXkgIDx0ZGVu
bmV5QGFwcGxlLmNvbT4KIAogICAgICAgICBbV0hMU0xdIExvY2FsIHZhcmlhYmxlcyBzaG91bGQg
YmUgc3RhdGljYWxseSBhbGxvY2F0ZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYkdQVVNoYWRpbmdM
YW5ndWFnZVJJL0ludHJpbnNpY3MuanMgYi9Ub29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9J
bnRyaW5zaWNzLmpzCmluZGV4IDY4YjBkZDU3M2ZjMDJlYTM4NTE3OTU1ZDgzODhhNjQ2YWE5MGE1
OTYuLjBkNzdiYTJkOGE0YmI2NzcwNjZhZWQ0NjI0MzgwNDExM2Q0NzM5ZGYgMTAwNjQ0Ci0tLSBh
L1Rvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL0ludHJpbnNpY3MuanMKKysrIGIvVG9vbHMv
V2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvSW50cmluc2ljcy5qcwpAQCAtNzUwLDIwICs3NTAsMTgg
QEAgY2xhc3MgSW50cmluc2ljcyB7CiAgICAgICAgICAgICAgICAgICAgIEVQdHIuYm94KE51bWJl
ci5pc05hTih2YWx1ZS5sb2FkVmFsdWUoKSkpOwogICAgICAgICAgICAgfSk7CiAKLSAgICAgICAg
Ly8gRklYTUU6IEltcGxlbWVudCB0aGlzLgogICAgICAgICB0aGlzLl9tYXAuc2V0KAogICAgICAg
ICAgICAgIm5hdGl2ZSBib29sIGlzbm9ybWFsKGhhbGYpIiwKICAgICAgICAgICAgIGZ1bmMgPT4g
ewogICAgICAgICAgICAgICAgIGZ1bmMuaW1wbGVtZW50YXRpb24gPSAoW3ZhbHVlXSkgPT4KLSAg
ICAgICAgICAgICAgICAgICAgRVB0ci5ib3goaXNOYU4odmFsdWUubG9hZFZhbHVlKCkpKTsKKyAg
ICAgICAgICAgICAgICAgICAgRVB0ci5ib3goIU51bWJlci5pc05hTih2YWx1ZS5sb2FkVmFsdWUo
KSkpOwogICAgICAgICAgICAgfSk7CiAKLSAgICAgICAgLy8gRklYTUU6IEltcGxlbWVudCB0aGlz
LgogICAgICAgICB0aGlzLl9tYXAuc2V0KAogICAgICAgICAgICAgIm5hdGl2ZSBib29sIGlzbm9y
bWFsKGZsb2F0KSIsCiAgICAgICAgICAgICBmdW5jID0+IHsKICAgICAgICAgICAgICAgICBmdW5j
LmltcGxlbWVudGF0aW9uID0gKFt2YWx1ZV0pID0+Ci0gICAgICAgICAgICAgICAgICAgIEVQdHIu
Ym94KGlzTmFOKHZhbHVlLmxvYWRWYWx1ZSgpKSk7CisgICAgICAgICAgICAgICAgICAgIEVQdHIu
Ym94KCFOdW1iZXIuaXNOYU4odmFsdWUubG9hZFZhbHVlKCkpKTsKICAgICAgICAgICAgIH0pOwog
CiAgICAgICAgIHRoaXMuX21hcC5zZXQoCkBAIC04MDAsMjEgKzc5OCwyMSBAQCBjbGFzcyBJbnRy
aW5zaWNzIHsKICAgICAgICAgICAgICAgICBmdW5jLmltcGxlbWVudGF0aW9uID0gKFt2YWx1ZV0p
ID0+CiAgICAgICAgICAgICAgICAgICAgIEVQdHIuYm94KGJpdHdpc2VDYXN0KFVpbnQzMkFycmF5
LCBGbG9hdDMyQXJyYXksIHZhbHVlLmxvYWRWYWx1ZSgpKSk7CiAgICAgICAgICAgICB9KTsKKyAg
ICAgICAgICAgIAorICAgICAgICAvLyBGSVhNRTogSSBoYXZlIG5vIGlkZWEgaG93IHRvIGNvcnJl
Y3RseSBpbXBsZW1lbnQgdGhlc2UgaW4gSlMuCiAKLSAgICAgICAgLy8gRklYTUU6IEltcGxlbWVu
dCB0aGlzLgogICAgICAgICB0aGlzLl9tYXAuc2V0KAogICAgICAgICAgICAgIm5hdGl2ZSBmbG9h
dCBmMTZ0b2YzMih1aW50KSIsCiAgICAgICAgICAgICBmdW5jID0+IHsKICAgICAgICAgICAgICAg
ICBmdW5jLmltcGxlbWVudGF0aW9uID0gKFt2YWx1ZV0pID0+Ci0gICAgICAgICAgICAgICAgICAg
IEVQdHIuYm94KDApOworICAgICAgICAgICAgICAgICAgICBFUHRyLmJveChjYXN0VG9GbG9hdChi
aXR3aXNlQ2FzdChGbG9hdDMyQXJyYXksIFVpbnQzMkFycmF5LCB2YWx1ZS5sb2FkVmFsdWUoKSAm
IDB4RkYpKSk7CiAgICAgICAgICAgICB9KTsKIAotICAgICAgICAvLyBGSVhNRTogSW1wbGVtZW50
IHRoaXMuCiAgICAgICAgIHRoaXMuX21hcC5zZXQoCiAgICAgICAgICAgICAibmF0aXZlIHVpbnQg
ZjMydG9mMTYoZmxvYXQpIiwKICAgICAgICAgICAgIGZ1bmMgPT4gewogICAgICAgICAgICAgICAg
IGZ1bmMuaW1wbGVtZW50YXRpb24gPSAoW3ZhbHVlXSkgPT4KLSAgICAgICAgICAgICAgICAgICAg
RVB0ci5ib3goMCk7CisgICAgICAgICAgICAgICAgICAgIEVQdHIuYm94KGJpdHdpc2VDYXN0KFVp
bnQzMkFycmF5LCBGbG9hdDMyQXJyYXksIGNhc3RUb0hhbGYodmFsdWUubG9hZFZhbHVlKCkpKSAm
IDB4RkYpOwogICAgICAgICAgICAgfSk7CiAKICAgICAgICAgdGhpcy5fbWFwLnNldCgKZGlmZiAt
LWdpdCBhL1Rvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Rlc3QuanMgYi9Ub29scy9XZWJH
UFVTaGFkaW5nTGFuZ3VhZ2VSSS9UZXN0LmpzCmluZGV4IGJmOWY1NWUzMTUzNzg0YjZkMDA3NGJl
MWI5YTkxNDhiYTJlNDI0OWUuLmJlOWY0ZmNjODViYjFkYjZmNTIxMGQxMWI4YTcyYjBkN2Y0ZTZi
ODUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Rlc3QuanMKKysr
IGIvVG9vbHMvV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvVGVzdC5qcwpAQCAtODIyNyw2ICs4MjI3
LDE1IEBAIHRlc3RzLnJlZmVyZW5jZVRha2VuVG9Mb2NhbFZhcmlhYmxlSW5FbnRyeVBvaW50U2hv
dWxkbnRNb3ZlQW55dGhpbmcgPSAoKSA9PiB7CiAgICAgY2hlY2tJbnQocHJvZ3JhbSwgY2FsbEZ1
bmN0aW9uKHByb2dyYW0sICJmb28iLCBbXSksIDQyKTsKIH07CiAKK3Rlc3RzLmhhbGZUb1VpbnRD
b252ZXJzaW9ucyA9IGZ1bmN0aW9uICgpIHsKKyAgICBjb25zdCBwcm9ncmFtID0gZG9QcmVwKGAK
KyAgICAgICAgdGVzdCBmbG9hdCBmb28oZmxvYXQgeCkgeyByZXR1cm4gZjE2dG9mMzIoZjMydG9m
MTYoeCkpOyB9CisgICAgICAgIHRlc3QgdWludCBiYXIoZmxvYXQgeCkgeyByZXR1cm4gZjMydG9m
MTYoeCk7IH0KKyAgICBgKTsKKyAgICAvLyBjaGVja0Zsb2F0KHByb2dyYW0sIGNhbGxGdW5jdGlv
bihwcm9ncmFtLCAiZm9vIiwgWyBtYWtlRmxvYXQocHJvZ3JhbSwgNDIgKV0pLCA0Mik7CisgICAg
Y2hlY2tGbG9hdChwcm9ncmFtLCBjYWxsRnVuY3Rpb24ocHJvZ3JhbSwgImZvbyIsIFsgbWFrZUZs
b2F0KHByb2dyYW0sIDQyICldKSwgNDIpOworfQorCiBva1RvVGVzdCA9IHRydWU7CiAKIGxldCB0
ZXN0RmlsdGVyID0gLy4qLzsgLy8gcnVuIGV2ZXJ5dGhpbmcgYnkgZGVmYXVsdAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>