189579 2018-09-13 03:27:34 -0700 Build error in ImageBufferCG when compiled with IOSurfacePool 2018-09-17 11:25:26 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 188043 1 fred.wang fred.wang benjamin cdumez cmarcelo commit-queue dbates esprehn+autocc ews-watchlist gyuyoung.kim lforschler mdelaney7 mjs simon.fraser thorton webkit-bug-importer oldest_to_newest 1459312 0 fred.wang 2018-09-13 03:27:34 -0700 Applying attachment 349536, I get the errors below on macOS and iOS ports, the unified file is: #include "platform/graphics/cg/IOSurfacePool.cpp" #include "platform/graphics/cg/ImageBufferCG.cpp" #include "platform/graphics/cg/ImageBufferDataCG.cpp" #include "platform/graphics/cg/ImageDecoderCG.cpp" #include "platform/graphics/cg/IntPointCG.cpp" #include "platform/graphics/cg/IntRectCG.cpp" #include "platform/graphics/cg/IntSizeCG.cpp" #include "platform/graphics/cg/NativeImageCG.cpp" IOSurfacePool includes IOSurface.h a first time without defining IOSURFACE_CANVAS_BACKING_STORE ImageBufferCG includes IOSurface.h again but defining IOSURFACE_CANVAS_BACKING_STORE (this second include is ignored because of the #pragma once directive) This is causing IOSurface::createFromImageBuffer to become undefined: In file included from /Users/fred/WebKit/WebKitBuild/Debug/DerivedSources/WebCore/unified-sources/UnifiedSource329.cpp:2: ./platform/graphics/cg/ImageBufferCG.cpp:305:48: error: no member named 'createFromImageBuffer' in 'WebCore::IOSurface' return IOSurface::sinkIntoImage(IOSurface::createFromImageBuffer(WTF... ~~~~~~~~~~~^ ./platform/graphics/cg/ImageBufferCG.cpp:348:71: error: no member named 'createFromImageBuffer' in 'WebCore::IOSurface' RetainPtr<CGImageRef> image = IOSurface::sinkIntoImage(IOSurface::create... ~~~~~~~~~~~^ 2 errors generated. 1459338 1 349660 fred.wang 2018-09-13 06:25:14 -0700 Created attachment 349660 Quick hack to work around the issue 1459372 2 349673 fred.wang 2018-09-13 08:56:07 -0700 Created attachment 349673 Patch A proposed solution. Maybe an alternative is to define USE_IOSURFACE_CANVAS_BACKING_STORE in Source/WTF/wtf/Platform.h? 1459389 3 349673 mjs 2018-09-13 09:47:28 -0700 Comment on attachment 349673 Patch Instead of this change, I think the right fix is to make sure all files have the same value for IOSURFACE_CANVAS_BACKING_STORE. If headers depend on an #ifdef and different files have it set differently, that is a potential problem even without unified builds. Not in this case since the only difference is a static member function, but if the define affected data members, then it would be real bad for different files to have different values. 1459484 4 fred.wang 2018-09-13 12:50:54 -0700 (In reply to Maciej Stachowiak from comment #3) > Comment on attachment 349673 [details] > Patch > > Instead of this change, I think the right fix is to make sure all files have > the same value for IOSURFACE_CANVAS_BACKING_STORE. If headers depend on an > #ifdef and different files have it set differently, that is a potential > problem even without unified builds. Not in this case since the only > difference is a static member function, but if the define affected data > members, then it would be real bad for different files to have different > values. Yeah, I was wondering that too. Does the alternative I propose in comment 2 make sense? 1459725 5 349757 fred.wang 2018-09-14 05:35:52 -0700 Created attachment 349757 Patch (move definition to Platform.h) 1460104 6 fred.wang 2018-09-16 23:13:16 -0700 cc'ing Simon and Matthew since it looks like the definition was added in bug 58084. 1460227 7 349757 thorton 2018-09-17 10:55:10 -0700 Comment on attachment 349757 Patch (move definition to Platform.h) View in context: https://bugs.webkit.org/attachment.cgi?id=349757&action=review > Source/WebCore/platform/graphics/cocoa/IOSurface.h:43 > +#if USE(IOSURFACE_CANVAS_BACKING_STORE) No real need for the #ifs here but they're fine too. 1460242 8 349757 commit-queue 2018-09-17 11:24:18 -0700 Comment on attachment 349757 Patch (move definition to Platform.h) Clearing flags on attachment: 349757 Committed r236074: <https://trac.webkit.org/changeset/236074> 1460243 9 commit-queue 2018-09-17 11:24:20 -0700 All reviewed patches have been landed. Closing bug. 1460245 10 webkit-bug-importer 2018-09-17 11:25:26 -0700 <rdar://problem/44527313> 349660 2018-09-13 06:25:14 -0700 2018-09-13 06:25:14 -0700 Quick hack to work around the issue a.patch text/plain 1592 fred.wang ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3Vy ZmFjZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNl LmgKaW5kZXggM2Y2OGVjZjk2Zi4uZTQ5NDIxYjQwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLmgKQEAgLTg5LDkgKzg5LDkgQEAg cHVibGljOgogICAgIHN0YXRpYyBzdGQ6OnVuaXF1ZV9wdHI8SU9TdXJmYWNlPiBjcmVhdGVGcm9t U3VyZmFjZShJT1N1cmZhY2VSZWYsIENHQ29sb3JTcGFjZVJlZik7CiAgICAgV0VCQ09SRV9FWFBP UlQgc3RhdGljIHN0ZDo6dW5pcXVlX3B0cjxJT1N1cmZhY2U+IGNyZWF0ZUZyb21JbWFnZShDR0lt YWdlUmVmKTsKICAgICAKLSNpZiBVU0UoSU9TVVJGQUNFX0NBTlZBU19CQUNLSU5HX1NUT1JFKQor ICAgIC8vI2lmIFVTRShJT1NVUkZBQ0VfQ0FOVkFTX0JBQ0tJTkdfU1RPUkUpCiAgICAgc3RhdGlj IHN0ZDo6dW5pcXVlX3B0cjxJT1N1cmZhY2U+IGNyZWF0ZUZyb21JbWFnZUJ1ZmZlcihzdGQ6OnVu aXF1ZV9wdHI8SW1hZ2VCdWZmZXI+KTsKLSNlbmRpZgorICAgIC8vI2VuZGlmCiAKICAgICBXRUJD T1JFX0VYUE9SVCBzdGF0aWMgdm9pZCBtb3ZlVG9Qb29sKHN0ZDo6dW5pcXVlX3B0cjxJT1N1cmZh Y2U+JiYpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j b2NvYS9JT1N1cmZhY2UubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2Nv YS9JT1N1cmZhY2UubW0KaW5kZXggZjgyMWVlMDcxZi4uYjMxODc0Mjc0MCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLm1tCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5tbQpAQCAt MTA4LDEyICsxMDgsMTIgQEAgdm9pZCBJT1N1cmZhY2U6Om1vdmVUb1Bvb2woc3RkOjp1bmlxdWVf cHRyPElPU3VyZmFjZT4mJiBzdXJmYWNlKQogICAgIElPU3VyZmFjZVBvb2w6OnNoYXJlZFBvb2wo KS5hZGRTdXJmYWNlKFdURk1vdmUoc3VyZmFjZSkpOwogfQogCi0jaWYgVVNFKElPU1VSRkFDRV9D QU5WQVNfQkFDS0lOR19TVE9SRSkKKy8vI2lmIFVTRShJT1NVUkZBQ0VfQ0FOVkFTX0JBQ0tJTkdf U1RPUkUpCiBzdGQ6OnVuaXF1ZV9wdHI8SU9TdXJmYWNlPiBJT1N1cmZhY2U6OmNyZWF0ZUZyb21J bWFnZUJ1ZmZlcihzdGQ6OnVuaXF1ZV9wdHI8SW1hZ2VCdWZmZXI+IGltYWdlQnVmZmVyKQogewog ICAgIHJldHVybiBXVEZNb3ZlKGltYWdlQnVmZmVyLT5tX2RhdGEuc3VyZmFjZSk7CiB9Ci0jZW5k aWYKKy8vI2VuZGlmCiAKIHN0YXRpYyBOU0RpY3Rpb25hcnkgKm9wdGlvbnNGb3JCaXBsYW5hclN1 cmZhY2UoSW50U2l6ZSBzaXplLCB1bnNpZ25lZCBwaXhlbEZvcm1hdCwgc2l6ZV90IGZpcnN0UGxh bmVCeXRlc1BlclBpeGVsLCBzaXplX3Qgc2Vjb25kUGxhbmVCeXRlc1BlclBpeGVsKQogewo= 349673 2018-09-13 08:56:07 -0700 2018-09-14 05:34:45 -0700 Patch 189579.patch text/plain 6929 fred.wang ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMDI0ZjZiNzNmMy4uMWZiOTE4YzEyODEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzMiBAQAorMjAxOC0wOS0xMyAgRnJlZGVyaWMgV2FuZyAgPGZ3YW5nQGlnYWxpYS5jb20+ CisKKyAgICAgICAgQnVpbGQgZXJyb3IgaW4gSW1hZ2VCdWZmZXJDRyB3aGVuIGNvbXBpbGVkIHdp dGggSU9TdXJmYWNlUG9vbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg5NTc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSU9TdXJmYWNlLmggbWlnaHQgYmUgaW5jbHVkZWQgd2l0aCBkaWZmZXJlbnQgdmFs dWUgb2YgSU9TVVJGQUNFX0NBTlZBU19CQUNLSU5HX1NUT1JFLCBjYXVzaW5nCisgICAgICAgIGNv bXBpbGF0aW9uIGVycm9ycyB3aGVuIGZpbGVzIGluIHRoZSBzYW1lIHVuaWZpZWQgc291cmNlIGRv IG5vdCBhZ3JlZSBvbiB0aGUgZGVmaW5pdGlvbi4KKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVz IHRoZSBjb25kaXRpb25hbCBvbiBJT1NVUkZBQ0VfQ0FOVkFTX0JBQ0tJTkdfU1RPUkUgZnJvbSBJ T1N1cmZhY2UgdG8gd29yaworICAgICAgICBhcm91bmQgdGhhdCBpc3N1ZS4gV2UgYWxzbyBlbnN1 cmUgdGhhdCBhbGwgdGhlIHJlbWFpbmluZyBwbGFjZXMgaW52b2x2aW5nCisgICAgICAgIElPU1VS RkFDRV9DQU5WQVNfQkFDS0lOR19TVE9SRSBhcmUgQysrIGZpbGVzIHRoYXQgZXhwbGljaXRseSBp bmNsdWRlIEltYWdlQnVmZmVyRGF0YS5oIChhbmQKKyAgICAgICAgaGVuY2UgcHJvcGVybHkgZGVm aW5lcyBJT1NVUkZBQ0VfQ0FOVkFTX0JBQ0tJTkdfU1RPUkUpIGFsdGhvdWdoIG1vc3QgYWxyZWFk eSBpbmNsdWRlIGl0CisgICAgICAgIGluZGlyZWN0bHkgdmlhIEltYWdlQnVmZmVyLmguCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCBiZWhhdmlvciB1bmNoYW5nZWQuCisKKyAgICAgICAgKiBodG1s L0hUTUxDYW52YXNFbGVtZW50LmNwcDogQWRkIEltYWdlQnVmZmVyIGluY2x1ZGUgc2luY2UgdGhl IGNsYXNzIGlzIHVzZWQgaW4gdGhpcyBmaWxlLgorICAgICAgICAqIGh0bWwvSW1hZ2VCaXRtYXAu Y3BwOgorICAgICAgICAqIGh0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2Uu Y3BwOgorICAgICAgICAqIGh0bWwvY2FudmFzL0ltYWdlQml0bWFwUmVuZGVyaW5nQ29udGV4dC5j cHA6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZmZXIuY3BwOgorICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQnVmZmVyQ0cuY3BwOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQnVmZmVyRGF0YUNHLmNwcDoKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9jb2NvYS9JT1N1cmZhY2UuaDogRm9yd2FyZC1kZWNsYXJlIEltYWdlQnVm ZmVyIHRvIGVuc3VyZSB3ZSBjYW4gYWx3YXlzCisgICAgICAgIGRlY2xhcmUgY3JlYXRlRnJvbUlt YWdlQnVmZmVyIGluIHRoaXMgaGVhZGVyLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nv Y29hL0lPU3VyZmFjZS5tbToKKyAgICAgICAgKFdlYkNvcmU6OklPU3VyZmFjZTo6Y3JlYXRlRnJv bUltYWdlQnVmZmVyKToKKwogMjAxOC0wOS0xMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3NoYWRvdy1k b20vZm9ybS1jb250cm9sLWZvcm0tYXR0cmlidXRlLmh0bWwgaGl0cyBhc3NlcnRpb24KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKaW5kZXggNDUzN2JiYmU0NWIuLjZk M2U4ODNkMzQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcApA QCAtNDIsNiArNDIsOCBAQAogI2luY2x1ZGUgIkhUTUxOYW1lcy5oIgogI2luY2x1ZGUgIkhUTUxQ YXJzZXJJZGlvbXMuaCIKICNpbmNsdWRlICJJbWFnZUJpdG1hcFJlbmRlcmluZ0NvbnRleHQuaCIK KyNpbmNsdWRlICJJbWFnZUJ1ZmZlci5oIgorI2luY2x1ZGUgIkltYWdlQnVmZmVyRGF0YS5oIiAv LyBEZWZpbmUgVVNFX0lPU1VSRkFDRV9DQU5WQVNfQkFDS0lOR19TVE9SRS4KICNpbmNsdWRlICJJ bWFnZURhdGEuaCIKICNpbmNsdWRlICJJbnNwZWN0b3JJbnN0cnVtZW50YXRpb24uaCIKICNpbmNs dWRlICJKU0RPTUNvbnZlcnREaWN0aW9uYXJ5LmgiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0ltYWdlQml0bWFwLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW1hZ2VCaXRtYXAu Y3BwCmluZGV4IDdkZTM0NjcwN2FjLi5mYmJlZDk4OWI0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9JbWFnZUJpdG1hcC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbWFn ZUJpdG1hcC5jcHAKQEAgLTM4LDYgKzM4LDcgQEAKICNpbmNsdWRlICJIVE1MVmlkZW9FbGVtZW50 LmgiCiAjaW5jbHVkZSAiSW1hZ2VCaXRtYXBPcHRpb25zLmgiCiAjaW5jbHVkZSAiSW1hZ2VCdWZm ZXIuaCIKKyNpbmNsdWRlICJJbWFnZUJ1ZmZlckRhdGEuaCIgLy8gRGVmaW5lIFVTRV9JT1NVUkZB Q0VfQ0FOVkFTX0JBQ0tJTkdfU1RPUkUuCiAjaW5jbHVkZSAiSW1hZ2VEYXRhLmgiCiAjaW5jbHVk ZSAiSW50UmVjdC5oIgogI2luY2x1ZGUgIkpTSW1hZ2VCaXRtYXAuaCIKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2UuY3Bw IGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFz ZS5jcHAKaW5kZXggNmQ3MWNiZTI4N2MuLjMzMTdlOGU1YTM2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNl LmNwcApAQCAtNDksNiArNDksNyBAQAogI2luY2x1ZGUgIkhUTUxWaWRlb0VsZW1lbnQuaCIKICNp bmNsdWRlICJJbWFnZUJpdG1hcC5oIgogI2luY2x1ZGUgIkltYWdlQnVmZmVyLmgiCisjaW5jbHVk ZSAiSW1hZ2VCdWZmZXJEYXRhLmgiIC8vIERlZmluZSBVU0VfSU9TVVJGQUNFX0NBTlZBU19CQUNL SU5HX1NUT1JFLgogI2luY2x1ZGUgIkltYWdlRGF0YS5oIgogI2luY2x1ZGUgIlBhdGgyRC5oIgog I2luY2x1ZGUgIlJlbmRlckVsZW1lbnQuaCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvY2FudmFzL0ltYWdlQml0bWFwUmVuZGVyaW5nQ29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL2NhbnZhcy9JbWFnZUJpdG1hcFJlbmRlcmluZ0NvbnRleHQuY3BwCmluZGV4IDg0ODk5 ZmFiYjEzLi40ZTg2ZmI3ZmY3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52 YXMvSW1hZ2VCaXRtYXBSZW5kZXJpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9JbWFnZUJpdG1hcFJlbmRlcmluZ0NvbnRleHQuY3BwCkBAIC0yOCw2ICsyOCw3 IEBACiAKICNpbmNsdWRlICJJbWFnZUJpdG1hcC5oIgogI2luY2x1ZGUgIkltYWdlQnVmZmVyLmgi CisjaW5jbHVkZSAiSW1hZ2VCdWZmZXJEYXRhLmgiIC8vIERlZmluZSBVU0VfSU9TVVJGQUNFX0NB TlZBU19CQUNLSU5HX1NUT1JFLgogI2luY2x1ZGUgIkluc3BlY3Rvckluc3RydW1lbnRhdGlvbi5o IgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9JbWFnZUJ1ZmZlci5jcHAKaW5kZXggOTdiYTFlYTFiOTQuLmYzZGMxY2I5ZjJjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZmZXIuY3Bw CkBAIC0zMCw2ICszMCw3IEBACiAKICNpbmNsdWRlICJDb2xvclV0aWxpdGllcy5oIgogI2luY2x1 ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgorI2luY2x1ZGUgIkltYWdlQnVmZmVyRGF0YS5oIiAvLyBE ZWZpbmUgVVNFX0lPU1VSRkFDRV9DQU5WQVNfQkFDS0lOR19TVE9SRS4KICNpbmNsdWRlICJJbnRS ZWN0LmgiCiAjaW5jbHVkZSA8d3RmL01hdGhFeHRyYXMuaD4KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VCdWZmZXJDRy5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUJ1ZmZlckNHLmNwcAppbmRleCA0MjE2 YmEwYjE2Yy4uMWVhNWYzYjVkOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NnL0ltYWdlQnVmZmVyQ0cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NnL0ltYWdlQnVmZmVyQ0cuY3BwCkBAIC0yNyw2ICsyNyw3IEBACiAKICNp bmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJJbWFnZUJ1ZmZlci5oIgorI2luY2x1ZGUgIklt YWdlQnVmZmVyRGF0YS5oIgogCiAjaWYgVVNFKENHKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUJ1ZmZlckRhdGFDRy5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUJ1ZmZlckRhdGFDRy5jcHAKaW5kZXgg ZDQyYWEzNDQ4YjAuLjQ3ZGNlMDdhZjY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUJ1ZmZlckRhdGFDRy5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VCdWZmZXJEYXRhQ0cuY3BwCkBAIC0yNCw3ICsy NCw3IEBACiAgKi8KIAogI2luY2x1ZGUgImNvbmZpZy5oIgotI2luY2x1ZGUgIkltYWdlQnVmZmVy RGF0YS5oIgorI2luY2x1ZGUgIkltYWdlQnVmZmVyRGF0YS5oIiAvLyBEZWZpbmUgVVNFX0lPU1VS RkFDRV9DQU5WQVNfQkFDS0lOR19TVE9SRS4KIAogI2lmIFVTRShDRykKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLmggYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9JT1N1cmZhY2UuaAppbmRleCAzZjY4 ZWNmOTZmYS4uODg4OGYyNTlkYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5oCkBAIC0zOSw2ICszOSw3IEBAIGNsYXNzIFRleHRT dHJlYW07CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIEhvc3RXaW5kb3c7CitjbGFzcyBJ bWFnZUJ1ZmZlcjsKICAgICAKIGNsYXNzIElPU3VyZmFjZSBmaW5hbCB7CiAgICAgV1RGX01BS0Vf RkFTVF9BTExPQ0FURUQ7CkBAIC04OSw5ICs5MCw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgc3Rk Ojp1bmlxdWVfcHRyPElPU3VyZmFjZT4gY3JlYXRlRnJvbVN1cmZhY2UoSU9TdXJmYWNlUmVmLCBD R0NvbG9yU3BhY2VSZWYpOwogICAgIFdFQkNPUkVfRVhQT1JUIHN0YXRpYyBzdGQ6OnVuaXF1ZV9w dHI8SU9TdXJmYWNlPiBjcmVhdGVGcm9tSW1hZ2UoQ0dJbWFnZVJlZik7CiAgICAgCi0jaWYgVVNF KElPU1VSRkFDRV9DQU5WQVNfQkFDS0lOR19TVE9SRSkKICAgICBzdGF0aWMgc3RkOjp1bmlxdWVf cHRyPElPU3VyZmFjZT4gY3JlYXRlRnJvbUltYWdlQnVmZmVyKHN0ZDo6dW5pcXVlX3B0cjxJbWFn ZUJ1ZmZlcj4pOwotI2VuZGlmCiAKICAgICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMgdm9pZCBtb3Zl VG9Qb29sKHN0ZDo6dW5pcXVlX3B0cjxJT1N1cmZhY2U+JiYpOwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9JT1N1cmZhY2UubW0gYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9JT1N1cmZhY2UubW0KaW5kZXggZjgyMWVl MDcxZmEuLjVhNmU3YWJiMGNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jb2NvYS9JT1N1cmZhY2UubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLm1tCkBAIC0xMDgsMTIgKzEwOCwxMCBAQCB2b2lkIElP U3VyZmFjZTo6bW92ZVRvUG9vbChzdGQ6OnVuaXF1ZV9wdHI8SU9TdXJmYWNlPiYmIHN1cmZhY2Up CiAgICAgSU9TdXJmYWNlUG9vbDo6c2hhcmVkUG9vbCgpLmFkZFN1cmZhY2UoV1RGTW92ZShzdXJm YWNlKSk7CiB9CiAKLSNpZiBVU0UoSU9TVVJGQUNFX0NBTlZBU19CQUNLSU5HX1NUT1JFKQogc3Rk Ojp1bmlxdWVfcHRyPElPU3VyZmFjZT4gSU9TdXJmYWNlOjpjcmVhdGVGcm9tSW1hZ2VCdWZmZXIo c3RkOjp1bmlxdWVfcHRyPEltYWdlQnVmZmVyPiBpbWFnZUJ1ZmZlcikKIHsKICAgICByZXR1cm4g V1RGTW92ZShpbWFnZUJ1ZmZlci0+bV9kYXRhLnN1cmZhY2UpOwogfQotI2VuZGlmCiAKIHN0YXRp YyBOU0RpY3Rpb25hcnkgKm9wdGlvbnNGb3JCaXBsYW5hclN1cmZhY2UoSW50U2l6ZSBzaXplLCB1 bnNpZ25lZCBwaXhlbEZvcm1hdCwgc2l6ZV90IGZpcnN0UGxhbmVCeXRlc1BlclBpeGVsLCBzaXpl X3Qgc2Vjb25kUGxhbmVCeXRlc1BlclBpeGVsKQogewo= 349757 2018-09-14 05:35:52 -0700 2018-09-17 11:24:18 -0700 Patch (move definition to Platform.h) 189579.patch text/plain 4490 fred.wang ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggOTY0ZWM4Y2NiODEuLmMyZmUzY2I2YTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4 LTA5LTE0ICBGcmVkZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBCdWls ZCBlcnJvciBpbiBJbWFnZUJ1ZmZlckNHIHdoZW4gY29tcGlsZWQgd2l0aCBJT1N1cmZhY2VQb29s CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODk1NzkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJT1N1cmZh Y2UuaCBtaWdodCBiZSBpbmNsdWRlZCB3aXRoIGRpZmZlcmVudCB2YWx1ZSBvZiBJT1NVUkZBQ0Vf Q0FOVkFTX0JBQ0tJTkdfU1RPUkUsIGNhdXNpbmcKKyAgICAgICAgY29tcGlsYXRpb24gZXJyb3Jz IHdoZW4gZmlsZXMgaW4gdGhlIHNhbWUgdW5pZmllZCBzb3VyY2UgZG8gbm90IGFncmVlIG9uIHRo ZSBkZWZpbml0aW9uLgorICAgICAgICBUaGlzIHBhdGNoIG1vdmVzIHRoZSBkZWZpbml0aW9uIG9m IElPU1VSRkFDRV9DQU5WQVNfQkFDS0lOR19TVE9SRSBmcm9tIEltYWdlQnVmZmVyRGF0YUNHLmgK KyAgICAgICAgdG8gUGxhdGZvcm0uaCBzbyB0aGF0IElPU1VSRkFDRV9DQU5WQVNfQkFDS0lOR19T VE9SRSBpcyBzZXQgdG8gdGhlIHNhbWUgdmFsdWUgaW4gYWxsIGZpbGVzLgorICAgICAgICBGaW5h bGx5IHNvbWUgbWlub3JzIGNoYW5nZXMgdG8gZXhwbGljaXRseSBkZWNsYXJlL2RlZmluZSBJbWFn ZUJ1ZmZlciBhcmUgcGVyZm9ybWVkIGluIG9yZGVyCisgICAgICAgIHRvIHByZXZlbnQgZnV0dXJl IGlzc3VlcyB3aXRoIFVuaWZpZWQgYnVpbGQgcm90YXRpbmcuCisKKyAgICAgICAgKiB3dGYvUGxh dGZvcm0uaDogTW92ZSBkZWZpbml0aW9uIGZyb20gSW1hZ2VCdWZmZXJEYXRhQ0cuaC4KKwogMjAx OC0wOS0xMyAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFi bGUgVVNFX01FRElBUkVNT1RFIG9uIGlPUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxh dGZvcm0uaCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKaW5kZXggMTJhMWU5MzhmYmYuLmU1 NjljZGM1NjM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1Nv dXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTEzNDcsNCArMTM0Nyw4IEBACiAjZGVmaW5lIEhB VkVfU0VDX0tFWV9QUk9YWSAxCiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKENPQ09BKSAmJiBVU0Uo Q0EpICYmICFQTEFURk9STShJT1NfU0lNVUxBVE9SKQorI2RlZmluZSBVU0VfSU9TVVJGQUNFX0NB TlZBU19CQUNLSU5HX1NUT1JFIDEKKyNlbmRpZgorCiAjZW5kaWYgLyogV1RGX1BsYXRmb3JtX2gg Ki8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCAxMWNmYWQxM2NmYy4uMWEyMTU0ZTlhMmMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyNCBAQAorMjAxOC0wOS0xNCAgRnJlZGVyaWMgV2FuZyAgPGZ3YW5nQGlnYWxpYS5j b20+CisKKyAgICAgICAgQnVpbGQgZXJyb3IgaW4gSW1hZ2VCdWZmZXJDRyB3aGVuIGNvbXBpbGVk IHdpdGggSU9TdXJmYWNlUG9vbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTg5NTc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSU9TdXJmYWNlLmggbWlnaHQgYmUgaW5jbHVkZWQgd2l0aCBkaWZmZXJlbnQg dmFsdWUgb2YgSU9TVVJGQUNFX0NBTlZBU19CQUNLSU5HX1NUT1JFLCBjYXVzaW5nCisgICAgICAg IGNvbXBpbGF0aW9uIGVycm9ycyB3aGVuIGZpbGVzIGluIHRoZSBzYW1lIHVuaWZpZWQgc291cmNl IGRvIG5vdCBhZ3JlZSBvbiB0aGUgZGVmaW5pdGlvbi4KKyAgICAgICAgVGhpcyBwYXRjaCBtb3Zl cyB0aGUgZGVmaW5pdGlvbiBvZiBJT1NVUkZBQ0VfQ0FOVkFTX0JBQ0tJTkdfU1RPUkUgZnJvbSBJ bWFnZUJ1ZmZlckRhdGFDRy5oCisgICAgICAgIHRvIFBsYXRmb3JtLmggc28gdGhhdCBJT1NVUkZB Q0VfQ0FOVkFTX0JBQ0tJTkdfU1RPUkUgaXMgc2V0IHRvIHRoZSBzYW1lIHZhbHVlIGluIGFsbCBm aWxlcy4KKyAgICAgICAgRmluYWxseSBzb21lIG1pbm9ycyBjaGFuZ2VzIHRvIGV4cGxpY2l0bHkg ZGVjbGFyZS9kZWZpbmUgSW1hZ2VCdWZmZXIgYXJlIHBlcmZvcm1lZCBpbiBvcmRlcgorICAgICAg ICB0byBwcmV2ZW50IGZ1dHVyZSBpc3N1ZXMgd2l0aCBVbmlmaWVkIGJ1aWxkIHJvdGF0aW5nLgor CisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVoYXZpb3IgdW5jaGFuZ2VkLgorCisgICAgICAgICog aHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHA6IEV4cGxpY2l0bHkgaW5jbHVkZSBJbWFnZUJ1ZmZl ci5oIHNpbmNlIGl0J3MgdXNlZCBpbiB0aGlzIGZpbGUuCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvY2cvSW1hZ2VCdWZmZXJEYXRhQ0cuaDogTW92ZSBkZWZpbml0aW9uIGludG8gUGxhdGZv cm0uaC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9JT1N1cmZhY2UuaDogRm9y d2FyZC1kZWNsYXJlIEltYWdlQnVmZmVyIHNpbmNlIGl0J3MgdXNlZCBpbiB0aGlzCisgICAgICAg IGhlYWRlci4KKwogMjAxOC0wOS0xMyAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4K IAogICAgICAgICBDYXB0dXJpbmcgZXZlbnQgbGlzdGVuZXJzIGFyZSBjYWxsZWQgZHVyaW5nIGJ1 YmJsaW5nIHBoYXNlIGZvciBzaGFkb3cgaG9zdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2Fu dmFzRWxlbWVudC5jcHAKaW5kZXggNDUzN2JiYmU0NWIuLjhmNzBlOTc4OWRlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcApAQCAtNDIsNiArNDIsNyBAQAogI2lu Y2x1ZGUgIkhUTUxOYW1lcy5oIgogI2luY2x1ZGUgIkhUTUxQYXJzZXJJZGlvbXMuaCIKICNpbmNs dWRlICJJbWFnZUJpdG1hcFJlbmRlcmluZ0NvbnRleHQuaCIKKyNpbmNsdWRlICJJbWFnZUJ1ZmZl ci5oIgogI2luY2x1ZGUgIkltYWdlRGF0YS5oIgogI2luY2x1ZGUgIkluc3BlY3Rvckluc3RydW1l bnRhdGlvbi5oIgogI2luY2x1ZGUgIkpTRE9NQ29udmVydERpY3Rpb25hcnkuaCIKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQnVmZmVyRGF0YUNH LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUJ1ZmZlckRhdGFD Ry5oCmluZGV4IDU3YjE2Y2Y1NzhhLi5jNTVhNTRhZDkxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VCdWZmZXJEYXRhQ0cuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUJ1ZmZlckRhdGFDRy5oCkBAIC0z MywxMCArMzMsNiBAQAogI2luY2x1ZGUgPHd0Zi9SZXRhaW5QdHIuaD4KICNpbmNsdWRlIDx3dGYv VmVjdG9yLmg+CiAKLSNpZiBQTEFURk9STShDT0NPQSkgJiYgVVNFKENBKSAmJiAhUExBVEZPUk0o SU9TX1NJTVVMQVRPUikKLSNkZWZpbmUgVVNFX0lPU1VSRkFDRV9DQU5WQVNfQkFDS0lOR19TVE9S RSAxCi0jZW5kaWYKLQogdHlwZWRlZiBzdHJ1Y3QgQ0dDb2xvclNwYWNlICpDR0NvbG9yU3BhY2VS ZWY7CiB0eXBlZGVmIHN0cnVjdCBDR0RhdGFQcm92aWRlciAqQ0dEYXRhUHJvdmlkZXJSZWY7CiB0 eXBlZGVmIHVpbnQzMl90IENHQml0bWFwSW5mbzsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLmgKaW5kZXggM2Y2OGVjZjk2ZmEuLmRhZjZl OTA5ODVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2Nv YS9JT1N1cmZhY2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2Nv YS9JT1N1cmZhY2UuaApAQCAtNDAsNiArNDAsMTAgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBj bGFzcyBIb3N0V2luZG93OwogICAgIAorI2lmIFVTRShJT1NVUkZBQ0VfQ0FOVkFTX0JBQ0tJTkdf U1RPUkUpCitjbGFzcyBJbWFnZUJ1ZmZlcjsKKyNlbmRpZgorCiBjbGFzcyBJT1N1cmZhY2UgZmlu YWwgewogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgo=