189540 2018-09-12 01:06:41 -0700 Linking against libWPEWebKit-0.1.so is not posible when WPE is build with ENABLE_VIDEO=OFF and ENABLE_WEB_AUDIO=OFF 2018-09-12 02:13:43 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psaavedra webkit-unassigned alex calvaris clopez commit-queue ews-watchlist pnormand webkit-bug-importer youennf oldest_to_newest 1458896 0 psaavedra 2018-09-12 01:06:41 -0700 Linking against a built libWPEWebKit-0.1.so is not posible when WPE is build with: -DENABLE_VIDEO=OFF -DENABLE_WEB_AUDIO=OFF Error: platform/mediastream/libwebrtc/LibWebRTCProviderGlib.cpp only is added if `ENABLE_VIDEO OR ENABLE_WEB_AUDIO` (L1 in Source/WebCore/platform/GStreamer.cmake) so `WebCore::LibWebRTCProvider::webRTCAvailable() and `WebCore::LibWebRTCProvider::create()' are not defined and the shared library is incomplete. /home/igalia/psaavedra/vorwerk-bsp/builds/wandboard/tmp/work/armv7ahf-neon-poky-linux-gnueabi/cog/gitAUTOINC-r0/recipe-sysroot/usr/lib/libWPEWebKit-0.1.so: undefined reference to `WebCore::LibWebRTCProvider::webRTCAvailable()' /home/igalia/psaavedra/vorwerk-bsp/builds/wandboard/tmp/work/armv7ahf-neon-poky-linux-gnueabi/cog/gitAUTOINC-r0/recipe-sysroot/usr/lib/libWPEWebKit-0.1.so: undefined reference to `WebCore::LibWebRTCProvider::create()' collect2: error: ld returned 1 exit status Other considerations: Actual CMake flags used for tests: -DPORT=WPE \ -DCMAKE_BUILD_TYPE=Release \ -DENABLE_ACCELERATED_2D_CANVAS=ON \ -DENABLE_DEVICE_ORIENTATION=OFF \ -DENABLE_ENCRYPTED_MEDIA=OFF \ -DENABLE_FETCH_API=ON \ -DENABLE_GAMEPAD=OFF \ -DENABLE_GEOLOCATION=OFF \ -DUSE_GSTREAMER_GL=OFF \ -DENABLE_MEDIA_SOURCE=OFF \ -DENABLE_REMOTE_INSPECTOR=ON \ -DENABLE_VIDEO=OFF \ -DENABLE_VIDEO_TRACK=OFF \ -DENABLE_WEB_AUDIO=OFF \ -DENABLE_WEB_CRYPTO=OFF \ -DUSE_WOFF2=ON WebRTC is not enabled in the CMake configuration: cat build/cmakeconfig.h | grep RTC #define ENABLE_WEB_RTC 0 #define USE_LIBWEBRTC 0 #define WEBRTC_WEBKIT_BUILD 0 Related issues: This issue is related with changes in https://bugs.webkit.org/show_bug.cgi?id=183080 This issue is introduced in https://bugs.webkit.org/show_bug.cgi?id=186547 1458897 1 349531 psaavedra 2018-09-12 01:12:36 -0700 Created attachment 349531 patch 1458898 2 ews-watchlist 2018-09-12 01:15:30 -0700 Attachment 349531 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] ERROR: Source/WebCore/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1458899 3 pnormand 2018-09-12 01:18:25 -0700 Looks good! Not sure why the style-checker complained though, can you check it? 1458900 4 349532 psaavedra 2018-09-12 01:25:28 -0700 Created attachment 349532 patch 1458901 5 psaavedra 2018-09-12 01:33:10 -0700 (In reply to Philippe Normand from comment #3) > Looks good! Not sure why the style-checker complained though, can you check > it? fixed. The style checker interprets a "* ___:___" pattern as a file change description item. 1458902 6 349532 commit-queue 2018-09-12 02:12:04 -0700 Comment on attachment 349532 patch Clearing flags on attachment: 349532 Committed r235933: <https://trac.webkit.org/changeset/235933> 1458903 7 commit-queue 2018-09-12 02:12:06 -0700 All reviewed patches have been landed. Closing bug. 1458904 8 webkit-bug-importer 2018-09-12 02:13:43 -0700 <rdar://problem/44376382> 349531 2018-09-12 01:12:36 -0700 2018-09-12 01:25:23 -0700 patch bug-189540-20180912101235.patch text/plain 3009 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1OTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTMwOWZkMzRkZTZlNjJl MDY2M2MzODNjMTE1NmYyNjgzNzkwMWIwMy4uYTUwNDIwMWU0NTI1NWQ5MzM1MGMzOWMzMWJlM2Ux ODE1YjQ0YzhkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA5LTEyICBQYWJs byBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIExpbmtpbmcgYWdh aW5zdCBsaWJXUEVXZWJLaXQtMC4xLnNvIGlzIG5vdCBwb3NpYmxlIHdoZW4gV1BFIGlzIGJ1aWxk IHdpdGggRU5BQkxFX1ZJREVPPU9GRiBhbmQgRU5BQkxFX1dFQl9BVURJTz1PRkYKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTU0MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbGF0ZWQgaXNzdWVzOgor CisgICAgICAgICogVGhpcyBpc3N1ZSBpcyByZWxhdGVkIHdpdGggY2hhbmdlcyBpbiBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTgzMDgwCisgICAgICAgICogVGhpcyBp c3N1ZSBpcyBpbnRyb2R1Y2VkIGluIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODY1NDcKKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGNoYW5nZXMgaW4gdGhlIGZ1 bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9HU3RyZWFtZXIuY21ha2U6CisgICAg ICAgICogcGxhdGZvcm0vU291cmNlc0dMaWIudHh0OgorICAgICAgICAqIHBsYXRmb3JtL21lZGlh c3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92aWRlckdsaWIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6TGliV2ViUlRDUHJvdmlkZXI6OndlYlJUQ0F2YWlsYWJsZSk6CisKIDIwMTgtMDktMTEg IFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQgV1BFIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0dT dHJlYW1lci5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0dTdHJlYW1lci5jbWFrZQpp bmRleCBmZjA1OTlmMDM2NDM0YjBhMGRhNzIwYTJlMDM0YzRmYjI2OWNjYTIwLi5kOWExZmRiMzBj NDIwZjA5ODFiZmVlZjRkY2RmNGM5NmFmZGRhMjVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9HU3RyZWFtZXIuY21ha2UKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v R1N0cmVhbWVyLmNtYWtlCkBAIC0zNiw3ICszNiw2IEBAIGlmIChFTkFCTEVfVklERU8gT1IgRU5B QkxFX1dFQl9BVURJTykKICAgICAgICAgcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0dT dHJlYW1lclZpZGVvRGVjb2RlckZhY3RvcnkuY3BwCiAgICAgICAgIHBsYXRmb3JtL21lZGlhc3Ry ZWFtL2xpYndlYnJ0Yy9HU3RyZWFtZXJWaWRlb0VuY29kZXJGYWN0b3J5LmNwcAogICAgICAgICBw bGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDQXVkaW9Nb2R1bGUuY3BwCi0g ICAgICAgIHBsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92aWRlckds aWIuY3BwCiAKICAgICAgICAgcGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVyL0dTdHJlYW1l ckF1ZGlvQ2FwdHVyZVNvdXJjZS5jcHAKICAgICAgICAgcGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0 cmVhbWVyL0dTdHJlYW1lckF1ZGlvQ2FwdHVyZXIuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9Tb3VyY2VzR0xpYi50eHQgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9T b3VyY2VzR0xpYi50eHQKaW5kZXggM2ExOGFkNGNkYzE0ZjM0OGExODhjNDg5NzViZDFkNTgwODQz NDBkMC4uODQ4MDE5MTMzYjNiZTI5MTVkYTQ0OTA4ZmNhZDEzYmM2YmQ2NTIwYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU291cmNlc0dMaWIudHh0CisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL1NvdXJjZXNHTGliLnR4dApAQCAtMzUsMyArMzUsNSBAQCBwbGF0Zm9y bS9nbGliL1NoYXJlZEJ1ZmZlckdsaWIuY3BwCiBwbGF0Zm9ybS9nbGliL1VzZXJBZ2VudEdMaWIu Y3BwCiAKIHBsYXRmb3JtL25ldHdvcmsvZ2xpYi9OZXR3b3JrU3RhdGVOb3RpZmllckdMaWIuY3Bw CisKK3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92aWRlckdsaWIu Y3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3 ZWJydGMvTGliV2ViUlRDUHJvdmlkZXJHbGliLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92aWRlckdsaWIuY3BwCmluZGV4IGRi ODFkMTQ3YjEyOTRmYWZhMTM4NGI2MTI4NTQxYTVhNTFmZGIyNDUuLjQyNTE0YWYwNGRhZmM2MDMw MDM0NTNhNWU3ZjM5N2FiNjhlNTMyYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92aWRlckdsaWIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQ cm92aWRlckdsaWIuY3BwCkBAIC00MSw3ICs0MSwxMSBAQCBVbmlxdWVSZWY8TGliV2ViUlRDUHJv dmlkZXI+IExpYldlYlJUQ1Byb3ZpZGVyOjpjcmVhdGUoKQogCiBib29sIExpYldlYlJUQ1Byb3Zp ZGVyOjp3ZWJSVENBdmFpbGFibGUoKQogeworI2lmIFVTRShMSUJXRUJSVEMpICYmIFVTRShHU1RS RUFNRVIpCiAgICAgcmV0dXJuIHRydWU7CisjZWxzZQorICAgIHJldHVybiBmYWxzZTsKKyNlbmRp ZgogfQogCiAjaWYgVVNFKExJQldFQlJUQykgJiYgVVNFKEdTVFJFQU1FUikK 349532 2018-09-12 01:25:28 -0700 2018-09-12 02:12:04 -0700 patch bug-189540-20180912102527.patch text/plain 3005 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1OTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTMwOWZkMzRkZTZlNjJl MDY2M2MzODNjMTE1NmYyNjgzNzkwMWIwMy4uMGQ1Zjk0YTIzMjg0ODU1YjNjYjAyM2E4OGM4OThm MDQ0MWRmNWUwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA5LTEyICBQYWJs byBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIExpbmtpbmcgYWdh aW5zdCBsaWJXUEVXZWJLaXQtMC4xLnNvIGlzIG5vdCBwb3NpYmxlIHdoZW4gV1BFIGlzIGJ1aWxk IHdpdGggRU5BQkxFX1ZJREVPPU9GRiBhbmQgRU5BQkxFX1dFQl9BVURJTz1PRkYKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTU0MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbGF0ZWQgaXNzdWVzOgor CisgICAgICAgIFRoaXMgaXNzdWUgaXMgcmVsYXRlZCB3aXRoIGNoYW5nZXMgaW4gaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4MzA4MAorICAgICAgICBUaGlzIGlzc3Vl IGlzIGludHJvZHVjZWQgaW4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4NjU0NworCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gY2hhbmdlcyBpbiB0aGUgZnVuY3Rp b25hbGl0eS4KKworICAgICAgICAqIHBsYXRmb3JtL0dTdHJlYW1lci5jbWFrZToKKyAgICAgICAg KiBwbGF0Zm9ybS9Tb3VyY2VzR0xpYi50eHQ6CisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJl YW0vbGlid2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVyR2xpYi5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpMaWJXZWJSVENQcm92aWRlcjo6d2ViUlRDQXZhaWxhYmxlKToKKwogMjAxOC0wOS0xMSAgWmFu IERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBX UEUgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vR1N0cmVh bWVyLmNtYWtlIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vR1N0cmVhbWVyLmNtYWtlCmluZGV4 IGZmMDU5OWYwMzY0MzRiMGEwZGE3MjBhMmUwMzRjNGZiMjY5Y2NhMjAuLmQ5YTFmZGIzMGM0MjBm MDk4MWJmZWVmNGRjZGY0Yzk2YWZkZGEyNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL0dTdHJlYW1lci5jbWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9HU3Ry ZWFtZXIuY21ha2UKQEAgLTM2LDcgKzM2LDYgQEAgaWYgKEVOQUJMRV9WSURFTyBPUiBFTkFCTEVf V0VCX0FVRElPKQogICAgICAgICBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvR1N0cmVh bWVyVmlkZW9EZWNvZGVyRmFjdG9yeS5jcHAKICAgICAgICAgcGxhdGZvcm0vbWVkaWFzdHJlYW0v bGlid2VicnRjL0dTdHJlYW1lclZpZGVvRW5jb2RlckZhY3RvcnkuY3BwCiAgICAgICAgIHBsYXRm b3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENBdWRpb01vZHVsZS5jcHAKLSAgICAg ICAgcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVyR2xpYi5j cHAKIAogICAgICAgICBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyQXVk aW9DYXB0dXJlU291cmNlLmNwcAogICAgICAgICBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFt ZXIvR1N0cmVhbWVyQXVkaW9DYXB0dXJlci5jcHAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL1NvdXJjZXNHTGliLnR4dCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1NvdXJj ZXNHTGliLnR4dAppbmRleCAzYTE4YWQ0Y2RjMTRmMzQ4YTE4OGM0ODk3NWJkMWQ1ODA4NDM0MGQw Li44NDgwMTkxMzNiM2JlMjkxNWRhNDQ5MDhmY2FkMTNiYzZiZDY1MjBjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Tb3VyY2VzR0xpYi50eHQKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vU291cmNlc0dMaWIudHh0CkBAIC0zNSwzICszNSw1IEBAIHBsYXRmb3JtL2ds aWIvU2hhcmVkQnVmZmVyR2xpYi5jcHAKIHBsYXRmb3JtL2dsaWIvVXNlckFnZW50R0xpYi5jcHAK IAogcGxhdGZvcm0vbmV0d29yay9nbGliL05ldHdvcmtTdGF0ZU5vdGlmaWVyR0xpYi5jcHAKKwor cGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVyR2xpYi5jcHAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0 Yy9MaWJXZWJSVENQcm92aWRlckdsaWIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVk aWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVyR2xpYi5jcHAKaW5kZXggZGI4MWQx NDdiMTI5NGZhZmExMzg0YjYxMjg1NDFhNWE1MWZkYjI0NS4uNDI1MTRhZjA0ZGFmYzYwMzAwMzQ1 M2E1ZTdmMzk3YWI2OGU1MzJiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVyR2xpYi5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Byb3Zp ZGVyR2xpYi5jcHAKQEAgLTQxLDcgKzQxLDExIEBAIFVuaXF1ZVJlZjxMaWJXZWJSVENQcm92aWRl cj4gTGliV2ViUlRDUHJvdmlkZXI6OmNyZWF0ZSgpCiAKIGJvb2wgTGliV2ViUlRDUHJvdmlkZXI6 OndlYlJUQ0F2YWlsYWJsZSgpCiB7CisjaWYgVVNFKExJQldFQlJUQykgJiYgVVNFKEdTVFJFQU1F UikKICAgICByZXR1cm4gdHJ1ZTsKKyNlbHNlCisgICAgcmV0dXJuIGZhbHNlOworI2VuZGlmCiB9 CiAKICNpZiBVU0UoTElCV0VCUlRDKSAmJiBVU0UoR1NUUkVBTUVSKQo=