189535 2018-09-11 18:54:09 -0700 [WHLSL] The standard library should be fully tested 2018-10-13 14:54:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED MOVED P2 Normal --- 176199 1 tdenney tdenney dino mmaxfield oldest_to_newest 1458816 0 tdenney 2018-09-11 18:54:09 -0700 [WHLSL] The standard library should be fully tested 1458817 1 349500 tdenney 2018-09-11 18:54:46 -0700 Created attachment 349500 WIP 1458820 2 tdenney 2018-09-11 19:00:05 -0700 We cannot remove the preparation stage that type checks the standard library in full (which makes running tests *much* faster) without ensuring that every function in the standard library is tested to ensure that each standard library function actually gets type checked. 1462209 3 mmaxfield 2018-09-21 18:16:23 -0700 There are a couple functions that I'm not very confident that their behavior matches HLSL: firstbithigh() firstbitlow() countbits() reversebits() all the texturing functions Also, these functions are implemented in a suboptimal way: log2() log10() exp2() fmod() isordered() Also: fma() and mad() are implemented identically, and I'm not sure if this is right. 1462230 4 tdenney 2018-09-21 18:57:18 -0700 (In reply to Myles C. Maxfield from comment #3) > There are a couple functions that I'm not very confident that their behavior > matches HLSL: > > firstbithigh() > firstbitlow() > countbits() > reversebits() > all the texturing functions > > Also, these functions are implemented in a suboptimal way: > > log2() > log10() > exp2() > fmod() > isordered() > > Also: fma() and mad() are implemented identically, and I'm not sure if this > is right. Likewise I’m pretty sure that isnormal isn’t implement correctly (it currently returns isNaN). 1468812 5 mmaxfield 2018-10-13 14:30:56 -0700 Migrated to https://api.github.com/repos/gpuweb/WHLSL/issues/36 1468858 6 mmaxfield 2018-10-13 14:54:37 -0700 https://github.com/gpuweb/WHLSL/issues/36 349500 2018-09-11 18:54:46 -0700 2018-09-11 18:54:46 -0700 WIP bug-189535-20180911185446.patch text/plain 1406 tdenney U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1OTI1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzY4NGE1ZTcyMzVlMmE3Njc1NjcyYjY4NTUwZDA0OGI3 NTk4ZjMyZi4uMjZiNTg5NTNjMjIwM2MyY2NiZTk1ZTZiNTg1MGExOWM2YzRkMjYyMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTA5LTExICBUaG9tYXMgRGVubmV5ICA8dGRlbm5leUBhcHBsZS5jb20+CisKKyAg ICAgICAgW1dITFNMXSBUaGUgc3RhbmRhcmQgbGlicmFyeSBzaG91bGQgYmUgZnVsbHkgdGVzdGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODk1MzUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkdQ VVNoYWRpbmdMYW5ndWFnZVJJL1Rlc3QuanM6IERlbGV0ZWQgdGhlIGluaXRpYWwgdHlwZSBjaGVj ayBvZiB0aGUKKyAgICAgICAgc3RhbmRhcmQgbGlicmFyeTsgdGhpcyBub3cgaGFwcGVucyBsYXpp bHkuCisKIDIwMTgtMDktMDcgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAg ICAgIEFkZCBhbmQgZXhwb3NlIEludGVybmFsIGZlYXR1cmVzIGZyb20gV2ViS2l0CmRpZmYgLS1n aXQgYS9Ub29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9UZXN0LmpzIGIvVG9vbHMvV2ViR1BV U2hhZGluZ0xhbmd1YWdlUkkvVGVzdC5qcwppbmRleCAyYmNlYTdkN2RhM2NiMzgyZjFhYWJlMjE2 N2VmM2E3ODkxMzkyMzMzLi4yYjM5YTkyOTU4OGFlNjcyMTE0ZGZmYzdjM2E1MWYwYTVmNmZiMmVk IDEwMDY0NAotLS0gYS9Ub29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9UZXN0LmpzCisrKyBi L1Rvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Rlc3QuanMKQEAgLTc5NDYsMTMgKzc5NDYs NiBAQCBmdW5jdGlvbiogZG9UZXN0KHRlc3RGaWx0ZXIpCiAgICAgICAgIHRocm93IG5ldyBFcnJv cigiVGVzdCBzZXR1cCBpcyBpbmNvbXBsZXRlLiIpOwogICAgIGxldCBiZWZvcmUgPSBwcmVjaXNl VGltZSgpOwogCi0gICAgcHJpbnQoIkNvbXBpbGluZyBzdGFuZGFyZCBsaWJyYXJ5Li4uIik7Ci0g ICAgY29uc3QgY29tcGlsZUJlZm9yZSA9IHByZWNpc2VUaW1lKCk7Ci0gICAgeWllbGQ7Ci0gICAg cHJlcGFyZSgpOwotICAgIGNvbnN0IGNvbXBpbGVBZnRlciA9IHByZWNpc2VUaW1lKCk7Ci0gICAg cHJpbnQoYCAgICBPSywgdG9vayAke01hdGgucm91bmQoKGNvbXBpbGVBZnRlciAtIGNvbXBpbGVC ZWZvcmUpICogMTAwMCl9IG1zYCk7Ci0KICAgICBsZXQgbmFtZXMgPSBbXTsKICAgICBmb3IgKGxl dCBzIGluIHRlc3RzKQogICAgICAgICBuYW1lcy5wdXNoKHMpOwo=