18951 2008-05-08 14:04:40 -0700 all DOM operations stop working when location.hash set to '#' 2008-07-07 13:36:38 -0700 1 1 1 Unclassified WebKit New Bugs 525.x (Safari 3.1) PC OS X 10.5 RESOLVED FIXED http://www.nick-santos.com/tests/safari_hash_test.html InRadar P2 Normal --- 1 nicksantos webkit-unassigned brettw ian.eng.webkit mrowe oldest_to_newest 79923 0 nicksantos 2008-05-08 14:04:40 -0700 The following javascript code: window.location.hash = '#b=BBB'; var node = document.createElement('span'); node.innerHTML = 'Safari '; document.body.appendChild(node); window.location.hash = '#'; var node2 = document.createElement('span'); node2.innerHTML = 'can\'t take the heat!'; document.body.appendChild(node2); makes all subsequent DOM operations fail. Weird. 79925 1 mrowe 2008-05-08 14:06:18 -0700 <rdar://problem/5921760> 79931 2 ian.eng.webkit 2008-05-08 15:02:34 -0700 KURL::setRef drops "#" if the hash string is empty, but FF appends '#' to the end of URL. Is it safe to just append "#" to new url even when the hash string is empty? 79934 3 ian.eng.webkit 2008-05-08 15:36:33 -0700 I tried this patch on my local build, and it fixes the issue described by Nick. Does this change has side-effect? and why '#' makes difference? Index: KURL.cpp =================================================================== --- KURL.cpp (revision 32987) +++ KURL.cpp (working copy) @@ -705,7 +705,7 @@ void KURL::setRef(const String& s) { if (!m_isValid) return; - parse(m_string.left(m_queryEnd) + (s.isEmpty() ? "" : "#" + s)); + parse(m_string.left(m_queryEnd) + "#" + s); } 79993 4 brettw 2008-05-09 11:36:01 -0700 You could change the setter to clear the # when you pass a NULL string, but make the ref empty (leaving the #) when you pass an empty string. I think this pattern would be good to use for the other setters as well (at least, the query) so that "foo?" and "foo" can be differentiated in the setter. 80001 5 ian.eng.webkit 2008-05-09 13:12:22 -0700 (In reply to comment #4) > You could change the setter to clear the # when you pass a NULL string, but > make the ref empty (leaving the #) when you pass an empty string. I think this > pattern would be good to use for the other setters as well (at least, the > query) so that "foo?" and "foo" can be differentiated in the setter. > That's good point. What's the difference between a URL with '#' and empty hash, and the same URL without '#' and hash? It seems changed loader behavior. 85374 6 beidson 2008-07-07 12:28:57 -0700 Working on this right now - seems that a tweak inside KURL will be the solution. 85384 7 beidson 2008-07-07 13:36:38 -0700 Fixed in http://trac.webkit.org/changeset/35040