189506 2018-09-11 10:48:24 -0700 Add missing #if ENABLE(VIDEO) WebProcess/FullScreen/WebFullScreenManager.cpp 2018-09-11 11:43:05 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psaavedra webkit-unassigned achristensen commit-queue dino graouts simon.fraser thorton webkit-bug-importer oldest_to_newest 1458514 0 psaavedra 2018-09-11 10:48:24 -0700 the use of `m_pipStandbyElement` must be guarded with ENABLE(VIDEO), otherwise a compilation error occurs with the VIDEO feature turned off m_pipStandbyElement is only defined in Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.h when ENABLE(VIDEO): ``` #if ENABLE(VIDEO) RefPtr<WebCore::HTMLVideoElement> m_pipStandbyElement; #endif ``` 1458521 1 349412 psaavedra 2018-09-11 10:59:31 -0700 Created attachment 349412 patch 1458523 2 349412 thorton 2018-09-11 11:00:29 -0700 Comment on attachment 349412 patch View in context: https://bugs.webkit.org/attachment.cgi?id=349412&action=review > Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:102 > +#if ENABLE(VIDEO) !ENABLE(VIDEO) knows what HTMLVideoElement is, though?? 1458524 3 psaavedra 2018-09-11 11:03:25 -0700 Related with https://bugs.webkit.org/show_bug.cgi?id=181338 1458550 4 349412 commit-queue 2018-09-11 11:38:36 -0700 Comment on attachment 349412 patch Clearing flags on attachment: 349412 Committed r235906: <https://trac.webkit.org/changeset/235906> 1458551 5 commit-queue 2018-09-11 11:38:37 -0700 All reviewed patches have been landed. Closing bug. 1458552 6 webkit-bug-importer 2018-09-11 11:39:22 -0700 <rdar://problem/44350074> 1458556 7 psaavedra 2018-09-11 11:43:05 -0700 (In reply to Tim Horton from comment #2) > Comment on attachment 349412 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=349412&action=review > > > Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:102 > > +#if ENABLE(VIDEO) > > !ENABLE(VIDEO) knows what HTMLVideoElement is, though?? (In reply to Tim Horton from comment #2) > Comment on attachment 349412 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=349412&action=review > > > Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:102 > > +#if ENABLE(VIDEO) > > !ENABLE(VIDEO) knows what HTMLVideoElement is, though?? WebCore/html/HTMLVideoElement.h Yes, it seems HTMLVideoElement is declared in the Webcore namespace in the top `WebKit/WebProcess/FullScreen/WebFullScreenManager.h` namespace WebCore { class IntRect; class Element; class GraphicsLayer; class HTMLVideoElement; } Since HTMLVideoElement is not actually used in a statement but in a declaration in the signature of the function is the reason why is valid. 349412 2018-09-11 10:59:31 -0700 2018-09-11 11:38:36 -0700 patch bug-189506-20180911195929.patch text/plain 1868 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1ODk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVmNGQzZTRiMGQ4YjIyMDgx MTIzZWQ4Nzg0NzE1YzFiZjRmNzRiOWYuLjBlZTQxNmJjNGNkZjA3MDVmODc0ZWQwN2QwM2YyNjkw NjhhMzVjMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMDktMTEgIFBhYmxvIFNh YXZlZHJhICA8cHNhYXZlZHJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgQWRkIG1pc3NpbmcgI2lm IEVOQUJMRShWSURFTykgV2ViUHJvY2Vzcy9GdWxsU2NyZWVuL1dlYkZ1bGxTY3JlZW5NYW5hZ2Vy LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5 NTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbV9w aXBTdGFuZGJ5RWxlbWVudCBpcyBvbmx5IGRlZmluZWQgaW4KKyAgICAgICAgV2ViS2l0L1dlYlBy b2Nlc3MvRnVsbFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFuYWdlci5oCisgICAgICAgIG9ubHkgd2hl biBFTkFCTEUoVklERU8pIChzZWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4MTMzOCkKKworICAgICAgICAqIFdlYlByb2Nlc3MvRnVsbFNjcmVlbi9X ZWJGdWxsU2NyZWVuTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZ1bGxTY3JlZW5N YW5hZ2VyOjpzZXRQSVBTdGFuZGJ5RWxlbWVudCk6CisKIDIwMTgtMDktMTEgIFdvb2Ryb3cgV2Fu ZyAgPHdvb2Ryb3dfd2FuZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIFdlYiBBUEkgU3RhdGlz dGljcyBDb2xsZWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvRnVs bFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvRnVsbFNjcmVlbi9XZWJGdWxsU2NyZWVuTWFuYWdlci5jcHAKaW5kZXggMTMzYTZjMjBkMWFj YzMxZGE0M2E4M2EyNTIxNGM4NjY3YThlZTMyMi4uNGNhZGMwNTNkYzFhYmQ1ZDRlMzFmZjBhZGI4 ODk1ZTIwZTBjNWVmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0Z1bGxT Y3JlZW4vV2ViRnVsbFNjcmVlbk1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9GdWxsU2NyZWVuL1dlYkZ1bGxTY3JlZW5NYW5hZ2VyLmNwcApAQCAtOTksNiArOTksNyBA QCB2b2lkIFdlYkZ1bGxTY3JlZW5NYW5hZ2VyOjp2aWRlb0NvbnRyb2xzTWFuYWdlckRpZENoYW5n ZSgpCiAKIHZvaWQgV2ViRnVsbFNjcmVlbk1hbmFnZXI6OnNldFBJUFN0YW5kYnlFbGVtZW50KFdl YkNvcmU6OkhUTUxWaWRlb0VsZW1lbnQqIHBpcFN0YW5kYnlFbGVtZW50KQogeworI2lmIEVOQUJM RShWSURFTykKICAgICBpZiAocGlwU3RhbmRieUVsZW1lbnQgPT0gbV9waXBTdGFuZGJ5RWxlbWVu dCkKICAgICAgICAgcmV0dXJuOwogCkBAIC0xMDksNiArMTEwLDcgQEAgdm9pZCBXZWJGdWxsU2Ny ZWVuTWFuYWdlcjo6c2V0UElQU3RhbmRieUVsZW1lbnQoV2ViQ29yZTo6SFRNTFZpZGVvRWxlbWVu dCogcGlwU3QKIAogICAgIGlmIChtX3BpcFN0YW5kYnlFbGVtZW50KQogICAgICAgICBtX3BpcFN0 YW5kYnlFbGVtZW50LT5zZXRWaWRlb0Z1bGxzY3JlZW5TdGFuZGJ5KHRydWUpOworI2VuZGlmCiB9 CiAKIHZvaWQgV2ViRnVsbFNjcmVlbk1hbmFnZXI6OmRpZFJlY2VpdmVNZXNzYWdlKElQQzo6Q29u bmVjdGlvbiYgY29ubmVjdGlvbiwgSVBDOjpEZWNvZGVyJiBkZWNvZGVyKQo=