189505 2018-09-11 09:48:04 -0700 [WPE][GTK] API documentation is unclear about how to modify requests before sending them 2018-09-13 09:50:47 -0700 1 1 1 Unclassified WebKit WebKit API Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez achristensen beidson berto cgarcia commit-queue darin ews-watchlist gustavo mcatanzaro webkit-bug-importer oldest_to_newest 1458489 0 aperez 2018-09-11 09:48:04 -0700 There are two places where a WebKitURIRequest can be inspected before it is sent over the network, and it is not clear in the documentation in which case the modifications apply to it will be reflected in the actual data sent over the network: - Signal handlers for WebKitWebView::decide-policy Modifications *ARE NOT* sent over the network. - Signal handlers for WebKitPage::send-request (in a Web extension) Modifications *ARE* sent over the network. It would be useful if the API documentation was explicit about this. 1458491 1 349403 aperez 2018-09-11 09:52:47 -0700 Created attachment 349403 Patch 1458492 2 ews-watchlist 2018-09-11 09:55:01 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1458497 3 349403 mcatanzaro 2018-09-11 10:10:50 -0700 Comment on attachment 349403 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349403&action=review I've been confused by this before too. Thanks. > Source/WebKit/UIProcess/API/glib/WebKitNavigationAction.cpp:128 > + * Modifications to the returned object are <emphasis>not</emphasis> taken Hm, gtk-doc removed support for XML a long time ago. Are you sure this is actually going to work? I suspect the output will literally say <emphasis>not</emphasis>. Do you have some recent HTML example of this working? I think it's supposed to be markdown instead? 1458515 4 aperez 2018-09-11 10:48:37 -0700 (In reply to Michael Catanzaro from comment #3) > Comment on attachment 349403 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=349403&action=review > > I've been confused by this before too. Thanks. > > > Source/WebKit/UIProcess/API/glib/WebKitNavigationAction.cpp:128 > > + * Modifications to the returned object are <emphasis>not</emphasis> taken > > Hm, gtk-doc removed support for XML a long time ago. Are you sure this is > actually going to work? I suspect the output will literally say > <emphasis>not</emphasis>. Do you have some recent HTML example of this > working? Carlos García figured out that <emphasis> works in his patch for bug #188742 > I think it's supposed to be markdown instead? Apparently DocBook is still being used, but in versions ≥1.20 it is also possible to use Markdown intermixed with DocBook. Or at least that's what I understand from reading here: https://developer.gnome.org/gtk-doc-manual/stable/documenting_syntax.html.en “While markdown is now preferred one can mix both. One limitation here is that one can use docbook xml within markdown, but markdown within docbook xml is not supported.” ¯\_(ツ)_/¯ 1458573 5 349403 commit-queue 2018-09-11 12:26:56 -0700 Comment on attachment 349403 Patch Clearing flags on attachment: 349403 Committed r235909: <https://trac.webkit.org/changeset/235909> 1458574 6 commit-queue 2018-09-11 12:26:57 -0700 All reviewed patches have been landed. Closing bug. 1458575 7 webkit-bug-importer 2018-09-11 12:27:38 -0700 <rdar://problem/44352135> 1458889 8 349403 cgarcia 2018-09-12 00:05:18 -0700 Comment on attachment 349403 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349403&action=review > Source/WebKit/UIProcess/API/glib/WebKitNavigationAction.cpp:130 > + * into account when the request is sent over the network, and is intended > + * only to aid in evaluating whether a navigation action should be taken or This is not accurate either. NavigationAction is used in policy decisions, but also in create signal. It's not intended to decide whether the action should be taken or not, it's just information, the intentation of that information depends on the caller rather tahn the action object itself. I would add this comment to decide-policy signal, to clarify that you can ignore/download/use, but request can't be modified at that point. > Source/WebKit/UIProcess/API/glib/WebKitResponsePolicyDecision.cpp:121 > + * Return the #WebKitURIRequest associated with the response decision. > + * Modifications to the returned object are <emphasis>not</emphasis> taken > + * into account when the request is sent over the network, and is intended > + * only to aid in evaluating whether a response decision should be taken or > + * not. To modify requests before they are sent over the network the It makes more sense here in this context, but maybe we can add a single comment in the signal description, you are suggesting to use a different signal in the end. 1459390 9 aperez 2018-09-13 09:50:47 -0700 (In reply to Carlos Garcia Campos from comment #8) > Comment on attachment 349403 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=349403&action=review > > > Source/WebKit/UIProcess/API/glib/WebKitNavigationAction.cpp:130 > > + * into account when the request is sent over the network, and is intended > > + * only to aid in evaluating whether a navigation action should be taken or > > This is not accurate either. NavigationAction is used in policy decisions, > but also in create signal. It's not intended to decide whether the action > should be taken or not, it's just information, the intentation of that > information depends on the caller rather tahn the action object itself. I > would add this comment to decide-policy signal, to clarify that you can > ignore/download/use, but request can't be modified at that point. > > > Source/WebKit/UIProcess/API/glib/WebKitResponsePolicyDecision.cpp:121 > > + * Return the #WebKitURIRequest associated with the response decision. > > + * Modifications to the returned object are <emphasis>not</emphasis> taken > > + * into account when the request is sent over the network, and is intended > > + * only to aid in evaluating whether a response decision should be taken or > > + * not. To modify requests before they are sent over the network the > > It makes more sense here in this context, but maybe we can add a single > comment in the signal description, you are suggesting to use a different > signal in the end. Thanks for the feedback, I'll make a follow-up patch soon to further improve the documentation taking it into account :-) 349403 2018-09-11 09:52:47 -0700 2018-09-11 12:26:56 -0700 Patch bug-189505-20180911195245.patch text/plain 6081 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1ODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU2MGFiZWU0MTg5ZjE0NDJh ZmM1MmM1OTgwOTkzMDVhMjAxNzVlZDEuLjcyZGMxYTJlNGE4OWYyZWJkZDAzMmY0ZDNmYTE3MWUx NTBjZDczYmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xICsxLDIzIEBACisyMDE4LTA5LTExICBBZHJpYW4gUGVy ZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV1bR1RLXSBB UEkgZG9jdW1lbnRhdGlvbiBpcyB1bmNsZWFyIGFib3V0IGhvdyB0byBtb2RpZnkgcmVxdWVzdHMg YmVmb3JlIHNlbmRpbmcgdGhlbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTg5NTA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIG5vdGVzIHRvIHRoZSBBUEkgZG9jdW1lbnRhdGlvbiB0byBtYWtlIGV4 cGxpY2l0IHdoZXJlIG1vZGlmaWNhdGlvbgorICAgICAgICBvZiBXZWJLaXRVUklSZXF1ZXN0IGlu c3RhbmNlcyBhZmZlY3RzIHRoZSByZXF1ZXN0IGRhdGEgc2VudCBvdmVyIHRoZQorICAgICAgICBu ZXR3b3JrLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdE5hdmlnYXRpb25B Y3Rpb24uY3BwOiBDbGFyaWZ5IHRoYXQKKyAgICAgICAgbW9kaWZpY2F0aW9ucyB0byB0aGUgYXNz b2NpYXRlZCBXZWJLaXRVUklSZXF1ZXN0IGRvIG5vdCBhZmZlY3QgdGhlCisgICAgICAgIGFjdHVh bCByZXF1ZXN0LiBQb2ludCB0byBXZWJLaXRQYWdlOjpzZW5kLXJlcXVlc3QgaW5zdGVhZC4KKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0UmVzcG9uc2VQb2xpY3lEZWNpc2lvbi5j cHA6IERpdHRvLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJWaWV3LmNw cDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KTogRGl0dG8gZm9yIHRoZSBk ZXNjcmlwdGlvbiBvZiB0aGUKKyAgICAgICAgV2ViS2l0V2ViVmlldzo6ZGVjaWRlLXBvbGljeSBz aWduYWwuIEFsc28gZml4IHRoZSBzeW50YXggb2YgZXhhbXBsZS4KKyAgICAgICAgKiBXZWJQcm9j ZXNzL0luamVjdGVkQnVuZGxlL0FQSS9nbGliL1dlYktpdFdlYlBhZ2UuY3BwOgorICAgICAgICAo d2Via2l0X3dlYl9wYWdlX2NsYXNzX2luaXQpOiBJbmRpY2F0ZSB0aGF0IG1vZGlmaWNhdGlvbnMg dG8gdGhlCisgICAgICAgIFdlYktpdFVSSVJlcXVlc3Qgd2lsbCBjaGFuZ2UgdGhlIGFjdHVhbCBu ZXR3b3JrIHJlcXVlc3QgZGF0YS4KKwogPT0gUm9sbGVkIG92ZXIgdG8gQ2hhbmdlTG9nLTIwMTgt MDktMTEgPT0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dl YktpdE5hdmlnYXRpb25BY3Rpb24uY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2ds aWIvV2ViS2l0TmF2aWdhdGlvbkFjdGlvbi5jcHAKaW5kZXggYThkYjkzOWJiODE1ODEwOWUxZDUz YzJmMjQ5MjYxYmViMTI1YzliOC4uYzlkOWFkYTBmZWUyOGFjZTVjM2QxMDRjYjkwZGJkOGIxYmVk ZDEzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0 TmF2aWdhdGlvbkFjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2ds aWIvV2ViS2l0TmF2aWdhdGlvbkFjdGlvbi5jcHAKQEAgLTEyNCw3ICsxMjQsMTIgQEAgdW5zaWdu ZWQgd2Via2l0X25hdmlnYXRpb25fYWN0aW9uX2dldF9tb2RpZmllcnMoV2ViS2l0TmF2aWdhdGlv bkFjdGlvbiogbmF2aWdhdGkKICAqIHdlYmtpdF9uYXZpZ2F0aW9uX2FjdGlvbl9nZXRfcmVxdWVz dDoKICAqIEBuYXZpZ2F0aW9uOiBhICNXZWJLaXROYXZpZ2F0aW9uQWN0aW9uCiAgKgotICogUmV0 dXJuIHRoZSBuYXZpZ2F0aW9uICNXZWJLaXRVUklSZXF1ZXN0CisgKiBSZXR1cm4gdGhlICNXZWJL aXRVUklSZXF1ZXN0IGFzc29jaWF0ZWQgd2l0aCB0aGUgbmF2aWdhdGlvbiBhY3Rpb24uCisgKiBN b2RpZmljYXRpb25zIHRvIHRoZSByZXR1cm5lZCBvYmplY3QgYXJlIDxlbXBoYXNpcz5ub3Q8L2Vt cGhhc2lzPiB0YWtlbgorICogaW50byBhY2NvdW50IHdoZW4gdGhlIHJlcXVlc3QgaXMgc2VudCBv dmVyIHRoZSBuZXR3b3JrLCBhbmQgaXMgaW50ZW5kZWQKKyAqIG9ubHkgdG8gYWlkIGluIGV2YWx1 YXRpbmcgd2hldGhlciBhIG5hdmlnYXRpb24gYWN0aW9uIHNob3VsZCBiZSB0YWtlbiBvcgorICog bm90LiBUbyBtb2RpZnkgcmVxdWVzdHMgYmVmb3JlIHRoZXkgYXJlIHNlbnQgb3ZlciB0aGUgbmV0 d29yayB0aGUKKyAqICNXZWJLaXRQYWdlOjpzZW5kLXJlcXVlc3Qgc2lnbmFsIGNhbiBiZSB1c2Vk IGluc3RlYWQuCiAgKgogICogUmV0dXJuczogKHRyYW5zZmVyIG5vbmUpOiBhICNXZWJLaXRVUklS ZXF1ZXN0CiAgKgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIv V2ViS2l0UmVzcG9uc2VQb2xpY3lEZWNpc2lvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvZ2xpYi9XZWJLaXRSZXNwb25zZVBvbGljeURlY2lzaW9uLmNwcAppbmRleCBlZTg2OWQw ZDg5OGQ2MGFlNmU0OGY1MjZkNDMyMjMwZTdhZGM4MjdkLi5iZjQwMDFiNDA3YjZkMjc1NmRlOWRl Yzc0NDQ5ZTBlM2M5ODRlYjY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvZ2xpYi9XZWJLaXRSZXNwb25zZVBvbGljeURlY2lzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRSZXNwb25zZVBvbGljeURlY2lzaW9uLmNwcApA QCAtMTE0LDcgKzExNCwxMiBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfcmVzcG9uc2VfcG9saWN5X2Rl Y2lzaW9uX2NsYXNzX2luaXQoV2ViS2l0UmVzcG9uc2VQb2xpY3lEZWNpcwogICogd2Via2l0X3Jl c3BvbnNlX3BvbGljeV9kZWNpc2lvbl9nZXRfcmVxdWVzdDoKICAqIEBkZWNpc2lvbjogYSAjV2Vi S2l0UmVzcG9uc2VQb2xpY3lEZWNpc2lvbgogICoKLSAqIEdldHMgdGhlIHZhbHVlIG9mIHRoZSAj V2ViS2l0UmVzcG9uc2VQb2xpY3lEZWNpc2lvbjpyZXF1ZXN0IHByb3BlcnR5LgorICogUmV0dXJu IHRoZSAjV2ViS2l0VVJJUmVxdWVzdCBhc3NvY2lhdGVkIHdpdGggdGhlIHJlc3BvbnNlIGRlY2lz aW9uLgorICogTW9kaWZpY2F0aW9ucyB0byB0aGUgcmV0dXJuZWQgb2JqZWN0IGFyZSA8ZW1waGFz aXM+bm90PC9lbXBoYXNpcz4gdGFrZW4KKyAqIGludG8gYWNjb3VudCB3aGVuIHRoZSByZXF1ZXN0 IGlzIHNlbnQgb3ZlciB0aGUgbmV0d29yaywgYW5kIGlzIGludGVuZGVkCisgKiBvbmx5IHRvIGFp ZCBpbiBldmFsdWF0aW5nIHdoZXRoZXIgYSByZXNwb25zZSBkZWNpc2lvbiBzaG91bGQgYmUgdGFr ZW4gb3IKKyAqIG5vdC4gVG8gbW9kaWZ5IHJlcXVlc3RzIGJlZm9yZSB0aGV5IGFyZSBzZW50IG92 ZXIgdGhlIG5ldHdvcmsgdGhlCisgKiAjV2ViS2l0UGFnZTo6c2VuZC1yZXF1ZXN0IHNpZ25hbCBj YW4gYmUgdXNlZCBpbnN0ZWFkLgogICoKICAqIFJldHVybnM6ICh0cmFuc2ZlciBub25lKTogVGhl IFVSSSByZXF1ZXN0IHRoYXQgaXMgYXNzb2NpYXRlZCB3aXRoIHRoaXMgcG9saWN5IGRlY2lzaW9u LgogICovCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJL aXRXZWJWaWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdl YlZpZXcuY3BwCmluZGV4IGU2ODczMTE1MjVmMjQxNGUwNGI1ODA1NzVhMDdkM2QzZGVhMzUzYWEu LjVhYzQ2Y2NlZWQ4OTUyOTc1YzkyMjFhN2JkNTgyYjE5MDNlNzQ1ZmQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYlZpZXcuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFdlYlZpZXcuY3BwCkBAIC0xMzg3 LDE0ICsxMzg3LDE2IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdl YktpdFdlYlZpZXdDbGFzcyogd2ViVmlld0NsYXNzKQogICAgICAqICAgICAgICAgICAgICAgICAg IFdlYktpdFBvbGljeURlY2lzaW9uVHlwZSB0eXBlKQogICAgICAqIHsKICAgICAgKiAgICAgc3dp dGNoICh0eXBlKSB7Ci0gICAgICogICAgIGNhc2UgV0VCS0lUX1BPTElDWV9ERUNJU0lPTl9UWVBF X05BVklHQVRJT05fQUNUSU9OOgorICAgICAqICAgICBjYXNlIFdFQktJVF9QT0xJQ1lfREVDSVNJ T05fVFlQRV9OQVZJR0FUSU9OX0FDVElPTjogewogICAgICAqICAgICAgICAgV2ViS2l0TmF2aWdh dGlvblBvbGljeURlY2lzaW9uICpuYXZpZ2F0aW9uX2RlY2lzaW9uID0gV0VCS0lUX05BVklHQVRJ T05fUE9MSUNZX0RFQ0lTSU9OIChkZWNpc2lvbik7CiAgICAgICogICAgICAgICAvPCEtLSAtLT4q IE1ha2UgYSBwb2xpY3kgZGVjaXNpb24gaGVyZS4gKjwhLS0gLS0+LwogICAgICAqICAgICAgICAg YnJlYWs7Ci0gICAgICogICAgIGNhc2UgV0VCS0lUX1BPTElDWV9ERUNJU0lPTl9UWVBFX05FV19X SU5ET1dfQUNUSU9OOgorICAgICAqICAgICB9CisgICAgICogICAgIGNhc2UgV0VCS0lUX1BPTElD WV9ERUNJU0lPTl9UWVBFX05FV19XSU5ET1dfQUNUSU9OOiB7CiAgICAgICogICAgICAgICBXZWJL aXROYXZpZ2F0aW9uUG9saWN5RGVjaXNpb24gKm5hdmlnYXRpb25fZGVjaXNpb24gPSBXRUJLSVRf TkFWSUdBVElPTl9QT0xJQ1lfREVDSVNJT04gKGRlY2lzaW9uKTsKICAgICAgKiAgICAgICAgIC88 IS0tIC0tPiogTWFrZSBhIHBvbGljeSBkZWNpc2lvbiBoZXJlLiAqPCEtLSAtLT4vCiAgICAgICog ICAgICAgICBicmVhazsKKyAgICAgKiAgICAgfQogICAgICAqICAgICBjYXNlIFdFQktJVF9QT0xJ Q1lfREVDSVNJT05fVFlQRV9SRVNQT05TRToKICAgICAgKiAgICAgICAgIFdlYktpdFJlc3BvbnNl UG9saWN5RGVjaXNpb24gKnJlc3BvbnNlID0gV0VCS0lUX1JFU1BPTlNFX1BPTElDWV9ERUNJU0lP TiAoZGVjaXNpb24pOwogICAgICAqICAgICAgICAgLzwhLS0gLS0+KiBNYWtlIGEgcG9saWN5IGRl Y2lzaW9uIGhlcmUuICo8IS0tIC0tPi8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ2xpYi9XZWJLaXRXZWJQYWdlLmNwcCBiL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ2xpYi9XZWJLaXRXZWJQYWdlLmNw cAppbmRleCA2NjdjZDgxYWZmNzZkZjgwMzQ1MTg3NTdiMWEyYjE4MTlmMTYwYThiLi40N2YwZjA0 Y2U3ZjkwNWQyYjUyMjE3MTU2ZTVjODQ4MWFlM2NhNmEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2dsaWIvV2ViS2l0V2ViUGFnZS5jcHAK KysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9nbGliL1dl YktpdFdlYlBhZ2UuY3BwCkBAIC00NzksNiArNDc5LDEwIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93 ZWJfcGFnZV9jbGFzc19pbml0KFdlYktpdFdlYlBhZ2VDbGFzcyoga2xhc3MpCiAgICAgICogQHJl ZGlyZWN0ZWRfcmVzcG9uc2UgcGFyYW1ldGVyIGNvbnRhaW5pbmcgdGhlIHJlc3BvbnNlCiAgICAg ICogcmVjZWl2ZWQgYnkgdGhlIHNlcnZlciBmb3IgdGhlIGluaXRpYWwgcmVxdWVzdC4KICAgICAg KgorICAgICAqIE1vZGlmaWNhdGlvbnMgdG8gdGhlICNXZWJLaXRVUklSZXF1ZXN0IGFuZCBpdHMg YXNzb2NpYXRlZAorICAgICAqICNTb3VwTWVzc2FnZUhlYWRlcnMgd2lsbCBiZSB0YWtlbiBpbnRv IGFjY291bnQgd2hlbiB0aGUgcmVxdWVzdAorICAgICAqIGlzIHNlbnQgb3ZlciB0aGUgbmV0d29y ay4KKyAgICAgKgogICAgICAqIFJldHVybnM6ICVUUlVFIHRvIHN0b3Agb3RoZXIgaGFuZGxlcnMg ZnJvbSBiZWluZyBpbnZva2VkIGZvciB0aGUgZXZlbnQuCiAgICAgICogICAgJUZBTFNFIHRvIGNv bnRpbnVlIGVtaXNzaW9uIG9mIHRoZSBldmVudC4KICAgICAgKi8K