189500 2018-09-11 08:13:54 -0700 Add missing #if ENABLE(VIDEO) Page.cpp and Page.h 2018-09-11 09:18:06 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psaavedra webkit-unassigned andersca ap cdumez commit-queue jiewen_tan webkit-bug-importer youennf oldest_to_newest 1458461 0 psaavedra 2018-09-11 08:13:54 -0700 playbackControlsManagerUpdateTimerFired and m_playbackControlsManagerUpdateTimer must be guarded with ENABLE(VIDEO), otherwise the following error occurs with the VIDEO feature turned off error: 'MediaElementSession' has not been declared in L1520 Source/WebCore/page/Page.cpp 1458462 1 349395 psaavedra 2018-09-11 08:20:19 -0700 Created attachment 349395 patch 1458472 2 349395 commit-queue 2018-09-11 09:07:52 -0700 Comment on attachment 349395 patch Clearing flags on attachment: 349395 Committed r235895: <https://trac.webkit.org/changeset/235895> 1458473 3 commit-queue 2018-09-11 09:07:54 -0700 All reviewed patches have been landed. Closing bug. 1458474 4 webkit-bug-importer 2018-09-11 09:08:23 -0700 <rdar://problem/44344299> 1458478 5 349395 youennf 2018-09-11 09:18:06 -0700 Comment on attachment 349395 patch View in context: https://bugs.webkit.org/attachment.cgi?id=349395&action=review > Source/WebCore/ChangeLog:8 > + error: 'MediaElementSession' has not been declared These explanations should be between "Reviewed by NOBODY (OOPS!)." and the filename list. > Source/WebCore/page/Page.cpp:1525 > void Page::playbackControlsManagerUpdateTimerFired() Would it be ok to just #if ENABLE(VIDEO) inside Page::playbackControlsManagerUpdateTimerFired? It might remove the need for the other #if/#endif 349395 2018-09-11 08:20:19 -0700 2018-09-11 09:07:52 -0700 patch bug-189500-20180911172017.patch text/plain 3543 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1ODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTNjZjI5MmFlYjgwOGNj ZTEwMWU2MWRhNDk1MjAwNTczYzczY2UzZi4uYTc5Y2ZmMDU2MGFhMTRhZjc1ODJjY2I2NjMyOTBj NDgyYTQ1YmYzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA5LTExICBQYWJs byBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIHBsYXliYWNrQ29u dHJvbHNNYW5hZ2VyVXBkYXRlVGltZXJGaXJlZCBhbmQKKyAgICAgICAgbV9wbGF5YmFja0NvbnRy b2xzTWFuYWdlclVwZGF0ZVRpbWVyIG11c3QgYmUKKyAgICAgICAgZ3VhcmRlZCB3aXRoIEVOQUJM RShWSURFTyksIG90aGVyd2lzZSB0aGUgZm9sbG93aW5nCisgICAgICAgIGVycm9yIG9jY3VycyB3 aXRoIHRoZSBWSURFTyBmZWF0dXJlIHR1cm5lZCBvZmY6CisKKyAgICAgICAgICBlcnJvcjogJ01l ZGlhRWxlbWVudFNlc3Npb24nIGhhcyBub3QgYmVlbiBkZWNsYXJlZAorCisgICAgICAgIEFkZCBt aXNzaW5nICNpZiBFTkFCTEUoVklERU8pIFBhZ2UuY3BwIGFuZCBQYWdlLmgKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTUwMAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlBhZ2U6OlBhZ2UpOgorICAgICAgICAoV2ViQ29yZTo6UGFnZTo6c2No ZWR1bGVQbGF5YmFja0NvbnRyb2xzTWFuYWdlclVwZGF0ZSk6CisgICAgICAgICogcGFnZS9QYWdl Lmg6CisKIDIwMTgtMDktMTEgIEZyZWRlcmljIFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgogCiAg ICAgICAgIFJlZmFjdG9yIGZpbHRlciBsaXN0IGNoZWNraW5nIGNvZGUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3Bw CmluZGV4IGYzYWMzNDU4ZWZjNTA1ZWMwMmZmMTc0OTI3ZTJjOTc1YjgzNWY5ZmIuLjRhYjQwYTc0 OGNlMjEyZjhlZjk5ZTk3OTYxNTFkM2RhNmYxY2IyNTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcApAQCAt MjQzLDcgKzI0Myw5IEBAIFBhZ2U6OlBhZ2UoUGFnZUNvbmZpZ3VyYXRpb24mJiBwYWdlQ29uZmln dXJhdGlvbikKICAgICAsIG1fdXNlckNvbnRlbnRQcm92aWRlcigqV1RGTW92ZShwYWdlQ29uZmln dXJhdGlvbi51c2VyQ29udGVudFByb3ZpZGVyKSkKICAgICAsIG1fdmlzaXRlZExpbmtTdG9yZSgq V1RGTW92ZShwYWdlQ29uZmlndXJhdGlvbi52aXNpdGVkTGlua1N0b3JlKSkKICAgICAsIG1fc2Vz c2lvbklEKFBBTDo6U2Vzc2lvbklEOjpkZWZhdWx0U2Vzc2lvbklEKCkpCisjaWYgRU5BQkxFKFZJ REVPKQogICAgICwgbV9wbGF5YmFja0NvbnRyb2xzTWFuYWdlclVwZGF0ZVRpbWVyKCp0aGlzLCAm UGFnZTo6cGxheWJhY2tDb250cm9sc01hbmFnZXJVcGRhdGVUaW1lckZpcmVkKQorI2VuZGlmCiAg ICAgLCBtX2lzVXRpbGl0eVBhZ2UoaXNVdGlsaXR5UGFnZUNocm9tZUNsaWVudChjaHJvbWUoKS5j bGllbnQoKSkpCiAgICAgLCBtX3BlcmZvcm1hbmNlTW9uaXRvcihpc1V0aWxpdHlQYWdlKCkgPyBu dWxscHRyIDogc3RkOjptYWtlX3VuaXF1ZTxQZXJmb3JtYW5jZU1vbml0b3I+KCp0aGlzKSkKICAg ICAsIG1fbG93UG93ZXJNb2RlTm90aWZpZXIoc3RkOjptYWtlX3VuaXF1ZTxMb3dQb3dlck1vZGVO b3RpZmllcj4oW3RoaXNdKGJvb2wgaXNMb3dQb3dlck1vZGVFbmFibGVkKSB7IGhhbmRsZUxvd01v ZGVQb3dlckNoYW5nZShpc0xvd1Bvd2VyTW9kZUVuYWJsZWQpOyB9KSkKQEAgLTE1MTMsMTAgKzE1 MTUsMTMgQEAgdm9pZCBQYWdlOjp1cGRhdGVJc1BsYXlpbmdNZWRpYSh1aW50NjRfdCBzb3VyY2VF bGVtZW50SUQpCiAKIHZvaWQgUGFnZTo6c2NoZWR1bGVQbGF5YmFja0NvbnRyb2xzTWFuYWdlclVw ZGF0ZSgpCiB7CisjaWYgRU5BQkxFKFZJREVPKQogICAgIGlmICghbV9wbGF5YmFja0NvbnRyb2xz TWFuYWdlclVwZGF0ZVRpbWVyLmlzQWN0aXZlKCkpCiAgICAgICAgIG1fcGxheWJhY2tDb250cm9s c01hbmFnZXJVcGRhdGVUaW1lci5zdGFydE9uZVNob3QoMF9zKTsKKyNlbmRpZgogfQogCisjaWYg RU5BQkxFKFZJREVPKQogdm9pZCBQYWdlOjpwbGF5YmFja0NvbnRyb2xzTWFuYWdlclVwZGF0ZVRp bWVyRmlyZWQoKQogewogICAgIGlmIChhdXRvIGJlc3RNZWRpYUVsZW1lbnQgPSBIVE1MTWVkaWFF bGVtZW50OjpiZXN0TWVkaWFFbGVtZW50Rm9yU2hvd2luZ1BsYXliYWNrQ29udHJvbHNNYW5hZ2Vy KE1lZGlhRWxlbWVudFNlc3Npb246OlBsYXliYWNrQ29udHJvbHNQdXJwb3NlOjpDb250cm9sc01h bmFnZXIpKQpAQCAtMTUyNCw2ICsxNTI5LDcgQEAgdm9pZCBQYWdlOjpwbGF5YmFja0NvbnRyb2xz TWFuYWdlclVwZGF0ZVRpbWVyRmlyZWQoKQogICAgIGVsc2UKICAgICAgICAgY2hyb21lKCkuY2xp ZW50KCkuY2xlYXJQbGF5YmFja0NvbnRyb2xzTWFuYWdlcigpOwogfQorI2VuZGlmCiAKIHZvaWQg UGFnZTo6c2V0TXV0ZWQoTWVkaWFQcm9kdWNlcjo6TXV0ZWRTdGF0ZUZsYWdzIG11dGVkKQogewpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmggYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL1BhZ2UuaAppbmRleCBhNzhjY2E0OTliYmNiZDMwYjYwZTUyNzc5NDgyMWYzODBhNjA1YzFj Li42YzFkNDMyZjlkYTI1Y2VkODJiZTM1OGI5OTE5Nzg2Y2JmOWY2MmMwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2Uu aApAQCAtNjkxLDcgKzY5MSw5IEBAIHByaXZhdGU6CiAKICAgICBzdGQ6Om9wdGlvbmFsPHN0ZDo6 cGFpcjxNZWRpYUNhblN0YXJ0TGlzdGVuZXImLCBEb2N1bWVudCY+PiB0YWtlQW55TWVkaWFDYW5T dGFydExpc3RlbmVyKCk7CiAKKyNpZiBFTkFCTEUoVklERU8pCiAgICAgdm9pZCBwbGF5YmFja0Nv bnRyb2xzTWFuYWdlclVwZGF0ZVRpbWVyRmlyZWQoKTsKKyNlbmRpZgogCiAgICAgVmVjdG9yPFJl ZjxQbHVnaW5WaWV3QmFzZT4+IHBsdWdpblZpZXdzKCk7CiAKQEAgLTg3MCw3ICs4NzIsOSBAQCBw cml2YXRlOgogCiAgICAgTWVkaWFQcm9kdWNlcjo6TWVkaWFTdGF0ZUZsYWdzIG1fbWVkaWFTdGF0 ZSB7IE1lZGlhUHJvZHVjZXI6OklzTm90UGxheWluZyB9OwogCisjaWYgRU5BQkxFKFZJREVPKQog ICAgIFRpbWVyIG1fcGxheWJhY2tDb250cm9sc01hbmFnZXJVcGRhdGVUaW1lcjsKKyNlbmRpZgog CiAgICAgYm9vbCBtX2FsbG93c01lZGlhRG9jdW1lbnRJbmxpbmVQbGF5YmFjayB7IGZhbHNlIH07 CiAgICAgYm9vbCBtX2FsbG93c1BsYXliYWNrQ29udHJvbHNGb3JBdXRvcGxheWluZ0F1ZGlvIHsg ZmFsc2UgfTsK