189480 2018-09-10 13:26:24 -0700 [macOS] Editor::readSelectionFromPasteboard’s MailBlockquoteHandling argument is effectively unused 2018-09-10 13:41:22 -0700 1 1 1 Unclassified WebKit HTML Editing Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz mitz andersca thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1458191 0 mitz 2018-09-10 13:26:24 -0700 Editor::readSelectionFromPasteboard’s second argument defaults to MailBlockquoteHandling::RespectBlockquote, and the only caller that passes the argument also passes the default value. Patch forthcoming. 1458194 1 349323 mitz 2018-09-10 13:29:41 -0700 Created attachment 349323 Remove useless argument 1458199 2 mitz 2018-09-10 13:40:11 -0700 Committed <https://trac.webkit.org/r235857>. 1458200 3 webkit-bug-importer 2018-09-10 13:41:22 -0700 <rdar://problem/44315408> 349323 2018-09-10 13:29:41 -0700 2018-09-10 13:34:16 -0700 Remove useless argument bug-189480-20180910132940.patch text/plain 2662 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNTg1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA5LTEwICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBFZGl0b3I6OnJlYWRT ZWxlY3Rpb25Gcm9tUGFzdGVib2FyZOKAmXMgTWFpbEJsb2NrcXVvdGVIYW5kbGluZyBhcmd1bWVu dCBpcyBlZmZlY3RpdmVseSB1bnVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4OTQ4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVjYXVzZSB0aGlzIGRvZXNu4oCZdCBjaGFu Z2UgYmVoYXZpb3IuCisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5oOiBSZW1vdmVkIHRoZSBN YWlsQmxvY2txdW90ZUhhbmRsaW5nIGFyZ3VtZW50IGZyb20KKyAgICAgICAgICByZWFkU2VsZWN0 aW9uRnJvbVBhc3RlYm9hcmQuCisgICAgICAgICogZWRpdGluZy9tYWMvRWRpdG9yTWFjLm1tOgor ICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjpyZWFkU2VsZWN0aW9uRnJvbVBhc3RlYm9hcmQpOiBE b27igJl0IHBhc3MgbWFpbEJsb2NrcXVvdGVIYW5kbGluZyB0bworICAgICAgICAgIHBhc3RlV2l0 aFBhc3RlYm9hcmQuIEl0IHdhcyBhbHdheXMgc2V0IHRvIFJlc3BlY3RCbG9ja3F1b3RlLCB3aGlj aCBpcyB0aGUgbGF0dGVy4oCZcworICAgICAgICAgIGRlZmF1bHQuCisKIDIwMTgtMDktMTAgIEFu ZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtQYXltZW50IFJlcXVlc3Rd IFVzZSBKU1ZhbHVlSW5XcmFwcGVkT2JqZWN0IGZvciBQYXltZW50UmVzcG9uc2UncyBkZXRhaWxz IGF0dHJpYnV0ZQpJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5oCShyZXZpc2lvbiAyMzU3NjQp CisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5oCSh3b3JraW5nIGNvcHkpCkBAIC00 NzEsNyArNDcxLDcgQEAgcHVibGljOgogI2lmICFQTEFURk9STShJT1MpCiAgICAgYm9vbCBjYW5D b3B5RXhjbHVkaW5nU3RhbmRhbG9uZUltYWdlcygpOwogICAgIHZvaWQgdGFrZUZpbmRTdHJpbmdG cm9tU2VsZWN0aW9uKCk7Ci0gICAgV0VCQ09SRV9FWFBPUlQgdm9pZCByZWFkU2VsZWN0aW9uRnJv bVBhc3RlYm9hcmQoY29uc3QgU3RyaW5nJiBwYXN0ZWJvYXJkTmFtZSwgTWFpbEJsb2NrcXVvdGVI YW5kbGluZyA9IE1haWxCbG9ja3F1b3RlSGFuZGxpbmc6OlJlc3BlY3RCbG9ja3F1b3RlKTsKKyAg ICBXRUJDT1JFX0VYUE9SVCB2b2lkIHJlYWRTZWxlY3Rpb25Gcm9tUGFzdGVib2FyZChjb25zdCBT dHJpbmcmIHBhc3RlYm9hcmROYW1lKTsKICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIHJlcGxhY2VO b2RlRnJvbVBhc3RlYm9hcmQoTm9kZSosIGNvbnN0IFN0cmluZyYgcGFzdGVib2FyZE5hbWUpOwog ICAgIFdFQkNPUkVfRVhQT1JUIFJlZlB0cjxTaGFyZWRCdWZmZXI+IGRhdGFTZWxlY3Rpb25Gb3JQ YXN0ZWJvYXJkKGNvbnN0IFN0cmluZyYgcGFzdGVib2FyZE5hbWUpOwogI2VuZGlmIC8vICFQTEFU Rk9STShJT1MpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hYy9FZGl0b3JNYWMubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9tYWMvRWRpdG9yTWFjLm1tCShy ZXZpc2lvbiAyMzU3NjQpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hYy9FZGl0b3JNYWMu bW0JKHdvcmtpbmcgY29weSkKQEAgLTExOCwxMSArMTE4LDExIEBAIHZvaWQgRWRpdG9yOjp0YWtl RmluZFN0cmluZ0Zyb21TZWxlY3Rpb24KICNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKIH0K IAotdm9pZCBFZGl0b3I6OnJlYWRTZWxlY3Rpb25Gcm9tUGFzdGVib2FyZChjb25zdCBTdHJpbmcm IHBhc3RlYm9hcmROYW1lLCBNYWlsQmxvY2txdW90ZUhhbmRsaW5nIG1haWxCbG9ja3F1b3RlSGFu ZGxpbmcpCit2b2lkIEVkaXRvcjo6cmVhZFNlbGVjdGlvbkZyb21QYXN0ZWJvYXJkKGNvbnN0IFN0 cmluZyYgcGFzdGVib2FyZE5hbWUpCiB7CiAgICAgUGFzdGVib2FyZCBwYXN0ZWJvYXJkKHBhc3Rl Ym9hcmROYW1lKTsKICAgICBpZiAobV9mcmFtZS5zZWxlY3Rpb24oKS5zZWxlY3Rpb24oKS5pc0Nv bnRlbnRSaWNobHlFZGl0YWJsZSgpKQotICAgICAgICBwYXN0ZVdpdGhQYXN0ZWJvYXJkKCZwYXN0 ZWJvYXJkLCB0cnVlLCBtYWlsQmxvY2txdW90ZUhhbmRsaW5nKTsKKyAgICAgICAgcGFzdGVXaXRo UGFzdGVib2FyZCgmcGFzdGVib2FyZCwgdHJ1ZSk7CiAgICAgZWxzZQogICAgICAgICBwYXN0ZUFz UGxhaW5UZXh0V2l0aFBhc3RlYm9hcmQocGFzdGVib2FyZCk7CiB9Cg==