189472 2018-09-10 01:29:56 -0700 Adjust default value of CSSOMViewScrollingAPI 2020-01-14 14:02:43 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=194701 https://bugs.webkit.org/show_bug.cgi?id=203003 https://bugs.webkit.org/show_bug.cgi?id=206258 https://w3c-test.org/css/cssom-view/scrolling-quirks-vs-nonquirks.html InRadar P2 Normal --- 5991 1 fred.wang fred.wang cdumez commit-queue dino mcatanzaro rbyers simon.fraser thorton tonikitoo webkit-bug-importer oldest_to_newest 1458100 0 fred.wang 2018-09-10 01:29:56 -0700 After bug 182230, the option is enabled when running tests. This bug is to enable it for developers/testers in order to allow more experiments. 1458101 1 349300 fred.wang 2018-09-10 01:32:44 -0700 Created attachment 349300 Patch 1459000 2 simon.fraser 2018-09-12 10:01:32 -0700 Dean/Tim: we need to communicate new policies for EFs. 1459268 3 fred.wang 2018-09-12 23:09:19 -0700 (In reply to Simon Fraser (smfr) from comment #2) > Dean/Tim: we need to communicate new policies for EFs. Thanks. So with the new policy this bug should just be to remove CSSOMViewScrollAPI from the experimental category and hence enable the new change by default. On the one hand, I have concern that such a change could be a bit abrupt for web developers and I would prefer a smoother path that still allows to get early feedback. On the other hand, I think WebKit developers should be aware of this asap so they stop using document.body.scroll* API in standard mode when writing tests. 1462658 4 350628 fred.wang 2018-09-24 02:45:14 -0700 Created attachment 350628 Patch 1472116 5 rbyers 2018-10-25 10:55:36 -0700 Simon and I chatted a bit about this at TPAC. He agreed with my assessment that the main compat risk is probably for webview and other embedders (if I recall we relied on a compat quirk in chromium to get the old behavior under Android WebView). Simon's recommendation was to expose this up to Safari as a WebPreference, and he'd get Safari to explicitly enable it. We didn't talk about the testing situation though. I assume if it'll be enabled in Safari, then you'd want it enabled for the webkit tests too? 1472120 6 fred.wang 2018-10-25 11:09:54 -0700 (In reply to Rick Byers from comment #5) > Simon and I chatted a bit about this at TPAC. He agreed with my assessment > that the main compat risk is probably for webview and other embedders (if I > recall we relied on a compat quirk in chromium to get the old behavior > under Android WebView). Simon's recommendation was to expose this up to > Safari as a WebPreference, and he'd get Safari to explicitly enable it. > > We didn't talk about the testing situation though. I assume if it'll be > enabled in Safari, then you'd want it enabled for the webkit tests too? Thanks for the update, Rick. There is already a WebPreference for this. Currently, it is an "Experimental Feature" disabled by default but enabled for tests (hence not in accordance with the proposed new policy https://lists.webkit.org/pipermail/webkit-dev/2018-September/030123.html). Attachment 350628 makes the feature non-experimental and enabled by default. From your comment, I think I need at least to be sure that the features remain disabled for the various iOS webviews. Not sure about other WebKit ports but I would say it's better to align with Safari's behavior. 1472356 7 353163 fred.wang 2018-10-26 01:24:13 -0700 Created attachment 353163 Patch 1472430 8 353163 mcatanzaro 2018-10-26 07:30:52 -0700 Comment on attachment 353163 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353163&action=review The ChangeLog is messed up (duplicated). > Source/WebKit/Shared/WebPreferencesDefaultValues.h:38 > +#if PLATFORM(GTK) || PLATFORM(WPE) > +#define DEFAULT_CSSOM_VIEW_SCROLLING_API_ENABLED true > +#else > +#define DEFAULT_CSSOM_VIEW_SCROLLING_API_ENABLED false > +#endif We should only have different defaults than Mac if there's a very strong reason for it. I guess if it will be on in Safari, but not Mac platform apps, that could qualify as a strong reason. I was going to suggest just turning it on with a header for any tests that need it: <!-- webkit-test-runner [internal:CSSOMViewScrollingAPIEnabled=true ] --> But you probably want it enabled in all tests, not just specific tests? 1472456 9 fred.wang 2018-10-26 08:19:35 -0700 (In reply to Michael Catanzaro from comment #8) > Comment on attachment 353163 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=353163&action=review > > The ChangeLog is messed up (duplicated). oops, will fix. > > > Source/WebKit/Shared/WebPreferencesDefaultValues.h:38 > > +#if PLATFORM(GTK) || PLATFORM(WPE) > > +#define DEFAULT_CSSOM_VIEW_SCROLLING_API_ENABLED true > > +#else > > +#define DEFAULT_CSSOM_VIEW_SCROLLING_API_ENABLED false > > +#endif > > We should only have different defaults than Mac if there's a very strong > reason for it. > > I guess if it will be on in Safari, but not Mac platform apps, that could > qualify as a strong reason. Yes per comment 5 that seems to be the plan. But let's see what Apple people say. I just wanted to be sure we are ok having the standard behavior enabled on our ports. > I was going to suggest just turning it on with a header for any tests that > need it: > > <!-- webkit-test-runner [internal:CSSOMViewScrollingAPIEnabled=true ] --> > > But you probably want it enabled in all tests, not just specific tests? The option is already enabled for all tests (I did that before the new policy proposal) and for this kind of behavior change I don't think it's actually a good idea to enable it on a per-test basis. Anyway, if Apple people confirm they want to enable it on Safari by default then this should indeed remain enabled for all tests. 1472519 10 webkit-bug-importer 2018-10-26 11:47:58 -0700 <rdar://problem/45594753> 1472659 11 simon.fraser 2018-10-26 22:26:29 -0700 If this would wait a couple of months, I'd be willing to take this change on macOS/iOS as well. 1472685 12 fred.wang 2018-10-27 03:17:28 -0700 (In reply to Simon Fraser (smfr) from comment #11) > If this would wait a couple of months, I'd be willing to take this change on > macOS/iOS as well. I think there is no hurry, we can wait that things are ready to be taken on macOS/iOS. 1492456 13 353163 simon.fraser 2019-01-07 15:42:15 -0800 Comment on attachment 353163 Patch Let's turn it on everywhere now. 1492569 14 350628 fred.wang 2019-01-08 01:31:11 -0800 Comment on attachment 350628 Patch (In reply to Simon Fraser (smfr) from comment #13) > Comment on attachment 353163 [details] > Patch > > Let's turn it on everywhere now. OK, then I think we can take this previous patch, which still applies on ToT. 1495036 15 fred.wang 2019-01-16 02:20:46 -0800 (In reply to Frédéric Wang (:fredw) from comment #14) > Comment on attachment 350628 [details] > Patch > > (In reply to Simon Fraser (smfr) from comment #13) > > Comment on attachment 353163 [details] > > Patch > > > > Let's turn it on everywhere now. > > OK, then I think we can take this previous patch, which still applies on ToT. @smfr: review ping? 1495083 16 350628 simon.fraser 2019-01-16 09:12:43 -0800 Comment on attachment 350628 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=350628&action=review > Source/WebKit/Shared/WebPreferences.yaml:-1199 > - category: experimental Please keep this as "category: internal" so we can switch it off in the UI for testing. 1496718 17 359722 fred.wang 2019-01-22 00:29:50 -0800 Created attachment 359722 Patch for landing 1496728 18 359722 commit-queue 2019-01-22 01:07:05 -0800 Comment on attachment 359722 Patch for landing Clearing flags on attachment: 359722 Committed r240250: <https://trac.webkit.org/changeset/240250> 1496729 19 commit-queue 2019-01-22 01:07:07 -0800 All reviewed patches have been landed. Closing bug. 349300 2018-09-10 01:32:44 -0700 2018-09-24 02:45:10 -0700 Patch bug-189472-20180910103243.patch text/plain 1561 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1ODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY3YTM4NDk1Y2RkYmNkMjg4 NWY4M2ZiODQwNjE2YjA5ZTcxNGYwNDQuLjM4M2MwOTg3NmEwYjdkYThkMjgzZDVkNzJhM2IzNDhh MTE4NTdmMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDktMTAgIEZyZWRlcmlj IFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgorCisgICAgICAgIFNldCBDU1NPTVZpZXdTY3JvbGxp bmdBUEkgdG8gREVGQVVMVF9FWFBFUklNRU5UQUxfRkVBVFVSRVNfRU5BQkxFRAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5NDcyCisKKyAgICAgICAg QWZ0ZXIgYnVnIDE4MjIzMCwgdGhlIG9wdGlvbiBpcyBlbmFibGVkIHdoZW4gcnVubmluZyB0ZXN0 cy4gSW4gdGhpcyBwYXRjaCwgd2UgY2hhbmdlIHRoZQorICAgICAgICBkZWZhdWx0IHZhbHVlIHRv IERFRkFVTFRfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTX0VOQUJMRUQgdG8gYWxsb3cgbW9yZSBwZW9w bGUgdG8gdGVzdCBpdC4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sOiBEZWZhdWx0IHRvIERFRkFVTFRf RVhQRVJJTUVOVEFMX0ZFQVRVUkVTX0VOQUJMRUQKKwogMjAxOC0wOS0wOSAgRnVqaWkgSGlyb25v cmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xs aW5nIG91dCByMjM1ODM5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJl ZmVyZW5jZXMueWFtbCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwK aW5kZXggNGJlZTYzNzkwOGU4NDA0Zjc3ZjE1YTJjMjQyMjhmOGMzNzBmY2FhZi4uZTJiZWVhMTI5 MmZhNjliOTlmOTkwN2ExYjE0ZTg3NThjOWRhZDhiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9X ZWJQcmVmZXJlbmNlcy55YW1sCkBAIC0xMjA5LDcgKzEyMDksNyBAQCBWaXN1YWxWaWV3cG9ydEFQ SUVuYWJsZWQ6CiAKIENTU09NVmlld1Njcm9sbGluZ0FQSUVuYWJsZWQ6CiAgIHR5cGU6IGJvb2wK LSAgZGVmYXVsdFZhbHVlOiBmYWxzZQorICBkZWZhdWx0VmFsdWU6IERFRkFVTFRfRVhQRVJJTUVO VEFMX0ZFQVRVUkVTX0VOQUJMRUQKICAgaHVtYW5SZWFkYWJsZU5hbWU6ICJDU1NPTSBWaWV3IFNj cm9sbGluZyBBUEkiCiAgIGh1bWFuUmVhZGFibGVEZXNjcmlwdGlvbjogIkltcGxlbWVudCBzdGFu ZGFyZCBiZWhhdmlvciBmb3Igc2Nyb2xsTGVmdCwgc2Nyb2xsVG9wLCBzY3JvbGxXaWR0aCwgc2Ny b2xsSGVpZ2h0LCBzY3JvbGxUbywgc2Nyb2xsQnkgYW5kIHNjcm9sbGluZ0VsZW1lbnQuIgogICBj YXRlZ29yeTogZXhwZXJpbWVudGFsCg== 350628 2018-09-24 02:45:14 -0700 2019-01-22 00:29:42 -0800 Patch bug-189472-20180924114512.patch text/plain 2075 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2MzkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDkxNDQwYmE1NDk0YWZmZmM2 OTVjZGUxNjRhODcwNWM0MWFmYzNiYmQuLmJhMTJjODQwZTQxODQ4MzA0YTdlZDgzZDQ5MDNkMzZi ODkzNzQ0MjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTgtMDktMjQgIEZyZWRlcmlj IFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgorCisgICAgICAgIEVuYWJsZSBDU1NPTVZpZXdTY3Jv bGxpbmdBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4OTQ3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoaXMgcGF0Y2ggZW5hYmxlcyB0aGUgQ1NTT01WaWV3U2Nyb2xsaW5nQVBJIG9wdGlvbiBieSBk ZWZhdWx0LiBUaGlzIGZlYXR1cmUgaGFzIGFscmVhZHkgYmVlbgorICAgICAgICBlbmFibGVkIGlu IHRlc3RzIHNpbmNlIHIyMzU4NTUuIEJhc2ljYWxseSwgdGhpcyBjaGFuZ2UgZml4ZXMgYW4gb2xk IGNvbXBhdGliaWxpdHkgaXNzdWUKKyAgICAgICAgcmVnYXJkaW5nIHdoaWNoIHNjcm9sbGluZyBl bGVtZW50IGNvcnJlc3BvbmQgdG8gdGhlIHZpZXdwb3J0IGluIHN0YW5kYXJkIG1vZGUgKFdlYktp dCB1c2VzCisgICAgICAgIGRvY3VtZW50LmJvZHkgd2hpbGUgR2Vja28vRWRnZS9DaHJvbWl1bSB1 c2UgZG9jdW1lbnQuZG9jdW1lbnRFbGVtZW50IGFzIGRlc2NyaWJlZCBpbiB0aGUKKyAgICAgICAg Q1NTT00gVmlldyBzcGVjaWZpY2F0aW9uKS4gV2ViS2l0IGRldmVsb3BlcnMgd3JpdGluZyB0ZXN0 cyBjYW4gdXNlIGRvY3VtZW50LnNjcm9sbGluZ0VsZW1lbnQKKyAgICAgICAgZm9yIHRoYXQgcHVy cG9zZSwgc28gdGhhdCB0aGV5IHdvcmsgaW5kZXBlbmRlbnRseSBvZiB3aGV0aGVyIHRoZSBvcHRp b24gaXMgZW5hYmxlZC4KKworICAgICAgICBbMV0gaHR0cHM6Ly9saXN0cy53ZWJraXQub3JnL3Bp cGVybWFpbC93ZWJraXQtZGV2LzIwMTgtSmFudWFyeS8wMjk4NTcuaHRtbAorCisgICAgICAgICog U2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWw6IEVuYWJsZSBieSBkZWZhdWx0IGFuZCByZW1vdmUg ImV4cGVyaW1lbnRhbCIgY2F0ZWdvcnkgaW4KKyAgICAgICAgYWNjb3JkYW5jZSB3aXRoIHRoZSBu ZXcgcG9saWN5LgorCiAyMDE4LTA5LTIxICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4K IAogICAgICAgICBBZGQgUG9pbnRlckV2ZW50LCBwbHVzIGZlYXR1cmUgZmxhZywgcGx1cyBXZWIg UGxhdGZvcm0gVGVzdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZl cmVuY2VzLnlhbWwgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCmlu ZGV4IGE4MmFiMTI1Mjg3ZGI1MzY0Mzk4NTVjMzBkYzNmY2NmOTAzN2Q1OTIuLjAyYTI3NjkzYmRl ZGU4NGMzMWIzYmQwNTZiMWY0YmIxNWI2MWQwZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv U2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2Vi UHJlZmVyZW5jZXMueWFtbApAQCAtMTE5MywxMCArMTE5Myw5IEBAIFBvaW50ZXJFdmVudHNFbmFi bGVkOgogCiBDU1NPTVZpZXdTY3JvbGxpbmdBUElFbmFibGVkOgogICB0eXBlOiBib29sCi0gIGRl ZmF1bHRWYWx1ZTogZmFsc2UKKyAgZGVmYXVsdFZhbHVlOiB0cnVlCiAgIGh1bWFuUmVhZGFibGVO YW1lOiAiQ1NTT00gVmlldyBTY3JvbGxpbmcgQVBJIgogICBodW1hblJlYWRhYmxlRGVzY3JpcHRp b246ICJJbXBsZW1lbnQgc3RhbmRhcmQgYmVoYXZpb3IgZm9yIHNjcm9sbExlZnQsIHNjcm9sbFRv cCwgc2Nyb2xsV2lkdGgsIHNjcm9sbEhlaWdodCwgc2Nyb2xsVG8sIHNjcm9sbEJ5IGFuZCBzY3Jv bGxpbmdFbGVtZW50LiIKLSAgY2F0ZWdvcnk6IGV4cGVyaW1lbnRhbAogCiBXZWJBbmltYXRpb25z RW5hYmxlZDoKICAgdHlwZTogYm9vbAo= 353163 2018-10-26 01:24:13 -0700 2019-01-22 00:29:45 -0800 Patch bug-189472-20181026102412.patch text/plain 4590 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3NDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVlODYzOWJmNDY1Mzk3YjZi YTI3OTJiNmZmMTg1ZGU1Zjk4YTUzMDUuLjU4ZGVjNThhMjlmMDZiNDlkNmM4ODVlYjkyZWIwNGQ1 YzBhOGQzZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNDEgQEAKKzIwMTgtMTAtMjYgIEZyZWRlcmlj IFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgorCisgICAgICAgIEFkanVzdCBkZWZhdWx0IHZhbHVl IG9mIENTU09NVmlld1Njcm9sbGluZ0FQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg5NDcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRW5hYmxpbmcgdGhlIENTU09NVmlld1Njcm9sbGluZ0FQSSBmZWF0 dXJlIGZpeGVzIGFuIG9sZCBjb21wYXRpYmlsaXR5IGlzc3VlIHJlZ2FyZGluZyB3aGljaAorICAg ICAgICBzY3JvbGxpbmcgZWxlbWVudCBjb3JyZXNwb25kcyB0byB0aGUgdmlld3BvcnQgaW4gc3Rh bmRhcmQgbW9kZSAoV2ViS2l0IHVzZXMgZG9jdW1lbnQuYm9keQorICAgICAgICB3aGlsZSBHZWNr by9FZGdlL0Nocm9taXVtIHVzZSBkb2N1bWVudC5kb2N1bWVudEVsZW1lbnQgYXMgZGVzY3JpYmVk IGluIHRoZSBDU1NPTSBWaWV3CisgICAgICAgIHNwZWNpZmljYXRpb24pLiBXZWJLaXQgZGV2ZWxv cGVycyB3cml0aW5nIHRlc3RzIGNhbiB1c2UgZG9jdW1lbnQuc2Nyb2xsaW5nRWxlbWVudCBmb3Ig dGhhdAorICAgICAgICBwdXJwb3NlLCBzbyB0aGF0IHRlc3RzIHdvcmsgaW5kZXBlbmRlbnRseSBv ZiB3aGV0aGVyIHRoZSBvcHRpb24gaXMgZW5hYmxlZC4KKworICAgICAgICBUaGlzIGZlYXR1cmUg aGFzIGFscmVhZHkgYmVlbiBlbmFibGVkIGluIHRlc3RzIHNpbmNlIHIyMzU4NTUuIFRoaXMgcGF0 Y2ggcmVtb3ZlcworICAgICAgICBDU1NPTVZpZXdTY3JvbGxpbmdBUEkgZnJvbSB0aGUgImV4cGVy aW1lbnRhbCIgY2F0ZWdvcnkgYW5kIGVuYWJsZXMgaXQgYnkgZGVmYXVsdCBvbiBXUEUgYW5kCisg ICAgICAgIEdUSyBwb3J0cy4gV2UgZG9uJ3QgZm9yY2UgdGhlIGZsYWcgb24gZXZlcnl3aGVyZSBk dWUgdG8gYmFja3dhcmQgY29tcGF0aWJpbGl0eSByaXNrIGZvcgorICAgICAgICB3ZWJ2aWV3cyBh bmQgb3RoZXIgZW1iZWRkZXJzIGJ1dCBpdCBtYWtlcyBzZW5zZSB0byBlbmFibGUgaXQgaW4gYWxs IFdlYktpdC1iYXNlZCBicm93c2Vycy4KKyAgICAgICAgVGhlIGRlY2lzaW9uIGlzIHVwIHRvIG90 aGVyIHBvcnQvYnJvd3NlciBtYWludGFpbmVycy4KKworICAgICAgICAqIFNoYXJlZC9XZWJQcmVm ZXJlbmNlcy55YW1sOiBSZW1vdmUgImV4cGVyaW1lbnRhbCIgY2F0ZWdvcnkgYW5kIGludHJvZHVj ZQorICAgICAgICBERUZBVUxUX0NTU09NX1ZJRVdfU0NST0xMSU5HX0FQSV9FTkFCTEVELgorICAg ICAgICAqIFNoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXMuaDogU2V0ICBERUZBVUxU X0NTU09NX1ZJRVdfU0NST0xMSU5HX0FQSV9FTkFCTEVEIHRvIHRydWUKKyAgICAgICAgb24gV1BF L0dUSyBwb3J0cy4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJlbmNlc1JlZlBy aXZhdGUuaDogVXBkYXRlIGNvbW1lbnQuCisKKzIwMTgtMDktMjQgIEZyZWRlcmljIFdhbmcgIDxm d2FuZ0BpZ2FsaWEuY29tPgorCisgICAgICAgIEVuYWJsZSBDU1NPTVZpZXdTY3JvbGxpbmdBUEkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTQ3Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0 Y2ggZW5hYmxlcyB0aGUgQ1NTT01WaWV3U2Nyb2xsaW5nQVBJIG9wdGlvbiBieSBkZWZhdWx0Lgor ICAgICAgICBbMV0gaHR0cHM6Ly9saXN0cy53ZWJraXQub3JnL3BpcGVybWFpbC93ZWJraXQtZGV2 LzIwMTgtSmFudWFyeS8wMjk4NTcuaHRtbAorCisgICAgICAgICogU2hhcmVkL1dlYlByZWZlcmVu Y2VzLnlhbWw6IEVuYWJsZSBieSBkZWZhdWx0IGFuZCByZW1vdmUgImV4cGVyaW1lbnRhbCIgY2F0 ZWdvcnkgaW4KKyAgICAgICAgYWNjb3JkYW5jZSB3aXRoIHRoZSBuZXcgcG9saWN5LgorCiAyMDE4 LTEwLTI1ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAg ICAgICBVbnJldmlld2VkLCBhbm90aGVyIHRyeSBhdCBmaXhpbmcgdGhlIEdUSyBidWlsZCB3aXRo IHNhbmRib3ggZW5hYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViUHJl ZmVyZW5jZXMueWFtbCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwK aW5kZXggNmQ2YWNkYzY5MGJmNmYwYzZiOWJiYmNjMjUzMThmYTRiNmE2NzMzOS4uZDU5MWM3ZmQ0 ODVmODdhMWQ0MDZjOWI5NzU5YjMwNDEwYWE2YTAyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9X ZWJQcmVmZXJlbmNlcy55YW1sCkBAIC0xMjE0LDEwICsxMjE0LDkgQEAgUG9pbnRlckV2ZW50c0Vu YWJsZWQ6CiAKIENTU09NVmlld1Njcm9sbGluZ0FQSUVuYWJsZWQ6CiAgIHR5cGU6IGJvb2wKLSAg ZGVmYXVsdFZhbHVlOiBmYWxzZQorICBkZWZhdWx0VmFsdWU6IERFRkFVTFRfQ1NTT01fVklFV19T Q1JPTExJTkdfQVBJX0VOQUJMRUQKICAgaHVtYW5SZWFkYWJsZU5hbWU6ICJDU1NPTSBWaWV3IFNj cm9sbGluZyBBUEkiCiAgIGh1bWFuUmVhZGFibGVEZXNjcmlwdGlvbjogIkltcGxlbWVudCBzdGFu ZGFyZCBiZWhhdmlvciBmb3Igc2Nyb2xsTGVmdCwgc2Nyb2xsVG9wLCBzY3JvbGxXaWR0aCwgc2Ny b2xsSGVpZ2h0LCBzY3JvbGxUbywgc2Nyb2xsQnkgYW5kIHNjcm9sbGluZ0VsZW1lbnQuIgotICBj YXRlZ29yeTogZXhwZXJpbWVudGFsCiAKIFdlYkFuaW1hdGlvbnNFbmFibGVkOgogICB0eXBlOiBi b29sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1 bHRWYWx1ZXMuaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZh bHVlcy5oCmluZGV4IDRkYTZjMTAyYTBiNTYzODdkZjRmODNiYTI2ZmJjMTAxZTBmMzU5ZTIuLmUy MzI2MDA2Yzc1MzhiMTg2ZGViYTAwZDMxYjlhY2ZjZGQxOTA2M2YgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5oCkBAIC0zMSw2ICsz MSwxMiBAQAogI2RlZmluZSBERUZBVUxUX1dFQktJVF9UQUJTVE9MSU5LU19FTkFCTEVEIGZhbHNl CiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oV1BFKQorI2RlZmluZSBE RUZBVUxUX0NTU09NX1ZJRVdfU0NST0xMSU5HX0FQSV9FTkFCTEVEIHRydWUKKyNlbHNlCisjZGVm aW5lIERFRkFVTFRfQ1NTT01fVklFV19TQ1JPTExJTkdfQVBJX0VOQUJMRUQgZmFsc2UKKyNlbmRp ZgorCiAjaWYgRU5BQkxFKFNNT09USF9TQ1JPTExJTkcpCiAjZGVmaW5lIERFRkFVTFRfV0VCS0lU X1NDUk9MTF9BTklNQVRPUl9FTkFCTEVEIHRydWUKICNlbHNlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzUmVmUHJpdmF0ZS5oIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tQcmVmZXJlbmNlc1JlZlByaXZhdGUuaAppbmRleCAw ZmNiMjA1YmU4ODQ1ZWJiZWY2MWFlMDIwYmFiZWU4MTRjOWJjZjI5Li44OWQ4YzI4OTAxOTdiZjEw MTViNjU4MzYyMTY2MmM3Mjc4MWQ4ZTRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvQy9XS1ByZWZlcmVuY2VzUmVmUHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9DL1dLUHJlZmVyZW5jZXNSZWZQcml2YXRlLmgKQEAgLTU2NCw3ICs1NjQs NyBAQCBXS19FWFBPUlQgYm9vbCBXS1ByZWZlcmVuY2VzR2V0QWNjZXNzaWJpbGl0eU9iamVjdE1v ZGVsRW5hYmxlZChXS1ByZWZlcmVuY2VzUmVmKQogV0tfRVhQT1JUIHZvaWQgV0tQcmVmZXJlbmNl c1NldEFyaWFSZWZsZWN0aW9uRW5hYmxlZChXS1ByZWZlcmVuY2VzUmVmLCBib29sIGZsYWcpOwog V0tfRVhQT1JUIGJvb2wgV0tQcmVmZXJlbmNlc0dldEFyaWFSZWZsZWN0aW9uRW5hYmxlZChXS1By ZWZlcmVuY2VzUmVmKTsKIAotLy8gRGVmYXVsdHMgdG8gZmFsc2UuCisvLyBEZWZhdWx0cyB0byB0 cnVlIG9uIEdUSy9XUEUsIGZhbHNlIGVsc2V3aGVyZS4KIFdLX0VYUE9SVCB2b2lkIFdLUHJlZmVy ZW5jZXNTZXRDU1NPTVZpZXdTY3JvbGxpbmdBUElFbmFibGVkKFdLUHJlZmVyZW5jZXNSZWYsIGJv b2wpOwogV0tfRVhQT1JUIGJvb2wgV0tQcmVmZXJlbmNlc0dldENTU09NVmlld1Njcm9sbGluZ0FQ SUVuYWJsZWQoV0tQcmVmZXJlbmNlc1JlZik7CiAK 359722 2019-01-22 00:29:50 -0800 2019-01-22 01:07:05 -0800 Patch for landing bug-189472-20190122092948.patch text/plain 2129 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjQwMjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJjNWRhMzY4YzIwYTM4ODYx NmI3MjU2ODBlMDdjNjMzMmQ4MGIxMzcuLjg1OTZkNmJiMTY0NGYyZWVjOGQ1ODNiMmYxYmM1NTk2 ZGEwNzQ4ZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTgtMDktMjQgIEZyZWRlcmlj IFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgorCisgICAgICAgIEVuYWJsZSBDU1NPTVZpZXdTY3Jv bGxpbmdBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4OTQ3MgorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KKworICAgICAgICBU aGlzIHBhdGNoIGVuYWJsZXMgdGhlIENTU09NVmlld1Njcm9sbGluZ0FQSSBvcHRpb24gYnkgZGVm YXVsdC4gVGhpcyBmZWF0dXJlIGhhcyBhbHJlYWR5IGJlZW4KKyAgICAgICAgZW5hYmxlZCBpbiB0 ZXN0cyBzaW5jZSByMjM1ODU1LiBCYXNpY2FsbHksIHRoaXMgY2hhbmdlIGZpeGVzIGFuIG9sZCBj b21wYXRpYmlsaXR5IGlzc3VlCisgICAgICAgIHJlZ2FyZGluZyB3aGljaCBzY3JvbGxpbmcgZWxl bWVudCBjb3JyZXNwb25kIHRvIHRoZSB2aWV3cG9ydCBpbiBzdGFuZGFyZCBtb2RlIChXZWJLaXQg dXNlcworICAgICAgICBkb2N1bWVudC5ib2R5IHdoaWxlIEdlY2tvL0VkZ2UvQ2hyb21pdW0gdXNl IGRvY3VtZW50LmRvY3VtZW50RWxlbWVudCBhcyBkZXNjcmliZWQgaW4gdGhlCisgICAgICAgIENT U09NIFZpZXcgc3BlY2lmaWNhdGlvbikuIFdlYktpdCBkZXZlbG9wZXJzIHdyaXRpbmcgdGVzdHMg Y2FuIHVzZSBkb2N1bWVudC5zY3JvbGxpbmdFbGVtZW50CisgICAgICAgIGZvciB0aGF0IHB1cnBv c2UsIHNvIHRoYXQgdGhleSB3b3JrIGluZGVwZW5kZW50bHkgb2Ygd2hldGhlciB0aGUgb3B0aW9u IGlzIGVuYWJsZWQuCisKKyAgICAgICAgWzFdIGh0dHBzOi8vbGlzdHMud2Via2l0Lm9yZy9waXBl cm1haWwvd2Via2l0LWRldi8yMDE4LUphbnVhcnkvMDI5ODU3Lmh0bWwKKworICAgICAgICAqIFNo YXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sOiBFbmFibGUgYnkgZGVmYXVsdCBhbmQgcmVtb3ZlICJl eHBlcmltZW50YWwiIGNhdGVnb3J5IGluCisgICAgICAgIGFjY29yZGFuY2Ugd2l0aCB0aGUgbmV3 IHBvbGljeS4gSW5zdGVhZCwga2VlcCBhbiBpbnRlcm5hbCBmbGFnIG9ubHkgZm9yIGRldmVsb3Bl cnMuCisKIDIwMTktMDEtMjEgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAg ICAgICAgIFtpT1NdIEhhbmRsZSBoaXQgdGVzdGluZyBmb3Igc3ViZnJhbWVzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sIGIvU291cmNlL1dlYktp dC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbAppbmRleCA4MmRkY2JjYzBjNjJmZjY4ZDk0OWFh MGExYmU0YzJmYjY5NTZkMTQxLi4wMjQzMjJhNDM4ZTY3Y2ZiODA2NTg5ZGI3Y2JhOWFmMDY1ZWJh YmUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1s CisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlhbWwKQEAgLTEyNTUs MTAgKzEyNTUsMTAgQEAgUG9pbnRlckV2ZW50c0VuYWJsZWQ6CiAKIENTU09NVmlld1Njcm9sbGlu Z0FQSUVuYWJsZWQ6CiAgIHR5cGU6IGJvb2wKLSAgZGVmYXVsdFZhbHVlOiBmYWxzZQorICBkZWZh dWx0VmFsdWU6IHRydWUKICAgaHVtYW5SZWFkYWJsZU5hbWU6ICJDU1NPTSBWaWV3IFNjcm9sbGlu ZyBBUEkiCiAgIGh1bWFuUmVhZGFibGVEZXNjcmlwdGlvbjogIkltcGxlbWVudCBzdGFuZGFyZCBi ZWhhdmlvciBmb3Igc2Nyb2xsTGVmdCwgc2Nyb2xsVG9wLCBzY3JvbGxXaWR0aCwgc2Nyb2xsSGVp Z2h0LCBzY3JvbGxUbywgc2Nyb2xsQnkgYW5kIHNjcm9sbGluZ0VsZW1lbnQuIgotICBjYXRlZ29y eTogZXhwZXJpbWVudGFsCisgIGNhdGVnb3J5OiBpbnRlcm5hbAogCiBXZWJBbmltYXRpb25zRW5h YmxlZDoKICAgdHlwZTogYm9vbAo=