189467 2018-09-09 20:21:13 -0700 [MSVC] X86Assembler.h(108): error C2666: 'WebCore::operator -': 7 overloads have similar conversions 2018-11-19 23:58:24 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=191538 https://bugs.webkit.org/show_bug.cgi?id=191853 InRadar P2 Normal --- 189987 1 fujii fujii achristensen ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam webkit-bug-importer ysuzuki oldest_to_newest 1458066 0 fujii 2018-09-09 20:21:13 -0700 [WinCairo] X86Assembler.h(108): error C2666: 'WebCore::operator -': 7 overloads have similar conversions https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Release%20%28Build%29/builds/3095 > FAILED: Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource43.cpp.obj > "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.14.26428\bin\Hostx64\x64\cl.exe" /nologo /TP -DBUILDING_WEBKIT -DBUILDING_WITH_CMAKE=1 -DBUILDING_WebKit -DHAVE_CONFIG_H=1 -DNOMINMAX -DUCHAR_TYPE=wchar_t -DUNICODE -DUSE_CAIRO=1 -DUSE_CURL=1 -DWINVER=0x601 -DWTF_PLATFORM_WIN_CAIRO=1 -DWebKit_EXPORTS -D_CRT_SECURE_CPP_OVERLOAD_STANDARD_NAMES=1 -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_UNICODE -D_WIN32_WINNT=0x601 -D_WINDOWS -D_WINSOCKAPI_="" -I..\..\WebKitLibraries\win\include -I..\..\Source\WebKit -I..\..\Source\WebKit\NetworkProcess -I..\..\Source\WebKit\NetworkProcess\Cookies -I..\..\Source\WebKit\NetworkProcess\CustomProtocols -I..\..\Source\WebKit\NetworkProcess\Downloads -I..\..\Source\WebKit\NetworkProcess\FileAPI -I..\..\Source\WebKit\NetworkProcess\cache -I..\..\Source\WebKit\NetworkProcess\capture -I..\..\Source\WebKit\NetworkProcess\watchos -I..\..\Source\WebKit\NetworkProcess\webrtc -I..\..\Source\WebKit\Platform -I..\..\Source\WebKit\Platform\IPC -I..\..\Source\WebKit\PluginProcess -I..\..\Source\WebKit\Shared -I..\..\Source\WebKit\Shared\API -I..\..\Source\WebKit\Shared\API\c -I..\..\Source\WebKit\Shared\Authentication -I..\..\Source\WebKit\Shared\CoreIPCSupport -I..\..\Source\WebKit\Shared\Databases -I..\..\Source\WebKit\Shared\Databases\IndexedDB -I..\..\Source\WebKit\Shared\FileAPI -I..\..\Source\WebKit\Shared\Gamepad -I..\..\Source\WebKit\Shared\Plugins -I..\..\Source\WebKit\Shared\Plugins\Netscape -I..\..\Source\WebKit\Shared\Plugins\Netscape\x11 -I..\..\Source\WebKit\Shared\RemoteLayerTree -I..\..\Source\WebKit\Shared\Storage -I..\..\Source\WebKit\Shared\WebsiteData -I..\..\Source\WebKit\StorageProcess -I..\..\Source\WebKit\StorageProcess\IndexedDB -I..\..\Source\WebKit\StorageProcess\ServiceWorker -I..\..\Source\WebKit\UIProcess -I..\..\Source\WebKit\UIProcess\API -I..\..\Source\WebKit\UIProcess\API\C -I..\..\Source\WebKit\UIProcess\API\cpp -I..\..\Source\WebKit\UIProcess\ApplePay -I..\..\Source\WebKit\UIProcess\Authentication -I..\..\Source\WebKit\UIProcess\Automation -I..\..\Source\WebKit\UIProcess\Downloads -I..\..\Source\WebKit\UIProcess\Gamepad -I..\..\Source\WebKit\UIProcess\Launcher -I..\..\Source\WebKit\UIProcess\Network -I..\..\Source\WebKit\UIProcess\Network\CustomProtocols -I..\..\Source\WebKit\UIProcess\Notifications -I..\..\Source\WebKit\UIProcess\Plugins -I..\..\Source\WebKit\UIProcess\RemoteLayerTree -I..\..\Source\WebKit\UIProcess\Storage -I..\..\Source\WebKit\UIProcess\UserContent -I..\..\Source\WebKit\UIProcess\WebStorage -I..\..\Source\WebKit\UIProcess\WebsiteData -I..\..\Source\WebKit\WebProcess -I..\..\Source\WebKit\WebProcess\ApplePay -I..\..\Source\WebKit\WebProcess\ApplicationCache -I..\..\Source\WebKit\WebProcess\Automation -I..\..\Source\WebKit\WebProcess\Cache -I..\..\Source\WebKit\WebProcess\Databases -I..\..\Source\WebKit\WebProcess\Databases\IndexedDB -I..\..\Source\WebKit\WebProcess\FileAPI -I..\..\Source\WebKit\WebProcess\FullScreen -I..\..\Source\WebKit\WebProcess\Gamepad -I..\..\Source\WebKit\WebProcess\Geolocation -I..\..\Source\WebKit\WebProcess\IconDatabase -I..\..\Source\WebKit\WebProcess\InjectedBundle -I..\..\Source\WebKit\WebProcess\InjectedBundle\API -I..\..\Source\WebKit\WebProcess\InjectedBundle\API\c -I..\..\Source\WebKit\WebProcess\InjectedBundle\DOM -I..\..\Source\WebKit\WebProcess\Launching -I..\..\Source\WebKit\WebProcess\MediaCache -I..\..\Source\WebKit\WebProcess\MediaStream -I..\..\Source\WebKit\WebProcess\Network -I..\..\Source\WebKit\WebProcess\Network\webrtc -I..\..\Source\WebKit\WebProcess\Notifications -I..\..\Source\WebKit\WebProcess\OriginData -I..\..\Source\WebKit\WebProcess\Plugins -I..\..\Source\WebKit\WebProcess\Plugins\Netscape -I..\..\Source\WebKit\WebProcess\ResourceCache -I..\..\Source\WebKit\WebProcess\Storage -I..\..\Source\WebKit\WebProcess\UserContent -I..\..\Source\WebKit\WebProcess\WebCoreSupport -I..\..\Source\WebKit\WebProcess\WebPage -I..\..\Source\WebKit\WebProcess\WebPage\RemoteLayerTree -I..\..\Source\WebKit\WebProcess\WebStorage -IDerivedSources\WebKit -IDerivedSources\WebKit\include -I..\..\Source -I..\..\WebKitLibraries -I..\..\Source\ThirdParty\ANGLE -I..\..\Source\ThirdParty\ANGLE\include\KHR -I..\..\Source\WebKit\NetworkProcess\win -I..\..\Source\WebKit\Platform\classifier -I..\..\Source\WebKit\PluginProcess\win -I..\..\Source\WebKit\Shared\API\c\win -I..\..\Source\WebKit\Shared\CoordinatedGraphics -I..\..\Source\WebKit\Shared\CoordinatedGraphics\threadedcompositor -I..\..\Source\WebKit\Shared\Plugins\win -I..\..\Source\WebKit\Shared\unix -I..\..\Source\WebKit\Shared\win -I..\..\Source\WebKit\StorageProcess\win -I..\..\Source\WebKit\UIProcess\API\C\cairo -I..\..\Source\WebKit\UIProcess\API\C\win -I..\..\Source\WebKit\UIProcess\API\cpp\win -I..\..\Source\WebKit\UIProcess\API\win -I..\..\Source\WebKit\UIProcess\Plugins\win -I..\..\Source\WebKit\UIProcess\win -I..\..\Source\WebKit\WebProcess\InjectedBundle\API\win -I..\..\Source\WebKit\WebProcess\InjectedBundle\API\win\DOM -I..\..\Source\WebKit\WebProcess\win -I..\..\Source\WebKit\WebProcess\WebCoreSupport\win -I..\..\Source\WebKit\WebProcess\WebPage\CoordinatedGraphics -I..\..\Source\WebKit\WebProcess\WebPage\win -I..\..\Source\WebKit\win -I..\..\Source\WebCore\platform\network\curl -I..\..\Source\WebKit\NetworkProcess\curl -I..\..\Source\WebKit\WebProcess\WebCoreSupport\curl -I..\..\WebKitLibraries\win\include\cairo -I. -I..\..\Source\WebCore -I..\..\Source\WebCore\Modules\airplay -I..\..\Source\WebCore\Modules\beacon -I..\..\Source\WebCore\Modules\applepay -I..\..\Source\WebCore\Modules\applepay\paymentrequest -I..\..\Source\WebCore\Modules\cache -I..\..\Source\WebCore\Modules\credentialmanagement -I..\..\Source\WebCore\Modules\encryptedmedia -I..\..\Source\WebCore\Modules\encryptedmedia\legacy -I..\..\Source\WebCore\Modules\entriesapi -I..\..\Source\WebCore\Modules\fetch -I..\..\Source\WebCore\Modules\geolocation -I..\..\Source\WebCore\Modules\indexeddb -I..\..\Source\WebCore\Modules\indexeddb\client -I..\..\Source\WebCore\Modules\indexeddb\server -I..\..\Source\WebCore\Modules\indexeddb\shared -I..\..\Source\WebCore\Modules\mediacapabilities -I..\..\Source\WebCore\Modules\mediacontrols -I..\..\Source\WebCore\Modules\mediasession -I..\..\Source\WebCore\Modules\mediasource -I..\..\Source\WebCore\Modules\mediastream -I..\..\Source\WebCore\Modules\navigatorcontentutils -I..\..\Source\WebCore\Modules\notifications -I..\..\Source\WebCore\Modules\paymentrequest -I..\..\Source\WebCore\Modules\plugins -I..\..\Source\WebCore\Modules\quota -I..\..\Source\WebCore\Modules\speech -I..\..\Source\WebCore\Modules\streams -I..\..\Source\WebCore\Modules\webaudio -I..\..\Source\WebCore\Modules\webauthn -I..\..\Source\WebCore\Modules\webdatabase -I..\..\Source\WebCore\Modules\webdriver -I..\..\Source\WebCore\Modules\websockets -I..\..\Source\WebCore\Modules\webvr -I..\..\Source\WebCore\accessibility -I..\..\Source\WebCore\animation -I..\..\Source\WebCore\bindings -I..\..\Source\WebCore\bindings\js -I..\..\Source\WebCore\bridge -I..\..\Source\WebCore\bridge\c -I..\..\Source\WebCore\bridge\jsc -I..\..\Source\WebCore\contentextensions -I..\..\Source\WebCore\crypto -I..\..\Source\WebCore\crypto\algorithms -I..\..\Source\WebCore\crypto\keys -I..\..\Source\WebCore\crypto\parameters -I..\..\Source\WebCore\css -I..\..\Source\WebCore\css\parser -I..\..\Source\WebCore\cssjit -I..\..\Source\WebCore\dom -I..\..\Source\WebCore\dom\default -I..\..\Source\WebCore\dom\messageports -I..\..\Source\WebCore\domjit -I..\..\Source\WebCore\editing -I..\..\Source\WebCore\fileapi -I..\..\Source\WebCore\history -I..\..\Source\WebCore\html -I..\..\Source\WebCore\html\canvas -I..\..\Source\WebCore\html\forms -I..\..\Source\WebCore\html\parser -I..\..\Source\WebCore\html\shadow -I..\..\Source\WebCore\html\track -I..\..\Source\WebCore\inspector -I..\..\Source\WebCore\inspector\agents -I..\..\Source\WebCore\inspector\agents\page -I..\..\Source\WebCore\inspector\agents\worker -I..\..\Source\WebCore\loader -I..\..\Source\WebCore\loader\appcache -I..\..\Source\WebCore\loader\archive -I..\..\Source\WebCore\loader\archive\mhtml -I..\..\Source\WebCore\loader\cache -I..\..\Source\WebCore\loader\icon -I..\..\Source\WebCore\mathml -I..\..\Source\WebCore\page -I..\..\Source\WebCore\page\animation -I..\..\Source\WebCore\page\csp -I..\..\Source\WebCore\page\scrolling -I..\..\Source\WebCore\platform -I..\..\Source\WebCore\platform\animation -I..\..\Source\WebCore\platform\audio -I..\..\Source\WebCore\platform\crypto -I..\..\Source\WebCore\platform\encryptedmedia -I..\..\Source\WebCore\platform\gamepad -I..\..\Source\WebCore\platform\graphics -I..\..\Source\WebCore\platform\graphics\cpu\arm -I..\..\Source\WebCore\platform\graphics\cpu\arm\filters -I..\..\Source\WebCore\platform\graphics\displaylists -I..\..\Source\WebCore\platform\graphics\filters -I..\..\Source\WebCore\platform\graphics\harfbuzz -I..\..\Source\WebCore\platform\graphics\harfbuzz\ng -I..\..\Source\WebCore\platform\graphics\iso -I..\..\Source\WebCore\platform\graphics\opentype -I..\..\Source\WebCore\platform\graphics\transforms -I..\..\Source\WebCore\platform\mediastream -I..\..\Source\WebCore\platform\mediastream\libwebrtc -I..\..\Source\WebCore\platform\mock -I..\..\Source\WebCore\platform\mock\mediasource -I..\..\Source\WebCore\platform\network -I..\..\Source\WebCore\platform\sql -I..\..\Source\WebCore\platform\text -I..\..\Source\WebCore\platform\text\icu -I..\..\Source\WebCore\platform\vr -I..\..\Source\WebCore\plugins -I..\..\Source\WebCore\rendering -I..\..\Source\WebCore\rendering\line -I..\..\Source\WebCore\rendering\mathml -I..\..\Source\WebCore\rendering\shapes -I..\..\Source\WebCore\rendering\style -I..\..\Source\WebCore\rendering\svg -I..\..\Source\WebCore\rendering\updating -I..\..\Source\WebCore\replay -I..\..\Source\WebCore\storage -I..\..\Source\WebCore\style -I..\..\Source\WebCore\svg -I..\..\Source\WebCore\svg\animation -I..\..\Source\WebCore\svg\graphics -I..\..\Source\WebCore\svg\graphics\filters -I..\..\Source\WebCore\svg\properties -I..\..\Source\WebCore\websockets -I..\..\Source\WebCore\workers -I..\..\Source\WebCore\workers\service -I..\..\Source\WebCore\workers\service\context -I..\..\Source\WebCore\workers\service\server -I..\..\Source\WebCore\xml -I..\..\Source\WebCore\xml\parser -IDerivedSources\WebCore -IDerivedSources\ForwardingHeaders\ANGLE -I..\..\Source\WebCore\platform\graphics\gpu -IDerivedSources\ForwardingHeaders -I..\include\private -I..\include\private\JavaScriptCore -I..\..\Source\WebCore\accessibility\win -I..\..\Source\WebCore\page\win -I..\..\Source\WebCore\platform\graphics\egl -I..\..\Source\WebCore\platform\graphics\opengl -I..\..\Source\WebCore\platform\graphics\win -I..\..\Source\WebCore\platform\mediacapabilities -I..\..\Source\WebCore\platform\network\win -I..\..\Source\WebCore\platform\win -I..\..\Source\ThirdParty\ANGLE\include -I..\..\Source\ThirdParty\ANGLE\include\egl -I..\..\Source\WebCore\platform\cf -I..\..\Source\WebCore\platform\cf\win -I..\..\Source\WebCore\platform\graphics\cairo -I..\..\Source\WebCore\platform\image-decoders -I..\..\Source\WebCore\platform\image-decoders\bmp -I..\..\Source\WebCore\platform\image-decoders\gif -I..\..\Source\WebCore\platform\image-decoders\ico -I..\..\Source\WebCore\platform\image-decoders\jpeg -I..\..\Source\WebCore\platform\image-decoders\png -I..\..\Source\WebCore\platform\image-decoders\webp -I..\..\Source\WebCore\platform\graphics\texmap -I..\..\Source\WebCore\loader\archive\cf -I..\..\Source\bmalloc -IDerivedSources -I..\..\Source\ThirdParty /DWIN32 /D_WINDOWS /W4 /GR- /EHs- /EHc- /MD /O2 /Ob2 /DNDEBUG /wd4018 /wd4068 /wd4099 /wd4100 /wd4127 /wd4138 /wd4146 /wd4180 /wd4189 /wd4201 /wd4206 /wd4244 /wd4251 /wd4267 /wd4275 /wd4288 /wd4291 /wd4305 /wd4309 /wd4344 /wd4355 /wd4389 /wd4396 /wd4456 /wd4457 /wd4458 /wd4459 /wd4481 /wd4503 /wd4505 /wd4510 /wd4512 /wd4530 /wd4610 /wd4611 /wd4646 /wd4702 /wd4706 /wd4722 /wd4800 /wd4819 /wd4951 /wd4952 /wd4996 /wd6011 /wd6031 /wd6211 /wd6246 /wd6255 /wd6387 /Zi /GS /EHa- /EHc- /EHs- /fp:except- /analyze- /bigobj /std:c++17 /utf-8 /validate-charset /Oy- /showIncludes /FoSource\WebKit\CMakeFiles\WebKit.dir\__\__\DerivedSources\WebKit\unified-sources\UnifiedSource43.cpp.obj /FdSource\WebKit\CMakeFiles\WebKit.dir\ /FS -c DerivedSources\WebKit\unified-sources\UnifiedSource43.cpp > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\javascriptcore\X86Assembler.h(108): error C2666: 'WebCore::operator -': 7 overloads have similar conversions > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\FontSelectionAlgorithm.h(119): note: could be 'WebCore::FontSelectionValue WebCore::operator -(WebCore::FontSelectionValue,WebCore::FontSelectionValue)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\FloatPoint3D.h(156): note: or 'WebCore::FloatPoint3D WebCore::operator -(const WebCore::FloatPoint3D &,const WebCore::FloatPoint3D &)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\LayoutPoint.h(140): note: or 'WebCore::LayoutPoint WebCore::operator -(const WebCore::LayoutPoint &,const WebCore::LayoutSize &)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\LayoutPoint.h(135): note: or 'WebCore::LayoutSize WebCore::operator -(const WebCore::LayoutPoint &,const WebCore::LayoutPoint &)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\LayoutSize.h(162): note: or 'WebCore::LayoutSize WebCore::operator -(const WebCore::LayoutSize &,const WebCore::LayoutSize &)' > C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore/FloatPoint.h(229): note: or 'WebCore::FloatPoint WebCore::operator -(const WebCore::FloatPoint &,const WebCore::FloatSize &)' > C:\WebKit-BuildWorker\wincairo-wkl-release\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\WebCore/FloatPoint.h(224): note: or 'WebCore::FloatSize WebCore::operator -(const WebCore::FloatPoint &,const WebCore::FloatPoint &)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\FloatSize.h(180): note: or 'WebCore::FloatSize WebCore::operator -(const WebCore::FloatSize &,const WebCore::FloatSize &)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\IntRect.h(237): note: or 'WebCore::IntRect WebCore::operator -(const WebCore::IntRect &,const WebCore::IntPoint &)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\LayoutUnit.h(655): note: or 'float WebCore::operator -(const float,const WebCore::LayoutUnit &)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\LayoutUnit.h(650): note: or 'WebCore::LayoutUnit WebCore::operator -(const int,const WebCore::LayoutUnit &)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\LayoutUnit.h(645): note: or 'float WebCore::operator -(const WebCore::LayoutUnit &,float)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\LayoutUnit.h(640): note: or 'WebCore::LayoutUnit WebCore::operator -(const WebCore::LayoutUnit &,unsigned int)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\LayoutUnit.h(635): note: or 'WebCore::LayoutUnit WebCore::operator -(const WebCore::LayoutUnit &,int)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\LayoutUnit.h(628): note: or 'WebCore::LayoutUnit WebCore::operator -(const WebCore::LayoutUnit &,const WebCore::LayoutUnit &)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\IntPoint.h(184): note: or 'WebCore::IntPoint WebCore::operator -(const WebCore::IntPoint &,const WebCore::IntSize &)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\IntPoint.h(179): note: or 'WebCore::IntSize WebCore::operator -(const WebCore::IntPoint &,const WebCore::IntPoint &)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\webcore\IntSize.h(198): note: or 'WebCore::IntSize WebCore::operator -(const WebCore::IntSize &,const WebCore::IntSize &)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\javascriptcore\X86Assembler.h(108): note: or 'built-in C++ operator-(JSC::X86Assembler::RegisterID, JSC::X86Assembler::RegisterID)' > c:\webkit-buildworker\wincairo-wkl-release\build\webkitbuild\release\derivedsources\forwardingheaders\javascriptcore\X86Assembler.h(108): note: while trying to match the argument list '(JSC::X86Assembler::RegisterID, JSC::X86Assembler::RegisterID)' 1458067 1 fujii 2018-09-09 20:21:36 -0700 This reminds me Bug 188589 Comment 29. 1458068 2 fujii 2018-09-09 21:44:10 -0700 This happens since Bug 189400 change. 1458069 3 349295 fujii 2018-09-09 21:44:59 -0700 Created attachment 349295 Patch 1458071 4 349295 fujii 2018-09-09 21:55:53 -0700 Comment on attachment 349295 Patch Clearing flags on attachment: 349295 Committed r235839: <https://trac.webkit.org/changeset/235839> 1458072 5 fujii 2018-09-09 21:55:56 -0700 All reviewed patches have been landed. Closing bug. 1458073 6 webkit-bug-importer 2018-09-09 21:56:22 -0700 <rdar://problem/44290945> 1458074 7 fujii 2018-09-09 21:56:41 -0700 Reopen to find a solution. 1458075 8 webkit-bug-importer 2018-09-09 21:56:57 -0700 <rdar://problem/44290955> 1458082 9 fujii 2018-09-09 22:38:02 -0700 Reverted r235839 for reason: Which breaks all Xcode based ports Committed r235842: <https://trac.webkit.org/changeset/235842> 1458094 10 349298 fujii 2018-09-10 00:35:47 -0700 Created attachment 349298 Patch 1458105 11 349298 fujii 2018-09-10 01:58:36 -0700 Comment on attachment 349298 Patch Clearing flags on attachment: 349298 Committed r235845: <https://trac.webkit.org/changeset/235845> 1458118 12 fujii 2018-09-10 03:47:05 -0700 This is a MSVC bug fixed in the latest. https://developercommunity.visualstudio.com/content/problem/315575/overload-resolution-for-built-in-operator-and-enum.html WebKit can't update MSVC due to other bug (Bug 188635). This issue happens under following conditions: * LayoutUnit has non-explicit constructors * using namespace WebCore * X86Assembler.h is included after using namespace WebCore There are possible workarounds: * Include programmatic JSC header files before using namespace * Remove all "using namespace {WebCore|WebKit};" in Source/WebKit/WebProcess/InjectedBundle/API/c/*.cpp * Remove non-explicit constructors of LayoutUnit * Do not unify source files in Source/WebKit/WebProcess/InjectedBundle/API/c/*.cpp * Update MSVC (Bug 188635) 1465942 13 fujii 2018-10-03 00:09:38 -0700 Remaining Task: r235845 <https://trac.webkit.org/changeset/235845> should be reverted after the MSVC issue will be fixed and WinCairo build bots will be switched to the new VS (Bug 189987). 1479185 14 349298 achristensen 2018-11-15 17:18:11 -0800 Comment on attachment 349298 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349298&action=review > Source/WebKit/ChangeLog:9 > + MSVC reports compilation errors if certain JSC header files are > + included after "using namespace" statements. I think we should probably remove the "using namespace" statements in question. 1479704 15 fujii 2018-11-16 15:59:38 -0800 This issue happens several times. And, it seems that it will take more time for Microsoft to fix the bug. We need a effective workaround not to repeat this issue until they fix MSVC. I think I should remove ": int8_t" of RegisterID only for COMPILER(MSVC). 1480119 16 355252 fujii 2018-11-18 21:13:04 -0800 Created attachment 355252 Patch 1480126 17 355252 mark.lam 2018-11-18 21:28:21 -0800 Comment on attachment 355252 Patch r=me 1480181 18 fujii 2018-11-19 03:05:05 -0800 Thank you very much for the review. I'd like to wait for hours to get more feedbacks before landing. 1480339 19 355252 fujii 2018-11-19 17:38:40 -0800 Comment on attachment 355252 Patch Clearing flags on attachment: 355252 Committed r238386: <https://trac.webkit.org/changeset/238386> 1480340 20 fujii 2018-11-19 17:38:44 -0800 All reviewed patches have been landed. Closing bug. 1480392 21 fujii 2018-11-19 23:01:35 -0800 Reopening to attach new patch. 1480393 22 355314 fujii 2018-11-19 23:02:08 -0800 Created attachment 355314 Patch 1480394 23 355314 mark.lam 2018-11-19 23:04:10 -0800 Comment on attachment 355314 Patch You should do this in a separate bug. Our practice is 1 change per bug. 1480397 24 fujii 2018-11-19 23:18:37 -0800 (In reply to Mark Lam from comment #23) > You should do this in a separate bug. Our practice is 1 change per bug. Agreed. Thank you for the feedback. I will do so. 349295 2018-09-09 21:44:59 -0700 2018-11-19 23:19:59 -0800 Patch bug-189467-20180910134458.patch text/plain 1773 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1ODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ5ZjE4OGJjN2VkZmE0ZGE5 Y2JlOTJmNWRjZGRhNWJhOTQ2MDQ3YzkuLmFlNmZjYWU4NTZkZDIyNjExOGM1NWZlNDY0MzdiY2Mz MzkzMWRjZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDktMDkgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW01TVkNdIFg4NkFz c2VtYmxlci5oKDEwOCk6IGVycm9yIEMyNjY2OiAnV2ViQ29yZTo6b3BlcmF0b3IgLSc6IDcgb3Zl cmxvYWRzIGhhdmUgc2ltaWxhciBjb252ZXJzaW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5NDY3CisKKyAgICAgICAgVW5yZXZpZXdlZCBidWls ZCBmaXggZm9yIFdpbkNhaXJvIHBvcnQuCisKKyAgICAgICAgTVNWQyByZXBvcnRzIGNvbXBpbGF0 aW9uIGVycm9ycyBpZiBjZXJ0YWluIEpTQyBoZWFkZXIgZmlsZXMgYXJlCisgICAgICAgIGluY2x1 ZGVkIGFmdGVyICJ1c2luZyBuYW1lc3BhY2UiIHN0YXRlbWVudHMuCisKKyAgICAgICAgKiBTb3Vy Y2VzLnR4dDogQWRkZWQgQG5vLXVuaWZ5IHRvIEluamVjdGVkQnVuZGxlTm9kZUhhbmRsZS5jcHAg YW5kIEluamVjdGVkQnVuZGxlUmFuZ2VIYW5kbGUuY3BwIHRlbXBvcmFyaWx5LgorCiAyMDE4LTA5 LTA4ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFJF R1JFU1NJT04gKHIyMzUxNTMpOiBbaU9TXSBDYW4ndCBtb3ZlIHNlbGVjdGlvbiBzdGFydCBncmFi YmVyIHdoZW4gc2VsZWN0aW5nIHRleHQgaW4gYSBzdWJmcmFtZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9Tb3VyY2VzLnR4dCBiL1NvdXJjZS9XZWJLaXQvU291cmNlcy50eHQKaW5kZXggMGQ5 OTQ1YzVhNTdhOGE0NmNlMDAzNDFkZWMwMjllYjcxYTY5OWZlMy4uOTQ3Y2ZkNDc0NDIyMDZlNjQ5 NDJiZDkwNzNiYzEzMWNmYzkzYjM1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9Tb3VyY2Vz LnR4dAorKysgYi9Tb3VyY2UvV2ViS2l0L1NvdXJjZXMudHh0CkBAIC00NTEsOCArNDUxLDggQEAg V2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVNjcmlwdFdvcmxkLmNwcAog CiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0RPTS9JbmplY3RlZEJ1bmRsZUNTU1N0eWxlRGVj bGFyYXRpb25IYW5kbGUuY3BwCiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0RPTS9JbmplY3Rl ZEJ1bmRsZUZpbGVIYW5kbGUuY3BwCi1XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0RPTS9Jbmpl Y3RlZEJ1bmRsZU5vZGVIYW5kbGUuY3BwCi1XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0RPTS9J bmplY3RlZEJ1bmRsZVJhbmdlSGFuZGxlLmNwcAorV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9E T00vSW5qZWN0ZWRCdW5kbGVOb2RlSGFuZGxlLmNwcCBAbm8tdW5pZnkKK1dlYlByb2Nlc3MvSW5q ZWN0ZWRCdW5kbGUvRE9NL0luamVjdGVkQnVuZGxlUmFuZ2VIYW5kbGUuY3BwIEBuby11bmlmeQog CiBXZWJQcm9jZXNzL01lZGlhU3RyZWFtL01lZGlhRGV2aWNlU2FuZGJveEV4dGVuc2lvbnMuY3Bw CiBXZWJQcm9jZXNzL01lZGlhU3RyZWFtL1VzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWFuYWdl ci5jcHAK 349298 2018-09-10 00:35:47 -0700 2018-11-18 21:12:29 -0800 Patch bug-189467-20180910163546.patch text/plain 4227 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1ODQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY3YTM4NDk1Y2RkYmNkMjg4 NWY4M2ZiODQwNjE2YjA5ZTcxNGYwNDQuLjVlMWQ4MDQ0MGU4N2ZmZjQ0NmJiMDc4NzNkOGY4OTY2 YmJmOTU3MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDktMTAgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW01TVkNdIFg4NkFz c2VtYmxlci5oKDEwOCk6IGVycm9yIEMyNjY2OiAnV2ViQ29yZTo6b3BlcmF0b3IgLSc6IDcgb3Zl cmxvYWRzIGhhdmUgc2ltaWxhciBjb252ZXJzaW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5NDY3CisKKyAgICAgICAgVW5yZXZpZXdlZCBidWls ZCBmaXggZm9yIFdpbkNhaXJvIHBvcnQuCisKKyAgICAgICAgTVNWQyByZXBvcnRzIGNvbXBpbGF0 aW9uIGVycm9ycyBpZiBjZXJ0YWluIEpTQyBoZWFkZXIgZmlsZXMgYXJlCisgICAgICAgIGluY2x1 ZGVkIGFmdGVyICJ1c2luZyBuYW1lc3BhY2UiIHN0YXRlbWVudHMuCisKKyAgICAgICAgKiBTb3Vy Y2VzLnR4dDogQWRkZWQgQG5vLXVuaWZ5IHRvIEluamVjdGVkQnVuZGxlTm9kZUhhbmRsZS5jcHAg YW5kIEluamVjdGVkQnVuZGxlUmFuZ2VIYW5kbGUuY3BwIHRlbXBvcmFyaWx5LgorICAgICAgICAq IFdlYktpdC54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOiBDb21waWxlIEluamVjdGVkQnVuZGxl Tm9kZUhhbmRsZS5jcHAgYW5kIEluamVjdGVkQnVuZGxlUmFuZ2VIYW5kbGUuY3BwLgorCiAyMDE4 LTA5LTA5ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMzU4MzkuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1NvdXJjZXMudHh0IGIvU291cmNlL1dlYktpdC9Tb3VyY2VzLnR4dAppbmRleCAwZDk5 NDVjNWE1N2E4YTQ2Y2UwMDM0MWRlYzAyOWViNzFhNjk5ZmUzLi45NDdjZmQ0NzQ0MjIwNmU2NDk0 MmJkOTA3M2JjMTMxY2ZjOTNiMzU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NvdXJjZXMu dHh0CisrKyBiL1NvdXJjZS9XZWJLaXQvU291cmNlcy50eHQKQEAgLTQ1MSw4ICs0NTEsOCBAQCBX ZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlU2NyaXB0V29ybGQuY3BwCiAK IFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvRE9NL0luamVjdGVkQnVuZGxlQ1NTU3R5bGVEZWNs YXJhdGlvbkhhbmRsZS5jcHAKIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvRE9NL0luamVjdGVk QnVuZGxlRmlsZUhhbmRsZS5jcHAKLVdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvRE9NL0luamVj dGVkQnVuZGxlTm9kZUhhbmRsZS5jcHAKLVdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvRE9NL0lu amVjdGVkQnVuZGxlUmFuZ2VIYW5kbGUuY3BwCitXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0RP TS9JbmplY3RlZEJ1bmRsZU5vZGVIYW5kbGUuY3BwIEBuby11bmlmeQorV2ViUHJvY2Vzcy9Jbmpl Y3RlZEJ1bmRsZS9ET00vSW5qZWN0ZWRCdW5kbGVSYW5nZUhhbmRsZS5jcHAgQG5vLXVuaWZ5CiAK IFdlYlByb2Nlc3MvTWVkaWFTdHJlYW0vTWVkaWFEZXZpY2VTYW5kYm94RXh0ZW5zaW9ucy5jcHAK IFdlYlByb2Nlc3MvTWVkaWFTdHJlYW0vVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2Vy LmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJLaXQueGNvZGVwcm9qL3Byb2plY3Qu cGJ4cHJvaiBiL1NvdXJjZS9XZWJLaXQvV2ViS2l0Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oK aW5kZXggN2JkYWM2MGZjMzJiNjA3MzdlNmVkMTFmNjE3Nzk0MTA1MGY3NTcwYS4uMTljYTM1ZDcz YzM5NjNkZGJmMjMzZDdjZDU1ODRkN2IyYjMwMmM5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9XZWJLaXQueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagorKysgYi9Tb3VyY2UvV2ViS2l0L1dl YktpdC54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCkBAIC00MTIsNiArNDEyLDggQEAKIAkJMjZG MTBCRTgxOTE4N0UyRTAwMUQwRTY4IC8qIFdLU3ludGhldGljQ2xpY2tUYXBHZXN0dXJlUmVjb2du aXplci5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gMjZG MTBCRTYxOTE4N0UyRTAwMUQwRTY4IC8qIFdLU3ludGhldGljQ2xpY2tUYXBHZXN0dXJlUmVjb2du aXplci5oICovOyB9OwogCQkyNkYxMEJFOTE5MTg3RTJFMDAxRDBFNjggLyogV0tTeW50aGV0aWND bGlja1RhcEdlc3R1cmVSZWNvZ25pemVyLm0gaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWls ZEZpbGU7IGZpbGVSZWYgPSAyNkYxMEJFNzE5MTg3RTJFMDAxRDBFNjggLyogV0tTeW50aGV0aWND bGlja1RhcEdlc3R1cmVSZWNvZ25pemVyLm0gKi87IH07CiAJCTI2RjlBODNCMThBMzQ2ODEwMEFF Qjg4QSAvKiBXS1dlYlZpZXdQcml2YXRlLmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWls ZEZpbGU7IGZpbGVSZWYgPSAyNkY5QTgzQTE4QTM0NjNGMDBBRUI4OEEgLyogV0tXZWJWaWV3UHJp dmF0ZS5oICovOyBzZXR0aW5ncyA9IHtBVFRSSUJVVEVTID0gKFByaXZhdGUsICk7IH07IH07CisJ CTI3NDlGNjQ0MjE0NjU2MUIwMDgzODBCRiAvKiBJbmplY3RlZEJ1bmRsZU5vZGVIYW5kbGUuY3Bw IGluIFNvdXJjZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gQkM0QkVFQUEx MjBBMEE1RjAwRkJBMEM3IC8qIEluamVjdGVkQnVuZGxlTm9kZUhhbmRsZS5jcHAgKi87IH07CisJ CTI3NDlGNjQ1MjE0NjU2MUUwMDgzODBCRiAvKiBJbmplY3RlZEJ1bmRsZVJhbmdlSGFuZGxlLmNw cCBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IEJDMzNFMEQw MTI0MDhFODYwMDM2MEYzRiAvKiBJbmplY3RlZEJ1bmRsZVJhbmdlSGFuZGxlLmNwcCAqLzsgfTsK IAkJMjkwRjQyNzIxNzJBMEM3NDAwOTM5RkYwIC8qIENoaWxkUHJvY2Vzc1N1cHBsZW1lbnQuaCBp biBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDI5MEY0MjcxMTcy QTBDNzQwMDkzOUZGMCAvKiBDaGlsZFByb2Nlc3NTdXBwbGVtZW50LmggKi87IH07CiAJCTI5MjMy REY0MThCMjlENjgwMEQwNTk2RiAvKiBXS0FjY2Vzc2liaWxpdHlXZWJQYWdlT2JqZWN0TWFjLmgg aW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSAyOTIzMkRGMzE4 QjI5RDY4MDBEMDU5NkYgLyogV0tBY2Nlc3NpYmlsaXR5V2ViUGFnZU9iamVjdE1hYy5oICovOyB9 OwogCQkyOTNFQkVBQjE2MjdEOUM5MDA1Rjg5RjEgLyogV0tET01UZXh0LmggaW4gSGVhZGVycyAq LyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSAyOTNFQkVBOTE2MjdEOUM5MDA1Rjg5 RjEgLyogV0tET01UZXh0LmggKi87IHNldHRpbmdzID0ge0FUVFJJQlVURVMgPSAoUHJpdmF0ZSwg KTsgfTsgfTsKQEAgLTEwNjM2LDYgKzEwNjM4LDggQEAKIAkJCQkxQTY0MjMwODEyREQwOUVCMDBD QUFFMkMgLyogRHJhd2luZ0FyZWFQcm94eU1lc3NhZ2VSZWNlaXZlci5jcHAgaW4gU291cmNlcyAq LywKIAkJCQkyRDkyQTc4MDIxMkI2QTcxMDBGNDkzRkQgLyogRW5jb2Rlci5jcHAgaW4gU291cmNl cyAqLywKIAkJCQkxQUE1NzYwMjE0OTZCOTc5MDBBNEVFMDYgLyogRXZlbnREaXNwYXRjaGVyTWVz c2FnZVJlY2VpdmVyLmNwcCBpbiBTb3VyY2VzICovLAorCQkJCTI3NDlGNjQ0MjE0NjU2MUIwMDgz ODBCRiAvKiBJbmplY3RlZEJ1bmRsZU5vZGVIYW5kbGUuY3BwIGluIFNvdXJjZXMgKi8sCisJCQkJ Mjc0OUY2NDUyMTQ2NTYxRTAwODM4MEJGIC8qIEluamVjdGVkQnVuZGxlUmFuZ2VIYW5kbGUuY3Bw IGluIFNvdXJjZXMgKi8sCiAJCQkJMkQ5MTM0NDEyMTJDRjlGMDAwMTI4QUZEIC8qIEpTTlBNZXRo b2QuY3BwIGluIFNvdXJjZXMgKi8sCiAJCQkJMkQ5MTM0NDIyMTJDRjlGMDAwMTI4QUZEIC8qIEpT TlBPYmplY3QuY3BwIGluIFNvdXJjZXMgKi8sCiAJCQkJMjk4NEY1ODgxNjRCQTA5NTAwNEJDMEM2 IC8qIExlZ2FjeUN1c3RvbVByb3RvY29sTWFuYWdlck1lc3NhZ2VSZWNlaXZlci5jcHAgaW4gU291 cmNlcyAqLywK 355252 2018-11-18 21:13:04 -0800 2018-11-19 23:19:34 -0800 Patch bug-189467-20181119141303.patch text/plain 2100 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 ZjZmZTU1NTc0ZmJjZTVmYWNlZDU5YjBiNzRlMTFlNWQ0NGZkZjQyLi5mNDdmN2Y3ZWYxNWEwNjIw OWE3NGRhYmU5ZTgzYWM3YzA4MTY4Njk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxOC0xMS0xOCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBbTVNWQ10gWDg2QXNzZW1ibGVyLmgoMTA4KTogZXJyb3IgQzI2 NjY6ICdXZWJDb3JlOjpvcGVyYXRvciAtJzogNyBvdmVybG9hZHMgaGF2ZSBzaW1pbGFyIGNvbnZl cnNpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODk0NjcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ0MjkwOTQ1PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXNzdWUgaGFzIGhhcHBlbmVk IHNldmVyYWwgdGltZXMuIEFuZCwgaXQgc2VlbXMgdGhhdCBpdCB3aWxsCisgICAgICAgIHRha2Ug bW9yZSB0aW1lIGZvciBNaWNyb3NvZnQgdG8gZml4IHRoZSBNU1ZDIGJ1Zy4gV2UgbmVlZCBhCisg ICAgICAgIGVmZmVjdGl2ZSB3b3JrYXJvdW5kIG5vdCB0byByZXBlYXQgdGhpcyBpc3N1ZSB1bnRp bCB0aGV5IGZpeCBNU1ZDLgorCisgICAgICAgIFJlbW92ZSAiOiBpbnQ4X3QiIG9mIFJlZ2lzdGVy SUQgb25seSBmb3IgQ09NUElMRVIoTVNWQykuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvWDg2QXNz ZW1ibGVyLmg6IEFkZGVkIEpTQ19YODZfQVNNX1JFR0lTVEVSX0lEX0VOVU1fQkFTRV9UWVBFIG1h Y3JvLgorCiAyMDE4LTExLTE4ICBZdXN1a2UgU3V6dWtpICA8eXVzdWtlc3V6dWtpQHNsb3dzdGFy dC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBpbiB0aGUgcmVzdCBvZiByMjM3 MjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1g4NkFzc2Vt Ymxlci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9YODZBc3NlbWJsZXIuaApp bmRleCBkMDgwZTc1YTFkZTFlOTRiYTA3ZDRjMzM5MmYxMjdlMTY2ZDkyZDhmLi4wNmNiOWUxNzFh ZmIxZGM1M2U0ODU0NWEwYzBhYTBjNmFiZWJjODliIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvYXNzZW1ibGVyL1g4NkFzc2VtYmxlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmgKQEAgLTQxLDcgKzQxLDEzIEBAIGlubGluZSBi b29sIENBTl9TSUdOX0VYVEVORF84XzMyKGludDMyX3QgdmFsdWUpIHsgcmV0dXJuIHZhbHVlID09 IChpbnQzMl90KShzaWduCiAKIG5hbWVzcGFjZSBYODZSZWdpc3RlcnMgewogCi10eXBlZGVmIGVu dW0gOiBpbnQ4X3QgeworI2lmIENPTVBJTEVSKE1TVkMpCisjZGVmaW5lIEpTQ19YODZfQVNNX1JF R0lTVEVSX0lEX0VOVU1fQkFTRV9UWVBFCisjZWxzZQorI2RlZmluZSBKU0NfWDg2X0FTTV9SRUdJ U1RFUl9JRF9FTlVNX0JBU0VfVFlQRSA6IGludDhfdAorI2VuZGlmCisKK3R5cGVkZWYgZW51bSBK U0NfWDg2X0FTTV9SRUdJU1RFUl9JRF9FTlVNX0JBU0VfVFlQRSB7CiAgICAgZWF4LAogICAgIGVj eCwKICAgICBlZHgsCkBAIC02MywxMiArNjksMTIgQEAgdHlwZWRlZiBlbnVtIDogaW50OF90IHsK ICAgICBJbnZhbGlkR1BSUmVnID0gLTEsCiB9IFJlZ2lzdGVySUQ7CiAKLXR5cGVkZWYgZW51bSA6 IGludDhfdCB7Cit0eXBlZGVmIGVudW0gSlNDX1g4Nl9BU01fUkVHSVNURVJfSURfRU5VTV9CQVNF X1RZUEUgewogICAgIGVpcCwKICAgICBlZmxhZ3MKIH0gU1BSZWdpc3RlcklEOwogCi10eXBlZGVm IGVudW0gOiBpbnQ4X3QgewordHlwZWRlZiBlbnVtIEpTQ19YODZfQVNNX1JFR0lTVEVSX0lEX0VO VU1fQkFTRV9UWVBFIHsKICAgICB4bW0wLAogICAgIHhtbTEsCiAgICAgeG1tMiwK 355314 2018-11-19 23:02:08 -0800 2018-11-19 23:19:06 -0800 Patch bug-189467-20181120160207.patch text/plain 4018 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM4MzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdhYTczODQ3NTYyMmMxMDJl OTc5M2QyMWI0MTU2MDEyM2NiYTE2MTQuLjIzMzBjMzgxNjhiNzVjZTdjNzI2NmI5N2U5YzE5ZjUw ZDkxOWFmNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMTEtMTkgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW01TVkNdIFg4NkFz c2VtYmxlci5oKDEwOCk6IGVycm9yIEMyNjY2OiAnV2ViQ29yZTo6b3BlcmF0b3IgLSc6IDcgb3Zl cmxvYWRzIGhhdmUgc2ltaWxhciBjb252ZXJzaW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5NDY3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80 NDI5MDk0NT4KKworICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjM1ODQ1LgorCisg ICAgICAgIFRoaXMgd29ya2Fyb3VuZCBpcyBub3QgbmVlZGVkIHNpbmNlIHIyMzgzODYuCisKKyAg ICAgICAgKiBTb3VyY2VzLnR4dDoKKyAgICAgICAgKiBXZWJLaXQueGNvZGVwcm9qL3Byb2plY3Qu cGJ4cHJvajoKKwogMjAxOC0xMS0xOSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnku Y29tPgogCiAgICAgICAgIFNpbXBsaWZ5IHBsYXRmb3JtIGNoZWNrIGluIFdlYkVkaXRvckNsaWVu dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9Tb3VyY2VzLnR4dCBiL1NvdXJjZS9XZWJLaXQv U291cmNlcy50eHQKaW5kZXggODc2NmRmZDMwMjA5NjMxZDM5OGE1Mzk4MzhjZWE5ZmMwNGE4Nzdm YS4uMmQ0MmEwZGEwMGE2NjQzODBhMmM4MDRkOThiN2E4MWNlMzhkMTVhMCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9Tb3VyY2VzLnR4dAorKysgYi9Tb3VyY2UvV2ViS2l0L1NvdXJjZXMudHh0 CkBAIC00NTYsOCArNDU2LDggQEAgV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1 bmRsZVJhbmdlSGFuZGxlLmNwcAogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1 bmRsZVNjcmlwdFdvcmxkLmNwcAogCiBXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0RPTS9Jbmpl Y3RlZEJ1bmRsZUNTU1N0eWxlRGVjbGFyYXRpb25IYW5kbGUuY3BwCi1XZWJQcm9jZXNzL0luamVj dGVkQnVuZGxlL0RPTS9JbmplY3RlZEJ1bmRsZU5vZGVIYW5kbGUuY3BwIEBuby11bmlmeQotV2Vi UHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9ET00vSW5qZWN0ZWRCdW5kbGVSYW5nZUhhbmRsZS5jcHAg QG5vLXVuaWZ5CitXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0RPTS9JbmplY3RlZEJ1bmRsZU5v ZGVIYW5kbGUuY3BwCitXZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0RPTS9JbmplY3RlZEJ1bmRs ZVJhbmdlSGFuZGxlLmNwcAogCiBXZWJQcm9jZXNzL01lZGlhU3RyZWFtL01lZGlhRGV2aWNlU2Fu ZGJveEV4dGVuc2lvbnMuY3BwCiBXZWJQcm9jZXNzL01lZGlhU3RyZWFtL1VzZXJNZWRpYVBlcm1p c3Npb25SZXF1ZXN0TWFuYWdlci5jcHAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViS2l0 Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2ogYi9Tb3VyY2UvV2ViS2l0L1dlYktpdC54Y29kZXBy b2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IGE5ZTVkMDcxMTBhY2QzZTIwNDE0YTkxZmUwOWM1ZGRk ZTIwMjFhZDguLmJkODE1OGMyYzY3MmU4ZjZhZDYxYTA1NWY5NWEzYmEwZTRhMTg5M2UgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViS2l0Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKKysr IGIvU291cmNlL1dlYktpdC9XZWJLaXQueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagpAQCAtNDEy LDggKzQxMiw2IEBACiAJCTI2RjEwQkU4MTkxODdFMkUwMDFEMEU2OCAvKiBXS1N5bnRoZXRpY0Ns aWNrVGFwR2VzdHVyZVJlY29nbml6ZXIuaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxk RmlsZTsgZmlsZVJlZiA9IDI2RjEwQkU2MTkxODdFMkUwMDFEMEU2OCAvKiBXS1N5bnRoZXRpY0Ns aWNrVGFwR2VzdHVyZVJlY29nbml6ZXIuaCAqLzsgfTsKIAkJMjZGMTBCRTkxOTE4N0UyRTAwMUQw RTY4IC8qIFdLU3ludGhldGljQ2xpY2tUYXBHZXN0dXJlUmVjb2duaXplci5tIGluIFNvdXJjZXMg Ki8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gMjZGMTBCRTcxOTE4N0UyRTAwMUQw RTY4IC8qIFdLU3ludGhldGljQ2xpY2tUYXBHZXN0dXJlUmVjb2duaXplci5tICovOyB9OwogCQky NkY5QTgzQjE4QTM0NjgxMDBBRUI4OEEgLyogV0tXZWJWaWV3UHJpdmF0ZS5oIGluIEhlYWRlcnMg Ki8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gMjZGOUE4M0ExOEEzNDYzRjAwQUVC ODhBIC8qIFdLV2ViVmlld1ByaXZhdGUuaCAqLzsgc2V0dGluZ3MgPSB7QVRUUklCVVRFUyA9IChQ cml2YXRlLCApOyB9OyB9OwotCQkyNzQ5RjY0NDIxNDY1NjFCMDA4MzgwQkYgLyogSW5qZWN0ZWRC dW5kbGVOb2RlSGFuZGxlLmNwcCBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsg ZmlsZVJlZiA9IEJDNEJFRUFBMTIwQTBBNUYwMEZCQTBDNyAvKiBJbmplY3RlZEJ1bmRsZU5vZGVI YW5kbGUuY3BwICovOyB9OwotCQkyNzQ5RjY0NTIxNDY1NjFFMDA4MzgwQkYgLyogSW5qZWN0ZWRC dW5kbGVSYW5nZUhhbmRsZS5jcHAgaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7 IGZpbGVSZWYgPSBCQzMzRTBEMDEyNDA4RTg2MDAzNjBGM0YgLyogSW5qZWN0ZWRCdW5kbGVSYW5n ZUhhbmRsZS5jcHAgKi87IH07CiAJCTI5MEY0MjcyMTcyQTBDNzQwMDkzOUZGMCAvKiBDaGlsZFBy b2Nlc3NTdXBwbGVtZW50LmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZp bGVSZWYgPSAyOTBGNDI3MTE3MkEwQzc0MDA5MzlGRjAgLyogQ2hpbGRQcm9jZXNzU3VwcGxlbWVu dC5oICovOyB9OwogCQkyOTIzMkRGNDE4QjI5RDY4MDBEMDU5NkYgLyogV0tBY2Nlc3NpYmlsaXR5 V2ViUGFnZU9iamVjdE1hYy5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBm aWxlUmVmID0gMjkyMzJERjMxOEIyOUQ2ODAwRDA1OTZGIC8qIFdLQWNjZXNzaWJpbGl0eVdlYlBh Z2VPYmplY3RNYWMuaCAqLzsgfTsKIAkJMjkzRUJFQUIxNjI3RDlDOTAwNUY4OUYxIC8qIFdLRE9N VGV4dC5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gMjkz RUJFQTkxNjI3RDlDOTAwNUY4OUYxIC8qIFdLRE9NVGV4dC5oICovOyBzZXR0aW5ncyA9IHtBVFRS SUJVVEVTID0gKFByaXZhdGUsICk7IH07IH07CkBAIC0xMDcxOSw4ICsxMDcxNyw2IEBACiAJCQkJ MUE2NDIzMDgxMkREMDlFQjAwQ0FBRTJDIC8qIERyYXdpbmdBcmVhUHJveHlNZXNzYWdlUmVjZWl2 ZXIuY3BwIGluIFNvdXJjZXMgKi8sCiAJCQkJMkQ5MkE3ODAyMTJCNkE3MTAwRjQ5M0ZEIC8qIEVu Y29kZXIuY3BwIGluIFNvdXJjZXMgKi8sCiAJCQkJMUFBNTc2MDIxNDk2Qjk3OTAwQTRFRTA2IC8q IEV2ZW50RGlzcGF0Y2hlck1lc3NhZ2VSZWNlaXZlci5jcHAgaW4gU291cmNlcyAqLywKLQkJCQky NzQ5RjY0NDIxNDY1NjFCMDA4MzgwQkYgLyogSW5qZWN0ZWRCdW5kbGVOb2RlSGFuZGxlLmNwcCBp biBTb3VyY2VzICovLAotCQkJCTI3NDlGNjQ1MjE0NjU2MUUwMDgzODBCRiAvKiBJbmplY3RlZEJ1 bmRsZVJhbmdlSGFuZGxlLmNwcCBpbiBTb3VyY2VzICovLAogCQkJCTJEOTEzNDQxMjEyQ0Y5RjAw MDEyOEFGRCAvKiBKU05QTWV0aG9kLmNwcCBpbiBTb3VyY2VzICovLAogCQkJCTJEOTEzNDQyMjEy Q0Y5RjAwMDEyOEFGRCAvKiBKU05QT2JqZWN0LmNwcCBpbiBTb3VyY2VzICovLAogCQkJCTI5ODRG NTg4MTY0QkEwOTUwMDRCQzBDNiAvKiBMZWdhY3lDdXN0b21Qcm90b2NvbE1hbmFnZXJNZXNzYWdl UmVjZWl2ZXIuY3BwIGluIFNvdXJjZXMgKi8sCg==