189466 2018-09-09 19:37:43 -0700 Add bindings support for representing attributes with JSValueInWrappedObject 2018-09-10 03:01:33 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=189458 P2 Normal --- 1 aestes webkit-unassigned cdumez ysuzuki oldest_to_newest 1458063 0 aestes 2018-09-09 19:37:43 -0700 In CustomEvent, History, MessageEvent, PaymentMethodChangeEvent, and PaymentResponse, we have custom bindings support for representing attributes of type object or any. These custom bindings tend to do two things: 1. Add a custom getter for an attribute of type object or any that converts the native value to a JSValue, cache that JSValue in a JSValueInWrappedObject in the wrapper class, then return the cached JSValue. 2. Add a custom mark function that visits the cached JSValueInWrappedObject as well as any other JSValueInWrappedObjects in the wrapper class. We should teach the bindings generator to do this for us for attributes of object or any type (perhaps with a custom annotation). 1458065 1 aestes 2018-09-09 19:41:24 -0700 (In reply to Andy Estes from comment #0) > In CustomEvent, History, MessageEvent, PaymentMethodChangeEvent, and > PaymentResponse, we have custom bindings support for representing attributes > of type object or any. > > These custom bindings tend to do two things: > > 1. Add a custom getter for an attribute of type object or any that converts > the native value to a JSValue, cache that JSValue in a > JSValueInWrappedObject in the wrapper class, then return the cached JSValue. > 2. Add a custom mark function that visits the cached JSValueInWrappedObject > as well as any other JSValueInWrappedObjects in the wrapper class. > > We should teach the bindings generator to do this for us for attributes of > object or any type (perhaps with a custom annotation). s/wrapper class/wrapped class