189404 2018-09-07 06:07:33 -0700 Also copy JSC when running benchmarks on remote machine 2022-12-23 04:30:19 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 227579 P2 Normal --- 1 dominik.infuehr webkit-unassigned achristensen angelos bfulgham fpizlo saam ysuzuki oldest_to_newest 1457470 0 dominik.infuehr 2018-09-07 06:07:33 -0700 Also copy JSC when running benchmarks on remote machine 1457471 1 349141 dominik.infuehr 2018-09-07 06:08:06 -0700 Created attachment 349141 Patch 1457472 2 349142 dominik.infuehr 2018-09-07 06:10:00 -0700 Created attachment 349142 Patch 1457473 3 dominik.infuehr 2018-09-07 06:15:27 -0700 When running benchmarks with `$WEBKIT/Tools/Scripts/run-jsc-benchmarks name:$BUILD_DIR/Release/bin/jsc --remote user@host`, JSC doesn't get copied onto the remote machine, only $BUILD_DIR/Release/lib is copied. 1488415 4 357435 dominik.infuehr 2018-12-17 04:37:55 -0800 Created attachment 357435 Patch 1488426 5 dominik.infuehr 2018-12-17 06:44:14 -0800 I've updated the change. 1810772 6 357435 achristensen 2021-11-01 12:43:50 -0700 Comment on attachment 357435 Patch This has been requesting review for more than one year. If this is still needed, please rebase and re-request review. 1921653 7 angelos 2022-12-23 04:29:42 -0800 (In reply to Alex Christensen from comment #6) > Comment on attachment 357435 [details] > Patch > > This has been requesting review for more than one year. If this is still > needed, please rebase and re-request review. AFAICT this has been fixed in https://bugs.webkit.org/show_bug.cgi?id=227579. 1921654 8 angelos 2022-12-23 04:30:19 -0800 *** This bug has been marked as a duplicate of bug 227579 *** 349141 2018-09-07 06:08:06 -0700 2018-09-07 06:09:42 -0700 Patch bug-189404-20180907150805.patch text/plain 2258 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NzgwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDUxYTQwMmQwODA3MTZlNmI5ZGUzYWFkZGRmNWNjNGY4 M2QxMjQyNi4uMjMwNGFkY2UxZTM4ODEyMDQyYzlhMjAxNTg2ZWJjYjE4NDJhZGExMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE4LTA5LTA3ICBEb21pbmlrIEluZnVlaHIgIDxkaW5mdWVockBpZ2FsaWEuY29tPgor CisgICAgICAgIEFsc28gY29weSBKU0Mgd2hlbiBydW5uaW5nIGJlbmNobWFya3Mgb24gcmVtb3Rl IG1hY2hpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4OTQwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy9ydW4tanNjLWJlbmNobWFya3M6CisKIDIwMTgtMDktMDYgIFphbGFuIEJ1anRh cyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXSBBZGQgc3VwcG9ydCBmb3IgbWlu L21heC1oZWlnaHQgcGVyY2VudGFnZSB2YWx1ZXMuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3J1bi1qc2MtYmVuY2htYXJrcyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1iZW5jaG1hcmtzCmlu ZGV4IDRkYTFjNmM2ZDAxOGQwOGE5M2FjYjczNjhiOTczZDNkYWY3NTdhNjMuLjcyMGJhM2MyYmJi NWUyOWUyYWVhYTA1MWFjOGI3OWJlODgyYzEyNTUgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv cnVuLWpzYy1iZW5jaG1hcmtzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1iZW5jaG1hcmtz CkBAIC0xMzgwLDkgKzEzODAsOSBAQCBjbGFzcyBWTQogICAgIGVsc2lmIEBwYXRoID1+IC9cL0Rl YnVnXC8oW2EtekEtWl0rKSQvCiAgICAgICBAbGliUGF0aCwgQHJlbGF0aXZlQmluUGF0aCA9IFsk fi5wcmVfbWF0Y2grIi9EZWJ1ZyJdLCAiLi8jeyQxfSIKICAgICBlbHNpZiBAcGF0aCA9fiAvXC9S ZWxlYXNlXC9iaW4oNjR8MzJ8KVwvKFtcLmEtekEtWl0rKSQvCi0gICAgICBAbGliUGF0aCwgQHJl bGF0aXZlQmluUGF0aCA9IFskfi5wcmVfbWF0Y2grIi9SZWxlYXNlL2xpYiN7JDF9Il0sICIuLyN7 JDJ9IgorICAgICAgQGxpYlBhdGgsIEByZWxhdGl2ZUJpblBhdGggPSBbJH4ucHJlX21hdGNoKyIv UmVsZWFzZS9saWIjeyQxfSIsIEBwYXRoXSwgIi4vI3skMn0iCiAgICAgZWxzaWYgQHBhdGggPX4g L1wvRGVidWdcL2Jpbig2NHwzMnwpXC8oW1wuYS16QS1aXSspJC8KLSAgICAgIEBsaWJQYXRoLCBA cmVsYXRpdmVCaW5QYXRoID0gWyR+LnByZV9tYXRjaCsiL0RlYnVnL2xpYiN7JDF9Il0sICIuLyN7 JDJ9IgorICAgICAgQGxpYlBhdGgsIEByZWxhdGl2ZUJpblBhdGggPSBbJH4ucHJlX21hdGNoKyIv RGVidWcvbGliI3skMX0iLCBAcGF0aF0sICIuLyN7JDJ9IgogICAgIGVsc2lmIEBwYXRoID1+IC9c L0NvbnRlbnRzXC9SZXNvdXJjZXNcLyhbYS16QS1aXSspJC8KICAgICAgIEBsaWJQYXRoID0gWyR+ LnByZV9tYXRjaCArICIvQ29udGVudHMvUmVzb3VyY2VzIiwgJH4ucHJlX21hdGNoICsgIi9Db250 ZW50cy9GcmFtZXdvcmtzIl0KICAgICBlbHNpZiBAcGF0aCA9fiAvXC9KYXZhU2NyaXB0Q29yZS5m cmFtZXdvcmtcL1Jlc291cmNlc1wvKFthLXpBLVpdKykkLwpAQCAtMTQxMiw3ICsxNDEyLDExIEBA IGNsYXNzIFZNCiAgICAgcmFpc2UgdW5sZXNzIERpci5ta2RpcihmaWxlbmFtZSkKICAgICBAbGli UGF0aC5lYWNoIHsKICAgICAgIHwgbGliUGF0aFBhcnQgfAotICAgICAgY21kID0gImNwIC1hICN7 U2hlbGx3b3Jkcy5zaGVsbGVzY2FwZShsaWJQYXRoUGFydCl9LyogI3tTaGVsbHdvcmRzLnNoZWxs ZXNjYXBlKGZpbGVuYW1lLnRvX3MpfSIKKyAgICAgIGlmIEZpbGUuZmlsZT8obGliUGF0aFBhcnQp CisgICAgICAgIGNtZCA9ICJjcCAtYSAje1NoZWxsd29yZHMuc2hlbGxlc2NhcGUobGliUGF0aFBh cnQpfSAje1NoZWxsd29yZHMuc2hlbGxlc2NhcGUoZmlsZW5hbWUudG9fcyl9IgorICAgICAgZWxz ZQorICAgICAgICBjbWQgPSAiY3AgLWEgI3tTaGVsbHdvcmRzLnNoZWxsZXNjYXBlKGxpYlBhdGhQ YXJ0KX0vKiAje1NoZWxsd29yZHMuc2hlbGxlc2NhcGUoZmlsZW5hbWUudG9fcyl9IgorICAgICAg ZW5kCiAgICAgICAkc3RkZXJyLnB1dHMgIj4+ICN7Y21kfSIgaWYgJHZlcmJvc2l0eT49MgogICAg ICAgcmFpc2UgdW5sZXNzIHN5c3RlbShjbWQpCiAgICAgfQo= 349142 2018-09-07 06:10:00 -0700 2018-12-17 04:37:49 -0800 Patch bug-189404-20180907150959.patch text/plain 2258 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NzgwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDUxYTQwMmQwODA3MTZlNmI5ZGUzYWFkZGRmNWNjNGY4 M2QxMjQyNi4uMjMwNGFkY2UxZTM4ODEyMDQyYzlhMjAxNTg2ZWJjYjE4NDJhZGExMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE4LTA5LTA3ICBEb21pbmlrIEluZnVlaHIgIDxkaW5mdWVockBpZ2FsaWEuY29tPgor CisgICAgICAgIEFsc28gY29weSBKU0Mgd2hlbiBydW5uaW5nIGJlbmNobWFya3Mgb24gcmVtb3Rl IG1hY2hpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4OTQwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy9ydW4tanNjLWJlbmNobWFya3M6CisKIDIwMTgtMDktMDYgIFphbGFuIEJ1anRh cyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXSBBZGQgc3VwcG9ydCBmb3IgbWlu L21heC1oZWlnaHQgcGVyY2VudGFnZSB2YWx1ZXMuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3J1bi1qc2MtYmVuY2htYXJrcyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1iZW5jaG1hcmtzCmlu ZGV4IDRkYTFjNmM2ZDAxOGQwOGE5M2FjYjczNjhiOTczZDNkYWY3NTdhNjMuLjcyMGJhM2MyYmJi NWUyOWUyYWVhYTA1MWFjOGI3OWJlODgyYzEyNTUgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv cnVuLWpzYy1iZW5jaG1hcmtzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1iZW5jaG1hcmtz CkBAIC0xMzgwLDkgKzEzODAsOSBAQCBjbGFzcyBWTQogICAgIGVsc2lmIEBwYXRoID1+IC9cL0Rl YnVnXC8oW2EtekEtWl0rKSQvCiAgICAgICBAbGliUGF0aCwgQHJlbGF0aXZlQmluUGF0aCA9IFsk fi5wcmVfbWF0Y2grIi9EZWJ1ZyJdLCAiLi8jeyQxfSIKICAgICBlbHNpZiBAcGF0aCA9fiAvXC9S ZWxlYXNlXC9iaW4oNjR8MzJ8KVwvKFtcLmEtekEtWl0rKSQvCi0gICAgICBAbGliUGF0aCwgQHJl bGF0aXZlQmluUGF0aCA9IFskfi5wcmVfbWF0Y2grIi9SZWxlYXNlL2xpYiN7JDF9Il0sICIuLyN7 JDJ9IgorICAgICAgQGxpYlBhdGgsIEByZWxhdGl2ZUJpblBhdGggPSBbJH4ucHJlX21hdGNoKyIv UmVsZWFzZS9saWIjeyQxfSIsIEBwYXRoXSwgIi4vI3skMn0iCiAgICAgZWxzaWYgQHBhdGggPX4g L1wvRGVidWdcL2Jpbig2NHwzMnwpXC8oW1wuYS16QS1aXSspJC8KLSAgICAgIEBsaWJQYXRoLCBA cmVsYXRpdmVCaW5QYXRoID0gWyR+LnByZV9tYXRjaCsiL0RlYnVnL2xpYiN7JDF9Il0sICIuLyN7 JDJ9IgorICAgICAgQGxpYlBhdGgsIEByZWxhdGl2ZUJpblBhdGggPSBbJH4ucHJlX21hdGNoKyIv RGVidWcvbGliI3skMX0iLCBAcGF0aF0sICIuLyN7JDJ9IgogICAgIGVsc2lmIEBwYXRoID1+IC9c L0NvbnRlbnRzXC9SZXNvdXJjZXNcLyhbYS16QS1aXSspJC8KICAgICAgIEBsaWJQYXRoID0gWyR+ LnByZV9tYXRjaCArICIvQ29udGVudHMvUmVzb3VyY2VzIiwgJH4ucHJlX21hdGNoICsgIi9Db250 ZW50cy9GcmFtZXdvcmtzIl0KICAgICBlbHNpZiBAcGF0aCA9fiAvXC9KYXZhU2NyaXB0Q29yZS5m cmFtZXdvcmtcL1Jlc291cmNlc1wvKFthLXpBLVpdKykkLwpAQCAtMTQxMiw3ICsxNDEyLDExIEBA IGNsYXNzIFZNCiAgICAgcmFpc2UgdW5sZXNzIERpci5ta2RpcihmaWxlbmFtZSkKICAgICBAbGli UGF0aC5lYWNoIHsKICAgICAgIHwgbGliUGF0aFBhcnQgfAotICAgICAgY21kID0gImNwIC1hICN7 U2hlbGx3b3Jkcy5zaGVsbGVzY2FwZShsaWJQYXRoUGFydCl9LyogI3tTaGVsbHdvcmRzLnNoZWxs ZXNjYXBlKGZpbGVuYW1lLnRvX3MpfSIKKyAgICAgIGlmIEZpbGUuZmlsZT8obGliUGF0aFBhcnQp CisgICAgICAgIGNtZCA9ICJjcCAtYSAje1NoZWxsd29yZHMuc2hlbGxlc2NhcGUobGliUGF0aFBh cnQpfSAje1NoZWxsd29yZHMuc2hlbGxlc2NhcGUoZmlsZW5hbWUudG9fcyl9IgorICAgICAgZWxz ZQorICAgICAgICBjbWQgPSAiY3AgLWEgI3tTaGVsbHdvcmRzLnNoZWxsZXNjYXBlKGxpYlBhdGhQ YXJ0KX0vKiAje1NoZWxsd29yZHMuc2hlbGxlc2NhcGUoZmlsZW5hbWUudG9fcyl9IgorICAgICAg ZW5kCiAgICAgICAkc3RkZXJyLnB1dHMgIj4+ICN7Y21kfSIgaWYgJHZlcmJvc2l0eT49MgogICAg ICAgcmFpc2UgdW5sZXNzIHN5c3RlbShjbWQpCiAgICAgfQo= 357435 2018-12-17 04:37:55 -0800 2021-11-01 12:43:50 -0700 Patch bug-189404-20181217133754.patch text/plain 2249 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjM5MjYyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTViOTMzOWE3NjkxZWMzZTRjYmYyZjk1N2VjMTlmZjVh MGNiY2VjMS4uNzZmYjNjZDc4ODRmNmZjYzc0YzE4OGYyYjYwNGY5ZGM3Njk2M2Q3NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE4LTEyLTE3ICBEb21pbmlrIEluZnVlaHIgIDxkaW5mdWVockBpZ2FsaWEuY29tPgor CisgICAgICAgIEFsc28gY29weSBKU0Mgd2hlbiBydW5uaW5nIGJlbmNobWFya3Mgb24gcmVtb3Rl IG1hY2hpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4OTQwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy9ydW4tanNjLWJlbmNobWFya3M6CisKIDIwMTgtMTItMTYgIEFkcmlhbiBQZXJl eiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1 aWxkIGZpeCBhZnRlciByMjM5MjUzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1qc2Mt YmVuY2htYXJrcyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1iZW5jaG1hcmtzCmluZGV4IDJjY2Zl OTIzZDMwZTUwYjdiMjA5YTI0ODA0MzJlNjcyZjZjYjNlZDAuLmExODZhNmViMjhjMWEzYzEyZjU1 YThkMjljNjc4N2EzNzQ1ZWRmZjcgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1i ZW5jaG1hcmtzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1iZW5jaG1hcmtzCkBAIC0xMzgy LDkgKzEzODIsOSBAQCBjbGFzcyBWTQogICAgIGVsc2lmIEBwYXRoID1+IC9cL0RlYnVnXC8oW2Et ekEtWl0rKSQvCiAgICAgICBAbGliUGF0aCwgQHJlbGF0aXZlQmluUGF0aCA9IFskfi5wcmVfbWF0 Y2grIi9EZWJ1ZyJdLCAiLi8jeyQxfSIKICAgICBlbHNpZiBAcGF0aCA9fiAvXC9SZWxlYXNlXC9i aW4oNjR8MzJ8KVwvKFtcLmEtekEtWl0rKSQvCi0gICAgICBAbGliUGF0aCwgQHJlbGF0aXZlQmlu UGF0aCA9IFskfi5wcmVfbWF0Y2grIi9SZWxlYXNlL2xpYiN7JDF9Il0sICIuLyN7JDJ9IgorICAg ICAgQGxpYlBhdGgsIEByZWxhdGl2ZUJpblBhdGggPSBbJH4ucHJlX21hdGNoKyIvUmVsZWFzZS9s aWIjeyQxfSIsIEBwYXRoXSwgIi4vI3skMn0iCiAgICAgZWxzaWYgQHBhdGggPX4gL1wvRGVidWdc L2Jpbig2NHwzMnwpXC8oW1wuYS16QS1aXSspJC8KLSAgICAgIEBsaWJQYXRoLCBAcmVsYXRpdmVC aW5QYXRoID0gWyR+LnByZV9tYXRjaCsiL0RlYnVnL2xpYiN7JDF9Il0sICIuLyN7JDJ9IgorICAg ICAgQGxpYlBhdGgsIEByZWxhdGl2ZUJpblBhdGggPSBbJH4ucHJlX21hdGNoKyIvRGVidWcvbGli I3skMX0iLCBAcGF0aF0sICIuLyN7JDJ9IgogICAgIGVsc2lmIEBwYXRoID1+IC9cL0NvbnRlbnRz XC9SZXNvdXJjZXNcLyhbYS16QS1aXSspJC8KICAgICAgIEBsaWJQYXRoID0gWyR+LnByZV9tYXRj aCArICIvQ29udGVudHMvUmVzb3VyY2VzIiwgJH4ucHJlX21hdGNoICsgIi9Db250ZW50cy9GcmFt ZXdvcmtzIl0KICAgICBlbHNpZiBAcGF0aCA9fiAvXC9KYXZhU2NyaXB0Q29yZS5mcmFtZXdvcmtc L1Jlc291cmNlc1wvKFthLXpBLVpdKykkLwpAQCAtMTQxNCw3ICsxNDE0LDExIEBAIGNsYXNzIFZN CiAgICAgcmFpc2UgdW5sZXNzIERpci5ta2RpcihmaWxlbmFtZSkKICAgICBAbGliUGF0aC5lYWNo IHsKICAgICAgIHwgbGliUGF0aFBhcnQgfAotICAgICAgY21kID0gImNwIC1hICN7U2hlbGx3b3Jk cy5zaGVsbGVzY2FwZShsaWJQYXRoUGFydCl9LyogI3tTaGVsbHdvcmRzLnNoZWxsZXNjYXBlKGZp bGVuYW1lLnRvX3MpfSIKKyAgICAgIGlmIEZpbGUuZmlsZT8obGliUGF0aFBhcnQpCisgICAgICAg IGNtZCA9ICJjcCAtYSAje1NoZWxsd29yZHMuc2hlbGxlc2NhcGUobGliUGF0aFBhcnQpfSAje1No ZWxsd29yZHMuc2hlbGxlc2NhcGUoZmlsZW5hbWUudG9fcyl9IgorICAgICAgZWxzZQorICAgICAg ICBjbWQgPSAiY3AgLWEgI3tTaGVsbHdvcmRzLnNoZWxsZXNjYXBlKGxpYlBhdGhQYXJ0KX0vKiAj e1NoZWxsd29yZHMuc2hlbGxlc2NhcGUoZmlsZW5hbWUudG9fcyl9IgorICAgICAgZW5kCiAgICAg ICAkc3RkZXJyLnB1dHMgIj4+ICN7Y21kfSIgaWYgJHZlcmJvc2l0eT49MgogICAgICAgcmFpc2Ug dW5sZXNzIHN5c3RlbShjbWQpCiAgICAgfQo=