189380 2018-09-06 15:52:58 -0700 Improper speculation type for Math.pow(NaN, 0) in Abstract Interpreter 2018-09-06 16:44:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff commit-queue ews-watchlist keith_miller mark.lam saam webkit-bug-importer oldest_to_newest 1457305 0 msaboff 2018-09-06 15:52:58 -0700 Given that Math.pow(NaN, 0) gives the result of 1, the computed SpeculatedType for ArithPow(NaN, non-NaN) should include Double values. 1457306 1 msaboff 2018-09-06 15:53:24 -0700 <rdar://problem/42908665> 1457309 2 349086 msaboff 2018-09-06 16:00:21 -0700 Created attachment 349086 Patch 1457317 3 349086 saam 2018-09-06 16:18:30 -0700 Comment on attachment 349086 Patch Let's keep an eye on perf bots after this to ensure this doesn't hurt perf anywhere 1457318 4 msaboff 2018-09-06 16:19:25 -0700 (In reply to Saam Barati from comment #3) > Comment on attachment 349086 [details] > Patch > > Let's keep an eye on perf bots after this to ensure this doesn't hurt perf > anywhere Good idea. 1457329 5 349086 commit-queue 2018-09-06 16:44:57 -0700 Comment on attachment 349086 Patch Clearing flags on attachment: 349086 Committed r235765: <https://trac.webkit.org/changeset/235765> 1457330 6 commit-queue 2018-09-06 16:44:58 -0700 All reviewed patches have been landed. Closing bug. 349086 2018-09-06 16:00:21 -0700 2018-09-06 16:44:57 -0700 Patch 189380.patch text/plain 2730 msaboff SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzU3NjMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE2IEBACisyMDE4LTA5LTA2ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBw bGUuY29tPgorCisgICAgICAgIEltcHJvcGVyIHNwZWN1bGF0aW9uIHR5cGUgZm9yIE1hdGgucG93 KE5hTiwgMCkgaW4gQWJzdHJhY3QgSW50ZXJwcmV0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTM4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5ldyB0ZXN0LgorCisgICAgICAgICogc3RyZXNzL21h dGgtcG93LW5hbi10by16ZXJvLXNwZWMtdHlwZS5qczogQWRkZWQuCisgICAgICAgIChmdW5jKToK KyAgICAgICAgKHRlc3QpOgorCiAyMDE4LTA5LTA2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxl LmNvbT4KIAogICAgICAgICBHYXJkZW5pbmc6IE1vdmUgcmVncmVzcy0xODkxODUuanMgdW5kZXIg SlNUZXN0cy93YXNtLgpJbmRleDogSlNUZXN0cy9zdHJlc3MvbWF0aC1wb3ctbmFuLXRvLXplcm8t c3BlYy10eXBlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL21hdGgtcG93LW5hbi10 by16ZXJvLXNwZWMtdHlwZS5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9tYXRo LXBvdy1uYW4tdG8temVyby1zcGVjLXR5cGUuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwy MSBAQAorLy8gVmVyaWZ5IHRoYXQgd2UgaGF2ZSB0aGUgY29ycmVjdCBzcGVjdWxhdGlvbiBjaGVj a3MgZm9yIE1hdGgucG93KE5hTiwgMCkuCisKK2Z1bmN0aW9uIGZ1bmMoeCkgeworICAgIHJldHVy biBmaWF0SW50NTIoTWF0aC5wb3coTmFOLCAoeCA+IDEpKSk7Cit9OworCitub0lubGluZShmdW5j KTsKKworZnVuY3Rpb24gdGVzdChmKQoreworICAgIGZvciAobGV0IGkgPSAwOyBpIDwgMTAwMDA7 ICsraSkgeworICAgICAgICBpZiAoZigwKSAhPSAxKQorICAgICAgICAgICAgdGhyb3cgIldyb25n IGV4cGVjdGVkIHZhbHVlIjsKKworICAgICAgICBpZiAoZigxKSAhPSAxKQorICAgICAgICAgICAg dGhyb3cgIldyb25nIGV4cGVjdGVkIHZhbHVlIjsKKyAgICB9Cit9CisKK3Rlc3QoZnVuYyk7CisK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM1Njg1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE4LTA5LTA2ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEltcHJvcGVyIHNwZWN1bGF0aW9uIHR5cGUgZm9yIE1hdGgucG93KE5hTiwgMCkgaW4gQWJz dHJhY3QgSW50ZXJwcmV0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4OTM4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFjY291bnQgZm9yIHRoZSBjYXNlIHdoZXJlIGluIE1hdGgucG93KE5hTiwgeSkg d2hlcmUgeSBjb3VsZCBiZSAwLgorCisgICAgICAgICogYnl0ZWNvZGUvU3BlY3VsYXRlZFR5cGUu Y3BwOgorICAgICAgICAoSlNDOjp0eXBlT2ZEb3VibGVQb3cpOgorCiAyMDE4LTA5LTA0ICBLZWl0 aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJFTEVBU0VfQVNT RVJUIGF0IC4uLy4uL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtlZFNwYWNlLmg6ODMK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TcGVjdWxhdGVkVHlwZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1NwZWN1bGF0ZWRU eXBlLmNwcAkocmV2aXNpb24gMjM1Njg1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVj b2RlL1NwZWN1bGF0ZWRUeXBlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjk3LDYgKzY5Nyw5IEBA IFNwZWN1bGF0ZWRUeXBlIHR5cGVPZkRvdWJsZVBvdyhTcGVjdWxhdGUKICAgICAvLyBXZSBhbHdh eXMgc2V0IGEgcHVyZSBOYU4gaW4gdGhhdCBjYXNlLgogICAgIGlmICh5VmFsdWUgJiBTcGVjRG91 YmxlTmFOKQogICAgICAgICB4VmFsdWUgfD0gU3BlY0RvdWJsZVB1cmVOYU47CisgICAgLy8gSGFu ZGxlIHRoZSB3aWVyZCBjYXNlIG9mIE5hTiBeIDAsIHdoaWNoIHJldHVybnMgMS4gU2VlIGh0dHBz Oi8vdGMzOS5naXRodWIuaW8vZWNtYTI2Mi8jc2VjLWFwcGx5aW5nLXRoZS1leHAtb3BlcmF0b3IK KyAgICBpZiAoeFZhbHVlICYgU3BlY0RvdWJsZU5hTikKKyAgICAgICAgeFZhbHVlIHw9IFNwZWNG dWxsRG91YmxlOwogICAgIHJldHVybiBwb2xsdXRlRG91YmxlKHhWYWx1ZSk7CiB9CiAK