<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>18938</bug_id>
          
          <creation_ts>2008-05-08 02:50:15 -0700</creation_ts>
          <short_desc>[GTK] Plugins not resized</short_desc>
          <delta_ts>2009-05-25 08:57:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Marco Barisione">marco.barisione</reporter>
          <assigned_to name="marcoil">marc.ordinasillopis</assigned_to>
          <cc>alp</cc>
    
    <cc>andersca</cc>
    
    <cc>aroben</cc>
    
    <cc>marc.ordinasillopis</cc>
    
    <cc>tonikitoo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>79874</commentid>
    <comment_count>0</comment_count>
    <who name="Marco Barisione">marco.barisione</who>
    <bug_when>2008-05-08 02:50:15 -0700</bug_when>
    <thetext>Plugin visited directly (e.g. inserting http://youtube.com/active_sharing.swf in the URL bar) are not resized when the window is resized.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>80983</commentid>
    <comment_count>1</comment_count>
      <attachid>21255</attachid>
    <who name="marcoil">marc.ordinasillopis</who>
    <bug_when>2008-05-20 07:23:50 -0700</bug_when>
    <thetext>Created attachment 21255
Fixes the issue for r33931

This patch ensures that changes in the geometry are sent to the plugin when the PluginView is the whole document (NP_FULL).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>80986</commentid>
    <comment_count>2</comment_count>
    <who name="marcoil">marc.ordinasillopis</who>
    <bug_when>2008-05-20 07:59:25 -0700</bug_when>
    <thetext>I forgot to mention that for the fix to work, the patches for Gtk present in bug #18935 have to be applied.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>82064</commentid>
    <comment_count>3</comment_count>
    <who name="Alp Toker">alp</who>
    <bug_when>2008-06-01 08:55:56 -0700</bug_when>
    <thetext>The issue does exist and the patch fixes GTK, but Anders remarked that this fix is wrong.

Anders, could you elaborate?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>82449</commentid>
    <comment_count>4</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2008-06-06 13:44:21 -0700</bug_when>
    <thetext>Hum... Adam Roben or someone who hacks on windows should take a look at this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>83974</commentid>
    <comment_count>5</comment_count>
      <attachid>21856</attachid>
    <who name="marcoil">marc.ordinasillopis</who>
    <bug_when>2008-06-20 09:48:11 -0700</bug_when>
    <thetext>Created attachment 21856
Fix for r34689

I&apos;ve made a new patch that should fix the issue without affecting the Windows port.
I&apos;ve used XP_UNIX because the X11 Qt port has the same behavior.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87000</commentid>
    <comment_count>6</comment_count>
      <attachid>21856</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2008-07-26 06:23:18 -0700</bug_when>
    <thetext>Comment on attachment 21856
Fix for r34689

Looks good to me. I would&apos;ve thought that set should _always_ call setNPWindowRect, even in a windowed resize, but it seems that is not necessary. This patch is safe in any case I would say.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87044</commentid>
    <comment_count>7</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2008-07-26 22:49:30 -0700</bug_when>
    <thetext>Landed in r35393.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>21255</attachid>
            <date>2008-05-20 07:23:50 -0700</date>
            <delta_ts>2008-06-20 09:48:11 -0700</delta_ts>
            <desc>Fixes the issue for r33931</desc>
            <filename>fix18938-r33931.patch</filename>
            <type>text/plain</type>
            <size>1167</size>
            <attacher name="marcoil">marc.ordinasillopis</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiAzMzkzMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDUtMjAgIE1hcmMgT3JkaW5hcyBpIExsb3BpcyAgPG1hcmMu
b3JkaW5hc2lsbG9waXNAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAxODkzODogW0dUS10gUGx1Z2lucyBub3QgcmVz
aXplZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5
MzgKKyAgICAgICAgCisgICAgICAgICogcGx1Z2lucy9QbHVnaW5WaWV3LmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6OlBsdWdpblZpZXc6OnNldEZyYW1lR2VvbWV0cnkpOiBXaGVuIHZpZXdpbmcgYSBm
dWxsLXBhZ2UKKyAgICAgICAgUGx1Z2luVmlldywgdHJhbnNtaXQgZ2VvbWV0cnkgY2hhbmdlcyB0
byB0aGUgcGx1Z2luLgorCiAyMDA4LTA1LTE5ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFw
cGxlLmNvbT4KIAogICAgICAgICBFeHBvc2UgdGhlIFByb2ZpbGVOb2RlIHNvcnRpbmcgZnVuY3Rp
b25zIG9uIEphdmFTY3JpcHRQcm9maWxlTm9kZS4KSW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9QbHVn
aW5WaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAJ
KHJldmlzaW9uIDMzOTMxKQorKysgV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuY3BwCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xMjEsOSArMTIxLDggQEAgdm9pZCBQbHVnaW5WaWV3OjpzZXRGcmFtZUdl
b21ldHJ5KGNvbnN0IAogCiAgICAgdXBkYXRlV2luZG93KCk7CiAKLSNpZiBQTEFURk9STShXSU4p
Ci0gICAgc2V0TlBXaW5kb3dSZWN0KHJlY3QpOwotI2VuZGlmCisgICAgaWYgKG1fbG9hZE1hbnVh
bGx5KQorICAgICAgICBzZXROUFdpbmRvd1JlY3QocmVjdCk7CiB9CiAKIHZvaWQgUGx1Z2luVmll
dzo6Z2VvbWV0cnlDaGFuZ2VkKCkgY29uc3QK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>21856</attachid>
            <date>2008-06-20 09:48:11 -0700</date>
            <delta_ts>2008-07-26 06:23:18 -0700</delta_ts>
            <desc>Fix for r34689</desc>
            <filename>fix18938-r34689.patch</filename>
            <type>text/plain</type>
            <size>1214</size>
            <attacher name="marcoil">marc.ordinasillopis</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiAzNDY4OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDYtMjAgIE1hcmMgT3JkaW5hcyBpIExsb3BpcyAgPG1hcmMu
b3JkaW5hc2lsbG9waXNAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAxODkzODogW0dUS10gUGx1Z2lucyBub3QgcmVz
aXplZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5
MzgKKworICAgICAgICAqIHBsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAgIChXZWJDb3Jl
OjpQbHVnaW5WaWV3OjpzZXRGcmFtZUdlb21ldHJ5KTogV2hlbiB2aWV3aW5nIGEgZnVsbC1wYWdl
CisgICAgICAgIHBsdWdpbiBpbiB1bml4LCBnZW9tZXRyeSBjaGFuZ2VzIGhhdmUgdG8gYmUgcGFz
c2VkIHRvIHRoZSBwbHVnaW4uCisKIDIwMDgtMDYtMTkgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFw
cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKb2huIFN1bGxpdmFuLgpJbmRleDogV2Vi
Q29yZS9wbHVnaW5zL1BsdWdpblZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGx1Z2lu
cy9QbHVnaW5WaWV3LmNwcAkocmV2aXNpb24gMzQ2ODkpCisrKyBXZWJDb3JlL3BsdWdpbnMvUGx1
Z2luVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyMiw3ICsxMjIsMTIgQEAgdm9pZCBQbHVn
aW5WaWV3OjpzZXRGcmFtZUdlb21ldHJ5KGNvbnN0IAogICAgIHVwZGF0ZVdpbmRvdygpOwogCiAj
aWYgUExBVEZPUk0oV0lOKQorICAgIC8vIE9uIFdpbmRvd3MsIGFsd2F5cyBjYWxsIHBsdWdpbiB0
byBjaGFuZ2UgZ2VvbWV0cnkuCiAgICAgc2V0TlBXaW5kb3dSZWN0KHJlY3QpOworI2VsaWYgWFBf
VU5JWAorICAgIC8vIE9uIFVuaXgsIG9ubHkgY2FsbCBwbHVnaW4gaWYgaXQncyBmdWxsLXBhZ2Uu
CisgICAgaWYgKG1fbW9kZSA9PSBOUF9GVUxMKQorICAgICAgICBzZXROUFdpbmRvd1JlY3QocmVj
dCk7CiAjZW5kaWYKIH0KIAo=
</data>
<flag name="review"
          id="9595"
          type_id="1"
          status="+"
          setter="hausmann"
    />
          </attachment>
      

    </bug>

</bugzilla>