189370 2018-09-06 14:20:13 -0700 QuickLook.mm and QuickLookSoftLink.mm must never be built in the same unified source file 2018-09-06 14:39:09 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED DUPLICATE 189009 P2 Normal --- 1 dbates dbates aestes ddkilzer lforschler oldest_to_newest 1457247 0 dbates 2018-09-06 14:20:13 -0700 Today when I re-built WebKit after removing file PlatformEventFactoryIOS.mm from the list of files that are compatible with unified sources (Source/WebCore/SourcesCocoa.txt) my build failed with the following compile error: [[ In file included from /Volumes/.../DerivedSources/WebCore/unified-sources/UnifiedSource43-mm.mm:8: platform/ios/QuickLookSoftLink.mm:32:1: error: redefinition of default argument SOFT_LINK_FRAMEWORK_FOR_SOURCE(WebCore, QuickLook) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /Volumes/.../DerivedSources/WebCore/unified-sources/UnifiedSource43-mm.mm:5: In file included from platform/ios/PlatformPasteboardIOS.mm:46: In file included from /Volumes/.../usr/local/include/wtf/SoftLinking.h:28: /Volumes/.../usr/local/include/wtf/cocoa/SoftLinking.h:345:35: note: expanded from macro 'SOFT_LINK_FRAMEWORK_FOR_SOURCE' void* framework##Library(bool isOptional = false); \ ^ ~~~~~ In file included from /Volumes/.../DerivedSources/WebCore/unified-sources/UnifiedSource43-mm.mm:7: In file included from platform/ios/QuickLook.mm:39: platform/ios/QuickLookSoftLink.h:30:1: note: previous definition is here SOFT_LINK_FRAMEWORK_FOR_HEADER(WebCore, QuickLook) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /Volumes/.../DerivedSources/WebCore/unified-sources/UnifiedSource43-mm.mm:5: In file included from platform/ios/PlatformPasteboardIOS.mm:46: In file included from /Volumes/.../usr/local/include/wtf/SoftLinking.h:28: /Volumes/.../usr/local/include/wtf/cocoa/SoftLinking.h:336:42: note: expanded from macro 'SOFT_LINK_FRAMEWORK_FOR_HEADER' extern void* framework##Library(bool isOptional = false); \ ]] 1457248 1 dbates 2018-09-06 14:20:54 -0700 The error indicates that QuickLook.mm and QuickLookSoftLink.mm cannot be built in the same unified source file. 1457256 2 349074 dbates 2018-09-06 14:31:56 -0700 Created attachment 349074 Patch 1457261 3 349074 aestes 2018-09-06 14:33:21 -0700 Comment on attachment 349074 Patch Why not annotate with @no-unify? 1457266 4 dbates 2018-09-06 14:37:49 -0700 (In reply to Andy Estes from comment #3) > Comment on attachment 349074 [details] > Patch > > Why not annotate with @no-unify? Forgot. 1457268 5 dbates 2018-09-06 14:39:09 -0700 This issue was fixed with the patch in bug #189009. *** This bug has been marked as a duplicate of bug 189009 *** 349074 2018-09-06 14:31:56 -0700 2018-09-06 14:37:54 -0700 Patch bug-189370-20180906143155.patch text/plain 4202 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGM0YjI1YWJiZTFmZjFm ODQ1NWExZmIxYWFlYzk3YTZiZDMwMzY5NS4uZDViNTNkOTFkZDgyZGMzZjJlZjczNGMwZThjZGI0 NmVjNmU2ODQ2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA5LTA2ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBRdWlja0xvb2subW0gYW5k IFF1aWNrTG9va1NvZnRMaW5rLm1tIG11c3QgbmV2ZXIgYmUgYnVpbHQgaW4gdGhlIHNhbWUgdW5p ZmllZCBzb3VyY2UgZmlsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg5MzcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUXVpY2tMb29rU29mdExpbmsubW0gbWFrZXMgdXNlIG9mIHRoZSBzb2Z0LWxpbmtp bmcgbWFjcm9zIHRvIHNvZnQgbGluayBhZ2FpbnN0IFF1aWNrTG9vay4KKyAgICAgICAgVGhlc2Ug bWFjcm9zIGxlYWQgdG8gYSByZWRlZmluaXRpb24gZXJyb3Igd2hlbiBRdWlja0xvb2tTb2Z0TGlu ay5tbSBhbmQgUXVpY2tMb29rU29mdExpbmsuaAorICAgICAgICBhcmUgaW5jbHVkZWQgaW4gdGhl IHNhbWUgdHJhbnNsYXRpb24gdW5pdC4gVGhpcyBjYW4gaGFwcGVuIGlmIHRoZSB1bmlmaWVkIGJ1 aWxkIHN5c3RlbSBncm91cHMKKyAgICAgICAgUXVpY2tMb29rU29mdExpbmsubW0gd2l0aCBhbm90 aGVyIGltcGxlbWVudGF0aW9uIGZpbGUgdGhhdCBpbmNsdWRlcyBRdWlja0xvb2tTb2Z0TGluay5o LgorICAgICAgICBJbiBwYXJ0aWN1bGFyLCB0aGUgZ3JvdXBpbmcgb2YgUXVpY2tMb29rU29mdExp bmsubW0gYW5kIFF1aWNrTG9vay5tbSB3aWxsIGNhdXNlIHRoaXMgaXNzdWUuCisgICAgICAgIFRo ZXJlZm9yZSwgd2UgZXhlbXB0IFF1aWNrTG9va1NvZnRMaW5rLm1tIGZyb20gdGhlIGxpc3Qgb2Yg ZmlsZXMgdGhhdCBjb21wYXRpYmxlIHdpdGgKKyAgICAgICAgdW5pZmllZCBzb3VyY2VzIHNvIGFz IHRvIHByZXZlbnQgc3VjaCBncm91cGluZ3MuCisKKyAgICAgICAgKiBTb3VyY2VzQ29jb2EudHh0 OgorICAgICAgICAqIFdlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvajoKKwogMjAxOC0w OS0wNiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW1hjb2Rl XSBQcmVmZXIgc3lzdGVtIGZyYW1ld29ya3MgYnVpbHQgaW50byAkKEJVSUxUX1BST0RVQ1RTX0RJ UikvU3lzdGVtL0xpYnJhcnkvRnJhbWV3b3JrcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv U291cmNlc0NvY29hLnR4dCBiL1NvdXJjZS9XZWJDb3JlL1NvdXJjZXNDb2NvYS50eHQKaW5kZXgg NjMyYmU3NWEwMzAwMGExNDI1ZWRhYmFiMDIxMWNkNGY4YWE2YWQ1OC4uNzUyM2VmOGMwM2UwYTFk OGMzZWNkZDY5OWViM2U2ZmUzNGJlN2RmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvU291 cmNlc0NvY29hLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Tb3VyY2VzQ29jb2EudHh0CkBAIC0z ODgsNyArMzg4LDYgQEAgcGxhdGZvcm0vaW9zL1BsYXRmb3JtU2NyZWVuSU9TLm1tCiBwbGF0Zm9y bS9pb3MvUGxhdGZvcm1TcGVlY2hTeW50aGVzaXplcklPUy5tbSBAbm8tdW5pZnkKIHBsYXRmb3Jt L2lvcy9QbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VBVktpdC5tbSBAbm8tdW5pZnkKIHBsYXRmb3Jt L2lvcy9RdWlja0xvb2subW0KLXBsYXRmb3JtL2lvcy9RdWlja0xvb2tTb2Z0TGluay5tbQogcGxh dGZvcm0vaW9zL1JlbW90ZUNvbW1hbmRMaXN0ZW5lcklPUy5tbQogcGxhdGZvcm0vaW9zL1Njcm9s bEFuaW1hdG9ySU9TLm1tCiBwbGF0Zm9ybS9pb3MvU2Nyb2xsYmFyVGhlbWVJT1MubW0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvaiBi L1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagppbmRleCAx N2JlNWI3ZjNkZDU2YjQ4YWJiZjM3NTU5ZTBiODhkZWU4OGI1MGUyLi5jOTNmNDdhNzg5Yjc4NTRm Yzc2MjQyNjE1ZTY5NmMxNDQ3YjQxYjc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJD b3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29y ZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCkBAIC00MDk4LDYgKzQwOTgsNyBAQAogCQlDRTE4 NjY0NTFGNzJFNUI0MDBBMENBQjYgLyogTWFya2VkVGV4dC5oIGluIEhlYWRlcnMgKi8gPSB7aXNh ID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gQ0UxODY2NDMxRjcyRTVCNDAwQTBDQUI2IC8qIE1h cmtlZFRleHQuaCAqLzsgc2V0dGluZ3MgPSB7QVRUUklCVVRFUyA9IChQcml2YXRlLCApOyB9OyB9 OwogCQlDRTI4NDk4NzFDQTM2MERGMDBCNEE1N0YgLyogQ29udGVudFNlY3VyaXR5UG9saWN5RGly ZWN0aXZlTmFtZXMuaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJl ZiA9IENFMjg0OTg2MUNBMzYwREYwMEI0QTU3RiAvKiBDb250ZW50U2VjdXJpdHlQb2xpY3lEaXJl Y3RpdmVOYW1lcy5oICovOyB9OwogCQlDRTQwODFENjIxNDFDREU4MDAxQjkwQUMgLyogUGxhdGZv cm1FdmVudEZhY3RvcnlJT1MubW0gaW4gU291cmNlcyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7 IGZpbGVSZWYgPSAyNjYwMUVCRTE0QjNCOUFEMDAxMkMwRkUgLyogUGxhdGZvcm1FdmVudEZhY3Rv cnlJT1MubW0gKi87IH07CisJCUNFNDA4MURBMjE0MUNGOEEwMDFCOTBBQyAvKiBRdWlja0xvb2tT b2Z0TGluay5tbSBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9 IDQ0MzkxN0ZEMUE5MUIyRjgwMDZFMDRGMiAvKiBRdWlja0xvb2tTb2Z0TGluay5tbSAqLzsgfTsK IAkJQ0U1RkEyNTUyMDlFNDhDNTAwNTFENzAwIC8qIENvbnRlbnRTZWN1cml0eVBvbGljeUNsaWVu dC5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gQ0U1RkEy NTMyMDlFNDhDNTAwNTFENzAwIC8qIENvbnRlbnRTZWN1cml0eVBvbGljeUNsaWVudC5oICovOyBz ZXR0aW5ncyA9IHtBVFRSSUJVVEVTID0gKFByaXZhdGUsICk7IH07IH07CiAJCUNFNkRBREZBMUM1 OTFFNkEwMDNGNkE4OCAvKiBDb250ZW50U2VjdXJpdHlQb2xpY3lSZXNwb25zZUhlYWRlcnMuaCBp biBIZWFkZXJzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IENFNkRBREY4MUM1 OTFFNkEwMDNGNkE4OCAvKiBDb250ZW50U2VjdXJpdHlQb2xpY3lSZXNwb25zZUhlYWRlcnMuaCAq Lzsgc2V0dGluZ3MgPSB7QVRUUklCVVRFUyA9IChQcml2YXRlLCApOyB9OyB9OwogCQlDRTc5OUY5 ODFDNkE0NkJDMDA5N0I1MTggLyogQ29udGVudFNlY3VyaXR5UG9saWN5U291cmNlTGlzdC5oIGlu IEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gQ0U3OTlGOTYxQzZB NDZCQzAwOTdCNTE4IC8qIENvbnRlbnRTZWN1cml0eVBvbGljeVNvdXJjZUxpc3QuaCAqLzsgfTsK QEAgLTMxNDM0LDYgKzMxNDM1LDcgQEAKIAkJCQlBQTEyREY0OTE3NDNERjgzMDA0REFGREYgLyog UGxhdGZvcm1TcGVlY2hTeW50aGVzaXplcklPUy5tbSBpbiBTb3VyY2VzICovLAogCQkJCUNEQTI5 QTMwMUNCRjc0RDQwMDkwMUNDRiAvKiBQbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VBVktpdC5tbSBp biBTb3VyY2VzICovLAogCQkJCUNEQTI5QTE2MUNCREE1NkMwMDkwMUNDRiAvKiBQbGF5YmFja1Nl c3Npb25JbnRlcmZhY2VNYWMubW0gaW4gU291cmNlcyAqLywKKwkJCQlDRTQwODFEQTIxNDFDRjhB MDAxQjkwQUMgLyogUXVpY2tMb29rU29mdExpbmsubW0gaW4gU291cmNlcyAqLywKIAkJCQk0MTky NDI0OTIxMjdCOTNFMDA2MzRGQ0YgLyogUmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlQ29jb2Eu bW0gaW4gU291cmNlcyAqLywKIAkJCQkzMTZEQ0I4QTFFN0E2OTk2MDAxQjVGODcgLyogUlRDSWNl VHJhbnNwb3J0LmNwcCBpbiBTb3VyY2VzICovLAogCQkJCUJDNTExNTZFMTJCMTc0OUMwMEM5Njc1 NCAvKiBTY3JvbGxBbmltYXRvck1hYy5tbSBpbiBTb3VyY2VzICovLAo=