189369 2018-09-06 14:17:38 -0700 WebPage::close should clear UserMediaPermissionRequestManager 2018-09-11 16:17:32 -0700 1 1 1 Unclassified WebKit WebRTC Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue webkit-bug-importer youennf oldest_to_newest 1457244 0 eric.carlson 2018-09-06 14:17:38 -0700 UserMediaPermissionRequestManager should not remove ActivityStateChangeObserver in destructor 1457245 1 webkit-bug-importer 2018-09-06 14:18:05 -0700 <rdar://problem/44196724> 1457252 2 349072 eric.carlson 2018-09-06 14:25:07 -0700 Created attachment 349072 Patch 1457272 3 349072 youennf 2018-09-06 14:44:40 -0700 Comment on attachment 349072 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349072&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:710 > +#endif I believe this cleanup call might be too late. How about doing it in WebPage::close() instead since it is the place where m_page is gone? If done there, setting m_userMediaPermissionRequestManager to nullptr in WebPage::close() might be good enough. 1458505 4 349406 eric.carlson 2018-09-11 10:26:26 -0700 Created attachment 349406 Updated patch 1458757 5 349406 commit-queue 2018-09-11 16:17:30 -0700 Comment on attachment 349406 Updated patch Clearing flags on attachment: 349406 Committed r235918: <https://trac.webkit.org/changeset/235918> 1458758 6 commit-queue 2018-09-11 16:17:32 -0700 All reviewed patches have been landed. Closing bug. 349072 2018-09-06 14:25:07 -0700 2018-09-11 10:26:25 -0700 Patch bug-189369-20180906142506.patch text/plain 3765 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDViYjQ5ZjA3MWZhMzMxMzRm NWE1NzYxODQxYjlhYWM3Y2FhNDc4ZTEuLmU2OWNjYWY2YTIzNjY2Nzg0MmRlMTZmMTYwYWMzNTVi NWY5MjU2MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMDktMDYgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlck1lZGlhUGVybWlz c2lvblJlcXVlc3RNYW5hZ2VyIHNob3VsZCBub3QgcmVtb3ZlIEFjdGl2aXR5U3RhdGVDaGFuZ2VP YnNlcnZlciBpbiBkZXN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODkzNjkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ0MTk2NzI0Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJv Y2Vzcy9NZWRpYVN0cmVhbS9Vc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIuY3BwOgor ICAgICAgICAoV2ViS2l0OjpVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXI6On5Vc2Vy TWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIpOgorICAgICAgICAoV2ViS2l0OjpVc2VyTWVk aWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXI6OmNsZWFudXApOgorICAgICAgICAqIFdlYlByb2Nl c3MvTWVkaWFTdHJlYW0vVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyLmg6CisgICAg ICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJQYWdlOjp+V2ViUGFnZSk6CisKIDIwMTgtMDktMDYgIEZyZWRlcmljIFdhbmcgIDxmd2FuZ0Bp Z2FsaWEuY29tPgogCiAgICAgICAgIFVzZSBtb3JlIGdlbmVyaWMgbmFtZXMgdGhhbiAib3ZlcmZs b3ciIGZvciBmdW5jdGlvbnMgdGhhdCBjYW4gYmUgdXNlZCBmb3Igc3ViZnJhbWVzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvTWVkaWFTdHJlYW0vVXNlck1lZGlhUGVybWlz c2lvblJlcXVlc3RNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9NZWRpYVN0 cmVhbS9Vc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIuY3BwCmluZGV4IDcxNDhmZWQy MTMyNWEzOGRhMGMzYmVmYWVmZmE0N2Y2OWI3N2Y2YTguLmQ4OTczYjE4MWQxNTZmMTA4ZDQ1MDVi ZTE3YmYxMDMwYTkzYWI4OTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9N ZWRpYVN0cmVhbS9Vc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9NZWRpYVN0cmVhbS9Vc2VyTWVkaWFQZXJtaXNzaW9uUmVx dWVzdE1hbmFnZXIuY3BwCkBAIC01MiwxMiArNTIsMjAgQEAgVXNlck1lZGlhUGVybWlzc2lvblJl cXVlc3RNYW5hZ2VyOjpVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIoV2ViUGFnZSYg cGEKIAogVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyOjp+VXNlck1lZGlhUGVybWlz c2lvblJlcXVlc3RNYW5hZ2VyKCkKIHsKLSAgICBpZiAobV9tb25pdG9yaW5nQWN0aXZpdHlTdGF0 ZUNoYW5nZSkKLSAgICAgICAgbV9wYWdlLmNvcmVQYWdlKCktPnJlbW92ZUFjdGl2aXR5U3RhdGVD aGFuZ2VPYnNlcnZlcigqdGhpcyk7CisgICAgQVNTRVJUKCFtX21vbml0b3JpbmdBY3Rpdml0eVN0 YXRlQ2hhbmdlKTsKICAgICBmb3IgKGF1dG8mIHNhbmRib3hFeHRlbnNpb24gOiBtX3VzZXJNZWRp YURldmljZVNhbmRib3hFeHRlbnNpb25zKQogICAgICAgICBzYW5kYm94RXh0ZW5zaW9uLnZhbHVl LT5yZXZva2UoKTsKIH0KIAordm9pZCBVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXI6 OmNsZWFudXAoKQoreworICAgIGlmICghbV9tb25pdG9yaW5nQWN0aXZpdHlTdGF0ZUNoYW5nZSkK KyAgICAgICAgcmV0dXJuOworCisgICAgbV9wYWdlLmNvcmVQYWdlKCktPnJlbW92ZUFjdGl2aXR5 U3RhdGVDaGFuZ2VPYnNlcnZlcigqdGhpcyk7CisgICAgbV9tb25pdG9yaW5nQWN0aXZpdHlTdGF0 ZUNoYW5nZSA9IGZhbHNlOworfQorCiB2b2lkIFVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWFu YWdlcjo6c3RhcnRVc2VyTWVkaWFSZXF1ZXN0KFVzZXJNZWRpYVJlcXVlc3QmIHJlcXVlc3QpCiB7 CiAgICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gcmVxdWVzdC5kb2N1bWVudCgpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL01lZGlhU3RyZWFtL1VzZXJNZWRpYVBlcm1pc3Np b25SZXF1ZXN0TWFuYWdlci5oIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL01lZGlhU3RyZWFt L1VzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlci5oCmluZGV4IDU3NDY3MTJjMDZmOTg2 MjEwMDBiYzQ3NGQzMjdjNThiMDZhYmY5MDcuLmE3MWRiNzQ2ODljNTI0MDA2MjhkN2JjYjk2ZTQ2 MmRkZmFhYzQzYzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9NZWRpYVN0 cmVhbS9Vc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvTWVkaWFTdHJlYW0vVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5h Z2VyLmgKQEAgLTQ1LDYgKzQ1LDggQEAgcHVibGljOgogICAgIGV4cGxpY2l0IFVzZXJNZWRpYVBl cm1pc3Npb25SZXF1ZXN0TWFuYWdlcihXZWJQYWdlJik7CiAgICAgflVzZXJNZWRpYVBlcm1pc3Np b25SZXF1ZXN0TWFuYWdlcigpOwogCisgICAgdm9pZCBjbGVhbnVwKCk7CisKICAgICB2b2lkIHN0 YXJ0VXNlck1lZGlhUmVxdWVzdChXZWJDb3JlOjpVc2VyTWVkaWFSZXF1ZXN0Jik7CiAgICAgdm9p ZCBjYW5jZWxVc2VyTWVkaWFSZXF1ZXN0KFdlYkNvcmU6OlVzZXJNZWRpYVJlcXVlc3QmKTsKICAg ICB2b2lkIHVzZXJNZWRpYUFjY2Vzc1dhc0dyYW50ZWQodWludDY0X3QsIFdlYkNvcmU6OkNhcHR1 cmVEZXZpY2UmJiBhdWRpb0RldmljZSwgV2ViQ29yZTo6Q2FwdHVyZURldmljZSYmIHZpZGVvRGV2 aWNlLCBTdHJpbmcmJiBkZXZpY2VJZGVudGlmaWVySGFzaFNhbHQpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAppbmRleCA0NGRlZmYxMzQwZjU5YWQ5NzAx ZTkzYjMyYTk0ZDRmNmQ3NjFhNjQwLi41MzQ3MjhiMTMzYjdhZGRmZThmNzFkNDc4YzFkNDViNDc1 NmQwM2M2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQ YWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNw cApAQCAtNzA1LDYgKzcwNSwxMCBAQCBXZWJQYWdlOjp+V2ViUGFnZSgpCiAgICAgICAgIHdlYlBy b2Nlc3MuZXZlbnREaXNwYXRjaGVyKCkucmVtb3ZlU2Nyb2xsaW5nVHJlZUZvclBhZ2UodGhpcyk7 CiAjZW5kaWYKIAorI2lmIEVOQUJMRShNRURJQV9TVFJFQU0pCisgICAgbV91c2VyTWVkaWFQZXJt aXNzaW9uUmVxdWVzdE1hbmFnZXItPmNsZWFudXAoKTsKKyNlbmRpZgorCiAgICAgcGxhdGZvcm1E ZXRhY2goKTsKICAgICAKICAgICBtX3NhbmRib3hFeHRlbnNpb25UcmFja2VyLmludmFsaWRhdGUo KTsK 349406 2018-09-11 10:26:26 -0700 2018-09-11 16:17:30 -0700 Updated patch bug-189369-20180911102625.patch text/plain 1314 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1ODk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVmNGQzZTRiMGQ4YjIyMDgx MTIzZWQ4Nzg0NzE1YzFiZjRmNzRiOWYuLjdiMTBkMjYxZDhhMjk5ODVmMTg1MTZjMmNlNzA0YTc0 MWM0Nzk3MzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDktMDYgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViUGFnZTo6Y2xvc2Ug c2hvdWxkIGNsZWFyIFVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5MzY5CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS80NDE5NjcyND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViUGFnZTo6Y2xvc2UpOiBDbGVhciBtX3VzZXJNZWRpYVBlcm1pc3Npb25S ZXF1ZXN0TWFuYWdlci4KKwogMjAxOC0wOS0xMSAgV29vZHJvdyBXYW5nICA8d29vZHJvd193YW5n QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgV2ViIEFQSSBTdGF0aXN0aWNzIENvbGxlY3Rpb24K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3Bw IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKaW5kZXggZTVh M2RmNjY3ODE5MDgxZTExNGFkMDI0MzRhNGZhNWQyY2M3MmY0Ny4uZGZjYjdkOTQxZWNlNTdkMzRk MjBjMDE2NzNmZjNhMzhjZGViODk1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5jcHAKQEAgLTExNjUsNiArMTE2NSwxMCBAQCB2b2lkIFdlYlBhZ2U6OmNs b3NlKCkKIAogICAgIG1fcGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigpLmRpc2Nvbm5lY3RBbGxG cm9udGVuZHMoKTsKIAorI2lmIEVOQUJMRShNRURJQV9TVFJFQU0pCisgICAgbV91c2VyTWVkaWFQ ZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXIgPSBudWxscHRyOworI2VuZGlmCisKICNpZiBFTkFCTEUo RlVMTFNDUkVFTl9BUEkpCiAgICAgbV9mdWxsU2NyZWVuTWFuYWdlciA9IG51bGxwdHI7CiAjZW5k aWYK