189367 2018-09-06 14:07:16 -0700 REGRESSION(r235755): Didn't address the review comment (Requested by rniwa on #webkit). 2018-09-06 14:12:27 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 189135 1 commit-queue commit-queue dewei_zhu rniwa webkit-bug-importer oldest_to_newest 1457233 0 commit-queue 2018-09-06 14:07:16 -0700 https://trac.webkit.org/changeset/235755 broke the build: Didn't address the review comment (Requested by rniwa on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1457234 1 349068 commit-queue 2018-09-06 14:07:23 -0700 Created attachment 349068 ROLLOUT of r235755 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1457236 2 349068 commit-queue 2018-09-06 14:09:21 -0700 Comment on attachment 349068 ROLLOUT of r235755 Clearing flags on attachment: 349068 Committed r235756: <https://trac.webkit.org/changeset/235756> 1457237 3 commit-queue 2018-09-06 14:09:23 -0700 All reviewed patches have been landed. Closing bug. 1457238 4 webkit-bug-importer 2018-09-06 14:12:27 -0700 <rdar://problem/44196442> 349068 2018-09-06 14:07:23 -0700 2018-09-06 14:09:21 -0700 ROLLOUT of r235755 bug-189367-20180906170722.patch text/plain 4021 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NzU1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDZhNzMxODZhNjM5NDZiMmQwZmViNjJlYmUxNTJmZDRm ZDE2YjdiMS4uOWZkNzU2YjQzZmRjMjIyMWQxMzY5MmZjODcxYzY4ODdlNGJjNjFlNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE4LTA5LTA2ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4K KworICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMjM1NzU1LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5MzY3CisKKyAgICAgICAgRGlk bid0IGFkZHJlc3MgdGhlIHJldmlldyBjb21tZW50IChSZXF1ZXN0ZWQgYnkgcm5pd2Egb24KKyAg ICAgICAgI3dlYmtpdCkuCisKKyAgICAgICAgUmV2ZXJ0ZWQgY2hhbmdlc2V0OgorCisgICAgICAg ICJCZW5jaG1hcmtSZXN1bHRzLmZvcm1hdCBzaG91bGQgc3VwcG9ydCBzcGVjaWZ5aW5nIGRlcHRo IG9mCisgICAgICAgIHRlc3RzIHRvIHNob3cuIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5MTM1CisgICAgICAgIGh0dHBzOi8vdHJhYy53ZWJraXQu b3JnL2NoYW5nZXNldC8yMzU3NTUKKwogMjAxOC0wOC0yOSAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KIAogICAgICAgICBCZW5jaG1hcmtSZXN1bHRzLmZvcm1hdCBzaG91bGQgc3Vw cG9ydCBzcGVjaWZ5aW5nIGRlcHRoIG9mIHRlc3RzIHRvIHNob3cuCmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvYmVuY2htYXJrX3Jlc3VsdHMucHkg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvYmVuY2htYXJrX3Jlc3Vs dHMucHkKaW5kZXggM2Q3MThkZTRlODlkYjA1NjlkZTRlMmUwZmRhYjNkM2RlMTlhMWE3OS4uZDAy ZGMxYTE2Njc5ODEwMDQ2ZWNkZmE4MzZmYWEyNWEyMThmNGZmNyAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2JlbmNobWFya19yZXN1bHRzLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9iZW5jaG1hcmtfcmVz dWx0cy5weQpAQCAtNDgsMTMgKzQ4LDExIEBAIGNsYXNzIEJlbmNobWFya1Jlc3VsdHMob2JqZWN0 KToKICAgICAgICAgc2VsZi5fbGludF9yZXN1bHRzKHJlc3VsdHMpCiAgICAgICAgIHNlbGYuX3Jl c3VsdHMgPSBzZWxmLl9hZ2dyZWdhdGVfcmVzdWx0cyhyZXN1bHRzKQogCi0gICAgZGVmIGZvcm1h dChzZWxmLCBzY2FsZV91bml0PVRydWUsIHNob3dfaXRlcmF0aW9uX3ZhbHVlcz1GYWxzZSwgbWF4 X2RlcHRoPU5vbmUpOgotICAgICAgICByZXR1cm4gc2VsZi5fZm9ybWF0X3Rlc3RzKHNlbGYuX3Jl c3VsdHMsIHNjYWxlX3VuaXQsIHNob3dfaXRlcmF0aW9uX3ZhbHVlcywgbWF4X2RlcHRoKQorICAg IGRlZiBmb3JtYXQoc2VsZiwgc2NhbGVfdW5pdD1UcnVlLCBzaG93X2l0ZXJhdGlvbl92YWx1ZXM9 RmFsc2UpOgorICAgICAgICByZXR1cm4gc2VsZi5fZm9ybWF0X3Rlc3RzKHNlbGYuX3Jlc3VsdHMs IHNjYWxlX3VuaXQsIHNob3dfaXRlcmF0aW9uX3ZhbHVlcykKIAogICAgIEBjbGFzc21ldGhvZAot ICAgIGRlZiBfZm9ybWF0X3Rlc3RzKGNscywgdGVzdHMsIHNjYWxlX3VuaXQsIHNob3dfaXRlcmF0 aW9uX3ZhbHVlcywgbWF4X2RlcHRoLCBpbmRlbnQ9JycpOgotICAgICAgICBpZiBtYXhfZGVwdGgg aXMgbm90IE5vbmUgYW5kIG1heF9kZXB0aCA8PSAwOgotICAgICAgICAgICAgcmV0dXJuICcnCisg ICAgZGVmIF9mb3JtYXRfdGVzdHMoY2xzLCB0ZXN0cywgc2NhbGVfdW5pdCwgc2hvd19pdGVyYXRp b25fdmFsdWVzLCBpbmRlbnQ9JycpOgogICAgICAgICBvdXRwdXQgPSAnJwogICAgICAgICBjb25m aWdfbmFtZSA9ICdjdXJyZW50JwogICAgICAgICBmb3IgdGVzdF9uYW1lIGluIHNvcnRlZCh0ZXN0 cy5rZXlzKCkpOgpAQCAtNzUsNyArNzMsNyBAQCBjbGFzcyBCZW5jaG1hcmtSZXN1bHRzKG9iamVj dCk6CiAgICAgICAgICAgICAgICAgICAgICAgICBvdXRwdXQgKz0gYWdncmVnYXRvcl9uYW1lICsg JzonCiAgICAgICAgICAgICAgICAgICAgIG91dHB1dCArPSAnICcgKyBjbHMuX2Zvcm1hdF92YWx1 ZXMobWV0cmljX25hbWUsIG1ldHJpY1thZ2dyZWdhdG9yX25hbWVdW2NvbmZpZ19uYW1lXSwgc2Nh bGVfdW5pdCwgc2hvd19pdGVyYXRpb25fdmFsdWVzKSArICdcbicKICAgICAgICAgICAgIGlmICd0 ZXN0cycgaW4gdGVzdDoKLSAgICAgICAgICAgICAgICBvdXRwdXQgKz0gY2xzLl9mb3JtYXRfdGVz dHModGVzdFsndGVzdHMnXSwgc2NhbGVfdW5pdCwgc2hvd19pdGVyYXRpb25fdmFsdWVzLCBtYXhf ZGVwdGggLSAxIGlmIG1heF9kZXB0aCBlbHNlIE5vbmUsIGluZGVudD0oaW5kZW50ICsgJyAnICog bGVuKHRlc3RfbmFtZSkpKQorICAgICAgICAgICAgICAgIG91dHB1dCArPSBjbHMuX2Zvcm1hdF90 ZXN0cyh0ZXN0Wyd0ZXN0cyddLCBzY2FsZV91bml0LCBzaG93X2l0ZXJhdGlvbl92YWx1ZXMsIGlu ZGVudD0oaW5kZW50ICsgJyAnICogbGVuKHRlc3RfbmFtZSkpKQogICAgICAgICByZXR1cm4gb3V0 cHV0CiAKICAgICBAY2xhc3NtZXRob2QKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvYmVuY2htYXJrX3J1bm5lci9iZW5jaG1hcmtfcmVzdWx0c191bml0dGVzdC5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvYmVuY2htYXJrX3J1bm5lci9iZW5jaG1hcmtfcmVzdWx0c191bml0 dGVzdC5weQppbmRleCBmM2RiNGIzZmQwYWJiZmRlODMzNTU5NjgzMmYxZDNjNTM4YThjNTA2Li5k NGJlNDNjODJlMzczNjU3NTY1YzEwY2EwMDdjM2VmMjNlYjExZTJlIDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2JlbmNobWFya19ydW5uZXIvYmVuY2htYXJrX3Jlc3VsdHNfdW5p dHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9iZW5jaG1hcmtfcnVubmVyL2Jl bmNobWFya19yZXN1bHRzX3VuaXR0ZXN0LnB5CkBAIC01NSwxOCArNTUsNiBAQCBTb21lVGVzdDpU aW1lOkFyaXRobWV0aWM6IDMuMG1zIHN0ZGV2PTMzLjMlCiAgICAgICAgIFN1YlRlc3QyOlRpbWU6 IDUuMG1zIHN0ZGV2PTIwLjAlCiAnJydbMTpdKQogCi0gICAgZGVmIHRlc3RfZm9ybWF0X3dpdGhf ZGVwdGhfbGltaXQoc2VsZik6Ci0gICAgICAgIHJlc3VsdCA9IEJlbmNobWFya1Jlc3VsdHMoeydT b21lVGVzdCc6IHsKLSAgICAgICAgICAgICdtZXRyaWNzJzogeydUaW1lJzogWydUb3RhbCcsICdB cml0aG1ldGljJ119LAotICAgICAgICAgICAgJ3Rlc3RzJzogewotICAgICAgICAgICAgICAgICdT dWJUZXN0MSc6IHsnbWV0cmljcyc6IHsnVGltZSc6IHsnY3VycmVudCc6IFsxLCAyLCAzXX19fSwK LSAgICAgICAgICAgICAgICAnU3ViVGVzdDInOiB7J21ldHJpY3MnOiB7J1RpbWUnOiB7J2N1cnJl bnQnOiBbNCwgNSwgNl19fX19fX0pCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocmVzdWx0LmZv cm1hdChtYXhfZGVwdGg9MSksICcnJwotU29tZVRlc3Q6VGltZTpBcml0aG1ldGljOiAzLjBtcyBz dGRldj0zMy4zJQotICAgICAgICA6VGltZTpUb3RhbDogNy4wbXMgc3RkZXY9MjguNiUKLScnJ1sx Ol0pCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocmVzdWx0LmZvcm1hdChtYXhfZGVwdGg9MCks ICIiKQotCiAgICAgZGVmIHRlc3RfZm9ybWF0X3ZhbHVlc193aXRoX2xhcmdlX2Vycm9yKHNlbGYp OgogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKEJlbmNobWFya1Jlc3VsdHMuX2Zvcm1hdF92YWx1 ZXMoJ1J1bnMnLCBbMSwgMiwgM10pLCAnMi4wL3Mgc3RkZXY9NTAuMCUnKQogICAgICAgICBzZWxm LmFzc2VydEVxdWFsKEJlbmNobWFya1Jlc3VsdHMuX2Zvcm1hdF92YWx1ZXMoJ1J1bnMnLCBbMTAs IDIwLCAzMF0pLCAnMjAvcyBzdGRldj01MC4wJScpCg==