18935 2008-05-07 22:32:46 -0700 [Gtk] Plugin Load crashes with NP_FULL mode 2008-05-25 02:56:45 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 sriram.neelakandan webkit-unassigned marc.ordinasillopis pierre-luc.beaudoin oldest_to_newest 79857 0 sriram.neelakandan 2008-05-07 22:32:46 -0700 NP_EMBED mode plugin works fine, when the same plugin is loaded with the URL, it crashes at void PluginView::didReceiveData(const char* data, int length) { ASSERT(m_loadManually); ASSERT(m_manualStream); m_manualStream->didReceiveData(0, data, length); } On further DEBUG i found m_manualStream is NULL. Reason: PluginView::didReceiveResponse does not get called, from FrameLoaderClient::commitedLoad. FrameLoaderCleint::m_hasSentResponseToPlugin is not initialized and has some JUNK data. So the following check fails : if (!m_hasSentResponseToPlugin) { m_pluginView->didReceiveResponse(loader->response()); m_hasSentResponseToPlugin = true; } I will attach a patch shortly to initialize m_hasSentResponseToPlugin 79860 1 21007 sriram.neelakandan 2008-05-07 23:03:22 -0700 Created attachment 21007 Fix for NP_FULL crash This uninitialized variable caused a crash as explained in the bug 79861 2 21008 sriram.neelakandan 2008-05-07 23:05:12 -0700 Created attachment 21008 Re-init variable in redirectDataToPlugin Not sure if this one is required. May be some one who knows the code better can take this in if required. 79883 3 21017 marc.ordinasillopis 2008-05-08 08:17:06 -0700 Created attachment 21017 Fix the bug for Qt This is the same fix applied to the Qt port. 79960 4 21017 hausmann 2008-05-09 01:52:19 -0700 Comment on attachment 21017 Fix the bug for Qt #21017 landed in r33001. 80163 5 marc.ordinasillopis 2008-05-12 01:33:53 -0700 The Gtk patches haven't landed yet, so I think this one should be re-opened. 80171 6 pierre-luc.beaudoin 2008-05-12 06:33:45 -0700 Reopening for the Gtk patch. 81429 7 alp 2008-05-25 02:56:45 -0700 Landed in r34121. 21007 2008-05-07 23:03:22 -0700 2008-05-25 02:56:24 -0700 Fix for NP_FULL crash pl_patch1.txt text/plain 1016 sriram.neelakandan SW5kZXg6IFdlYktpdC9ndGsvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvQ2hh bmdlTG9nICAgICAgICAocmV2aXNpb24gMzI5NzApCisrKyBXZWJLaXQvZ3RrL0NoYW5nZUxvZyAg ICAgICAgKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMCBAQAorMjAwOC0wNS0wNyAgU3JpcmFt IE5lZWxha2FuZGFuICA8c3JpcmFtLm5lZWxha2FuZGFuQGdtYWlsLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Zy YW1lTG9hZGVyQ2xpZW50R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6RnJhbWVMb2FkZXJDbGll bnQ6OkZyYW1lTG9hZGVyQ2xpZW50KToKKwogMjAwOC0wNS0wNiAgQ2hyaXN0aWFuIER5d2FuICA8 Y2hyaXN0aWFuQHR3b3RvYXN0cy5kZT4KCiAgICAgICAgICBSdWJiZXIgc3RhbXBlZCBieSBBbHAu CkluZGV4OiBXZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xp ZW50R3RrLmNwcCAgKHJldmlzaW9uIDMyOTcwKQorKysgV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9y dC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAgICh3b3JraW5nIGNvcHkpCkBAIC01OSw2ICs1OSw3 IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogRnJhbWVMb2FkZXJDbGllbnQ6OkZyYW1lTG9hZGVyQ2xp ZW50KFdlYktpdFdlYkZyYW1lKiBmcmFtZSkKICAgICA6IG1fZnJhbWUoZnJhbWUpCiAgICAgLCBt X3BsdWdpblZpZXcoMCkKKyAgICAsIG1faGFzU2VudFJlc3BvbnNlVG9QbHVnaW4oZmFsc2UpCiAg ICAgLCBtX3VzZXJBZ2VudCgiIikKIHsKICAgICBBU1NFUlQobV9mcmFtZSk7Cgo= 21008 2008-05-07 23:05:12 -0700 2008-05-25 02:56:26 -0700 Re-init variable in redirectDataToPlugin pl_patch2.txt text/plain 535 sriram.neelakandan SW5kZXg6IFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRHdGsuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGll bnRHdGsuY3BwICAocmV2aXNpb24gMzI5NzApCisrKyBXZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0 L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcCAgKHdvcmtpbmcgY29weSkKQEAgLTMxNyw3ICszMTgs OSBAQCBQYXNzUmVmUHRyPEZyYW1lPiBGcmFtZUxvYWRlckNsaWVudDo6Y3JlCgogdm9pZCBGcmFt ZUxvYWRlckNsaWVudDo6cmVkaXJlY3REYXRhVG9QbHVnaW4oV2lkZ2V0KiBwbHVnaW5XaWRnZXQp CiB7CisgICAgQVNTRVJUKCFtX3BsdWdpblZpZXcpOwogICAgIG1fcGx1Z2luVmlldyA9IHN0YXRp Y19jYXN0PFBsdWdpblZpZXcqPihwbHVnaW5XaWRnZXQpOworICAgIG1faGFzU2VudFJlc3BvbnNl VG9QbHVnaW4gPSBmYWxzZTsKIH0KCg== 21017 2008-05-08 08:17:06 -0700 2008-05-09 00:55:35 -0700 Fix the bug for Qt plugins-qt-bug18935-r32979.patch text/plain 1625 marc.ordinasillopis SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gMzI5NzkpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDgtMDUtMDggIE1hcmMgT3JkaW5hcyBpIExsb3BpcyAg PG1hcmMub3JkaW5hc2lsbG9waXNAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODkzNQorICAgICAgICAKKyAgICAgICAgQmFzZWQgb24gd29yayBieSBT cmlyYW0gTmVlbGFrYW5kYW4gZm9yIHRoZSBHdGsgcG9ydC4KKworICAgICAgICAqIFdlYkNvcmVT dXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwOiBJbml0aWFsaXplCisgICAgICAgIG1faGFz U2VudFJlc3BvbnNlVG9QbHVnaW4uCisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVu dFF0OjpGcmFtZUxvYWRlckNsaWVudFF0KToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVy Q2xpZW50UXQ6OnJlZGlyZWN0RGF0YVRvUGx1Z2luKToKKwogMjAwOC0wNS0wOCAgV2Fyd2ljayBB bGxpc29uICA8d2Fyd2lja0B0cm9sbHRlY2guY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNp bW9uLgpJbmRleDogV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNs aWVudFF0LmNwcAkocmV2aXNpb24gMzI5NzkpCisrKyBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQv RnJhbWVMb2FkZXJDbGllbnRRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzNSw2ICsxMzUsNyBA QCBGcmFtZUxvYWRlckNsaWVudFF0OjpGcmFtZUxvYWRlckNsaWVudFF0CiAgICAgOiBtX2ZyYW1l KDApCiAgICAgLCBtX3dlYkZyYW1lKDApCiAgICAgLCBtX3BsdWdpblZpZXcoMCkKKyAgICAsIG1f aGFzU2VudFJlc3BvbnNlVG9QbHVnaW4oZmFsc2UpCiAgICAgLCBtX2ZpcnN0RGF0YShmYWxzZSkK ICAgICAsIG1fcG9saWN5RnVuY3Rpb24oMCkKICAgICAsIG1fbG9hZFN1Y2NlZWRlZChmYWxzZSkK QEAgLTEwODcsNyArMTA4OCw5IEBAIFdpZGdldCogRnJhbWVMb2FkZXJDbGllbnRRdDo6Y3JlYXRl UGx1Z2kKIAogdm9pZCBGcmFtZUxvYWRlckNsaWVudFF0OjpyZWRpcmVjdERhdGFUb1BsdWdpbihX aWRnZXQqIHBsdWdpbldpZGdldCkKIHsKKyAgICBBU1NFUlQoIW1fcGx1Z2luVmlldyk7CiAgICAg bV9wbHVnaW5WaWV3ID0gc3RhdGljX2Nhc3Q8UGx1Z2luVmlldyo+KHBsdWdpbldpZGdldCk7Cisg ICAgbV9oYXNTZW50UmVzcG9uc2VUb1BsdWdpbiA9IGZhbHNlOwogfQogCiBXaWRnZXQqIEZyYW1l TG9hZGVyQ2xpZW50UXQ6OmNyZWF0ZUphdmFBcHBsZXRXaWRnZXQoY29uc3QgSW50U2l6ZSYsIEVs ZW1lbnQqLCBjb25zdCBLVVJMJiBiYXNlVVJMLAo=