189349 2018-09-06 07:46:14 -0700 [GStreamer] Several media related tests timing out around the same revision 2018-09-10 02:10:50 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez pnormand bugs-noreply calvaris cgarcia pnormand oldest_to_newest 1457078 0 magomez 2018-09-06 07:46:14 -0700 media/media-ended.html [ Timeout ] media/media-fragments/TC0004.html [ Timeout ] media/media-fragments/TC0017.html [ Timeout ] media/video-currentTime-delay.html [ Timeout ] media/video-currentTime-set.html [ Timeout ] I already reported bugs for the flakiness of these tests, but I suspect there might be something common to all of them that could be related to their timeouts. All the timeouts started to happen around r234983 (at least one at that revision exactly), which makes me think that it could be related. Checking that revision I see that it's precisely media related: [GStreamer] reduce position queries frequency, so that could have something to do with the problem. 1457079 1 magomez 2018-09-06 07:47:07 -0700 Phil, could you give it a look and check whether your change could be causing the timeouts? If not, just call me crazy and close the bug ;) 1457461 2 pnormand 2018-09-07 05:01:45 -0700 It's possible yes :) I'll try to check this, soon... 1457542 3 pnormand 2018-09-07 10:50:45 -0700 I almost have a patch. 1457545 4 pnormand 2018-09-07 10:51:30 -0700 *** Bug 189340 has been marked as a duplicate of this bug. *** 1457547 5 pnormand 2018-09-07 10:51:51 -0700 *** Bug 189341 has been marked as a duplicate of this bug. *** 1457550 6 pnormand 2018-09-07 10:52:11 -0700 *** Bug 189342 has been marked as a duplicate of this bug. *** 1457552 7 pnormand 2018-09-07 10:52:39 -0700 *** Bug 189346 has been marked as a duplicate of this bug. *** 1457554 8 pnormand 2018-09-07 10:52:58 -0700 *** Bug 189348 has been marked as a duplicate of this bug. *** 1457564 9 349163 pnormand 2018-09-07 11:05:00 -0700 Created attachment 349163 Patch 1458085 10 349163 cgarcia 2018-09-09 23:43:55 -0700 Comment on attachment 349163 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349163&action=review > Source/WebCore/ChangeLog:3 > + [GTK] Several media related tests timing out around the same revision Why is this GTK specific? > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:348 > - if (m_lastQuery > -1 && ((now - m_lastQuery) < 300) && m_cachedPosition.isValid()) > + if (m_lastQuery > -1 && ((now - m_lastQuery) < 200) && m_cachedPosition.isValid()) This would be easier to read if m_lastQuery was a std::optional<Seconds> (and probably renamed to m_lastQuertTime) and now was Seconds too. I would also avoid the magic number, giving 200 a name: static const Seconds positionCacheThreshold = 200_ms; Seconds now = WTF::WallTime::now().secondsSinceEpoch(); if (m_lastQueryTime && (now - m_lastQueryTime.value()) < positionCacheThreshold && m_cachedPosition.isValid()) something like that 1458107 11 pnormand 2018-09-10 02:10:50 -0700 Committed r235846: <https://trac.webkit.org/changeset/235846> 349163 2018-09-07 11:05:00 -0700 2018-09-09 23:43:55 -0700 Patch bug-189349-20180907200459.patch text/plain 6193 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjhjNmFiN2I4ZTU4ODA1 ZTQyMjNmZTZjNGUwMDlkZGI5NTMyODA3ZS4uZDMzNDUxNDk1YmU0YzYwZWFlZjY3OWFiNzRlYzI3 MTNlMGY5ZTI1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA5LTA3ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBTZXZl cmFsIG1lZGlhIHJlbGF0ZWQgdGVzdHMgdGltaW5nIG91dCBhcm91bmQgdGhlIHNhbWUgcmV2aXNp b24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTM0 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSB0 aW1lb3V0cyB3ZXJlIGhhcHBlbmluZyBiZWNhdXNlIHRoZSBgZW5kZWRgIGV2ZW50IHdhcyBubwor ICAgICAgICBsb25nZXIgcHJvcGVybHkgZW1pdHRlZC4gVGhlIGNoYW5nZSBpbiBwbGF5YmFja1Bv c2l0aW9uIGFsc28KKyAgICAgICAgZW5zdXJlcyBgdGltZXVwZGF0ZWAgZXZlbnQgcmVtYWlucyBl bWl0dGVkIGluIGEuLi4gdGltZWx5IG1hbm5lci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpwbGF5YmFja1Bvc2l0aW9uIGNv bnN0KToKKyAgICAgICAgUmVkdWNlIHRoZSBwb3NpdGlvbiBjYWNoZSB0aHJlc2hvbGQgdG8gMjAw bXMsIHdoaWNoIGlzIGEgdmFsdWUKKyAgICAgICAgc2xpZ2h0bHkgbG93ZXIgdGhhbiB0aGUgMjUw bXMgZGVmaW5lZCBpbiBIVE1MTWVkaWFFbGVtZW50LgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQ bGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpkaWRFbmQpOiBSZXNldCB0aGUgY2FjaGVkCisgICAgICAg IHBvc2l0aW9uIHZhbHVlIHRvIGVuc3VyZSB0aGUgZm9sbG93aW5nIHF1ZXJ5IHdpbGwgbW9zdCBs aWtlbHkKKyAgICAgICAgcmV0dXJuIHRoZSBzYW1lIHZhbHVlIGFzIHJlcG9ydGVkIGJ5IHRoZSBk dXJhdGlvbiBxdWVyeS4KKwogMjAxOC0wOS0wNiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBTaGFkb3dSb290IHNob3VsZCBoYXZlIGl0cyBvd24gbm9kZSBmbGFn CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4 IGEzNmQxYTQ5NTY3NDM4OTJmZTY2NTFlNGYwODBjZGVhMmM4ZGNjNzMuLmMyNmJiYTM5M2JmNzg2 NzA5ZTVjMmE2NTY2NWU3ZjNiYmE5NjM1N2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXIuY3BwCkBAIC0zNDUsNyArMzQ1LDcgQEAgTWVkaWFUaW1lIE1l ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6cGxheWJhY2tQb3NpdGlvbigpIGNvbnN0CiAgICAg ICAgIHJldHVybiBtX3NlZWtUaW1lOwogCiAgICAgZG91YmxlIG5vdyA9IFdURjo6V2FsbFRpbWU6 Om5vdygpLnNlY29uZHNTaW5jZUVwb2NoKCkubWlsbGlzZWNvbmRzKCk7Ci0gICAgaWYgKG1fbGFz dFF1ZXJ5ID4gLTEgJiYgKChub3cgLSBtX2xhc3RRdWVyeSkgPCAzMDApICYmIG1fY2FjaGVkUG9z aXRpb24uaXNWYWxpZCgpKQorICAgIGlmIChtX2xhc3RRdWVyeSA+IC0xICYmICgobm93IC0gbV9s YXN0UXVlcnkpIDwgMjAwKSAmJiBtX2NhY2hlZFBvc2l0aW9uLmlzVmFsaWQoKSkKICAgICAgICAg cmV0dXJuIG1fY2FjaGVkUG9zaXRpb247CiAKICAgICBtX2xhc3RRdWVyeSA9IG5vdzsKQEAgLTIx NDksNiArMjE0OSw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpkaWRFbmQo KQogICAgIC8vIFN5bmNocm9uaXplIHBvc2l0aW9uIGFuZCBkdXJhdGlvbiB2YWx1ZXMgdG8gbm90 IGNvbmZ1c2UgdGhlCiAgICAgLy8gSFRNTE1lZGlhRWxlbWVudC4gSW4gc29tZSBjYXNlcyBsaWtl IHJldmVyc2UgcGxheWJhY2sgdGhlCiAgICAgLy8gcG9zaXRpb24gaXMgbm90IGFsd2F5cyByZXBv cnRlZCBhcyAwIGZvciBpbnN0YW5jZS4KKyAgICBtX2NhY2hlZFBvc2l0aW9uID0gTWVkaWFUaW1l OjppbnZhbGlkVGltZSgpOwogICAgIE1lZGlhVGltZSBub3cgPSBjdXJyZW50TWVkaWFUaW1lKCk7 CiAgICAgaWYgKG5vdyA+IE1lZGlhVGltZSB7IH0gJiYgbm93IDw9IGR1cmF0aW9uTWVkaWFUaW1l KCkpCiAgICAgICAgIG1fcGxheWVyLT5kdXJhdGlvbkNoYW5nZWQoKTsKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmNWEyN2Zk M2NmYmQ1ZmM1NTczZGU4OTIwNTc5Y2U3ZTcwNjY2MTdkLi43NjkyNGFmZjJjY2I3MDlhZjBhZjY0 ZTQ2NzNkNWJjMzZmMTc1Y2U4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTgtMDktMDcgIFBo aWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFNl dmVyYWwgbWVkaWEgcmVsYXRlZCB0ZXN0cyB0aW1pbmcgb3V0IGFyb3VuZCB0aGUgc2FtZSByZXZp c2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5 MzQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczogVW5mbGFnIFRpbWVvdXQgZnJvbSBub3ctdW5h ZmZlY3RlZCB0ZXN0cy4KKwogMjAxOC0wOS0wNiAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUu Y29tPgogCiAgICAgICAgIFtMRkNdIEFkZCBzdXBwb3J0IGZvciBtaW4vbWF4LWhlaWdodCBwZXJj ZW50YWdlIHZhbHVlcy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0 RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMK aW5kZXggNDAyODc5ODJlMDZkMmRkMDA1Y2JlNmIwYzMxNzVmN2QwZTIxYTg1NC4uNGI1MjAxNDk2 Y2NhOWNiNzM3MTM5MDA0YWUyNjQ5Y2Q2M2U3N2EwOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Z3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTE1MjcsMTQgKzE1MjcsMTMgQEAgd2Via2l0Lm9yZy9i LzEzMjE4NSBlZGl0aW5nL3Bhc3RlYm9hcmQvZ3RrL21pZGRsZS1idXR0b24tcGFzdGUuaHRtbCBb IEZhaWx1cmUgUGEKICMgU29tZSBtZWRpYSBmcmFnbWVudCB0ZXN0cyBhcmUgZmxha3kKIHdlYmtp dC5vcmcvYi8xMzIyNDggbWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RDMDAwMS5odG1sIFsgVGltZW91 dCBQYXNzIF0KIHdlYmtpdC5vcmcvYi8xMzIyNDggbWVkaWEvbWVkaWEtZnJhZ21lbnRzL1RDMDAw Mi5odG1sIFsgQ3Jhc2ggUGFzcyBdCi13ZWJraXQub3JnL2IvMTMyMjQ4IG1lZGlhL21lZGlhLWZy YWdtZW50cy9UQzAwMDQuaHRtbCBbIFRpbWVvdXQgQ3Jhc2ggUGFzcyBdCit3ZWJraXQub3JnL2Iv MTMyMjQ4IG1lZGlhL21lZGlhLWZyYWdtZW50cy9UQzAwMDQuaHRtbCBbIENyYXNoIFBhc3MgXQog d2Via2l0Lm9yZy9iLzEzMjI0OCBtZWRpYS9tZWRpYS1mcmFnbWVudHMvVEMwMDA1Lmh0bWwgWyBG YWlsdXJlIENyYXNoIFBhc3MgXQogd2Via2l0Lm9yZy9iLzEzMjI0OCBtZWRpYS9tZWRpYS1mcmFn bWVudHMvVEMwMDA2Lmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogd2Via2l0Lm9yZy9iLzEzMjI0OCBt ZWRpYS9tZWRpYS1mcmFnbWVudHMvVEMwMDA5Lmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogd2Via2l0 Lm9yZy9iLzEzMjI0OCBtZWRpYS9tZWRpYS1mcmFnbWVudHMvVEMwMDExLmh0bWwgWyBGYWlsdXJl IFBhc3MgXQogd2Via2l0Lm9yZy9iLzEzMjI0OCBtZWRpYS9tZWRpYS1mcmFnbWVudHMvVEMwMDE0 Lmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogd2Via2l0Lm9yZy9iLzEzMjI0OCBtZWRpYS9tZWRpYS1m cmFnbWVudHMvVEMwMDE1Lmh0bWwgWyBGYWlsdXJlIENyYXNoIFBhc3MgXQotd2Via2l0Lm9yZy9i LzEzMjI0OCBtZWRpYS9tZWRpYS1mcmFnbWVudHMvVEMwMDE3Lmh0bWwgWyBUaW1lb3V0IFBhc3Mg XQogd2Via2l0Lm9yZy9iLzEzNDU3NCBtZWRpYS9tZWRpYS1mcmFnbWVudHMvVEMwMDI0Lmh0bWwg WyBGYWlsdXJlIFRpbWVvdXQgUGFzcyBdCiB3ZWJraXQub3JnL2IvMTMyMjQ4IG1lZGlhL21lZGlh LWZyYWdtZW50cy9UQzAwMzUuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCiB3ZWJraXQub3JnL2IvMTMy MjQ4IG1lZGlhL21lZGlhLWZyYWdtZW50cy9UQzAwMzYuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCkBA IC0xOTg0LDcgKzE5ODMsNyBAQCB3ZWJraXQub3JnL2IvMTg2NjczIGVkaXRpbmcvc3BlbGxpbmcv c3BlbGxjaGVjay1hc3luYy1tdXRhdGlvbi5odG1sIFsgRmFpbHVyZSBQYQogCiB3ZWJraXQub3Jn L2IvMTg2Njc4IGZhc3QvbWVkaWFzdHJlYW0vY2hhbmdlLXRyYWNrcy1tZWRpYS1zdHJlYW0tYmVp bmctcGxheWVkLmh0bWwgWyBDcmFzaCBQYXNzIF0KIAotd2Via2l0Lm9yZy9iLzE4NjY3OSBtZWRp YS92aWRlby1jdXJyZW50VGltZS1kZWxheS5odG1sIFsgVGltZW91dCBDcmFzaCBQYXNzIF0KK3dl YmtpdC5vcmcvYi8xODY2NzkgbWVkaWEvdmlkZW8tY3VycmVudFRpbWUtZGVsYXkuaHRtbCBbIENy YXNoIFBhc3MgXQogCiB3ZWJraXQub3JnL2IvMTg2NzUwIGltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvV2ViQ3J5cHRvQVBJL2Rlcml2ZV9iaXRzX2tleXMvdGVzdF9oa2RmLmh0dHBzLmh0 bWwgWyBQYXNzIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE4Njc1MCBpbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL1dlYkNyeXB0b0FQSS9kZXJpdmVfYml0c19rZXlzL3Rlc3RfcGJrZGYy X3Nob3J0X2xvbmcuaHR0cHMuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCkBAIC0yMDQ0LDE2ICsyMDQz LDYgQEAgd2Via2l0Lm9yZy9iLzE4OTMzOCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz L3Zpc3VhbC12aWV3cG9ydC92aWV3cG9ydC1yZXMKIAogd2Via2l0Lm9yZy9iLzE4OTMzOSBjb21w b3NpdGluZy9maWx0ZXJzL29wYWNpdHktY2hhbmdlLW9uLWZpbHRlcmVkLXBhaW50cy1pbnRvLWFu Y2VzdG9yLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIFBhc3MgXQogCi13ZWJraXQub3JnL2IvMTg5 MzQwIHdlYmF1ZGlvL3NpbGVuY2UtYWZ0ZXItcGxheWJhY2suaHRtbCBbIEZhaWx1cmUgVGltZW91 dCBQYXNzIF0KLQotd2Via2l0Lm9yZy9iLzE4OTM0MSBodHRwL3Rlc3RzL3NlY3VyaXR5L3dlYmF1 ZGlvLXJlbmRlci1yZW1vdGUtYXVkaW8tYWxsb3dlZC1jcm9zc29yaWdpbi5odG1sIFsgVGltZW91 dCBQYXNzIF0KLQotd2Via2l0Lm9yZy9iLzE4OTM0MiBtZWRpYS9tZWRpYS1mdWxsc2NyZWVuLXJl dHVybi10by1pbmxpbmUuaHRtbCBbIFRpbWVvdXQgUGFzcyBdCi0KLXdlYmtpdC5vcmcvYi8xODkz NDYgbWVkaWEvbWVkaWEtZW5kZWQuaHRtbCBbIFRpbWVvdXQgUGFzcyBdCi0KLXdlYmtpdC5vcmcv Yi8xODkzNDggbWVkaWEvdmlkZW8tY3VycmVudFRpbWUtc2V0Lmh0bWwgWyBUaW1lb3V0IFBhc3Mg XQotCiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwogIyBFbmQgb2YgRmxha3kgdGVz dHMKICMvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCg==