189347 2018-09-06 07:33:13 -0700 Move regress-189185.js under JSTests/wasm. 2018-09-09 13:26:39 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=189312 InRadar P2 Normal --- 1 dominik.infuehr mark.lam commit-queue keith_miller mark.lam msaboff realdawei saam webkit-bug-importer ysuzuki oldest_to_newest 1457072 0 dominik.infuehr 2018-09-06 07:33:13 -0700 Disable test when WebAssembly not enabled 1457074 1 349022 dominik.infuehr 2018-09-06 07:35:56 -0700 Created attachment 349022 Patch 1457076 2 349023 dominik.infuehr 2018-09-06 07:38:42 -0700 Created attachment 349023 Patch 1457080 3 349023 saam 2018-09-06 07:47:43 -0700 Comment on attachment 349023 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349023&action=review > JSTests/stress/regress-189185.js:1 > +//@ skip if !isWebAssemblyEnabled Why not move this test into the Wasm test directory? 1457111 4 349023 mark.lam 2018-09-06 09:42:37 -0700 Comment on attachment 349023 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=349023&action=review >> JSTests/stress/regress-189185.js:1 >> +//@ skip if !isWebAssemblyEnabled > > Why not move this test into the Wasm test directory? I agree with Saam. I should have put this test in JSTests/wasm directory. I just wasn't aware of that option at the time. Let's move the test there instead. Thanks. 1457147 5 mark.lam 2018-09-06 10:59:52 -0700 Since Dominik hasn't responded yet, and this issue seems to be creating problems with some of our internal testing as well, I'll go ahead and implement the fix. 1457167 6 349048 mark.lam 2018-09-06 11:49:07 -0700 Created attachment 349048 patch for landing. 1457187 7 349048 commit-queue 2018-09-06 12:47:23 -0700 Comment on attachment 349048 patch for landing. Rejecting attachment 349048 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 349048, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/JSTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: https://webkit-queues.webkit.org/results/9117011 1457203 8 mark.lam 2018-09-06 12:59:52 -0700 Landed in r235751: <http://trac.webkit.org/r235751>. 1457207 9 webkit-bug-importer 2018-09-06 13:02:56 -0700 <rdar://problem/44193122> 1457440 10 dominik.infuehr 2018-09-07 01:27:07 -0700 Thanks for fixing that! 349022 2018-09-06 07:35:56 -0700 2018-09-06 07:38:27 -0700 Patch bug-189347-20180906163555.patch text/plain 2159 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NzMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTBhYzcyM2FlNmM2Nzk5MzY2MThkMzg3OWIzZGJiNzJj ZTNlOWQxZi4uMWE0YzYwNzdhOGVjYmVjZTA4MmE5ZTFjZGE1ZTY4ODk4NzEyOTFmNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE4LTA5LTA2ICBEb21pbmlrIEluZnVlaHIgIDxkaW5mdWVockBpZ2FsaWEuY29tPgor CisgICAgICAgIERpc2FibGUgdGVzdCB3aGVuIFdlYkFzc2VtYmx5IG5vdCBlbmFibGVkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkzNDcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworCUFkZCBmdW5jdGlvbiB0aGF0IHRl c3RzIGlmIFdlYkFzc2VtYmx5IGlzIGVuYWJsZWQuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1q c2Mtc3RyZXNzLXRlc3RzOgorCiAyMDE4LTA5LTA1ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3Rl YWRAc29ueS5jb20+CiAKICAgICAgICAgW0NNYWtlXSBBbGxvdyBwb3J0IHNwZWNpZmljIG9wdGlv bnMgb24gZ3Rlc3QKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVz dHMgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCmluZGV4IGI3OTFkZjhmYTdh ZjgwNGQyODRmNjE5ZTAyNzY0MTU0MDk0YjNkNjAuLmY1MGM5Mzk0MWZmM2UwODNiMzRlYzcwODRm MmNlYzczZjRlNjFlNjkgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3Mt dGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwpAQCAtNDM3LDYg KzQzNywxMCBAQCBkZWYgaXNGVExFbmFibGVkCiAgICAgJGppdFRlc3RzICYmICRpc0ZUTFBsYXRm b3JtCiBlbmQKIAorZGVmIGlzV2ViQXNzZW1ibHlFbmFibGVkCisgICAgJGppdFRlc3RzICYmICRp c0ZUTFBsYXRmb3JtCitlbmQKKwogaWYgISR0ZXN0UnVubmVyVHlwZQogICAgIGlmICRyZW1vdGUg YW5kICRob3N0T1MgPT0gImRhcndpbiIKICAgICAgICAgJHRlc3RSdW5uZXJUeXBlID0gOnNoZWxs CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4 IGQyNjc2MGQ2NzM3MDRjNWYyYTc3ZDBjODExZjY1NWJjYzU1YWE2MjMuLjg0YzQ2MTVkZTVmOWU5 ZmI2OTY5ZDA5NjQ0ODk0YmZiNmNiNmZlYTQgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9n CisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTgtMDktMDYgIERv bWluaWsgSW5mdWVociAgPGRpbmZ1ZWhyQGlnYWxpYS5jb20+CisKKyAgICAgICAgRGlzYWJsZSB0 ZXN0IHdoZW4gV2ViQXNzZW1ibHkgbm90IGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTM0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL3JlZ3Jlc3MtMTg5MTg1LmpzOgorCiAy MDE4LTA5LTA1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBKU1By b3BlcnR5TmFtZUVudW1lcmF0b3I6OnZpc2l0Q2hpbGRyZW4oKSBuZWVkcyB0byB2aXNpdCBpdHMg bV9jYWNoZWRTdHJ1Y3R1cmVJRC4KZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL3JlZ3Jlc3Mt MTg5MTg1LmpzIGIvSlNUZXN0cy9zdHJlc3MvcmVncmVzcy0xODkxODUuanMKaW5kZXggMTRiOTAx ZTdjYTI4MWM5ZTk1ZWU3N2Q0MWM4N2JlZWM4OTk2MWY5YS4uNGY3MzE4MjFmMmFhZmU1Y2ExMDI1 ODNiYTQxODcyNjZiMmFkNDg4MSAxMDA2NDQKLS0tIGEvSlNUZXN0cy9zdHJlc3MvcmVncmVzcy0x ODkxODUuanMKKysrIGIvSlNUZXN0cy9zdHJlc3MvcmVncmVzcy0xODkxODUuanMKQEAgLTEsNCAr MSw0IEBACi0vL0Agc2tpcCBpZiAkYXJjaGl0ZWN0dXJlID09ICJ4ODYiCisvL0Agc2tpcCBpZiAh aXNXZWJBc3NlbWJseUVuYWJsZWQKIC8vQCBydW5EZWZhdWx0CiAvLyBUaGlzIHBhc3NlcyBpZiBp dCBkb2VzIG5vdCBjcmFzaC4KIG5ldyBXZWJBc3NlbWJseS5Db21waWxlRXJyb3Ioewo= 349023 2018-09-06 07:38:42 -0700 2018-09-06 11:42:28 -0700 Patch bug-189347-20180906163840.patch text/plain 2166 dominik.infuehr U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NzMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTBhYzcyM2FlNmM2Nzk5MzY2MThkMzg3OWIzZGJiNzJj ZTNlOWQxZi4uY2JmYTc3NWYxNGQxNTRjOGQ4NzIxMGIxZmZjZTAyOTMyNDQxYTk4YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE4LTA5LTA2ICBEb21pbmlrIEluZnVlaHIgIDxkaW5mdWVockBpZ2FsaWEuY29tPgor CisgICAgICAgIERpc2FibGUgdGVzdCB3aGVuIFdlYkFzc2VtYmx5IG5vdCBlbmFibGVkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkzNDcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgZnVuY3Rpb24g dGhhdCB0ZXN0cyBpZiBXZWJBc3NlbWJseSBpcyBlbmFibGVkLgorCisgICAgICAgICogU2NyaXB0 cy9ydW4tanNjLXN0cmVzcy10ZXN0czoKKwogMjAxOC0wOS0wNSAgRG9uIE9sbXN0ZWFkICA8ZG9u Lm9sbXN0ZWFkQHNvbnkuY29tPgogCiAgICAgICAgIFtDTWFrZV0gQWxsb3cgcG9ydCBzcGVjaWZp YyBvcHRpb25zIG9uIGd0ZXN0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3Ry ZXNzLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwppbmRleCBiNzkx ZGY4ZmE3YWY4MDRkMjg0ZjYxOWUwMjc2NDE1NDA5NGIzZDYwLi5mNTBjOTM5NDFmZjNlMDgzYjM0 ZWM3MDg0ZjJjZWM3M2Y0ZTYxZTY5IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi1qc2Mt c3RyZXNzLXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKQEAg LTQzNyw2ICs0MzcsMTAgQEAgZGVmIGlzRlRMRW5hYmxlZAogICAgICRqaXRUZXN0cyAmJiAkaXNG VExQbGF0Zm9ybQogZW5kCiAKK2RlZiBpc1dlYkFzc2VtYmx5RW5hYmxlZAorICAgICRqaXRUZXN0 cyAmJiAkaXNGVExQbGF0Zm9ybQorZW5kCisKIGlmICEkdGVzdFJ1bm5lclR5cGUKICAgICBpZiAk cmVtb3RlIGFuZCAkaG9zdE9TID09ICJkYXJ3aW4iCiAgICAgICAgICR0ZXN0UnVubmVyVHlwZSA9 IDpzaGVsbApkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxv ZwppbmRleCBkMjY3NjBkNjczNzA0YzVmMmE3N2QwYzgxMWY2NTViY2M1NWFhNjIzLi44NGM0NjE1 ZGU1ZjllOWZiNjk2OWQwOTY0NDg5NGJmYjZjYjZmZWE0IDEwMDY0NAotLS0gYS9KU1Rlc3RzL0No YW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE4LTA5 LTA2ICBEb21pbmlrIEluZnVlaHIgIDxkaW5mdWVockBpZ2FsaWEuY29tPgorCisgICAgICAgIERp c2FibGUgdGVzdCB3aGVuIFdlYkFzc2VtYmx5IG5vdCBlbmFibGVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkzNDcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9yZWdyZXNzLTE4OTE4NS5q czoKKwogMjAxOC0wOS0wNSAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAg ICAgSlNQcm9wZXJ0eU5hbWVFbnVtZXJhdG9yOjp2aXNpdENoaWxkcmVuKCkgbmVlZHMgdG8gdmlz aXQgaXRzIG1fY2FjaGVkU3RydWN0dXJlSUQuCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9y ZWdyZXNzLTE4OTE4NS5qcyBiL0pTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTg5MTg1LmpzCmluZGV4 IDE0YjkwMWU3Y2EyODFjOWU5NWVlNzdkNDFjODdiZWVjODk5NjFmOWEuLjRmNzMxODIxZjJhYWZl NWNhMTAyNTgzYmE0MTg3MjY2YjJhZDQ4ODEgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvc3RyZXNzL3Jl Z3Jlc3MtMTg5MTg1LmpzCisrKyBiL0pTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTg5MTg1LmpzCkBA IC0xLDQgKzEsNCBAQAotLy9AIHNraXAgaWYgJGFyY2hpdGVjdHVyZSA9PSAieDg2IgorLy9AIHNr aXAgaWYgIWlzV2ViQXNzZW1ibHlFbmFibGVkCiAvL0AgcnVuRGVmYXVsdAogLy8gVGhpcyBwYXNz ZXMgaWYgaXQgZG9lcyBub3QgY3Jhc2guCiBuZXcgV2ViQXNzZW1ibHkuQ29tcGlsZUVycm9yKHsK 349048 2018-09-06 11:49:07 -0700 2018-09-06 12:47:23 -0700 patch for landing. bug-189347.patch text/plain 1945 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzU3NDUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTA5LTA2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBHYXJkZW5pbmc6IE1vdmUgcmVncmVzcy0xODkxODUuanMgdW5kZXIgSlNU ZXN0cy93YXNtLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTg5MzQ3CisKKyAgICAgICAgTm90IHJldmlld2VkLgorCisgICAgICAgICogc3RyZXNzL3Jl Z3Jlc3MtMTg5MTg1LmpzOiBSZW1vdmVkLgorICAgICAgICAqIHdhc20vcmVncmVzcy9yZWdyZXNz LTE4OTE4NS5qczogQ29waWVkIGZyb20gSlNUZXN0cy9zdHJlc3MvcmVncmVzcy0xODkxODUuanMu CisKIDIwMTgtMDktMDUgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAg IEpTUHJvcGVydHlOYW1lRW51bWVyYXRvcjo6dmlzaXRDaGlsZHJlbigpIG5lZWRzIHRvIHZpc2l0 IGl0cyBtX2NhY2hlZFN0cnVjdHVyZUlELgpJbmRleDogSlNUZXN0cy9zdHJlc3MvcmVncmVzcy0x ODkxODUuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvcmVncmVzcy0xODkxODUuanMJ KHJldmlzaW9uIDIzNTc0MSkKKysrIEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTg5MTg1LmpzCShu b25leGlzdGVudCkKQEAgLTEsOCArMCwwIEBACi0vL0Agc2tpcCBpZiAkYXJjaGl0ZWN0dXJlID09 ICJ4ODYiCi0vL0AgcnVuRGVmYXVsdAotLy8gVGhpcyBwYXNzZXMgaWYgaXQgZG9lcyBub3QgY3Jh c2guCi1uZXcgV2ViQXNzZW1ibHkuQ29tcGlsZUVycm9yKHsKLSAgICB2YWx1ZU9mKCkgewotICAg ICAgICB0aHJvdyBuZXcgRXJyb3IoKTsKLSAgICB9Ci19KTsKSW5kZXg6IEpTVGVzdHMvd2FzbS9y ZWdyZXNzL3JlZ3Jlc3MtMTg5MTg1LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvd2FzbS9yZWdy ZXNzL3JlZ3Jlc3MtMTg5MTg1LmpzCShyZXZpc2lvbiAyMzU3NDEpCShmcm9tIEpTVGVzdHMvc3Ry ZXNzL3JlZ3Jlc3MtMTg5MTg1LmpzOjIzNTc0MSkKKysrIEpTVGVzdHMvd2FzbS9yZWdyZXNzL3Jl Z3Jlc3MtMTg5MTg1LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsOCBAQAorLy9AIHNraXAg aWYgJGFyY2hpdGVjdHVyZSA9PSAieDg2IgorLy9AIHJ1bkRlZmF1bHQKKy8vIFRoaXMgcGFzc2Vz IGlmIGl0IGRvZXMgbm90IGNyYXNoLgorbmV3IFdlYkFzc2VtYmx5LkNvbXBpbGVFcnJvcih7Cisg ICAgdmFsdWVPZigpIHsKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCk7CisgICAgfQorfSk7Cklu ZGV4OiBKU1Rlc3RzL3dhc20vcmVncmVzcy9yZWdyZXNzLTE4OTE4NS5qcwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBKU1Rlc3RzL3dhc20vcmVncmVzcy9yZWdyZXNzLTE4OTE4NS5qcwkocmV2aXNpb24gMjM1NzQx KQorKysgSlNUZXN0cy93YXNtL3JlZ3Jlc3MvcmVncmVzcy0xODkxODUuanMJKHdvcmtpbmcgY29w eSkKQEAgLTEsNSArMSw0IEBACi0vL0Agc2tpcCBpZiAkYXJjaGl0ZWN0dXJlID09ICJ4ODYiCi0v L0AgcnVuRGVmYXVsdAorLy9AIHJ1bldlYkFzc2VtYmx5CiAvLyBUaGlzIHBhc3NlcyBpZiBpdCBk b2VzIG5vdCBjcmFzaC4KIG5ldyBXZWJBc3NlbWJseS5Db21waWxlRXJyb3IoewogICAgIHZhbHVl T2YoKSB7Cg==