189333 2018-09-05 20:56:57 -0700 [LFC][BFC] ComputeFloat* methods should take a const FloatingContext& 2018-09-05 21:07:26 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1456980 0 zalan 2018-09-05 20:56:57 -0700 instead of a non-const. 1456981 1 349001 zalan 2018-09-05 20:59:35 -0700 Created attachment 349001 Patch 1456985 2 zalan 2018-09-05 21:06:20 -0700 Committed r235720: <https://trac.webkit.org/changeset/235720> 1456986 3 webkit-bug-importer 2018-09-05 21:07:26 -0700 <rdar://problem/44167617> 349001 2018-09-05 20:59:35 -0700 2018-09-05 21:01:35 -0700 Patch bug-189333-20180905205930.patch text/plain 4540 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDY0MTVjZTk1NjRmNjEx NzY4Y2VjNDU2MmQwYmEwZGJjNWNlM2I1Ny4uNTE3MmI5NmUyNzA4MzY5YzdlZTg5MjE5ZDI1ZmEw ODk1ZjNkNWQyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA5LTA1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXSBDb21wdXRl RmxvYXQqIG1ldGhvZHMgc2hvdWxkIHRha2UgYSBjb25zdCBGbG9hdGluZ0NvbnRleHQmCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkzMzMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbmx5IGxheW91dEZv cm1hdHRpbmdDb250ZXh0Um9vdCgpIG5lZWRzIGEgbm9uLWNvbnN0IEZsb2F0aW5nQ29udGV4dCYg b2JqZWN0ICh0byBhZGQgdGhlIGZsb2F0aW5nIGJveCB0byB0aGUgZmxvYXRpbmcgc3RhdGUpLgor CisgICAgICAgICogbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6QmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6 bGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRSb290IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6Okxh eW91dDo6QmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6Y29tcHV0ZUZsb2F0aW5nUG9zaXRpb24gY29u c3QpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpCbG9ja0Zvcm1hdHRpbmdDb250ZXh0Ojpj b21wdXRlUG9zaXRpb25Ub0F2b2lkRmxvYXRzIGNvbnN0KToKKyAgICAgICAgKiBsYXlvdXQvYmxv Y2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuaDoKKwogMjAxOC0wOS0wNSAgWmFs YW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdIFBhc3MgaW4gY29u c3QgTGF5b3V0Q29udGV4dCYgdG8gZ2VvbWV0cnkgbWV0aG9kcyB3aGVuIHBvc3NpYmxlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0 dGluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9C bG9ja0Zvcm1hdHRpbmdDb250ZXh0LmNwcAppbmRleCBkMjhiOWY3ZDk4ZDk1YjEwN2U1MDNiNWM3 N2VkOGVjNzkyZTAwNDYzLi45ZjBiZDU4NTdjZTViNzMyMTM3YTdhNmVmMjlmN2FhMDAwZjBhMmJl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2Nr Rm9ybWF0dGluZ0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zv cm1hdHRpbmcvQmxvY2tGb3JtYXR0aW5nQ29udGV4dC5jcHAKQEAgLTE0Miw4ICsxNDIsMTAgQEAg dm9pZCBCbG9ja0Zvcm1hdHRpbmdDb250ZXh0OjpsYXlvdXRGb3JtYXR0aW5nQ29udGV4dFJvb3Qo TGF5b3V0Q29udGV4dCYgbGF5b3V0Q28KICAgICBjb21wdXRlSGVpZ2h0QW5kTWFyZ2luKGxheW91 dENvbnRleHQsIGxheW91dEJveCk7CiAKICAgICAvLyBGbG9hdCByZWxhdGVkIGZpbmFsIHBvc2l0 aW9uaW5nLgotICAgIGlmIChsYXlvdXRCb3guaXNGbG9hdGluZ1Bvc2l0aW9uZWQoKSkKKyAgICBp ZiAobGF5b3V0Qm94LmlzRmxvYXRpbmdQb3NpdGlvbmVkKCkpIHsKICAgICAgICAgY29tcHV0ZUZs b2F0aW5nUG9zaXRpb24obGF5b3V0Q29udGV4dCwgZmxvYXRpbmdDb250ZXh0LCBsYXlvdXRCb3gp OworICAgICAgICBmbG9hdGluZ0NvbnRleHQuZmxvYXRpbmdTdGF0ZSgpLmFwcGVuZChsYXlvdXRC b3gpOworICAgIH0KICAgICBlbHNlIGlmIChsYXlvdXRCb3guaGFzRmxvYXRDbGVhcigpKQogICAg ICAgICBjb21wdXRlVmVydGljYWxQb3NpdGlvbkZvckZsb2F0Q2xlYXIobGF5b3V0Q29udGV4dCwg ZmxvYXRpbmdDb250ZXh0LCBsYXlvdXRCb3gpOwogICAgIGVsc2UKQEAgLTE5Miw3ICsxOTQsNyBA QCB2b2lkIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1dGVFc3RpbWF0ZWRNYXJnaW5Ub3BG b3JBbmNlc3RvcnMoY29uc3QgTGF5b3V0QwogICAgIH0KIH0KIAotdm9pZCBCbG9ja0Zvcm1hdHRp bmdDb250ZXh0Ojpjb21wdXRlRmxvYXRpbmdQb3NpdGlvbihjb25zdCBMYXlvdXRDb250ZXh0JiBs YXlvdXRDb250ZXh0LCBGbG9hdGluZ0NvbnRleHQmIGZsb2F0aW5nQ29udGV4dCwgY29uc3QgQm94 JiBsYXlvdXRCb3gpIGNvbnN0Cit2b2lkIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1dGVG bG9hdGluZ1Bvc2l0aW9uKGNvbnN0IExheW91dENvbnRleHQmIGxheW91dENvbnRleHQsIGNvbnN0 IEZsb2F0aW5nQ29udGV4dCYgZmxvYXRpbmdDb250ZXh0LCBjb25zdCBCb3gmIGxheW91dEJveCkg Y29uc3QKIHsKICAgICBBU1NFUlQobGF5b3V0Qm94LmlzRmxvYXRpbmdQb3NpdGlvbmVkKCkpOwog ICAgIGF1dG8mIGRpc3BsYXlCb3ggPSBsYXlvdXRDb250ZXh0LmRpc3BsYXlCb3hGb3JMYXlvdXRC b3gobGF5b3V0Qm94KTsKQEAgLTIwNSwxMCArMjA3LDkgQEAgdm9pZCBCbG9ja0Zvcm1hdHRpbmdD b250ZXh0Ojpjb21wdXRlRmxvYXRpbmdQb3NpdGlvbihjb25zdCBMYXlvdXRDb250ZXh0JiBsYXlv dXQKICAgICB9CiAgICAgY29tcHV0ZUVzdGltYXRlZE1hcmdpblRvcEZvckFuY2VzdG9ycyhsYXlv dXRDb250ZXh0LCBsYXlvdXRCb3gpOwogICAgIGRpc3BsYXlCb3guc2V0VG9wTGVmdChmbG9hdGlu Z0NvbnRleHQucG9zaXRpb25Gb3JGbG9hdChsYXlvdXRCb3gpKTsKLSAgICBmbG9hdGluZ0NvbnRl eHQuZmxvYXRpbmdTdGF0ZSgpLmFwcGVuZChsYXlvdXRCb3gpOwogfQogCi12b2lkIEJsb2NrRm9y bWF0dGluZ0NvbnRleHQ6OmNvbXB1dGVQb3NpdGlvblRvQXZvaWRGbG9hdHMoY29uc3QgTGF5b3V0 Q29udGV4dCYgbGF5b3V0Q29udGV4dCwgRmxvYXRpbmdDb250ZXh0JiBmbG9hdGluZ0NvbnRleHQs IGNvbnN0IEJveCYgbGF5b3V0Qm94KSBjb25zdAordm9pZCBCbG9ja0Zvcm1hdHRpbmdDb250ZXh0 Ojpjb21wdXRlUG9zaXRpb25Ub0F2b2lkRmxvYXRzKGNvbnN0IExheW91dENvbnRleHQmIGxheW91 dENvbnRleHQsIGNvbnN0IEZsb2F0aW5nQ29udGV4dCYgZmxvYXRpbmdDb250ZXh0LCBjb25zdCBC b3gmIGxheW91dEJveCkgY29uc3QKIHsKICAgICAvLyBGb3JtYXR0aW5nIGNvbnRleHQgcm9vdHMg YXZvaWQgZmxvYXRzLgogICAgIEFTU0VSVChsYXlvdXRCb3guZXN0YWJsaXNoZXNCbG9ja0Zvcm1h dHRpbmdDb250ZXh0KCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2Nr Zm9ybWF0dGluZy9CbG9ja0Zvcm1hdHRpbmdDb250ZXh0LmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlv dXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuaAppbmRleCA4ZDU0MjE2 OTE3MGViYTg4ODdmY2VjY2IxNDczM2EwNTgyNTY4OGI0Li43ZDI3NzNhNDVjZTRlOWRiN2ZiYzBh YmVkNjY0MTQwODIzZmYxOTEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxv Y2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrRm9ybWF0dGluZ0NvbnRleHQuaApAQCAtNTYs OCArNTYsOCBAQCBwcml2YXRlOgogICAgIHZvaWQgY29tcHV0ZUhlaWdodEFuZE1hcmdpbihjb25z dCBMYXlvdXRDb250ZXh0JiwgY29uc3QgQm94JikgY29uc3Q7CiAKICAgICB2b2lkIGNvbXB1dGVT dGF0aWNQb3NpdGlvbihjb25zdCBMYXlvdXRDb250ZXh0JiwgY29uc3QgQm94JikgY29uc3Qgb3Zl cnJpZGU7Ci0gICAgdm9pZCBjb21wdXRlRmxvYXRpbmdQb3NpdGlvbihjb25zdCBMYXlvdXRDb250 ZXh0JiwgRmxvYXRpbmdDb250ZXh0JiwgY29uc3QgQm94JikgY29uc3Q7Ci0gICAgdm9pZCBjb21w dXRlUG9zaXRpb25Ub0F2b2lkRmxvYXRzKGNvbnN0IExheW91dENvbnRleHQmLCBGbG9hdGluZ0Nv bnRleHQmLCBjb25zdCBCb3gmKSBjb25zdDsKKyAgICB2b2lkIGNvbXB1dGVGbG9hdGluZ1Bvc2l0 aW9uKGNvbnN0IExheW91dENvbnRleHQmLCBjb25zdCBGbG9hdGluZ0NvbnRleHQmLCBjb25zdCBC b3gmKSBjb25zdDsKKyAgICB2b2lkIGNvbXB1dGVQb3NpdGlvblRvQXZvaWRGbG9hdHMoY29uc3Qg TGF5b3V0Q29udGV4dCYsIGNvbnN0IEZsb2F0aW5nQ29udGV4dCYsIGNvbnN0IEJveCYpIGNvbnN0 OwogICAgIHZvaWQgY29tcHV0ZVZlcnRpY2FsUG9zaXRpb25Gb3JGbG9hdENsZWFyKGNvbnN0IExh eW91dENvbnRleHQmLCBjb25zdCBGbG9hdGluZ0NvbnRleHQmLCBjb25zdCBCb3gmKSBjb25zdDsK IAogICAgIHZvaWQgY29tcHV0ZUluRmxvd1Bvc2l0aW9uZWRQb3NpdGlvbihjb25zdCBMYXlvdXRD b250ZXh0JiwgY29uc3QgQm94JikgY29uc3Qgb3ZlcnJpZGU7Cg==