189315 2018-09-05 13:34:23 -0700 [macOS] DragAndDropTests.ExposeMultipleURLsInDataTransfer fails on macOS versions prior to Mojave 2018-09-08 18:51:09 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes commit-queue darin jlewis3 realdawei ryanhaddad thorton tsavell webkit-bug-importer oldest_to_newest 1456837 0 wenson_hsieh 2018-09-05 13:34:23 -0700 [macOS] DragAndDropTests.ExposeMultipleURLsInDataTransfer fails on macOS versions prior to Mojave 1456838 1 348958 wenson_hsieh 2018-09-05 13:35:08 -0700 Created attachment 348958 Patch 1456857 2 348958 commit-queue 2018-09-05 14:16:02 -0700 Comment on attachment 348958 Patch Clearing flags on attachment: 348958 Committed r235689: <https://trac.webkit.org/changeset/235689> 1456858 3 commit-queue 2018-09-05 14:16:03 -0700 All reviewed patches have been landed. Closing bug. 1456859 4 webkit-bug-importer 2018-09-05 14:17:59 -0700 <rdar://problem/44153801> 1457959 5 348958 darin 2018-09-08 18:34:35 -0700 Comment on attachment 348958 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348958&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:51 > + WKPreferencesSetCustomPasteboardDataEnabled((WKPreferencesRef)[webView configuration].preferences, true); __bridge WKPreferencesRef 1457960 6 darin 2018-09-08 18:35:10 -0700 Sorry, I mean that as a question. 1457963 7 wenson_hsieh 2018-09-08 18:51:09 -0700 (In reply to Darin Adler from comment #6) > Sorry, I mean that as a question. You're right, it looks like this should be bridged (WKPreferencesRef <=> WKPreferences). I'll fix instances of this in TestWebKitAPI here: <https://bugs.webkit.org/show_bug.cgi?id=189457>. 348958 2018-09-05 13:35:08 -0700 2018-09-05 14:16:02 -0700 Patch bug-189315-20180905133507.patch text/plain 1744 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NjgzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWJiNDgxOTNiYzE0MzM1MmQ5OTQ0ZmZlY2Y2ZDgzNDQx YzZmMWY0OS4uZmMwOWUzMjQyMTIyNGRkOWZjODMxMmE3ZjU0M2U4NDU5ZDc0YzRhYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE4LTA5LTA1ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgor CisgICAgICAgIFttYWNPU10gRHJhZ0FuZERyb3BUZXN0cy5FeHBvc2VNdWx0aXBsZVVSTHNJbkRh dGFUcmFuc2ZlciBmYWlscyBvbiBtYWNPUyB2ZXJzaW9ucyBwcmlvciB0byBNb2phdmUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4OTMxNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCB0aGUgdGVzdCBm YWlsdXJlIGJ5IGV4cGxpY2l0bHkgZW5hYmxpbmcgY3VzdG9tIHBhc3RlYm9hcmQgZGF0YS4KKwor ICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvRHJhZ0FuZERyb3BUZXN0 cy5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDE4LTA5LTA1ICBXb29kcm93IFdhbmcgIDx3b29k cm93X3dhbmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZGVkIHJ1bnRpbWUgZmVhdHVyZSBmbGFn IGZvciB3ZWIgQVBJIHN0YXRpc3RpY3MKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0Q29jb2EvRHJhZ0FuZERyb3BUZXN0cy5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0Q29jb2EvRHJhZ0FuZERyb3BUZXN0cy5tbQppbmRleCA5NGI1ZjcwOGU5 NjcwNGI5MDAzMTE3ZTU0ZGU2YzU1YTAwNDBjOGYzLi4yMDY3MDllZmIwNDQzZTUxMTVkYjE1NDll YmM3MmQzYjk5MDhmMDQwIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdENvY29hL0RyYWdBbmREcm9wVGVzdHMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXRDb2NvYS9EcmFnQW5kRHJvcFRlc3RzLm1tCkBAIC0yNyw2ICsyNyw3IEBACiAK ICNpbXBvcnQgIkRyYWdBbmREcm9wU2ltdWxhdG9yLmgiCiAjaW1wb3J0ICJQbGF0Zm9ybVV0aWxp dGllcy5oIgorI2ltcG9ydCA8V2ViS2l0L1dLUHJlZmVyZW5jZXNQcml2YXRlLmg+CiAKICNpZiBX S19BUElfRU5BQkxFRCAmJiBFTkFCTEUoRFJBR19TVVBQT1JUKQogCkBAIC00Nyw2ICs0OCw3IEBA IFRFU1QoRHJhZ0FuZERyb3BUZXN0cywgRXhwb3NlTXVsdGlwbGVVUkxzSW5EYXRhVHJhbnNmZXIp CiB7CiAgICAgYXV0byBzaW11bGF0b3IgPSBhZG9wdE5TKFtbRHJhZ0FuZERyb3BTaW11bGF0b3Ig YWxsb2NdIGluaXRXaXRoV2ViVmlld0ZyYW1lOkNHUmVjdE1ha2UoMCwgMCwgMzIwLCA1MDApXSk7 CiAgICAgYXV0byB3ZWJWaWV3ID0gW3NpbXVsYXRvciB3ZWJWaWV3XTsKKyAgICBXS1ByZWZlcmVu Y2VzU2V0Q3VzdG9tUGFzdGVib2FyZERhdGFFbmFibGVkKChXS1ByZWZlcmVuY2VzUmVmKVt3ZWJW aWV3IGNvbmZpZ3VyYXRpb25dLnByZWZlcmVuY2VzLCB0cnVlKTsKICAgICBbd2ViVmlldyBzeW5j aHJvbm91c2x5TG9hZFRlc3RQYWdlTmFtZWQ6QCJEYXRhVHJhbnNmZXIiXTsKIAogICAgIE5TU3Ry aW5nICpzdHJpbmdEYXRhID0gQCJIZWxsbyB3b3JsZCI7Cg==