189313 2018-09-05 12:19:20 -0700 [CMake] Allow port specific options on gtest 2018-09-05 20:47:02 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 don.olmstead don.olmstead achristensen annulen commit-queue mcatanzaro webkit-bug-importer oldest_to_newest 1456821 0 don.olmstead 2018-09-05 12:19:20 -0700 Currently there is no way for a port to configure gtest. The options are also not readily available to TestWebKitAPI. 1456824 1 348954 don.olmstead 2018-09-05 12:28:53 -0700 Created attachment 348954 Patch 1456825 2 don.olmstead 2018-09-05 12:46:54 -0700 Ports may want to set any one of the variables set in https://github.com/google/googletest/blob/release-1.8.1/googletest/include/gtest/internal/gtest-port.h#L46-L115 to describe their environment so this allows that. 1456977 3 348954 commit-queue 2018-09-05 20:46:24 -0700 Comment on attachment 348954 Patch Clearing flags on attachment: 348954 Committed r235718: <https://trac.webkit.org/changeset/235718> 1456978 4 commit-queue 2018-09-05 20:46:26 -0700 All reviewed patches have been landed. Closing bug. 348954 2018-09-05 12:28:53 -0700 2018-09-05 20:46:24 -0700 Patch bug-189313.diff text/plain 5188 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZyBiL1NvdXJjZS9UaGlyZFBh cnR5L0NoYW5nZUxvZwppbmRleCA5ZTY1ZTBiMmM3MC4uNDk5MmI1NTFhMTggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxOC0wOS0wNSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9s bXN0ZWFkQHNvbnkuY29tPgorCisgICAgICAgIFtDTWFrZV0gQWxsb3cgcG9ydCBzcGVjaWZpYyBv cHRpb25zIG9uIGd0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODkzMTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBbGxvd3MgYSBwb3J0IHRvIGNvbmZpZ3VyZSBvcHRpb25zIHdpdGhpbiBndGVzdCBm b3IgaXRzIHBsYXRmb3JtLgorICAgICAgICBUaGUgbGlicmFyeSB0eXBlIGNhbiBiZSBzZXQgb3Ro ZXJ3aXNlIGl0IGRlZmF1bHRzIHRvIHNoYXJlZC4gQWxzbyB0aGUKKyAgICAgICAgY29tcGlsZSBk ZWZpbml0aW9ucyBhcmUgcHJvcG9nYXRlZCB0byBUZXN0V2ViS2l0QVBJIHRocm91Z2ggYSBnbG9i YWwKKyAgICAgICAgcHJvcGVydHkuCisKKyAgICAgICAgKiBndGVzdC9DTWFrZUxpc3RzLnR4dDoK KyAgICAgICAgKiBndGVzdC9QbGF0Zm9ybVdpbi5jbWFrZTogQWRkZWQuCisKIDIwMTgtMDktMDQg IFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgogCiAgICAgICAgIFVwZGF0 ZSBnb29nbGV0ZXN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9ndGVzdC9DTWFrZUxp c3RzLnR4dCBiL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0L0NNYWtlTGlzdHMudHh0CmluZGV4IDQz MDdiYzhiNzJmLi41MTA0M2UyNjY5MiAxMDA3NTUKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvZ3Rl c3QvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1RoaXJkUGFydHkvZ3Rlc3QvQ01ha2VMaXN0 cy50eHQKQEAgLTIwLDE0ICsyMCwyMiBAQCBzZXQoR1RFU1RfU09VUkNFUwogICAgICR7R1RFU1Rf RElSfS9zcmMvZ3Rlc3QtdHlwZWQtdGVzdC5jYwogKQogCi1pZiAoV0lOMzIpCi0gICAgIyBNU1ZD IDIwMTUgcmVxdWlyZXMgdGhpcyBkZWZpbml0aW9uIGZvciBJTlRNQVhfTUFYIHRvIGJlIGRlZmlu ZWQuCi0gICAgYWRkX2RlZmluaXRpb25zKC1EX19TVERDX0xJTUlUX01BQ1JPUyAtREdURVNUX0NS RUFURV9TSEFSRURfTElCUkFSWT0wKQotICAgICMgZ3Rlc3QgY3Jhc2hlcyBvbiBleGl0IG9uIFdp bmRvd3MgaWYgaXQgaXMgYSBkbGwuCi0gICAgYWRkX2xpYnJhcnkoZ3Rlc3QgU1RBVElDICR7R1RF U1RfU09VUkNFU30pCi1lbHNlICgpCi0gICAgYWRkX2RlZmluaXRpb25zKC1ER1RFU1RfQ1JFQVRF X1NIQVJFRF9MSUJSQVJZPTEpCitzZXQoZ3Rlc3RfREVGSU5JVElPTlMgLURHVEVTVF9IQVNfUlRU ST0wKQorCisjIEFkZGl0aW9uYWwgZ3Rlc3QgY29uZmlndXJhdGlvbiBjYW4gYmUgYWRkZWQgaW4g dGhlIHBvcnQncyBjbWFrZSBmaWxlCitXRUJLSVRfSU5DTFVERV9DT05GSUdfRklMRVNfSUZfRVhJ U1RTKCkKKworIyBCeSBkZWZhdWx0IHVzZSBhIHNoYXJlZCBsaWJyYXJ5CitpZiAoTk9UIERFRklO RUQgZ3Rlc3RfTElCUkFSWV9UWVBFKQorICAgIHNldChndGVzdF9MSUJSQVJZX1RZUEUgU0hBUkVE KQorZW5kaWYgKCkKKworaWYgKGd0ZXN0X0xJQlJBUllfVFlQRSBNQVRDSEVTIFNIQVJFRCkKKyAg ICBsaXN0KEFQUEVORCBndGVzdF9ERUZJTklUSU9OUyAtREdURVNUX0NSRUFURV9TSEFSRURfTElC UkFSWT0xKQogICAgIGFkZF9saWJyYXJ5KGd0ZXN0IFNIQVJFRCAke0dURVNUX1NPVVJDRVN9KQor ZWxzZSAoKQorICAgIGxpc3QoQVBQRU5EIGd0ZXN0X0RFRklOSVRJT05TIC1ER1RFU1RfQ1JFQVRF X1NIQVJFRF9MSUJSQVJZPTApCisgICAgYWRkX2xpYnJhcnkoZ3Rlc3QgU1RBVElDICR7R1RFU1Rf U09VUkNFU30pCiBlbmRpZiAoKQogCiBpbmNsdWRlX2RpcmVjdG9yaWVzKCR7R1RFU1RfSU5DTFVE RV9ESVJFQ1RPUklFU30pCkBAIC0zOCw3ICs0NiwxMiBAQCBXRUJLSVRfQUREX1RBUkdFVF9DWFhf RkxBR1MoZ3Rlc3QgLVduby11bmRlZgogCiBpZiAoQ01BS0VfVVNFX1BUSFJFQURTX0lOSVQpCiAg ICAgdGFyZ2V0X2xpbmtfbGlicmFyaWVzKGd0ZXN0ICR7Q01BS0VfVEhSRUFEX0xJQlNfSU5JVH0p Ci0gICAgYWRkX2RlZmluaXRpb25zKC1ER1RFU1RfSEFTX1BUSFJFQUQ9MSkKKyAgICBsaXN0KEFQ UEVORCBndGVzdF9ERUZJTklUSU9OUyAtREdURVNUX0hBU19QVEhSRUFEPTEpCiBlbHNlICgpCi0g ICAgYWRkX2RlZmluaXRpb25zKC1ER1RFU1RfSEFTX1BUSFJFQUQ9MCkKKyAgICBsaXN0KEFQUEVO RCBndGVzdF9ERUZJTklUSU9OUyAtREdURVNUX0hBU19QVEhSRUFEPTApCiBlbmRpZiAoKQorCith ZGRfZGVmaW5pdGlvbnMoJHtndGVzdF9ERUZJTklUSU9OU30pCisKKyMgQ3JlYXRlIGEgZ2xvYmFs IHByb3BlcnR5IHNvIGl0IGNhbiBiZSBhY2Nlc3NlZCBpbiBUZXN0V2ViS2l0QVBJCitzZXRfcHJv cGVydHkoR0xPQkFMIFBST1BFUlRZIGd0ZXN0X0RFRklOSVRJT05TICR7Z3Rlc3RfREVGSU5JVElP TlN9KQpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvZ3Rlc3QvUGxhdGZvcm1XaW4uY21h a2UgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9ndGVzdC9QbGF0Zm9ybVdpbi5jbWFrZQpuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uMDc0ZmM4OTFjNzUKLS0tIC9kZXYvbnVsbAor KysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9ndGVzdC9QbGF0Zm9ybVdpbi5jbWFrZQpAQCAtMCwwICsx LDQgQEAKK3NldChndGVzdF9MSUJSQVJZX1RZUEUgU1RBVElDKQorCisjIE1TVkMgMjAxNSByZXF1 aXJlcyB0aGlzIGRlZmluaXRpb24gZm9yIElOVE1BWF9NQVggdG8gYmUgZGVmaW5lZC4KK2FkZF9k ZWZpbml0aW9ucygtRF9fU1REQ19MSU1JVF9NQUNST1MpCmRpZmYgLS1naXQgYS9Ub29scy9DaGFu Z2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2U2ZTQ1MmNiMTguLmRkZWM0NGU1ODY0IDEw MDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTgtMDktMDUgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNv bT4KKworICAgICAgICBbQ01ha2VdIEFsbG93IHBvcnQgc3BlY2lmaWMgb3B0aW9ucyBvbiBndGVz dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5MzEz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHRo ZSBnbG9iYWwgcHJvcGVydHkgc2V0IGJ5IHRoZSBndGVzdCBDTWFrZSBmaWxlIHRvIGFkZCB0byB0 aGUKKyAgICAgICAgY29tcGlsYXRpb24gZGVmaW5pdGlvbnMgZm9yIFRlc3RXZWJLaXRBUEkgcmF0 aGVyIHRoYW4gcmVwZWF0aW5nIHRoZQorICAgICAgICBsb2dpYy4KKworICAgICAgICAqIFRlc3RX ZWJLaXRBUEkvQ01ha2VMaXN0cy50eHQ6CisKIDIwMTgtMDktMDUgIERhdmlkIEtpbHplciAgPGRk a2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjA5NDcwKTogRWRpdGlu Z0hpc3RvcnkgZm9sZGVyIGlzIG1pc3NpbmcgaW4gRWRpdGluZ0hpc3RvcnkgWGNvZGUgcHJvamVj dApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9DTWFrZUxpc3RzLnR4dCBiL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvQ01ha2VMaXN0cy50eHQKaW5kZXggOWM1MTk3MmI0YzAuLmNhYTg1ZmNi NTNkIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL0NNYWtlTGlzdHMudHh0CisrKyBi L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ01ha2VMaXN0cy50eHQKQEAgLTIzNiwyMiArMjM2LDEzIEBA IGlmIChFTkFCTEVfV0VCS0lUKQogICAgIGVuZGlmICgpCiBlbmRpZiAoKQogCi1pZiAoV0lOMzIp Ci0gICAgYWRkX2RlZmluaXRpb25zKC1ER1RFU1RfTElOS0VEX0FTX1NIQVJFRF9MSUJSQVJZPTAp Ci1lbHNlICgpCi0gICAgYWRkX2RlZmluaXRpb25zKC1ER1RFU1RfTElOS0VEX0FTX1NIQVJFRF9M SUJSQVJZPTEpCi1lbmRpZiAoKQorZ2V0X3Byb3BlcnR5KGd0ZXN0X0RFRklOSVRJT05TIEdMT0JB TCBQUk9QRVJUWSBndGVzdF9ERUZJTklUSU9OUykKIAotYWRkX2RlZmluaXRpb25zKC1ER1RFU1Rf SEFTX1JUVEk9MAorYWRkX2RlZmluaXRpb25zKAorICAgICR7Z3Rlc3RfREVGSU5JVElPTlN9CiAg ICAgLURURVNUX1dFQktJVDJfUkVTT1VSQ0VTX0RJUj1cIiR7VEVTVFdFQktJVEFQSV9ESVJ9L1Rl c3RzL1dlYktpdFwiCiApCiAKLSMgRklYTUU6IFRoaXMgd29ya3MgYXJvdW5kIGNvbXBhdGliaWxp dHkgcHJvYmxlbXMgaW4gdGhlIG9sZCB2ZXJzaW9uIG9mIHRoZSB0aGlyZC1wYXJ5Ci0jIGdvb2ds ZXRlc3Qgc291cmNlIGNvZGUgY2hlY2tvdXQuIEl0IHNob3VsZCBiZSByZW1vdmVkIG9uY2Ugd2Ug dXBncmFkZSB0byBhIG5ld2VyIHZlcnNpb24uCi1pZiAoIiR7Q01BS0VfQ1hYX0NPTVBJTEVSX0lE fSIgU1RSRVFVQUwgIkNsYW5nIikKLSAgICBhZGRfZGVmaW5pdGlvbnMoLURHVEVTVF9IQVNfVFIx X1RVUExFPTApCi1lbmRpZiAoKQotCiBhZGRfZXhlY3V0YWJsZShUZXN0V1RGCiAgICAgJHt0ZXN0 X21haW5fU09VUkNFU30KICAgICAke1Rlc3RXVEZfU09VUkNFU30KQEAgLTI3NywxMiArMjY4LDYg QEAgaWYgKENPTVBJTEVSX0lTX0dDQ19PUl9DTEFORykKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAtV25vLXVudXNlZC1wYXJhbWV0ZXIpCiBlbmRpZiAoKQogCi0jIEZJ WE1FOiBUaGlzIHdvcmtzIGFyb3VuZCBjb21wYXRpYmlsaXR5IHByb2JsZW1zIGluIHRoZSBvbGQg dmVyc2lvbiBvZiB0aGUgdGhpcmQtcGFyeQotIyBnb29nbGV0ZXN0IHNvdXJjZSBjb2RlIGNoZWNr b3V0LiBJdCBzaG91bGQgYmUgcmVtb3ZlZCBvbmNlIHdlIHVwZ3JhZGUgdG8gYSBuZXdlciB2ZXJz aW9uLgotaWYgKENPTVBJTEVSX0lTX0NMQU5HKQotICAgIGFkZF9kZWZpbml0aW9ucygtREdURVNU X0hBU19UUjFfVFVQTEU9MCkKLWVuZGlmICgpCi0KIGlmIChFTkFCTEVfV0VCS0lUKQogICAgIGFk ZF9saWJyYXJ5KFRlc3RXZWJLaXRBUElCYXNlCiAgICAgICAgICR7dGVzdF9tYWluX1NPVVJDRVN9 Cg==