189298 2018-09-04 23:25:48 -0700 Update code style guidelines for using namespace inside a namespace definition 2018-09-05 19:56:21 -0700 1 1 1 Unclassified WebKit WebKit Website WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii jond keith_miller rniwa webkit-bug-importer oldest_to_newest 1456642 0 fujii 2018-09-04 23:25:48 -0700 Update code style guidelines for using namespace inside a namespace definition https://webkit.org/code-style-guidelines/#using-position > [](#using-position) In implementation files, put all other "using" statements at the beginning of the file, before any namespace definitions and after any "include" statements. > > ###### Right: > > ```cpp > // HTMLSelectElement.cpp > > using namespace other; > > namespace WebCore { > > } // namespace WebCore > ``` > > ###### Wrong: > > ```cpp > // HTMLSelectElement.cpp > > namespace WebCore { > > using namespace other; > > } // namespace WebCore > ``` [webkit-dev] Moving WebCore to unified source builds and style changes. https://lists.webkit.org/pipermail/webkit-dev/2017-October/029656.html > 1) Move all “using namespace <name>;” inside the WebCore namespace (they used to be in the global namespace) and change to "using WebCore::<type-name>;” in .mm files. 1456643 1 348897 fujii 2018-09-04 23:37:17 -0700 Created attachment 348897 Patch 1456967 2 348897 fujii 2018-09-05 19:55:46 -0700 Comment on attachment 348897 Patch Clearing flags on attachment: 348897 Committed r235717: <https://trac.webkit.org/changeset/235717> 1456968 3 fujii 2018-09-05 19:55:49 -0700 All reviewed patches have been landed. Closing bug. 1456969 4 webkit-bug-importer 2018-09-05 19:56:21 -0700 <rdar://problem/44165719> 348897 2018-09-04 23:37:17 -0700 2018-09-05 19:55:46 -0700 Patch bug-189298-20180905153716.patch text/plain 1768 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NjU2CmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IGY5Y2Fl MmFjM2E0NmNiZWVkZjYwMDY0ODM2OWNkOWMwNmI2ZDM0NzUuLmU1N2E1NGQ5OTJkNzkwMGU3NzY0 ZGQ4MjM4NjVmMThhOWMyZjE2ZjkgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTgtMDktMDQgIEZ1amlpIEhpcm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+ CisKKyAgICAgICAgVXBkYXRlIGNvZGUgc3R5bGUgZ3VpZGVsaW5lcyBmb3IgdXNpbmcgbmFtZXNw YWNlIGluc2lkZSBhIG5hbWVzcGFjZSBkZWZpbml0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkyOTgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAidXNpbmcgbmFtZXNwYWNlIiBzdGF0ZW1lbnRzIHNo b3VsZCBiZSBpbnNpZGUgbmFtZXNwYWNlIGRlZmluaXRpb25zIGZvcgorICAgICAgICB1bmlmaWVk IHNvdXJjZSBidWlsZHMuCisKKyAgICAgICAgKiBjb2RlLXN0eWxlLm1kKCN1c2luZy1wb3NpdGlv bik6IAorCiAyMDE4LTA4LTMxICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAg ICAgICBBZGQgc3VwcG9ydCBmb3IgVVNEWiB0byB3ZWJraXQub3JnIGZvciBhIHNhbXBsZSBmaWxl CmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQub3JnL2NvZGUtc3R5bGUubWQgYi9XZWJzaXRl cy93ZWJraXQub3JnL2NvZGUtc3R5bGUubWQKaW5kZXggNzU5NDA2NzRhOTBlZjkwNDZkZDNlNzM1 YWIxN2RjZmJhODg2ZmY1Zi4uMGI3MWU4ZDY2NjZkNGNlYTA4YWM5NTE5ODNiNmMwMWE4NTQzZTVi MCAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RlLXN0eWxlLm1kCisrKyBiL1dl YnNpdGVzL3dlYmtpdC5vcmcvY29kZS1zdHlsZS5tZApAQCAtMTEyNiwxNyArMTEyNiwxNyBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiBgYGAKIAotW10oI3Vz aW5nLXBvc2l0aW9uKSBJbiBpbXBsZW1lbnRhdGlvbiBmaWxlcywgcHV0IGFsbCBvdGhlciAidXNp bmciIHN0YXRlbWVudHMgYXQgdGhlIGJlZ2lubmluZyBvZiB0aGUgZmlsZSwgYmVmb3JlIGFueSBu YW1lc3BhY2UgZGVmaW5pdGlvbnMgYW5kIGFmdGVyIGFueSAiaW5jbHVkZSIgc3RhdGVtZW50cy4K K1tdKCN1c2luZy1wb3NpdGlvbikgSW4gaW1wbGVtZW50YXRpb24gZmlsZXMsIHB1dCBhbGwgInVz aW5nIG5hbWVzcGFjZSIgc3RhdGVtZW50cyBpbnNpZGUgbmFtZXNwYWNlIGRlZmluaXRpb25zLgog CiAjIyMjIyMgUmlnaHQ6CiAKIGBgYGNwcAogLy8gSFRNTFNlbGVjdEVsZW1lbnQuY3BwCiAKLXVz aW5nIG5hbWVzcGFjZSBvdGhlcjsKLQogbmFtZXNwYWNlIFdlYkNvcmUgewogCit1c2luZyBuYW1l c3BhY2Ugb3RoZXI7CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIGBgYAogCkBAIC0xMTQ1LDEw ICsxMTQ1LDEwIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIGBgYGNwcAogLy8gSFRNTFNlbGVjdEVs ZW1lbnQuY3BwCiAKLW5hbWVzcGFjZSBXZWJDb3JlIHsKLQogdXNpbmcgbmFtZXNwYWNlIG90aGVy OwogCituYW1lc3BhY2UgV2ViQ29yZSB7CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIGBgYAog Cg==