189297 2018-09-04 21:47:54 -0700 Remove unused bad_optional_access implementation. 2018-09-05 00:53:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo commit-queue dbates ddkilzer ews-watchlist fpizlo jfbastien keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1456622 0 mark.lam 2018-09-04 21:47:54 -0700 This is a speculative fix for resolving build errors arising from conflicting definitions of bad_optional_access when building WebKit with the latest clang. 1456624 1 348893 mark.lam 2018-09-04 21:52:11 -0700 Created attachment 348893 proposed patch. 1456625 2 348893 mark.lam 2018-09-04 21:52:45 -0700 Comment on attachment 348893 proposed patch. I'll wait for EWS confirmation before landing. 1456627 3 348893 ddkilzer 2018-09-04 21:56:29 -0700 Comment on attachment 348893 proposed patch. r=me 1456657 4 348893 mark.lam 2018-09-05 00:26:17 -0700 Comment on attachment 348893 proposed patch. Thanks for the review. Landing now. 1456658 5 348893 commit-queue 2018-09-05 00:52:24 -0700 Comment on attachment 348893 proposed patch. Clearing flags on attachment: 348893 Committed r235661: <https://trac.webkit.org/changeset/235661> 1456659 6 commit-queue 2018-09-05 00:52:26 -0700 All reviewed patches have been landed. Closing bug. 1456660 7 webkit-bug-importer 2018-09-05 00:53:17 -0700 <rdar://problem/44130109> 348893 2018-09-04 21:52:11 -0700 2018-09-05 00:52:24 -0700 proposed patch. bug-189297.patch text/plain 1384 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzU2NTcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA5LTA0ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW51c2VkIGJhZF9vcHRpb25hbF9hY2Nlc3Mg aW1wbGVtZW50YXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODkyOTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIGlzIGEgc3BlY3VsYXRpdmUgZml4IGZvciByZXNvbHZpbmcgYnVpbGQgZXJy b3JzIGFyaXNpbmcgZnJvbSBjb25mbGljdGluZworICAgICAgICBkZWZpbml0aW9ucyBvZiBiYWRf b3B0aW9uYWxfYWNjZXNzIHdoZW4gYnVpbGRpbmcgV2ViS2l0IHdpdGggdGhlIGxhdGVzdCBjbGFu Zy4KKworICAgICAgICAqIHd0Zi9PcHRpb25hbC5oOgorICAgICAgICAoc3RkOjpiYWRfb3B0aW9u YWxfYWNjZXNzOjpiYWRfb3B0aW9uYWxfYWNjZXNzKTogRGVsZXRlZC4KKwogMjAxOC0wOS0wNCAg TWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBZQVJSOiBKSVQg UmVnRXhwcyB3aXRoIGJhY2sgcmVmZXJlbmNlcwpJbmRleDogU291cmNlL1dURi93dGYvT3B0aW9u YWwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9PcHRpb25hbC5oCShyZXZpc2lvbiAy MzU2NTcpCisrKyBTb3VyY2UvV1RGL3d0Zi9PcHRpb25hbC5oCSh3b3JraW5nIGNvcHkpCkBAIC0y NzcsMTQgKzI3Nyw2IEBAIHN0cnVjdCBudWxsb3B0X3QKIGNvbnN0ZXhwciBudWxsb3B0X3QgbnVs bG9wdHtudWxsb3B0X3Q6OmluaXQoKX07CiAKIAotLy8gMjAuNS44LCBjbGFzcyBiYWRfb3B0aW9u YWxfYWNjZXNzCi1jbGFzcyBiYWRfb3B0aW9uYWxfYWNjZXNzIDogcHVibGljIHN0ZDo6bG9naWNf ZXJyb3IgewotcHVibGljOgotICBleHBsaWNpdCBiYWRfb3B0aW9uYWxfYWNjZXNzKGNvbnN0IHN0 ZDo6c3RyaW5nJiB3aGF0X2FyZykgOiBzdGQ6OmxvZ2ljX2Vycm9ye3doYXRfYXJnfSB7fQotICBl eHBsaWNpdCBiYWRfb3B0aW9uYWxfYWNjZXNzKGNvbnN0IGNoYXIqIHdoYXRfYXJnKSA6IHN0ZDo6 bG9naWNfZXJyb3J7d2hhdF9hcmd9IHt9Ci19OwotCi0KIHRlbXBsYXRlIDxjbGFzcyBUPgogdW5p b24gc3RvcmFnZV90CiB7Cg==