189293 2018-09-04 18:19:40 -0700 Log when leak detection changes the test result 2018-09-06 17:28:04 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 186214 1 simon.fraser simon.fraser ap commit-queue ews-watchlist glenn jbedard jonlee simon.fraser webkit-bug-importer oldest_to_newest 1456581 0 simon.fraser 2018-09-04 18:19:40 -0700 Log when leak detection changes the test result 1456583 1 348883 simon.fraser 2018-09-04 18:21:25 -0700 Created attachment 348883 Patch 1456854 2 348883 jbedard 2018-09-05 14:00:08 -0700 Comment on attachment 348883 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348883&action=review > Tools/ChangeLog:10 > + When you have an "Leak" expectation in TestExpectations, it's confusing to see a test unexpectedly pass, > + but then show up as an expected fail at the end (because leak detection happens at the end of a shard). > + So log when leak detection changes a test result. Does this change actually address the fact that a test will show up as an unexpected pass until the leak detection happens? Or does it just log when the result changes after leak detection occurs? It looks like this does the second. I'd like to eventually do the first, but this seems like a decent mitigation. 1456869 3 simon.fraser 2018-09-05 14:47:02 -0700 (In reply to Jonathan Bedard from comment #2) > Comment on attachment 348883 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348883&action=review > > > Tools/ChangeLog:10 > > + When you have an "Leak" expectation in TestExpectations, it's confusing to see a test unexpectedly pass, > > + but then show up as an expected fail at the end (because leak detection happens at the end of a shard). > > + So log when leak detection changes a test result. > > Does this change actually address the fact that a test will show up as an > unexpected pass until the leak detection happens? Or does it just log when > the result changes after leak detection occurs? > > It looks like this does the second. I'd like to eventually do the first, but > this seems like a decent mitigation. The latter. Leak detect is async, so the only other option would be to log something like: "fast/css/user-drag-none.html passed, but might leak", and then something when the leak is detected. 1456884 4 jbedard 2018-09-05 15:08:18 -0700 (In reply to Simon Fraser (smfr) from comment #3) > (In reply to Jonathan Bedard from comment #2) > > Comment on attachment 348883 [details] > > ... > > The latter. Leak detect is async, so the only other option would be to log > something like: "fast/css/user-drag-none.html passed, but might leak", and > then something when the leak is detected. So I like the other option for tests that are expected to leak. There is a third (but much more painful) option: we could defer printing ALL results until leak checking is finished. But that's a pretty non-trivial and controversial change. 1457298 5 349084 simon.fraser 2018-09-06 15:36:44 -0700 Created attachment 349084 Patch 1457301 6 simon.fraser 2018-09-06 15:38:17 -0700 Output: Unexpected leak: [1/1] fast/css/user-drag-none.html passed fast/css/user-drag-none.html -> changed by leak detection from a pass (expected) to a leak (unexpected) Expected leak: [1/1] fast/css/user-drag-none.html passed (leak detection is pending) fast/css/user-drag-none.html -> changed by leak detection from a pass (unexpected) to a leak (expected) 1457344 7 349084 commit-queue 2018-09-06 17:02:24 -0700 Comment on attachment 349084 Patch Rejecting attachment 349084 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 349084, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=349084&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=189293&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 349084 from bug 189293. Fetching: https://bugs.webkit.org/attachment.cgi?id=349084 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jon Lee']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 4 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py Hunk #1 FAILED at 200. 1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py.rej patching file Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py Hunk #1 succeeded at 815 (offset 14 lines). patching file Tools/Scripts/webkitpy/layout_tests/views/printing.py Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jon Lee']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/9120256 1457357 8 simon.fraser 2018-09-06 17:25:19 -0700 https://trac.webkit.org/r235771 1457360 9 webkit-bug-importer 2018-09-06 17:28:04 -0700 <rdar://problem/44204528> 348883 2018-09-04 18:21:25 -0700 2018-09-06 15:36:43 -0700 Patch bug-189293-20180904182124.patch text/plain 3904 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NjMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzhjYjIxMjg1YjE1NWVlMDUwNzVhNjBlY2Q4NDgyNDNi MTA0MjEyOC4uMGYyZWRmMDc3ODQxM2JmYzg2ZWEzN2I1ZTI3ZjRiOGIyN2QxYTZlMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE4LTA5LTA0ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIExvZyB3aGVuIGxlYWsgZGV0ZWN0aW9uIGNoYW5nZXMgdGhlIHRlc3QgcmVzdWx0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkyOTMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAg IFdoZW4geW91IGhhdmUgYW4gIkxlYWsiIGV4cGVjdGF0aW9uIGluIFRlc3RFeHBlY3RhdGlvbnMs IGl0J3MgY29uZnVzaW5nIHRvIHNlZSBhIHRlc3QgdW5leHBlY3RlZGx5IHBhc3MsCisgICAgICAg IGJ1dCB0aGVuIHNob3cgdXAgYXMgYW4gZXhwZWN0ZWQgZmFpbCBhdCB0aGUgZW5kIChiZWNhdXNl IGxlYWsgZGV0ZWN0aW9uIGhhcHBlbnMgYXQgdGhlIGVuZCBvZiBhIHNoYXJkKS4KKyAgICAgICAg U28gbG9nIHdoZW4gbGVhayBkZXRlY3Rpb24gY2hhbmdlcyBhIHRlc3QgcmVzdWx0LgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbGF5b3V0X3Rl c3RfcnVubmVyLnB5OgorICAgICAgICAoTGF5b3V0VGVzdFJ1bm5lci5fYW5ub3RhdGVfcmVzdWx0 c193aXRoX2FkZGl0aW9uYWxfZmFpbHVyZXMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weToKKyAgICAgICAgKFRlc3RF eHBlY3RhdGlvbnMpOgorCiAyMDE4LTA5LTA0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5j b20+CiAKICAgICAgICAgQWRkIHByb2Nlc3MgcG9vbCBjb25maWd1cmF0aW9uIGZsYWcgdG8gdHVy biBvbiBhdXRvbWF0aWMgcHJvY2VzcyBwcmUtd2FybWluZwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbGF5b3V0X3Rlc3RfcnVubmVy LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbGF5 b3V0X3Rlc3RfcnVubmVyLnB5CmluZGV4IDRiMTk5NzRkOTg3NGRkODI2ZDNhYjVkNmRiMmI4MGVl ZDk5ZDE0MTIuLmViM2NlYzI5NDU5ZWIxNjVmODBmZjVjZGY4NzM4ZjM5MGRlNjEzMWIgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL2xh eW91dF90ZXN0X3J1bm5lci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9jb250cm9sbGVycy9sYXlvdXRfdGVzdF9ydW5uZXIucHkKQEAgLTIwMCw2ICsyMDAsMTAg QEAgY2xhc3MgTGF5b3V0VGVzdFJ1bm5lcihvYmplY3QpOgogICAgICAgICAgICAgaWYgZXhpc3Rp bmdfcmVzdWx0IGFuZCBleGlzdGluZ19yZXN1bHQudGVzdF9udW1iZXIgaXMgbm90IE5vbmU6CiAg ICAgICAgICAgICAgICAgd2FzX2V4cGVjdGVkID0gc2VsZi5fZXhwZWN0YXRpb25zLm1hdGNoZXNf YW5fZXhwZWN0ZWRfcmVzdWx0KG5ld19yZXN1bHQudGVzdF9uYW1lLCBleGlzdGluZ19yZXN1bHQu dHlwZSwgc2VsZi5fb3B0aW9ucy5waXhlbF90ZXN0cyBvciBleGlzdGluZ19yZXN1bHQucmVmdGVz dF90eXBlLCBzZWxmLl9vcHRpb25zLndvcmxkX2xlYWtzKQogICAgICAgICAgICAgICAgIG5vd19l eHBlY3RlZCA9IHNlbGYuX2V4cGVjdGF0aW9ucy5tYXRjaGVzX2FuX2V4cGVjdGVkX3Jlc3VsdChu ZXdfcmVzdWx0LnRlc3RfbmFtZSwgbmV3X3Jlc3VsdC50eXBlLCBzZWxmLl9vcHRpb25zLnBpeGVs X3Rlc3RzIG9yIG5ld19yZXN1bHQucmVmdGVzdF90eXBlLCBzZWxmLl9vcHRpb25zLndvcmxkX2xl YWtzKQorICAgICAgICAgICAgICAgIGlmIHdhc19leHBlY3RlZCAhPSBub3dfZXhwZWN0ZWQ6Cisg ICAgICAgICAgICAgICAgICAgIF9sb2cud2FybmluZygnICAlcyAtPiB0ZXN0IHdhcyBhICVzICgl cykgYnV0IGlzIG5vdyBhICVzICglcyknICUgKG5ld19yZXN1bHQudGVzdF9uYW1lLAorICAgICAg ICAgICAgICAgICAgICAgICAgVGVzdEV4cGVjdGF0aW9ucy5FWFBFQ1RBVElPTl9ERVNDUklQVElP TltleGlzdGluZ19yZXN1bHQudHlwZV0sICdleHBlY3RlZCcgaWYgd2FzX2V4cGVjdGVkIGVsc2Ug J3VuZXhwZWN0ZWQnLAorICAgICAgICAgICAgICAgICAgICAgICAgVGVzdEV4cGVjdGF0aW9ucy5F WFBFQ1RBVElPTl9ERVNDUklQVElPTltuZXdfcmVzdWx0LnR5cGVdLCAnZXhwZWN0ZWQnIGlmIG5v d19leHBlY3RlZCBlbHNlICd1bmV4cGVjdGVkJykpCiAgICAgICAgICAgICAgICAgcnVuX3Jlc3Vs dHMuY2hhbmdlX3Jlc3VsdF90b19mYWlsdXJlKGV4aXN0aW5nX3Jlc3VsdCwgbmV3X3Jlc3VsdCwg d2FzX2V4cGVjdGVkLCBub3dfZXhwZWN0ZWQpCiAKICAgICBkZWYgc3RhcnRfc2VydmVycyhzZWxm KToKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVs cy90ZXN0X2V4cGVjdGF0aW9ucy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weQppbmRleCBiM2FjYzY3MjVhNzRlNGEzZjhi OTM4YThkMGRmNDhmODdkNjk5YjIwLi40N2YwMWM5OGNlMWZlYTgzNGFlYTBiYTM3NWZiNTBmNGI3 ZDRhODhiIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9t b2RlbHMvdGVzdF9leHBlY3RhdGlvbnMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CkBAIC04MDEsNiArODAxLDE5 IEBAIGNsYXNzIFRlc3RFeHBlY3RhdGlvbnMob2JqZWN0KToKICAgICAgICAgICAgICAgICAgICAg J2xlYWsnOiBMRUFLLAogICAgICAgICAgICAgICAgICAgICAnc2tpcCc6IFNLSVB9CiAKKyAgICAj IFNpbmd1bGFycworICAgIEVYUEVDVEFUSU9OX0RFU0NSSVBUSU9OID0ge1NLSVA6ICdza2lwcGVk JywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUEFTUzogJ3Bhc3MnLAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBGQUlMOiAnZmFpbHVyZScsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIElNQUdFOiAnaW1hZ2Utb25seSBmYWlsdXJlJywKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgVEVYVDogJ3RleHQtb25seSBmYWlsdXJlJywKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgSU1BR0VfUExVU19URVhUOiAnaW1hZ2UgYW5kIHRl eHQgZmFpbHVyZScsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEFVRElPOiAnYXVk aW8gZmFpbHVyZScsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIENSQVNIOiAnY3Jh c2gnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBUSU1FT1VUOiAndGltZW91dCcs CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE1JU1NJTkc6ICdtaXNzaW5nJywKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTEVBSzogJ2xlYWsnfQorCiAgICAgIyAoYWdn cmVnYXRlZCBieSBjYXRlZ29yeSwgcGFzcy9mYWlsL3NraXAsIHR5cGUpCiAgICAgRVhQRUNUQVRJ T05fREVTQ1JJUFRJT05TID0ge1NLSVA6ICdza2lwcGVkJywKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgUEFTUzogJ3Bhc3NlcycsCg== 349084 2018-09-06 15:36:44 -0700 2018-09-06 17:02:24 -0700 Patch bug-189293-20180906153644.patch text/plain 5414 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NzQxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWExZTIxNjQ0OTQ1MWJiNDM2ZDFkNzMzMDBmMmRmOWUx MTYxNjc2YS4uY2UxYzFiNGU1MWMyNDkwMTRiNmZiOGJiYzM5Y2YyZWQxMzljMTBjMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE4LTA5LTA2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIExvZyB3aGVuIGxlYWsgZGV0ZWN0aW9uIGNoYW5nZXMgdGhlIHRlc3QgcmVzdWx0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkyOTMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAg IFdoZW4geW91IGhhdmUgYW4gIkxlYWsiIGV4cGVjdGF0aW9uIGluIFRlc3RFeHBlY3RhdGlvbnMs IGl0J3MgY29uZnVzaW5nIHRvIHNlZSBhIHRlc3QgdW5leHBlY3RlZGx5IHBhc3MsCisgICAgICAg IGJ1dCB0aGVuIHNob3cgdXAgYXMgYW4gZXhwZWN0ZWQgZmFpbCBhdCB0aGUgZW5kIChiZWNhdXNl IGxlYWsgZGV0ZWN0aW9uIGhhcHBlbnMgYXQgdGhlIGVuZCBvZiBhIHNoYXJkKS4KKyAgICAgICAg U28gbG9nIHdoZW4gbGVhayBkZXRlY3Rpb24gY2hhbmdlcyBhIHRlc3QgcmVzdWx0LgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbGF5b3V0X3Rl c3RfcnVubmVyLnB5OgorICAgICAgICAoTGF5b3V0VGVzdFJ1bm5lci5fYW5ub3RhdGVfcmVzdWx0 c193aXRoX2FkZGl0aW9uYWxfZmFpbHVyZXMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weToKKyAgICAgICAgKFRlc3RF eHBlY3RhdGlvbnMpOgorCiAyMDE4LTA5LTA2ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVs ZEBhcHBsZS5jb20+CiAKICAgICAgICAgW1dITFNMXSBUaGUgcGFyc2VyIGlzIHRvbyBzbG93CmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVy cy9sYXlvdXRfdGVzdF9ydW5uZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9jb250cm9sbGVycy9sYXlvdXRfdGVzdF9ydW5uZXIucHkKaW5kZXggNGIxOTk3NGQ5ODc0 ZGQ4MjZkM2FiNWQ2ZGIyYjgwZWVkOTlkMTQxMi4uYmY1N2Y2ZjNmYjI1ZjRlMzQ3ODNkODYwOTRl ZWUwNmEwMDk5MDJiMiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvY29udHJvbGxlcnMvbGF5b3V0X3Rlc3RfcnVubmVyLnB5CisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL2xheW91dF90ZXN0X3J1bm5lci5w eQpAQCAtMjAwLDYgKzIwMCwxMSBAQCBjbGFzcyBMYXlvdXRUZXN0UnVubmVyKG9iamVjdCk6CiAg ICAgICAgICAgICBpZiBleGlzdGluZ19yZXN1bHQgYW5kIGV4aXN0aW5nX3Jlc3VsdC50ZXN0X251 bWJlciBpcyBub3QgTm9uZToKICAgICAgICAgICAgICAgICB3YXNfZXhwZWN0ZWQgPSBzZWxmLl9l eHBlY3RhdGlvbnMubWF0Y2hlc19hbl9leHBlY3RlZF9yZXN1bHQobmV3X3Jlc3VsdC50ZXN0X25h bWUsIGV4aXN0aW5nX3Jlc3VsdC50eXBlLCBzZWxmLl9vcHRpb25zLnBpeGVsX3Rlc3RzIG9yIGV4 aXN0aW5nX3Jlc3VsdC5yZWZ0ZXN0X3R5cGUsIHNlbGYuX29wdGlvbnMud29ybGRfbGVha3MpCiAg ICAgICAgICAgICAgICAgbm93X2V4cGVjdGVkID0gc2VsZi5fZXhwZWN0YXRpb25zLm1hdGNoZXNf YW5fZXhwZWN0ZWRfcmVzdWx0KG5ld19yZXN1bHQudGVzdF9uYW1lLCBuZXdfcmVzdWx0LnR5cGUs IHNlbGYuX29wdGlvbnMucGl4ZWxfdGVzdHMgb3IgbmV3X3Jlc3VsdC5yZWZ0ZXN0X3R5cGUsIHNl bGYuX29wdGlvbnMud29ybGRfbGVha3MpCisgICAgICAgICAgICAgICAgaWYgd2FzX2V4cGVjdGVk ICE9IG5vd19leHBlY3RlZDoKKyAgICAgICAgICAgICAgICAgICAgIyBXaGVuIGFubm90YXRpb24g aXMgbm90IGp1c3QgYWJvdXQgbGVha3MsIHRoaXMgbG9nZ2luZyBzaG91bGQgYmUgY2hhbmdlZC4K KyAgICAgICAgICAgICAgICAgICAgX2xvZy53YXJuaW5nKCcgICVzIC0+IGNoYW5nZWQgYnkgbGVh ayBkZXRlY3Rpb24gZnJvbSBhICVzICglcykgdG8gYSAlcyAoJXMpJyAlIChuZXdfcmVzdWx0LnRl c3RfbmFtZSwKKyAgICAgICAgICAgICAgICAgICAgICAgIFRlc3RFeHBlY3RhdGlvbnMuRVhQRUNU QVRJT05fREVTQ1JJUFRJT05bZXhpc3RpbmdfcmVzdWx0LnR5cGVdLCAnZXhwZWN0ZWQnIGlmIHdh c19leHBlY3RlZCBlbHNlICd1bmV4cGVjdGVkJywKKyAgICAgICAgICAgICAgICAgICAgICAgIFRl c3RFeHBlY3RhdGlvbnMuRVhQRUNUQVRJT05fREVTQ1JJUFRJT05bbmV3X3Jlc3VsdC50eXBlXSwg J2V4cGVjdGVkJyBpZiBub3dfZXhwZWN0ZWQgZWxzZSAndW5leHBlY3RlZCcpKQogICAgICAgICAg ICAgICAgIHJ1bl9yZXN1bHRzLmNoYW5nZV9yZXN1bHRfdG9fZmFpbHVyZShleGlzdGluZ19yZXN1 bHQsIG5ld19yZXN1bHQsIHdhc19leHBlY3RlZCwgbm93X2V4cGVjdGVkKQogCiAgICAgZGVmIHN0 YXJ0X3NlcnZlcnMoc2VsZik6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnMucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnMucHkKaW5kZXggYjNh Y2M2NzI1YTc0ZTRhM2Y4YjkzOGE4ZDBkZjQ4Zjg3ZDY5OWIyMC4uNDdmMDFjOThjZTFmZWE4MzRh ZWEwYmEzNzVmYjUwZjRiN2Q0YTg4YiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weQpA QCAtODAxLDYgKzgwMSwxOSBAQCBjbGFzcyBUZXN0RXhwZWN0YXRpb25zKG9iamVjdCk6CiAgICAg ICAgICAgICAgICAgICAgICdsZWFrJzogTEVBSywKICAgICAgICAgICAgICAgICAgICAgJ3NraXAn OiBTS0lQfQogCisgICAgIyBTaW5ndWxhcnMKKyAgICBFWFBFQ1RBVElPTl9ERVNDUklQVElPTiA9 IHtTS0lQOiAnc2tpcHBlZCcsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBBU1M6 ICdwYXNzJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRkFJTDogJ2ZhaWx1cmUn LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBJTUFHRTogJ2ltYWdlLW9ubHkgZmFp bHVyZScsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFRFWFQ6ICd0ZXh0LW9ubHkg ZmFpbHVyZScsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIElNQUdFX1BMVVNfVEVY VDogJ2ltYWdlIGFuZCB0ZXh0IGZhaWx1cmUnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBBVURJTzogJ2F1ZGlvIGZhaWx1cmUnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBDUkFTSDogJ2NyYXNoJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgVElN RU9VVDogJ3RpbWVvdXQnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBNSVNTSU5H OiAnbWlzc2luZycsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIExFQUs6ICdsZWFr J30KKwogICAgICMgKGFnZ3JlZ2F0ZWQgYnkgY2F0ZWdvcnksIHBhc3MvZmFpbC9za2lwLCB0eXBl KQogICAgIEVYUEVDVEFUSU9OX0RFU0NSSVBUSU9OUyA9IHtTS0lQOiAnc2tpcHBlZCcsCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBBU1M6ICdwYXNzZXMnLApkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvdmlld3MvcHJpbnRpbmcucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy92aWV3cy9wcmludGluZy5weQppbmRl eCAwZGVjOWM4MWFjNGQ0Nzg1ZDEwYTc2NzMwM2Y3MzE5ODczYTM5YTJlLi4xZDEyMzcxMTA4ZTll MWI1NTYxY2MzNTk2NmNmNDZmMDVhZDUzMjlkIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy92aWV3cy9wcmludGluZy5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy92aWV3cy9wcmludGluZy5weQpAQCAtMzIxLDcgKzMyMSw3 IEBAIGNsYXNzIFByaW50ZXIob2JqZWN0KToKICAgICBkZWYgcHJpbnRfZmluaXNoZWRfdGVzdChz ZWxmLCByZXN1bHQsIGV4cGVjdGVkLCBleHBfc3RyLCBnb3Rfc3RyKToKICAgICAgICAgdGVzdF9u YW1lID0gcmVzdWx0LnRlc3RfbmFtZQogCi0gICAgICAgIHJlc3VsdF9tZXNzYWdlID0gc2VsZi5f cmVzdWx0X21lc3NhZ2UocmVzdWx0LnR5cGUsIHJlc3VsdC5mYWlsdXJlcywgZXhwZWN0ZWQsIHNl bGYuX29wdGlvbnMudmVyYm9zZSkKKyAgICAgICAgcmVzdWx0X21lc3NhZ2UgPSBzZWxmLl9yZXN1 bHRfbWVzc2FnZShyZXN1bHQudHlwZSwgcmVzdWx0LmZhaWx1cmVzLCBleHBlY3RlZCwgZXhwX3N0 ciwgc2VsZi5fb3B0aW9ucy52ZXJib3NlKQogCiAgICAgICAgIGlmIHNlbGYuX29wdGlvbnMuZGV0 YWlsczoKICAgICAgICAgICAgIHNlbGYuX3ByaW50X3Rlc3RfdHJhY2UocmVzdWx0LCBleHBfc3Ry LCBnb3Rfc3RyKQpAQCAtMzQwLDggKzM0MCwxMSBAQCBjbGFzcyBQcmludGVyKG9iamVjdCk6CiAg ICAgICAgICAgICBzZWxmLl9jb21wbGV0ZWRfdGVzdHMgPSBbXQogICAgICAgICBzZWxmLl9ydW5u aW5nX3Rlc3RzLnJlbW92ZSh0ZXN0X25hbWUpCiAKLSAgICBkZWYgX3Jlc3VsdF9tZXNzYWdlKHNl bGYsIHJlc3VsdF90eXBlLCBmYWlsdXJlcywgZXhwZWN0ZWQsIHZlcmJvc2UpOgotICAgICAgICBl eHBfc3RyaW5nID0gJyB1bmV4cGVjdGVkbHknIGlmIG5vdCBleHBlY3RlZCBlbHNlICcnCisgICAg ZGVmIF9yZXN1bHRfbWVzc2FnZShzZWxmLCByZXN1bHRfdHlwZSwgZmFpbHVyZXMsIGV4cGVjdGVk LCBleHBfc3RyLCB2ZXJib3NlKToKKyAgICAgICAgZXhwX3N0cmluZyA9ICcnCisgICAgICAgIGlm IG5vdCBleHBlY3RlZDoKKyAgICAgICAgICAgIGV4cF9zdHJpbmcgPSAnIChsZWFrIGRldGVjdGlv biBpcyBwZW5kaW5nKScgaWYgJ0xFQUsnIGluIGV4cF9zdHIgZWxzZSAnIHVuZXhwZWN0ZWRseScK KwogICAgICAgICBpZiByZXN1bHRfdHlwZSA9PSB0ZXN0X2V4cGVjdGF0aW9ucy5QQVNTOgogICAg ICAgICAgICAgcmV0dXJuICcgcGFzc2VkJXMnICUgZXhwX3N0cmluZwogICAgICAgICBlbHNlOgo=