189292 2018-09-04 17:55:13 -0700 isAsyncGeneratorMethodParseMode() should check for SourceParseMode::AsyncGeneratorWrapperMethodMode. 2018-09-05 01:14:53 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1456567 0 mark.lam 2018-09-04 17:55:13 -0700 Currently, it's checking for SourceParseMode::AsyncGeneratorWrapperFunctionMode instead. <rdar://problem/38907433> 1456576 1 348881 mark.lam 2018-09-04 18:04:01 -0700 Created attachment 348881 proposed patch. 1456623 2 348881 saam 2018-09-04 21:49:09 -0700 Comment on attachment 348881 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=348881&action=review r=me Did this make any test262 tests pass? > Source/JavaScriptCore/ChangeLog:9 > + Previously, it's checking for SourceParseMode::AsyncGeneratorWrapperFunctionMode instead. You need to rewrite this sentence > Source/JavaScriptCore/parser/ParserModes.h:192 > + SourceParseMode::AsyncGeneratorWrapperMethodMode).contains(parseMode); Why on two lines? The indentation here looks weird (though perhaps that’s a bugzilla bug) 1456626 3 348881 mark.lam 2018-09-04 21:55:49 -0700 Comment on attachment 348881 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=348881&action=review Thanks for the review. >> Source/JavaScriptCore/parser/ParserModes.h:192 >> + SourceParseMode::AsyncGeneratorWrapperMethodMode).contains(parseMode); > > Why on two lines? The indentation here looks weird (though perhaps that’s a bugzilla bug) I'll put it back on 1 line. 1456632 4 mark.lam 2018-09-04 22:17:35 -0700 (In reply to Saam Barati from comment #2) > Did this make any test262 tests pass? I'm running test262 now. 1456640 5 mark.lam 2018-09-04 23:14:40 -0700 (In reply to Mark Lam from comment #4) > (In reply to Saam Barati from comment #2) > > Did this make any test262 tests pass? > > I'm running test262 now. The test262 results: NEW PASS test/intl402/PluralRules/prototype/resolvedOptions/pluralCategories.js (strict mode) NEW PASS test/intl402/PluralRules/prototype/resolvedOptions/pluralCategories.js (default) NEW PASS test/intl402/NumberFormat/prototype/formatToParts/length.js (strict mode) NEW PASS test/intl402/NumberFormat/prototype/formatToParts/formatToParts.js (strict mode) NEW PASS test/intl402/NumberFormat/prototype/formatToParts/default-parameter.js (strict mode) NEW PASS test/intl402/NumberFormat/prototype/formatToParts/name.js (strict mode) NEW PASS test/intl402/NumberFormat/prototype/formatToParts/return-abrupt-tonumber.js (strict mode) NEW PASS test/intl402/NumberFormat/prototype/formatToParts/main.js (strict mode) NEW PASS test/intl402/NumberFormat/prototype/formatToParts/length.js (default) NEW PASS test/intl402/NumberFormat/prototype/formatToParts/name.js (default) NEW PASS test/intl402/NumberFormat/prototype/formatToParts/formatToParts.js (default) NEW PASS test/intl402/NumberFormat/prototype/formatToParts/default-parameter.js (default) NEW PASS test/intl402/NumberFormat/prototype/formatToParts/return-abrupt-tonumber.js (default) NEW PASS test/intl402/NumberFormat/prototype/formatToParts/main.js (default) 49176 tests run 5031 test files skipped 2375 tests failed in total 0 tests newly fail 14 tests newly pass These 14 new passes are all in the intl402 spec. I don't think they have anything to do with my patch. 1456641 6 348896 mark.lam 2018-09-04 23:17:20 -0700 Created attachment 348896 patch for landing. 1456661 7 348896 commit-queue 2018-09-05 01:14:51 -0700 Comment on attachment 348896 patch for landing. Clearing flags on attachment: 348896 Committed r235662: <https://trac.webkit.org/changeset/235662> 1456662 8 commit-queue 2018-09-05 01:14:53 -0700 All reviewed patches have been landed. Closing bug. 348881 2018-09-04 18:04:01 -0700 2018-09-04 23:17:20 -0700 proposed patch. bug-189292.patch text/plain 2926 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzU2NTEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTA5LTA0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBpc0FzeW5jR2VuZXJhdG9yTWV0aG9kUGFyc2VNb2RlKCkgc2hvdWxkIGNo ZWNrIGZvciBTb3VyY2VQYXJzZU1vZGU6OkFzeW5jR2VuZXJhdG9yV3JhcHBlck1ldGhvZE1vZGUu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkyOTIK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM4OTA3NDMzPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL3JlZ3Jlc3MtMTg5MjkyLmpzOiBB ZGRlZC4KKwogMjAxOC0wOS0wNCAgRGF2aWQgRmVudG9uICA8ZGF2aWRfZmVudG9uQGFwcGxlLmNv bT4KIAogICAgICAgICBTa2lwIFRlc3Qgb24gMzItYml0IHBsYXRmb3Jtcy4KSW5kZXg6IEpTVGVz dHMvc3RyZXNzL3JlZ3Jlc3MtMTg5MjkyLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNz L3JlZ3Jlc3MtMTg5MjkyLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL3JlZ3Jl c3MtMTg5MjkyLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTggQEAKKy8vQCBydW5EZWZh dWx0CisKK2Z1bmN0aW9uIGFzc2VydChhLCBiKSB7CisgICAgaWYgKGEgIT0gYikKKyAgICAgICAg dGhyb3cgIkZBSUwiOworfQorCitmdW5jdGlvbiB0ZXN0KHNjcmlwdCkgeworICAgIHRyeSB7Cisg ICAgICAgIGV2YWwoc2NyaXB0KTsKKyAgICB9IGNhdGNoIChlKSB7CisgICAgICAgIHJldHVybiBl OworICAgIH0KK30KKworYXNzZXJ0KHRlc3QoImNsYXNzIEMxIHsgYXN5bmMgY29uc3RydWN0b3Io KSB7IH0gfSIpLCAiU3ludGF4RXJyb3I6IENhbm5vdCBkZWNsYXJlIGFuIGFzeW5jIG1ldGhvZCBu YW1lZCAnY29uc3RydWN0b3InLiIpOworYXNzZXJ0KHRlc3QoImNsYXNzIEMxIHsgKmNvbnN0cnVj dG9yKCkgeyB9IH0iKSwgIlN5bnRheEVycm9yOiBDYW5ub3QgZGVjbGFyZSBhIGdlbmVyYXRvciBm dW5jdGlvbiBuYW1lZCAnY29uc3RydWN0b3InLiIpOworYXNzZXJ0KHRlc3QoImNsYXNzIEMxIHsg YXN5bmMgKmNvbnN0cnVjdG9yKCkgeyB9IH0iKSwgIlN5bnRheEVycm9yOiBDYW5ub3QgZGVjbGFy ZSBhbiBhc3luYyBnZW5lcmF0b3IgbWV0aG9kIG5hbWVkICdjb25zdHJ1Y3RvcicuIik7CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNTYyNykKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAx OC0wOS0wNCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAgaXNBc3lu Y0dlbmVyYXRvck1ldGhvZFBhcnNlTW9kZSgpIHNob3VsZCBjaGVjayBmb3IgU291cmNlUGFyc2VN b2RlOjpBc3luY0dlbmVyYXRvcldyYXBwZXJNZXRob2RNb2RlLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5MjkyCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8zODkwNzQzMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBQcmV2aW91c2x5LCBpdCdzIGNoZWNraW5nIGZvciBTb3VyY2VQYXJzZU1vZGU6OkFz eW5jR2VuZXJhdG9yV3JhcHBlckZ1bmN0aW9uTW9kZSBpbnN0ZWFkLgorCisgICAgICAgICogcGFy c2VyL1BhcnNlck1vZGVzLmg6CisgICAgICAgIChKU0M6OmlzQXN5bmNHZW5lcmF0b3JNZXRob2RQ YXJzZU1vZGUpOgorCiAyMDE4LTA5LTA0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4K IAogICAgICAgICBNYWtlIHRoZSBqc2Mgc2hlbGwgcHJpbnQsIHByaW50RXJyLCBhbmQgZGVidWcg ZnVuY3Rpb25zIG1vcmUgcm9idXN0LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNl ci9QYXJzZXJNb2Rlcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJz ZXIvUGFyc2VyTW9kZXMuaAkocmV2aXNpb24gMjM1NjI3KQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL3BhcnNlci9QYXJzZXJNb2Rlcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xODgsNyArMTg4LDgg QEAgQUxXQVlTX0lOTElORSBib29sIGlzQXN5bmNNZXRob2RQYXJzZU1vZAogICAgIAogQUxXQVlT X0lOTElORSBib29sIGlzQXN5bmNHZW5lcmF0b3JNZXRob2RQYXJzZU1vZGUoU291cmNlUGFyc2VN b2RlIHBhcnNlTW9kZSkKIHsKLSAgICByZXR1cm4gU291cmNlUGFyc2VNb2RlU2V0KFNvdXJjZVBh cnNlTW9kZTo6QXN5bmNHZW5lcmF0b3JXcmFwcGVyRnVuY3Rpb25Nb2RlKS5jb250YWlucyhwYXJz ZU1vZGUpOworICAgIHJldHVybiBTb3VyY2VQYXJzZU1vZGVTZXQoCisgICAgICAgIFNvdXJjZVBh cnNlTW9kZTo6QXN5bmNHZW5lcmF0b3JXcmFwcGVyTWV0aG9kTW9kZSkuY29udGFpbnMocGFyc2VN b2RlKTsKIH0KIAogQUxXQVlTX0lOTElORSBib29sIGlzTWV0aG9kUGFyc2VNb2RlKFNvdXJjZVBh cnNlTW9kZSBwYXJzZU1vZGUpCg== 348896 2018-09-04 23:17:20 -0700 2018-09-05 01:14:51 -0700 patch for landing. bug-189292.patch text/plain 3108 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzU2NTkpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTA5LTA0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBpc0FzeW5jR2VuZXJhdG9yTWV0aG9kUGFyc2VNb2RlKCkgc2hvdWxkIGNo ZWNrIGZvciBTb3VyY2VQYXJzZU1vZGU6OkFzeW5jR2VuZXJhdG9yV3JhcHBlck1ldGhvZE1vZGUu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkyOTIK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM4OTA3NDMzPgorCisgICAgICAgIFJldmlld2VkIGJ5 IFNhYW0gQmFyYXRpLgorCisgICAgICAgICogc3RyZXNzL3JlZ3Jlc3MtMTg5MjkyLmpzOiBBZGRl ZC4KKwogMjAxOC0wOS0wNCAgRGF2aWQgRmVudG9uICA8ZGF2aWRfZmVudG9uQGFwcGxlLmNvbT4K IAogICAgICAgICBTa2lwIFRlc3Qgb24gMzItYml0IHBsYXRmb3Jtcy4KSW5kZXg6IEpTVGVzdHMv c3RyZXNzL3JlZ3Jlc3MtMTg5MjkyLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3Jl Z3Jlc3MtMTg5MjkyLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3Mt MTg5MjkyLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTggQEAKKy8vQCBydW5EZWZhdWx0 CisKK2Z1bmN0aW9uIGFzc2VydChhLCBiKSB7CisgICAgaWYgKGEgIT0gYikKKyAgICAgICAgdGhy b3cgIkZBSUwiOworfQorCitmdW5jdGlvbiB0ZXN0KHNjcmlwdCkgeworICAgIHRyeSB7CisgICAg ICAgIGV2YWwoc2NyaXB0KTsKKyAgICB9IGNhdGNoIChlKSB7CisgICAgICAgIHJldHVybiBlOwor ICAgIH0KK30KKworYXNzZXJ0KHRlc3QoImNsYXNzIEMxIHsgYXN5bmMgY29uc3RydWN0b3IoKSB7 IH0gfSIpLCAiU3ludGF4RXJyb3I6IENhbm5vdCBkZWNsYXJlIGFuIGFzeW5jIG1ldGhvZCBuYW1l ZCAnY29uc3RydWN0b3InLiIpOworYXNzZXJ0KHRlc3QoImNsYXNzIEMxIHsgKmNvbnN0cnVjdG9y KCkgeyB9IH0iKSwgIlN5bnRheEVycm9yOiBDYW5ub3QgZGVjbGFyZSBhIGdlbmVyYXRvciBmdW5j dGlvbiBuYW1lZCAnY29uc3RydWN0b3InLiIpOworYXNzZXJ0KHRlc3QoImNsYXNzIEMxIHsgYXN5 bmMgKmNvbnN0cnVjdG9yKCkgeyB9IH0iKSwgIlN5bnRheEVycm9yOiBDYW5ub3QgZGVjbGFyZSBh biBhc3luYyBnZW5lcmF0b3IgbWV0aG9kIG5hbWVkICdjb25zdHJ1Y3RvcicuIik7CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNTY1OSkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOSBAQAorMjAxOC0w OS0wNCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAgaXNBc3luY0dl bmVyYXRvck1ldGhvZFBhcnNlTW9kZSgpIHNob3VsZCBjaGVjayBmb3IgU291cmNlUGFyc2VNb2Rl OjpBc3luY0dlbmVyYXRvcldyYXBwZXJNZXRob2RNb2RlLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5MjkyCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8zODkwNzQzMz4KKworICAgICAgICBSZXZpZXdlZCBieSBTYWFtIEJhcmF0aS4KKworICAgICAg ICBQcmV2aW91c2x5LCBpc0FzeW5jR2VuZXJhdG9yTWV0aG9kUGFyc2VNb2RlKCkgd2FzIGNoZWNr aW5nIGZvciBBc3luY0dlbmVyYXRvcldyYXBwZXJGdW5jdGlvbk1vZGUKKyAgICAgICAgaW5zdGVh ZCBvZiBBc3luY0dlbmVyYXRvcldyYXBwZXJNZXRob2RNb2RlLiAgVGhpcyBwYXRjaCBmaXhlcyBp dAorICAgICAgICB0byBjaGVjayBmb3IgQXN5bmNHZW5lcmF0b3JXcmFwcGVyTWV0aG9kTW9kZSAo dG8gbWF0Y2ggd2hhdCBpcyBleHBlY3RlZCBhcyBpbmRpY2F0ZWQKKyAgICAgICAgaW4gdGhlIG5h bWUgaXNBc3luY0dlbmVyYXRvck1ldGhvZFBhcnNlTW9kZSkuCisKKyAgICAgICAgKiBwYXJzZXIv UGFyc2VyTW9kZXMuaDoKKyAgICAgICAgKEpTQzo6aXNBc3luY0dlbmVyYXRvck1ldGhvZFBhcnNl TW9kZSk6CisKIDIwMTgtMDktMDQgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZCBpbmRlbnRhdGlvbnMgY2hhbmdlLgpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXJNb2Rlcy5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyTW9kZXMuaAkocmV2aXNpb24gMjM1NjU5KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXJNb2Rlcy5oCSh3b3JraW5nIGNv cHkpCkBAIC0xODgsNyArMTg4LDcgQEAgQUxXQVlTX0lOTElORSBib29sIGlzQXN5bmNNZXRob2RQ YXJzZU1vZAogICAgIAogQUxXQVlTX0lOTElORSBib29sIGlzQXN5bmNHZW5lcmF0b3JNZXRob2RQ YXJzZU1vZGUoU291cmNlUGFyc2VNb2RlIHBhcnNlTW9kZSkKIHsKLSAgICByZXR1cm4gU291cmNl UGFyc2VNb2RlU2V0KFNvdXJjZVBhcnNlTW9kZTo6QXN5bmNHZW5lcmF0b3JXcmFwcGVyRnVuY3Rp b25Nb2RlKS5jb250YWlucyhwYXJzZU1vZGUpOworICAgIHJldHVybiBTb3VyY2VQYXJzZU1vZGVT ZXQoU291cmNlUGFyc2VNb2RlOjpBc3luY0dlbmVyYXRvcldyYXBwZXJNZXRob2RNb2RlKS5jb250 YWlucyhwYXJzZU1vZGUpOwogfQogCiBBTFdBWVNfSU5MSU5FIGJvb2wgaXNNZXRob2RQYXJzZU1v ZGUoU291cmNlUGFyc2VNb2RlIHBhcnNlTW9kZSkK