<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>189247</bug_id>
          
          <creation_ts>2018-09-03 10:52:15 -0700</creation_ts>
          <short_desc>CallFrame::unsafeCallee() should use an ASAN suppressed Register::asanUnsafePointer().</short_desc>
          <delta_ts>2018-09-03 16:30:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mark Lam">mark.lam</reporter>
          <assigned_to name="Mark Lam">mark.lam</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>fpizlo</cc>
    
    <cc>keith_miller</cc>
    
    <cc>msaboff</cc>
    
    <cc>rmorisset</cc>
    
    <cc>saam</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1456187</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2018-09-03 10:52:15 -0700</bug_when>
    <thetext>Patch coming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456190</commentid>
    <comment_count>1</comment_count>
      <attachid>348779</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2018-09-03 11:08:05 -0700</bug_when>
    <thetext>Created attachment 348779
proposed patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456209</commentid>
    <comment_count>2</comment_count>
      <attachid>348779</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2018-09-03 13:06:06 -0700</bug_when>
    <thetext>Comment on attachment 348779
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=348779&amp;action=review

&gt; Source/JavaScriptCore/interpreter/Register.h:125
&gt; +        return asanUnsafeJSValue();

How does this not remove asan protection?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456212</commentid>
    <comment_count>3</comment_count>
      <attachid>348779</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2018-09-03 13:11:12 -0700</bug_when>
    <thetext>Comment on attachment 348779
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=348779&amp;action=review

&gt;&gt; Source/JavaScriptCore/interpreter/Register.h:125
&gt;&gt; +        return asanUnsafeJSValue();
&gt; 
&gt; How does this not remove asan protection?

I was previously thinking that the outer function Register::jsValue() not being a ASAN suppressed function means that this is OK.  But I&apos;m wrong: this is a bug.  I will undo these call forwardinh changes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456213</commentid>
    <comment_count>4</comment_count>
      <attachid>348788</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2018-09-03 13:17:52 -0700</bug_when>
    <thetext>Created attachment 348788
proposed patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456214</commentid>
    <comment_count>5</comment_count>
      <attachid>348788</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2018-09-03 13:27:12 -0700</bug_when>
    <thetext>Comment on attachment 348788
proposed patch.

Got a bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456216</commentid>
    <comment_count>6</comment_count>
      <attachid>348789</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2018-09-03 13:45:31 -0700</bug_when>
    <thetext>Created attachment 348789
proposed patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456229</commentid>
    <comment_count>7</comment_count>
      <attachid>348789</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-09-03 16:29:43 -0700</bug_when>
    <thetext>Comment on attachment 348789
proposed patch.

Clearing flags on attachment: 348789

Committed r235603: &lt;https://trac.webkit.org/changeset/235603&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456230</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-09-03 16:29:45 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456231</commentid>
    <comment_count>9</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-09-03 16:30:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/44079982&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>348779</attachid>
            <date>2018-09-03 11:08:05 -0700</date>
            <delta_ts>2018-09-03 13:17:52 -0700</delta_ts>
            <desc>proposed patch.</desc>
            <filename>bug-189247.patch</filename>
            <type>text/plain</type>
            <size>3623</size>
            <attacher name="Mark Lam">mark.lam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM1NjAwKQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA
CisyMDE4LTA5LTAzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD
YWxsRnJhbWU6OnVuc2FmZUNhbGxlZSgpIHNob3VsZCB1c2UgYW4gQVNBTiBzdXBwcmVzc2VkIFJl
Z2lzdGVyOjphc2FuVW5zYWZlUG9pbnRlcigpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5MjQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgQWxzbyBtYWRlIHNvbWUgUmVnaXN0ZXIgbWV0aG9kcyBjYWxs
IHRoZWlyIGFzYW5VbnNhZmUgZXF1aXZhbGVudHMuICBUaGlzIGVuc3VyZXMKKyAgICAgICAgdGhh
dCB0aGlzIG9uZSBzaW5nbGUgY2Fub25pY2FsIGRlZmluaXRpb24gb2Ygd2hhdCB0aG9zZSBtZXRo
b2RzIGRvLgorCisgICAgICAgICogaW50ZXJwcmV0ZXIvQ2FsbEZyYW1lLmg6CisgICAgICAgIChK
U0M6OkV4ZWNTdGF0ZTo6dW5zYWZlQ2FsbGVlIGNvbnN0KToKKyAgICAgICAgKiBpbnRlcnByZXRl
ci9SZWdpc3Rlci5oOgorICAgICAgICAoSlNDOjpSZWdpc3Rlcjo6anNWYWx1ZSBjb25zdCk6Cisg
ICAgICAgIChKU0M6OlJlZ2lzdGVyOjpjb2RlQmxvY2sgY29uc3QpOgorICAgICAgICAoSlNDOjpS
ZWdpc3Rlcjo6cG9pbnRlciBjb25zdCk6CisgICAgICAgIChKU0M6OlJlZ2lzdGVyOjphc2FuVW5z
YWZlUG9pbnRlciBjb25zdCk6CisKIDIwMTgtMDktMDIgIFl1c3VrZSBTdXp1a2kgIDx5dXN1a2Vz
dXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAgICAgICBJbXBsZW1lbnQgT2JqZWN0LmZyb21FbnRy
aWVzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvQ2FsbEZyYW1lLmgK
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0NhbGxGcmFt
ZS5oCShyZXZpc2lvbiAyMzU2MDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0
ZXIvQ2FsbEZyYW1lLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwNiw3ICsxMDYsNyBAQCBuYW1lc3Bh
Y2UgSlNDICB7CiAgICAgICAgICAgICByZXR1cm4gdGhpc1tDYWxsRnJhbWVTbG90OjpjYWxsZWVd
Lm9iamVjdCgpOwogICAgICAgICB9CiAgICAgICAgIENhbGxlZUJpdHMgY2FsbGVlKCkgY29uc3Qg
eyByZXR1cm4gQ2FsbGVlQml0cyh0aGlzW0NhbGxGcmFtZVNsb3Q6OmNhbGxlZV0ucG9pbnRlcigp
KTsgfQotICAgICAgICBTVVBQUkVTU19BU0FOIENhbGxlZUJpdHMgdW5zYWZlQ2FsbGVlKCkgY29u
c3QgeyByZXR1cm4gQ2FsbGVlQml0cyh0aGlzW0NhbGxGcmFtZVNsb3Q6OmNhbGxlZV0ucG9pbnRl
cigpKTsgfQorICAgICAgICBTVVBQUkVTU19BU0FOIENhbGxlZUJpdHMgdW5zYWZlQ2FsbGVlKCkg
Y29uc3QgeyByZXR1cm4gQ2FsbGVlQml0cyh0aGlzW0NhbGxGcmFtZVNsb3Q6OmNhbGxlZV0uYXNh
blVuc2FmZVBvaW50ZXIoKSk7IH0KICAgICAgICAgQ29kZUJsb2NrKiBjb2RlQmxvY2soKSBjb25z
dCB7IHJldHVybiB0aGlzW0NhbGxGcmFtZVNsb3Q6OmNvZGVCbG9ja10uUmVnaXN0ZXI6OmNvZGVC
bG9jaygpOyB9CiAgICAgICAgIENvZGVCbG9jayoqIGFkZHJlc3NPZkNvZGVCbG9jaygpIGNvbnN0
IHsgcmV0dXJuIGJpdHdpc2VfY2FzdDxDb2RlQmxvY2sqKj4odGhpcyArIENhbGxGcmFtZVNsb3Q6
OmNvZGVCbG9jayk7IH0KICAgICAgICAgU1VQUFJFU1NfQVNBTiBDb2RlQmxvY2sqIHVuc2FmZUNv
ZGVCbG9jaygpIGNvbnN0IHsgcmV0dXJuIHRoaXNbQ2FsbEZyYW1lU2xvdDo6Y29kZUJsb2NrXS5S
ZWdpc3Rlcjo6YXNhblVuc2FmZUNvZGVCbG9jaygpOyB9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw
dENvcmUvaW50ZXJwcmV0ZXIvUmVnaXN0ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj
cmlwdENvcmUvaW50ZXJwcmV0ZXIvUmVnaXN0ZXIuaAkocmV2aXNpb24gMjM1NjAwKQorKysgU291
cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL1JlZ2lzdGVyLmgJKHdvcmtpbmcgY29weSkK
QEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA4LCAyMDA5IEFwcGxlIElu
Yy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwOC0yMDE4IEFwcGxl
IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNl
IGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNh
dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u
cwpAQCAtNzcsNiArNzcsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgaW50MzJfdCYgdGFn
KCk7CiAKICAgICAgICAgdm9pZCogcG9pbnRlcigpIGNvbnN0OworICAgICAgICB2b2lkKiBhc2Fu
VW5zYWZlUG9pbnRlcigpIGNvbnN0OwogCiAgICAgICAgIHN0YXRpYyBSZWdpc3RlciB3aXRoSW50
KGludDMyX3QgaSkKICAgICAgICAgewpAQCAtMTIxLDcgKzEyMiw3IEBAIG5hbWVzcGFjZSBKU0Mg
ewogCiAgICAgQUxXQVlTX0lOTElORSBKU1ZhbHVlIFJlZ2lzdGVyOjpqc1ZhbHVlKCkgY29uc3QK
ICAgICB7Ci0gICAgICAgIHJldHVybiBKU1ZhbHVlOjpkZWNvZGUodS52YWx1ZSk7CisgICAgICAg
IHJldHVybiBhc2FuVW5zYWZlSlNWYWx1ZSgpOwogICAgIH0KIAogICAgIEFMV0FZU19JTkxJTkUg
RW5jb2RlZEpTVmFsdWUgUmVnaXN0ZXI6OmVuY29kZWRKU1ZhbHVlKCkgY29uc3QKQEAgLTE1NSw3
ICsxNTYsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAKICAgICBBTFdBWVNfSU5MSU5FIENvZGVC
bG9jayogUmVnaXN0ZXI6OmNvZGVCbG9jaygpIGNvbnN0CiAgICAgewotICAgICAgICByZXR1cm4g
dS5jb2RlQmxvY2s7CisgICAgICAgIHJldHVybiBhc2FuVW5zYWZlQ29kZUJsb2NrKCk7CiAgICAg
fQogCiAgICAgU1VQUFJFU1NfQVNBTiBBTFdBWVNfSU5MSU5FIENvZGVCbG9jayogUmVnaXN0ZXI6
OmFzYW5VbnNhZmVDb2RlQmxvY2soKSBjb25zdApAQCAtMTk5LDYgKzIwMCwxMSBAQCBuYW1lc3Bh
Y2UgSlNDIHsKIAogICAgIEFMV0FZU19JTkxJTkUgdm9pZCogUmVnaXN0ZXI6OnBvaW50ZXIoKSBj
b25zdAogICAgIHsKKyAgICAgICAgcmV0dXJuIGFzYW5VbnNhZmVQb2ludGVyKCk7CisgICAgfQor
CisgICAgU1VQUFJFU1NfQVNBTiBBTFdBWVNfSU5MSU5FIHZvaWQqIFJlZ2lzdGVyOjphc2FuVW5z
YWZlUG9pbnRlcigpIGNvbnN0CisgICAgewogI2lmIFVTRShKU1ZBTFVFNjQpCiAgICAgICAgIHJl
dHVybiB1LmVuY29kZWRWYWx1ZS5wdHI7CiAjZWxzZQo=
</data>
<flag name="review"
          id="366377"
          type_id="1"
          status="+"
          setter="saam"
    />
    <flag name="commit-queue"
          id="366378"
          type_id="3"
          status="-"
          setter="saam"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>348788</attachid>
            <date>2018-09-03 13:17:52 -0700</date>
            <delta_ts>2018-09-03 13:45:43 -0700</delta_ts>
            <desc>proposed patch.</desc>
            <filename>bug-189247.patch</filename>
            <type>text/plain</type>
            <size>2893</size>
            <attacher name="Mark Lam">mark.lam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM1NjAwKQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA
CisyMDE4LTA5LTAzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD
YWxsRnJhbWU6OnVuc2FmZUNhbGxlZSgpIHNob3VsZCB1c2UgYW4gQVNBTiBzdXBwcmVzc2VkIFJl
Z2lzdGVyOjphc2FuVW5zYWZlUG9pbnRlcigpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5MjQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgKiBpbnRlcnByZXRlci9DYWxsRnJhbWUuaDoKKyAgICAgICAg
KEpTQzo6RXhlY1N0YXRlOjp1bnNhZmVDYWxsZWUgY29uc3QpOgorICAgICAgICAqIGludGVycHJl
dGVyL1JlZ2lzdGVyLmg6CisgICAgICAgIChKU0M6OlJlZ2lzdGVyOjphc2FuVW5zYWZlUG9pbnRl
ciBjb25zdCk6CisKIDIwMTgtMDktMDIgIFl1c3VrZSBTdXp1a2kgIDx5dXN1a2VzdXp1a2lAc2xv
d3N0YXJ0Lm9yZz4KIAogICAgICAgICBJbXBsZW1lbnQgT2JqZWN0LmZyb21FbnRyaWVzCkluZGV4
OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvQ2FsbEZyYW1lLmgKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0NhbGxGcmFtZS5oCShyZXZp
c2lvbiAyMzU2MDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvQ2FsbEZy
YW1lLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwNiw3ICsxMDYsNyBAQCBuYW1lc3BhY2UgSlNDICB7
CiAgICAgICAgICAgICByZXR1cm4gdGhpc1tDYWxsRnJhbWVTbG90OjpjYWxsZWVdLm9iamVjdCgp
OwogICAgICAgICB9CiAgICAgICAgIENhbGxlZUJpdHMgY2FsbGVlKCkgY29uc3QgeyByZXR1cm4g
Q2FsbGVlQml0cyh0aGlzW0NhbGxGcmFtZVNsb3Q6OmNhbGxlZV0ucG9pbnRlcigpKTsgfQotICAg
ICAgICBTVVBQUkVTU19BU0FOIENhbGxlZUJpdHMgdW5zYWZlQ2FsbGVlKCkgY29uc3QgeyByZXR1
cm4gQ2FsbGVlQml0cyh0aGlzW0NhbGxGcmFtZVNsb3Q6OmNhbGxlZV0ucG9pbnRlcigpKTsgfQor
ICAgICAgICBTVVBQUkVTU19BU0FOIENhbGxlZUJpdHMgdW5zYWZlQ2FsbGVlKCkgY29uc3QgeyBy
ZXR1cm4gQ2FsbGVlQml0cyh0aGlzW0NhbGxGcmFtZVNsb3Q6OmNhbGxlZV0uYXNhblVuc2FmZVBv
aW50ZXIoKSk7IH0KICAgICAgICAgQ29kZUJsb2NrKiBjb2RlQmxvY2soKSBjb25zdCB7IHJldHVy
biB0aGlzW0NhbGxGcmFtZVNsb3Q6OmNvZGVCbG9ja10uUmVnaXN0ZXI6OmNvZGVCbG9jaygpOyB9
CiAgICAgICAgIENvZGVCbG9jayoqIGFkZHJlc3NPZkNvZGVCbG9jaygpIGNvbnN0IHsgcmV0dXJu
IGJpdHdpc2VfY2FzdDxDb2RlQmxvY2sqKj4odGhpcyArIENhbGxGcmFtZVNsb3Q6OmNvZGVCbG9j
ayk7IH0KICAgICAgICAgU1VQUFJFU1NfQVNBTiBDb2RlQmxvY2sqIHVuc2FmZUNvZGVCbG9jaygp
IGNvbnN0IHsgcmV0dXJuIHRoaXNbQ2FsbEZyYW1lU2xvdDo6Y29kZUJsb2NrXS5SZWdpc3Rlcjo6
YXNhblVuc2FmZUNvZGVCbG9jaygpOyB9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50
ZXJwcmV0ZXIvUmVnaXN0ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv
aW50ZXJwcmV0ZXIvUmVnaXN0ZXIuaAkocmV2aXNpb24gMjM1NjAwKQorKysgU291cmNlL0phdmFT
Y3JpcHRDb3JlL2ludGVycHJldGVyL1JlZ2lzdGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTEsNSAr
MSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA4LCAyMDA5IEFwcGxlIEluYy4gQWxsIHJp
Z2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAwOC0yMDE4IEFwcGxlIEluYy4gQWxs
IHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJj
ZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJl
IHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtNzcs
NiArNzcsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgaW50MzJfdCYgdGFnKCk7CiAKICAg
ICAgICAgdm9pZCogcG9pbnRlcigpIGNvbnN0OworICAgICAgICB2b2lkKiBhc2FuVW5zYWZlUG9p
bnRlcigpIGNvbnN0OwogCiAgICAgICAgIHN0YXRpYyBSZWdpc3RlciB3aXRoSW50KGludDMyX3Qg
aSkKICAgICAgICAgewpAQCAtMjA2LDYgKzIwNywxNSBAQCBuYW1lc3BhY2UgSlNDIHsKICNlbmRp
ZgogICAgIH0KIAorICAgIFNVUFBSRVNTX0FTQU4gQUxXQVlTX0lOTElORSB2b2lkKiBSZWdpc3Rl
cjo6YXNhblVuc2FmZVBvaW50ZXIoKSBjb25zdAorICAgIHsKKyNpZiBVU0UoSlNWQUxVRTY0KQor
ICAgICAgICByZXR1cm4gdS5lbmNvZGVkVmFsdWUucHRyOworI2Vsc2UKKyAgICAgICAgcmV0dXJu
IGJpdHdpc2VfY2FzdDx2b2lkKj4ocGF5bG9hZCgpKTsKKyNlbmRpZgorICAgIH0KKwogICAgIEFM
V0FZU19JTkxJTkUgaW50MzJfdCBSZWdpc3Rlcjo6cGF5bG9hZCgpIGNvbnN0CiAgICAgewogICAg
ICAgICByZXR1cm4gdS5lbmNvZGVkVmFsdWUuYXNCaXRzLnBheWxvYWQ7Cg==
</data>
<flag name="review"
          id="366391"
          type_id="1"
          status="-"
          setter="mark.lam"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>348789</attachid>
            <date>2018-09-03 13:45:31 -0700</date>
            <delta_ts>2018-09-03 16:29:43 -0700</delta_ts>
            <desc>proposed patch.</desc>
            <filename>bug-189247.patch</filename>
            <type>text/plain</type>
            <size>3499</size>
            <attacher name="Mark Lam">mark.lam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM1NjAxKQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA
CisyMDE4LTA5LTAzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD
YWxsRnJhbWU6OnVuc2FmZUNhbGxlZSgpIHNob3VsZCB1c2UgYW4gQVNBTiBzdXBwcmVzc2VkIFJl
Z2lzdGVyOjphc2FuVW5zYWZlUG9pbnRlcigpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5MjQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgKiBpbnRlcnByZXRlci9DYWxsRnJhbWUuaDoKKyAgICAgICAg
KEpTQzo6RXhlY1N0YXRlOjp1bnNhZmVDYWxsZWUgY29uc3QpOgorICAgICAgICAqIGludGVycHJl
dGVyL1JlZ2lzdGVyLmg6CisgICAgICAgIChKU0M6OlJlZ2lzdGVyOjphc2FuVW5zYWZlUG9pbnRl
ciBjb25zdCk6CisgICAgICAgIChKU0M6OlJlZ2lzdGVyOjp1bnNhZmVQYXlsb2FkIGNvbnN0KToK
KwogMjAxOC0wOS0wMiAgWXVzdWtlIFN1enVraSAgPHl1c3VrZXN1enVraUBzbG93c3RhcnQub3Jn
PgogCiAgICAgICAgIEltcGxlbWVudCBPYmplY3QuZnJvbUVudHJpZXMKSW5kZXg6IFNvdXJjZS9K
YXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9DYWxsRnJhbWUuaAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvQ2FsbEZyYW1lLmgJKHJldmlzaW9uIDIzNTYw
MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9DYWxsRnJhbWUuaAkod29y
a2luZyBjb3B5KQpAQCAtMTA2LDcgKzEwNiw3IEBAIG5hbWVzcGFjZSBKU0MgIHsKICAgICAgICAg
ICAgIHJldHVybiB0aGlzW0NhbGxGcmFtZVNsb3Q6OmNhbGxlZV0ub2JqZWN0KCk7CiAgICAgICAg
IH0KICAgICAgICAgQ2FsbGVlQml0cyBjYWxsZWUoKSBjb25zdCB7IHJldHVybiBDYWxsZWVCaXRz
KHRoaXNbQ2FsbEZyYW1lU2xvdDo6Y2FsbGVlXS5wb2ludGVyKCkpOyB9Ci0gICAgICAgIFNVUFBS
RVNTX0FTQU4gQ2FsbGVlQml0cyB1bnNhZmVDYWxsZWUoKSBjb25zdCB7IHJldHVybiBDYWxsZWVC
aXRzKHRoaXNbQ2FsbEZyYW1lU2xvdDo6Y2FsbGVlXS5wb2ludGVyKCkpOyB9CisgICAgICAgIFNV
UFBSRVNTX0FTQU4gQ2FsbGVlQml0cyB1bnNhZmVDYWxsZWUoKSBjb25zdCB7IHJldHVybiBDYWxs
ZWVCaXRzKHRoaXNbQ2FsbEZyYW1lU2xvdDo6Y2FsbGVlXS5hc2FuVW5zYWZlUG9pbnRlcigpKTsg
fQogICAgICAgICBDb2RlQmxvY2sqIGNvZGVCbG9jaygpIGNvbnN0IHsgcmV0dXJuIHRoaXNbQ2Fs
bEZyYW1lU2xvdDo6Y29kZUJsb2NrXS5SZWdpc3Rlcjo6Y29kZUJsb2NrKCk7IH0KICAgICAgICAg
Q29kZUJsb2NrKiogYWRkcmVzc09mQ29kZUJsb2NrKCkgY29uc3QgeyByZXR1cm4gYml0d2lzZV9j
YXN0PENvZGVCbG9jayoqPih0aGlzICsgQ2FsbEZyYW1lU2xvdDo6Y29kZUJsb2NrKTsgfQogICAg
ICAgICBTVVBQUkVTU19BU0FOIENvZGVCbG9jayogdW5zYWZlQ29kZUJsb2NrKCkgY29uc3QgeyBy
ZXR1cm4gdGhpc1tDYWxsRnJhbWVTbG90Ojpjb2RlQmxvY2tdLlJlZ2lzdGVyOjphc2FuVW5zYWZl
Q29kZUJsb2NrKCk7IH0KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9S
ZWdpc3Rlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRl
ci9SZWdpc3Rlci5oCShyZXZpc2lvbiAyMzU2MDEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv
aW50ZXJwcmV0ZXIvUmVnaXN0ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8q
Ci0gKiBDb3B5cmlnaHQgKEMpIDIwMDgsIDIwMDkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy
dmVkLgorICogQ29weXJpZ2h0IChDKSAyMDA4LTIwMTggQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJl
c2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5h
cnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVk
IHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC03MiwxMSArNzIsMTMg
QEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIEpTQ2VsbCogdW5ib3hlZENlbGwoKSBjb25zdDsK
ICAgICAgICAgaW50MzJfdCBwYXlsb2FkKCkgY29uc3Q7CiAgICAgICAgIGludDMyX3QgdGFnKCkg
Y29uc3Q7CisgICAgICAgIGludDMyX3QgdW5zYWZlUGF5bG9hZCgpIGNvbnN0OwogICAgICAgICBp
bnQzMl90IHVuc2FmZVRhZygpIGNvbnN0OwogICAgICAgICBpbnQzMl90JiBwYXlsb2FkKCk7CiAg
ICAgICAgIGludDMyX3QmIHRhZygpOwogCiAgICAgICAgIHZvaWQqIHBvaW50ZXIoKSBjb25zdDsK
KyAgICAgICAgdm9pZCogYXNhblVuc2FmZVBvaW50ZXIoKSBjb25zdDsKIAogICAgICAgICBzdGF0
aWMgUmVnaXN0ZXIgd2l0aEludChpbnQzMl90IGkpCiAgICAgICAgIHsKQEAgLTIwNiw2ICsyMDgs
MTUgQEAgbmFtZXNwYWNlIEpTQyB7CiAjZW5kaWYKICAgICB9CiAKKyAgICBTVVBQUkVTU19BU0FO
IEFMV0FZU19JTkxJTkUgdm9pZCogUmVnaXN0ZXI6OmFzYW5VbnNhZmVQb2ludGVyKCkgY29uc3QK
KyAgICB7CisjaWYgVVNFKEpTVkFMVUU2NCkKKyAgICAgICAgcmV0dXJuIHUuZW5jb2RlZFZhbHVl
LnB0cjsKKyNlbHNlCisgICAgICAgIHJldHVybiBiaXR3aXNlX2Nhc3Q8dm9pZCo+KHVuc2FmZVBh
eWxvYWQoKSk7CisjZW5kaWYKKyAgICB9CisKICAgICBBTFdBWVNfSU5MSU5FIGludDMyX3QgUmVn
aXN0ZXI6OnBheWxvYWQoKSBjb25zdAogICAgIHsKICAgICAgICAgcmV0dXJuIHUuZW5jb2RlZFZh
bHVlLmFzQml0cy5wYXlsb2FkOwpAQCAtMjE2LDYgKzIyNywxMSBAQCBuYW1lc3BhY2UgSlNDIHsK
ICAgICAgICAgcmV0dXJuIHUuZW5jb2RlZFZhbHVlLmFzQml0cy50YWc7CiAgICAgfQogCisgICAg
U1VQUFJFU1NfQVNBTiBBTFdBWVNfSU5MSU5FIGludDMyX3QgUmVnaXN0ZXI6OnVuc2FmZVBheWxv
YWQoKSBjb25zdAorICAgIHsKKyAgICAgICAgcmV0dXJuIHUuZW5jb2RlZFZhbHVlLmFzQml0cy5w
YXlsb2FkOworICAgIH0KKwogICAgIFNVUFBSRVNTX0FTQU4gQUxXQVlTX0lOTElORSBpbnQzMl90
IFJlZ2lzdGVyOjp1bnNhZmVUYWcoKSBjb25zdAogICAgIHsKICAgICAgICAgcmV0dXJuIHUuZW5j
b2RlZFZhbHVlLmFzQml0cy50YWc7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>