189243 2018-09-03 06:02:12 -0700 [WPE][GTK] Add more unused result warnings to JSC API 2018-09-04 07:49:05 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro webkit-unassigned bugs-noreply cgarcia commit-queue ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam oldest_to_newest 1456155 0 mcatanzaro 2018-09-03 06:02:12 -0700 Add more unused result warnings to JSC API, as suggested by Carlos Garcia 1456156 1 348767 mcatanzaro 2018-09-03 06:04:42 -0700 Created attachment 348767 [WPE][GTK] Add more unused result warnings to JSC API 1456157 2 348767 cgarcia 2018-09-03 06:12:37 -0700 Comment on attachment 348767 [WPE][GTK] Add more unused result warnings to JSC API What about jsc_value_constructor_call and jsc_value_constructor_callv? Is it more obvious that you should get a value in those cases? 1456165 3 mcatanzaro 2018-09-03 06:48:47 -0700 Nope, I just grepped for "evaluate" because you suggested that one, I didn't consider jsc_value_constructor_call(). Will add it there too 1456168 4 mcatanzaro 2018-09-03 06:51:36 -0700 Wait, no, it is indeed more obvious that you should get a value from those, because they're constructors. Why would you call a constructor and not expect to get a value. :P So yes, it's not needed there IMO. 1456303 5 348767 commit-queue 2018-09-04 07:49:03 -0700 Comment on attachment 348767 [WPE][GTK] Add more unused result warnings to JSC API Clearing flags on attachment: 348767 Committed r235612: <https://trac.webkit.org/changeset/235612> 1456304 6 commit-queue 2018-09-04 07:49:05 -0700 All reviewed patches have been landed. Closing bug. 348767 2018-09-03 06:04:42 -0700 2018-09-04 07:49:03 -0700 [WPE][GTK] Add more unused result warnings to JSC API bug-189243-20180903080441.patch text/plain 2711 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 ZDVlMmUzNmZmMzllYjM0OWI4MGU0NTA3MGNkMjU0N2Y5MTM5ZmRjLi45NWQyODJlODljZDE1MDhk ZTVlNTY4NGQwNTRkYjIzYTRmZjM1MWViIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOC0wOS0wMyAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGln YWxpYS5jb20+CisKKyAgICAgICAgW1dQRV1bR1RLXSBBZGQgbW9yZSB1bnVzZWQgcmVzdWx0IHdh cm5pbmdzIHRvIEpTQyBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4OTI0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSBqc2NfY29udGV4dF9ldmFsdWF0ZSgpIGZhbWlseSBvZiBmdW5jdGlvbnMg aGFzIGEgKHRyYW5zZmVyIGZ1bGwpIHJldHVybiB2YWx1ZSwgYnV0IHRoZQorICAgICAgICBjYWxs ZXIgbWF5IGJlIHRlbXB0ZWQgdG8gbm90IGluc3BlY3QgaXQgaWYgdW5pbnRlcmVzdGVkIGluIHRo ZSByZXR1cm4gdmFsdWUuIFRoaXMgd291bGQgYmUKKyAgICAgICAgYW4gZXJyb3IsIGJlY2F1c2Ug aXQgbXVzdCBiZSBmcmVlZC4KKworICAgICAgICAqIEFQSS9nbGliL0pTQ0NvbnRleHQuaDoKKwog MjAxOC0wOC0zMSAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4 IGV4Y2VwdGlvbiBjaGVjayBhY2NvdW50aW5nIGluIGNvbnN0cnVjdEpTV2ViQXNzZW1ibHlDb21w aWxlRXJyb3IoKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvZ2xpYi9K U0NDb250ZXh0LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL2dsaWIvSlNDQ29udGV4dC5o CmluZGV4IGU0NjQ5NGUzODQ5NWYyZGQzZDFjNzcwNTBhMTViY2VmZmEzZTliNTkuLjA2NzNmZmE1 ODliZTU2NTAyNDUxNDIwNmE0NzViN2Q2NDUxMjAxMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9BUEkvZ2xpYi9KU0NDb250ZXh0LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0FQSS9nbGliL0pTQ0NvbnRleHQuaApAQCAtMTM1LDE0ICsxMzUsMTQgQEAganNjX2NvbnRl eHRfZ2V0X2N1cnJlbnQgICAgICAgICAgICAgICh2b2lkKTsKIEpTQ19BUEkgSlNDVmFsdWUgKgog anNjX2NvbnRleHRfZXZhbHVhdGUgICAgICAgICAgICAgICAgIChKU0NDb250ZXh0ICAgICAgICAg KmNvbnRleHQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGNo YXIgICAgICAgICAqY29kZSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Z3NzaXplICAgICAgICAgICAgICBsZW5ndGgpOworICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBnc3NpemUgICAgICAgICAgICAgIGxlbmd0aCkgR19HTlVDX1dBUk5fVU5VU0VE X1JFU1VMVDsKIAogSlNDX0FQSSBKU0NWYWx1ZSAqCiBqc2NfY29udGV4dF9ldmFsdWF0ZV93aXRo X3NvdXJjZV91cmkgKEpTQ0NvbnRleHQgICAgICAgICAqY29udGV4dCwKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgY2hhciAgICAgICAgICpjb2RlLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnc3NpemUgICAgICAgICAgICAgIGxlbmd0 aCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgY2hhciAgICAg ICAgICp1cmksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGd1aW50ICAg ICAgICAgICAgICAgbGluZV9udW1iZXIpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBndWludCAgICAgICAgICAgICAgIGxpbmVfbnVtYmVyKSBHX0dOVUNfV0FSTl9VTlVT RURfUkVTVUxUOwogCiBKU0NfQVBJIEpTQ1ZhbHVlICoKIGpzY19jb250ZXh0X2V2YWx1YXRlX2lu X29iamVjdCAgICAgICAoSlNDQ29udGV4dCAgICAgICAgICpjb250ZXh0LApAQCAtMTUyLDcgKzE1 Miw3IEBAIGpzY19jb250ZXh0X2V2YWx1YXRlX2luX29iamVjdCAgICAgICAoSlNDQ29udGV4dCAg ICAgICAgICpjb250ZXh0LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBK U0NDbGFzcyAgICAgICAgICAgKm9iamVjdF9jbGFzcywKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgY29uc3QgY2hhciAgICAgICAgICp1cmksCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGd1aW50ICAgICAgICAgICAgICAgbGluZV9udW1iZXIsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEpTQ1ZhbHVlICAgICAgICAgICoq b2JqZWN0KTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSlNDVmFsdWUg ICAgICAgICAgKipvYmplY3QpIEdfR05VQ19XQVJOX1VOVVNFRF9SRVNVTFQ7CiAKIEpTQ19BUEkg SlNDQ2hlY2tTeW50YXhSZXN1bHQKIGpzY19jb250ZXh0X2NoZWNrX3N5bnRheCAgICAgICAgICAg ICAoSlNDQ29udGV4dCAgICAgICAgICpjb250ZXh0LAo=