<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>189233</bug_id>
          
          <creation_ts>2018-09-02 09:19:14 -0700</creation_ts>
          <short_desc>[macOS] REGRESSION (r235398): Can’t run-safari: crash on launch in WKPageSetPageLoaderClient</short_desc>
          <delta_ts>2018-09-03 01:34:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit API</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>189190</dup_id>
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=188997</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=189234</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Regression</keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>mitz</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>achristensen</cc>
    
    <cc>ap</cc>
    
    <cc>fred.wang</cc>
    
    <cc>thorton</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1456045</commentid>
    <comment_count>0</comment_count>
    <who name="">mitz</who>
    <bug_when>2018-09-02 09:19:14 -0700</bug_when>
    <thetext>Safari can’t run with a Debug build of r235583:

$ run-safari 
Starting SafariForWebKitDevelopment with DYLD_FRAMEWORK_PATH set to point to built WebKit in […]Debug.
ASSERTION FAILED: !m_client.didFinishDocumentLoadForFrame
/Projects/Safari/OpenSource/Source/WebKit/UIProcess/API/C/WKPage.cpp(1047) : WKPageSetPageLoaderClient(WKPageRef, const WKPageLoaderClientBase *)::LoaderClient::LoaderClient(const WKPageLoaderClientBase *)
1   0x10f428da9 WTFCrash
2   0x11400d3fb WTFCrashWithInfo(int, char const*, char const*, int)
3   0x115196374 WKPageSetPageLoaderClient::LoaderClient::LoaderClient(WKPageLoaderClientBase const*)
4   0x1151962bd WKPageSetPageLoaderClient::LoaderClient::LoaderClient(WKPageLoaderClientBase const*)
5   0x11518f95d WKPageSetPageLoaderClient
6   0x7fff573f0e8e Safari::WK::Page::setPageLoaderClient(Safari::WK::PageLoaderClient*) const
[…]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456046</commentid>
    <comment_count>1</comment_count>
    <who name="">mitz</who>
    <bug_when>2018-09-02 09:21:32 -0700</bug_when>
    <thetext>This is with Safari from macOS High Sierra 10.13.6.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456062</commentid>
    <comment_count>2</comment_count>
    <who name="">mitz</who>
    <bug_when>2018-09-02 10:00:52 -0700</bug_when>
    <thetext>Release builds crash as well:

0   com.apple.WebKit              	0x000000010c86b313 WTFCrashWithInfo(int, char const*, char const*, int) + 19 (Assertions.h:551)
1   com.apple.WebKit              	0x000000010cc4995b WKPageSetPageLoaderClient + 680 (Assertions.h:570)
2   com.apple.Safari.framework    	0x00007fff573f0e8e Safari::WK::Page::setPageLoaderClient(Safari::WK::PageLoaderClient*) const + 56</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456064</commentid>
    <comment_count>3</comment_count>
    <who name="">mitz</who>
    <bug_when>2018-09-02 10:12:22 -0700</bug_when>
    <thetext>Caused by &lt;https://trac.webkit.org/r235398&gt;, the change made for bug 188997.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456097</commentid>
    <comment_count>4</comment_count>
    <who name="Tim Horton">thorton</who>
    <bug_when>2018-09-02 15:32:57 -0700</bug_when>
    <thetext>Is this the same as https://bugs.webkit.org/show_bug.cgi?id=189190</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456098</commentid>
    <comment_count>5</comment_count>
    <who name="">mitz</who>
    <bug_when>2018-09-02 15:34:25 -0700</bug_when>
    <thetext>(In reply to Tim Horton from comment #4)
&gt; Is this the same as https://bugs.webkit.org/show_bug.cgi?id=189190

Seems so.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456126</commentid>
    <comment_count>6</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-03 01:34:19 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 189190 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>