189203 2018-08-31 12:50:18 -0700 Compile error in RealtimeOutgoingVideoSource.cpp; unused parameter in libwebrtc header 2018-09-07 12:39:33 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue darin webkit-bug-importer youennf oldest_to_newest 1455809 0 jer.noble 2018-08-31 12:50:18 -0700 Compile error in RealtimeOutgoingVideoSource.cpp; unused parameter in libwebrtc header 1455813 1 348665 jer.noble 2018-08-31 12:52:12 -0700 Created attachment 348665 Patch 1455888 2 348665 commit-queue 2018-08-31 16:22:55 -0700 Comment on attachment 348665 Patch Clearing flags on attachment: 348665 Committed r235575: <https://trac.webkit.org/changeset/235575> 1455889 3 commit-queue 2018-08-31 16:22:57 -0700 All reviewed patches have been landed. Closing bug. 1455890 4 webkit-bug-importer 2018-08-31 16:23:16 -0700 <rdar://problem/43960652> 1456005 5 darin 2018-09-01 21:29:56 -0700 Would be nice to eventually change this in libwebrtc itself unless there is some reason the header has to have an unused parameter in it. Even if the libwebrtc project itself doesn’t want to compile with this warning, it’s nice for headers at least to be compatible with it. 1457629 6 youennf 2018-09-07 12:39:33 -0700 (In reply to Darin Adler from comment #5) > Would be nice to eventually change this in libwebrtc itself unless there is > some reason the header has to have an unused parameter in it. Even if the > libwebrtc project itself doesn’t want to compile with this warning, it’s > nice for headers at least to be compatible with it. We started discussing with the project upstream but there is no concrete plan yet there. I am not sure how tractable it would be for the upstream project to make the headers compatible without actually enforcing this at compile time. We were previously patching these files but this proved to be a hurdle for every libwebrtc refresh. We should probably try to reduce WebCore dependency on libwebrtc headers. 348665 2018-08-31 12:52:12 -0700 2018-08-31 16:22:55 -0700 Patch bug-189203-20180831125212.patch text/plain 1609 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGY2OGFmNGQxYzQwOTAy OTk1YmM4YTEyNDkwN2U4YjBjZjliZjBmNi4uYTdiZDM3YjBlODc5ZGI2MGQ5ZGEyZjNkNjU0OTUz ZmYwNjJjNWYyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA4LTMxICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIENvbXBpbGUgZXJyb3IgaW4g UmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlLmNwcDsgdW51c2VkIHBhcmFtZXRlciBpbiBsaWJ3 ZWJydGMgaGVhZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODkyMDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJZiBSZWFsdGltZU91dGdvaW5nVmlkZW9Tb3VyY2UuY3BwIGlzIGNvbXBpbGVkIGFsb25l IChub24tdW5pZmllZCkgb3IgaWYgaXQgaXMgdGhlIGZpcnN0IGZpbGUgY29tcGlsZWQgaW4KKyAg ICAgICAgYSB1bmlmaWVkIGJ1aWxkLCB0aGVyZSBpcyBubyBwcmFnbWEgc2V0IHRvIGlnbm9yZSB1 bnVzZWQgcGFyYW1ldGVyIHdhcm5pbmdzIGluIHBsYWNlLgorCisgICAgICAgICogcGxhdGZvcm0v bWVkaWFzdHJlYW0vUmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlLmNwcDoKKwogMjAxOC0wOC0y OSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgVVNF X01FRElBUkVNT1RFIG9uIGlPUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWVkaWFzdHJlYW0vUmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL1JlYWx0aW1lT3V0Z29pbmdWaWRlb1NvdXJjZS5jcHAK aW5kZXggNTQ0YTQ0MzZjZTQxNzExYjJhZmMyYjRjZjUyMGY5MGJhZGIyZWE2Mi4uMTRhOGU5NGJk MmI4YThiM2U4ZWFlZjcwN2MxNmNkZjBjNjBlN2IxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vUmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9SZWFsdGltZU91dGdvaW5n VmlkZW9Tb3VyY2UuY3BwCkBAIC0zMiw4ICszMiwxNSBAQAogI2lmIFVTRShMSUJXRUJSVEMpCiAK ICNpbmNsdWRlICJMb2dnaW5nLmgiCisKKyNwcmFnbWEgR0NDIGRpYWdub3N0aWMgcHVzaAorI3By YWdtYSBHQ0MgZGlhZ25vc3RpYyBpZ25vcmVkICItV3VudXNlZC1wYXJhbWV0ZXIiCisKICNpbmNs dWRlIDx3ZWJydGMvYXBpL3ZpZGVvL2k0MjBfYnVmZmVyLmg+CiAjaW5jbHVkZSA8d2VicnRjL2Nv bW1vbl92aWRlby9saWJ5dXYvaW5jbHVkZS93ZWJydGNfbGlieXV2Lmg+CisKKyNwcmFnbWEgR0ND IGRpYWdub3N0aWMgcG9wCisKICNpbmNsdWRlIDx3dGYvTWFpblRocmVhZC5oPgogCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7Cg==