<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>189190</bug_id>
          
          <creation_ts>2018-08-31 05:36:39 -0700</creation_ts>
          <short_desc>REGRESSION(r235398) ASSERTION failure !m_client.didFinishDocumentLoadForFrame</short_desc>
          <delta_ts>2018-09-04 11:32:23 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=189234</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Frédéric Wang Nélar">fred.wang</reporter>
          <assigned_to name="Frédéric Wang Nélar">fred.wang</assigned_to>
          <cc>achristensen</cc>
    
    <cc>ap</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>dbates</cc>
    
    <cc>mitz</cc>
    
    <cc>rwlbuis</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1455662</commentid>
    <comment_count>0</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-08-31 05:36:39 -0700</bug_when>
    <thetext>There are assertions in the deprecated WKPageSetPageLoaderClient class after bug 188997 ; it seems they are currently hit when running build with the external SDK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1455666</commentid>
    <comment_count>1</comment_count>
      <attachid>348636</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-08-31 05:53:48 -0700</bug_when>
    <thetext>Created attachment 348636
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1455728</commentid>
    <comment_count>2</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2018-08-31 09:59:31 -0700</bug_when>
    <thetext>I assume this is when you run system safari with your build of WebKit.  Does Safari work well enough with this WebKit?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1455730</commentid>
    <comment_count>3</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2018-08-31 10:01:23 -0700</bug_when>
    <thetext>This would be more correct if it were a version check to see if you&apos;re on Mojave or before.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1455740</commentid>
    <comment_count>4</comment_count>
      <attachid>348636</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2018-08-31 10:19:56 -0700</bug_when>
    <thetext>Comment on attachment 348636
Patch

I mean, we would want to not assert if you&apos;re on Mojave or before just to work with system safari.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1455751</commentid>
    <comment_count>5</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-08-31 10:32:01 -0700</bug_when>
    <thetext>(In reply to Alex Christensen from comment #2)
&gt; I assume this is when you run system safari with your build of WebKit.  Does
&gt; Safari work well enough with this WebKit?

I&apos;m just doing run-safari [--ios-simulator] using the public SDK, so AFAIK yes it is the system one.

(In reply to Alex Christensen from comment #3)
&gt; This would be more correct if it were a version check to see if you&apos;re on
&gt; Mojave or before.

Right, I&apos;ll try to see how to do that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1455752</commentid>
    <comment_count>6</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2018-08-31 10:32:53 -0700</bug_when>
    <thetext>Also, if you could get it to use Safari Tech Preview instead of Safari, that would probably fix it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1455996</commentid>
    <comment_count>7</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2018-09-01 19:47:18 -0700</bug_when>
    <thetext>Is &quot;Mojave or before&quot; the right check, or is it actually about Safari 11.x?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456124</commentid>
    <comment_count>8</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-03 01:19:30 -0700</bug_when>
    <thetext>(In reply to Alex Christensen from comment #6)
&gt; Also, if you could get it to use Safari Tech Preview instead of Safari, that
&gt; would probably fix it.

I think I&apos;ve never been able to make run-webkit-app work ; I just tried again and Safari Tech Preview does not seem to use the local build. Also, in any case that&apos;s not an option for running Safari on the iOS simulator.

(In reply to Alexey Proskuryakov from comment #7)
&gt; Is &quot;Mojave or before&quot; the right check, or is it actually about Safari 11.x?

Good question. Comment 6 seems to suggest it&apos;s about the Safari version, not the OS so probably we should try that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456127</commentid>
    <comment_count>9</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-03 01:34:19 -0700</bug_when>
    <thetext>*** Bug 189233 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456129</commentid>
    <comment_count>10</comment_count>
      <attachid>348762</attachid>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-03 01:39:34 -0700</bug_when>
    <thetext>Created attachment 348762
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456130</commentid>
    <comment_count>11</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-03 01:40:49 -0700</bug_when>
    <thetext>I&apos;ve updated the patch to use a OS version check (I&apos;m not sure how to check Safari&apos;s version). I hope it&apos;s good enough.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456332</commentid>
    <comment_count>12</comment_count>
      <attachid>348822</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2018-09-04 09:50:23 -0700</bug_when>
    <thetext>Created attachment 348822
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456334</commentid>
    <comment_count>13</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2018-09-04 09:53:17 -0700</bug_when>
    <thetext>I made the check for Mojave or before rather than add a bundle check for Safari.  That should be good enough for the open source developers checking their work with Safari until the next release.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456362</commentid>
    <comment_count>14</comment_count>
      <attachid>348822</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-09-04 10:28:36 -0700</bug_when>
    <thetext>Comment on attachment 348822
patch

Clearing flags on attachment: 348822

Committed r235618: &lt;https://trac.webkit.org/changeset/235618&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456363</commentid>
    <comment_count>15</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-09-04 10:28:38 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456364</commentid>
    <comment_count>16</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-09-04 10:29:19 -0700</bug_when>
    <thetext>&lt;rdar://problem/44102173&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456378</commentid>
    <comment_count>17</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-04 11:10:46 -0700</bug_when>
    <thetext>(In reply to WebKit Commit Bot from comment #14)
&gt; Comment on attachment 348822 [details]
&gt; patch
&gt; 
&gt; Clearing flags on attachment: 348822
&gt; 
&gt; Committed r235618: &lt;https://trac.webkit.org/changeset/235618&gt;

@Alex: Any reason why you removed the condition &quot;PLATFORM(IOS) &amp;&amp; __IPHONE_OS_VERSION_MIN_REQUIRED &gt;= 120000&quot;? It seems the landed commit will still fail to make &quot;run-safari --ios-simulator&quot; work for open source developers...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456379</commentid>
    <comment_count>18</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2018-09-04 11:11:52 -0700</bug_when>
    <thetext>iOS Safari never used WKPageSetPageLoaderClient :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1456389</commentid>
    <comment_count>19</comment_count>
    <who name="Frédéric Wang Nélar">fred.wang</who>
    <bug_when>2018-09-04 11:32:23 -0700</bug_when>
    <thetext>OK, maybe I mixed up the other day because bug 189188 happened at the same time.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>348636</attachid>
            <date>2018-08-31 05:53:48 -0700</date>
            <delta_ts>2018-09-03 01:39:30 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-189190-20180831145346.patch</filename>
            <type>text/plain</type>
            <size>2030</size>
            <attacher name="Frédéric Wang Nélar">fred.wang</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY4MmQ5ZjRlZTJmODYzYTJj
MzYzZjZlYTViOTMxN2I4NWE0NjVmNzMuLjY1MzJkOTZjMjA5MWQ0NzBhMzYzMDQ2NDBlMzVkODk3
NDQ4ZjZhNzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDgtMzEgIEZyZWRlcmlj
IFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIzNTM5OCkg
QVNTRVJUSU9OIGZhaWx1cmUgaW4gV0tQYWdlU2V0UGFnZUxvYWRlckNsaWVudCB3aXRoIGV4dGVy
bmFsIFNESyBidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTg5MTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgQXNzZXJ0aW9ucyB0byBwcmV2ZW50IHVzZSBvZiB0aGUgZGVwcmVjYXRlZCBXS1BhZ2VT
ZXRQYWdlTG9hZGVyQ2xpZW50IGNsYXNzIGFyZSBoaXQgd2hlbgorICAgICAgICBydW5uaW5nIFNh
ZmFyaSBidWlsZHMgd2l0aCB0aGUgZXh0ZXJuYWwgU0RLLiBUaGlzIHBhdGNoIGNvbmRpdGlvbmFs
bHkgc2tpcHMgdGhlc2UgYXNzZXJ0aW9ucy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9X
S1BhZ2UuY3BwOgorICAgICAgICAoV0tQYWdlU2V0UGFnZUxvYWRlckNsaWVudCk6CisKIDIwMTgt
MDgtMzEgIEZyZWRlcmljIFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgogCiAgICAgICAgIEJ1ZyAx
ODIwNTMgLSBbQ1NTT00gVmlld10gSW1wbGVtZW50IHN0YW5kYXJkIGJlaGF2aW9yIGZvciBzY3Jv
bGxpbmdFbGVtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9X
S1BhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcAppbmRl
eCAwMzk5NzQxYTJlMmUxYmQxNTM0YWQ1OTJmYmIzMDBmZTEwYjNmYTcyLi4xMzRiNDZiM2QwNzdl
ODU0NDg0MTJjZjg4MjQyZjQ1OTI4OTNhYzg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ
UHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ
SS9DL1dLUGFnZS5jcHAKQEAgLTEwNDQsNiArMTA0NCw3IEBAIHZvaWQgV0tQYWdlU2V0UGFnZUxv
YWRlckNsaWVudChXS1BhZ2VSZWYgcGFnZVJlZiwgY29uc3QgV0tQYWdlTG9hZGVyQ2xpZW50QmFz
ZSoKICAgICAgICAgICAgIGluaXRpYWxpemUoY2xpZW50KTsKICAgICAgICAgICAgIAogICAgICAg
ICAgICAgLy8gV0tQYWdlU2V0UGFnZUxvYWRlckNsaWVudCBpcyBkZXByZWNhdGVkLiBVc2UgV0tQ
YWdlU2V0UGFnZU5hdmlnYXRpb25DbGllbnQgaW5zdGVhZC4KKyNpZiBVU0UoQVBQTEVfSU5URVJO
QUxfU0RLKQogICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQoIW1fY2xpZW50LmRpZEZpbmlzaERv
Y3VtZW50TG9hZEZvckZyYW1lKTsKICAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUKCFtX2NsaWVu
dC5kaWRTYW1lRG9jdW1lbnROYXZpZ2F0aW9uRm9yRnJhbWUpOwogICAgICAgICAgICAgUkVMRUFT
RV9BU1NFUlQoIW1fY2xpZW50LmRpZFJlY2VpdmVUaXRsZUZvckZyYW1lKTsKQEAgLTEwNzUsNiAr
MTA3Niw3IEBAIHZvaWQgV0tQYWdlU2V0UGFnZUxvYWRlckNsaWVudChXS1BhZ2VSZWYgcGFnZVJl
ZiwgY29uc3QgV0tQYWdlTG9hZGVyQ2xpZW50QmFzZSoKICAgICAgICAgICAgIFJFTEVBU0VfQVNT
RVJUKCFtX2NsaWVudC5uYXZpZ2F0aW9uR2VzdHVyZURpZEJlZ2luKTsKICAgICAgICAgICAgIFJF
TEVBU0VfQVNTRVJUKCFtX2NsaWVudC5uYXZpZ2F0aW9uR2VzdHVyZVdpbGxFbmQpOwogICAgICAg
ICAgICAgUkVMRUFTRV9BU1NFUlQoIW1fY2xpZW50Lm5hdmlnYXRpb25HZXN0dXJlRGlkRW5kKTsK
KyNlbmRpZgogICAgICAgICB9CiAKICAgICBwcml2YXRlOgo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>348762</attachid>
            <date>2018-09-03 01:39:34 -0700</date>
            <delta_ts>2018-09-04 09:50:23 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-189190-20180903103932.patch</filename>
            <type>text/plain</type>
            <size>2241</size>
            <attacher name="Frédéric Wang Nélar">fred.wang</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE0Mzk3ZDJmZDY0NGZmZDEx
ZTIwN2EyOTllNDM5MmM0OTMyMTdhMDUuLmFkYzNlMDBjN2E0MzU4Y2FlMmQ0MTkwOTI2ODg2NDM1
ZDA4MTM5NjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMDktMDMgIEZyZWRlcmlj
IFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgorCisgICAgICAgIEJ1ZyAxODkxOTAgLSBSRUdSRVNT
SU9OKHIyMzUzOTgpIEFTU0VSVElPTiBmYWlsdXJlICFtX2NsaWVudC5kaWRGaW5pc2hEb2N1bWVu
dExvYWRGb3JGcmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTg5MTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg
ICAgICAgQXNzZXJ0aW9ucyB0byBwcmV2ZW50IHVzZSBvZiB0aGUgZGVwcmVjYXRlZCBXS1BhZ2VT
ZXRQYWdlTG9hZGVyQ2xpZW50IGNsYXNzIGFyZSBoaXQgd2hlbgorICAgICAgICBydW5uaW5nIHN5
c3RlbSBTYWZhcmkgd2l0aCB0aGUgY3VycmVudCBtYWNPUy9pT1MgcmVsZWFzZXMsIG1ha2luZyBp
bXBvc3NpYmxlIHRvIGxhdW5jaCBpdC4KKyAgICAgICAgVGhpcyBwYXRjaCBjb25kaXRpb25hbGx5
IHNraXBzIHRoZXNlIGFzc2VydGlvbnMgc28gdGhhdCB0aGV5IGFyZSBvbmx5IHZlcmlmaWVkIGZv
cgorICAgICAgICBtYWNPUyA+PSAxMC4xNCBhbmQgaU9TID49IDEyLgorCisgICAgICAgICogVUlQ
cm9jZXNzL0FQSS9DL1dLUGFnZS5jcHA6CisgICAgICAgIChXS1BhZ2VTZXRQYWdlTG9hZGVyQ2xp
ZW50KTogT25seSBhc3NlcnQgb24gZnV0dXJlIE9TIHJlbGVhc2VzLgorCiAyMDE4LTA5LTAxICBE
YXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBbQ0ZOZXR3b3JrXSBVcGRh
dGUgQ0ZOZXR3b3JrIFNQSSB1c2UgdG8gdXNlIENGTmV0d29ya1NQSS5oIG1vcmUgY29uc2lzdGVu
dGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3Bw
IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcAppbmRleCA1MTVjYWNi
NDIyNGZjMzU1ZjJjOGFiZjJkNTNmZjMxZjliYjlmOTcwLi45NGMxMzFhMTI0OTUwYWYxNjlhN2Vm
MjE0YTYzYWYyNDJmNWVmYzZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B
UEkvQy9XS1BhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLUGFn
ZS5jcHAKQEAgLTEwNDMsNiArMTA0Myw3IEBAIHZvaWQgV0tQYWdlU2V0UGFnZUxvYWRlckNsaWVu
dChXS1BhZ2VSZWYgcGFnZVJlZiwgY29uc3QgV0tQYWdlTG9hZGVyQ2xpZW50QmFzZSoKICAgICAg
ICAgewogICAgICAgICAgICAgaW5pdGlhbGl6ZShjbGllbnQpOwogICAgICAgICAgICAgCisjaWYg
KFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE0
MDApIHx8IChQTEFURk9STShJT1MpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVE
ID49IDEyMDAwMCkKICAgICAgICAgICAgIC8vIFdLUGFnZVNldFBhZ2VMb2FkZXJDbGllbnQgaXMg
ZGVwcmVjYXRlZC4gVXNlIFdLUGFnZVNldFBhZ2VOYXZpZ2F0aW9uQ2xpZW50IGluc3RlYWQuCiAg
ICAgICAgICAgICBSRUxFQVNFX0FTU0VSVCghbV9jbGllbnQuZGlkRmluaXNoRG9jdW1lbnRMb2Fk
Rm9yRnJhbWUpOwogICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQoIW1fY2xpZW50LmRpZFNhbWVE
b2N1bWVudE5hdmlnYXRpb25Gb3JGcmFtZSk7CkBAIC0xMDc1LDYgKzEwNzYsNyBAQCB2b2lkIFdL
UGFnZVNldFBhZ2VMb2FkZXJDbGllbnQoV0tQYWdlUmVmIHBhZ2VSZWYsIGNvbnN0IFdLUGFnZUxv
YWRlckNsaWVudEJhc2UqCiAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVCghbV9jbGllbnQubmF2
aWdhdGlvbkdlc3R1cmVEaWRCZWdpbik7CiAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVCghbV9j
bGllbnQubmF2aWdhdGlvbkdlc3R1cmVXaWxsRW5kKTsKICAgICAgICAgICAgIFJFTEVBU0VfQVNT
RVJUKCFtX2NsaWVudC5uYXZpZ2F0aW9uR2VzdHVyZURpZEVuZCk7CisjZW5kaWYKICAgICAgICAg
fQogCiAgICAgcHJpdmF0ZToK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>348822</attachid>
            <date>2018-09-04 09:50:23 -0700</date>
            <delta_ts>2018-09-04 10:28:36 -0700</delta_ts>
            <desc>patch</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>2179</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE0Mzk3ZDJmZDY0NGZmZDEx
ZTIwN2EyOTllNDM5MmM0OTMyMTdhMDUuLmFkYzNlMDBjN2E0MzU4Y2FlMmQ0MTkwOTI2ODg2NDM1
ZDA4MTM5NjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMDktMDMgIEZyZWRlcmlj
IFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgorCisgICAgICAgIEJ1ZyAxODkxOTAgLSBSRUdSRVNT
SU9OKHIyMzUzOTgpIEFTU0VSVElPTiBmYWlsdXJlICFtX2NsaWVudC5kaWRGaW5pc2hEb2N1bWVu
dExvYWRGb3JGcmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MTg5MTkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleCBDaHJpc3RlbnNlbi4KKwor
ICAgICAgICBBc3NlcnRpb25zIHRvIHByZXZlbnQgdXNlIG9mIHRoZSBkZXByZWNhdGVkIFdLUGFn
ZVNldFBhZ2VMb2FkZXJDbGllbnQgY2xhc3MgYXJlIGhpdCB3aGVuCisgICAgICAgIHJ1bm5pbmcg
c3lzdGVtIFNhZmFyaSB3aXRoIHRoZSBjdXJyZW50IG1hY09TL2lPUyByZWxlYXNlcywgbWFraW5n
IGltcG9zc2libGUgdG8gbGF1bmNoIGl0LgorICAgICAgICBUaGlzIHBhdGNoIGNvbmRpdGlvbmFs
bHkgc2tpcHMgdGhlc2UgYXNzZXJ0aW9ucyBzbyB0aGF0IHRoZXkgYXJlIG9ubHkgdmVyaWZpZWQg
Zm9yCisgICAgICAgIG1hY09TID4gMTAuMTQgb3Igb3RoZXIgcGxhdGZvcm1zLgorCisgICAgICAg
ICogVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHA6CisgICAgICAgIChXS1BhZ2VTZXRQYWdlTG9h
ZGVyQ2xpZW50KTogT25seSBhc3NlcnQgb24gZnV0dXJlIE9TIHJlbGVhc2VzLgorCiAyMDE4LTA5
LTAxICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBbQ0ZOZXR3b3Jr
XSBVcGRhdGUgQ0ZOZXR3b3JrIFNQSSB1c2UgdG8gdXNlIENGTmV0d29ya1NQSS5oIG1vcmUgY29u
c2lzdGVudGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS1Bh
Z2UuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcAppbmRleCA1
MTVjYWNiNDIyNGZjMzU1ZjJjOGFiZjJkNTNmZjMxZjliYjlmOTcwLi45NGMxMzFhMTI0OTUwYWYx
NjlhN2VmMjE0YTYzYWYyNDJmNWVmYzZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJv
Y2Vzcy9BUEkvQy9XS1BhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9D
L1dLUGFnZS5jcHAKQEAgLTEwNDMsNiArMTA0Myw3IEBAIHZvaWQgV0tQYWdlU2V0UGFnZUxvYWRl
ckNsaWVudChXS1BhZ2VSZWYgcGFnZVJlZiwgY29uc3QgV0tQYWdlTG9hZGVyQ2xpZW50QmFzZSoK
ICAgICAgICAgewogICAgICAgICAgICAgaW5pdGlhbGl6ZShjbGllbnQpOwogICAgICAgICAgICAg
CisjaWYgIVBMQVRGT1JNKE1BQykgfHwgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+
IDEwMTQwMAogICAgICAgICAgICAgLy8gV0tQYWdlU2V0UGFnZUxvYWRlckNsaWVudCBpcyBkZXBy
ZWNhdGVkLiBVc2UgV0tQYWdlU2V0UGFnZU5hdmlnYXRpb25DbGllbnQgaW5zdGVhZC4KICAgICAg
ICAgICAgIFJFTEVBU0VfQVNTRVJUKCFtX2NsaWVudC5kaWRGaW5pc2hEb2N1bWVudExvYWRGb3JG
cmFtZSk7CiAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVCghbV9jbGllbnQuZGlkU2FtZURvY3Vt
ZW50TmF2aWdhdGlvbkZvckZyYW1lKTsKQEAgLTEwNzUsNiArMTA3Niw3IEBAIHZvaWQgV0tQYWdl
U2V0UGFnZUxvYWRlckNsaWVudChXS1BhZ2VSZWYgcGFnZVJlZiwgY29uc3QgV0tQYWdlTG9hZGVy
Q2xpZW50QmFzZSoKICAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUKCFtX2NsaWVudC5uYXZpZ2F0
aW9uR2VzdHVyZURpZEJlZ2luKTsKICAgICAgICAgICAgIFJFTEVBU0VfQVNTRVJUKCFtX2NsaWVu
dC5uYXZpZ2F0aW9uR2VzdHVyZVdpbGxFbmQpOwogICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlQo
IW1fY2xpZW50Lm5hdmlnYXRpb25HZXN0dXJlRGlkRW5kKTsKKyNlbmRpZgogICAgICAgICB9CiAK
ICAgICBwcml2YXRlOg==
</data>

          </attachment>
      

    </bug>

</bugzilla>