189185 2018-08-31 00:06:21 -0700 Fix exception check accounting in constructJSWebAssemblyCompileError(). 2018-09-04 11:53:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue ews-watchlist keith_miller msaboff realdawei saam webkit-bug-importer oldest_to_newest 1455593 0 mark.lam 2018-08-31 00:06:21 -0700 <rdar://problem/39786007> 1455595 1 348616 mark.lam 2018-08-31 00:15:19 -0700 Created attachment 348616 proposed patch. 1455720 2 348616 msaboff 2018-08-31 09:47:15 -0700 Comment on attachment 348616 proposed patch. r=me 1455732 3 348616 commit-queue 2018-08-31 10:12:39 -0700 Comment on attachment 348616 proposed patch. Clearing flags on attachment: 348616 Committed r235558: <https://trac.webkit.org/changeset/235558> 1455733 4 commit-queue 2018-08-31 10:12:40 -0700 All reviewed patches have been landed. Closing bug. 1455785 5 348616 saam 2018-08-31 11:30:46 -0700 Comment on attachment 348616 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=348616&action=review > Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp:51 > + auto* error = JSWebAssemblyCompileError::create(exec, vm, structure->globalObject()->WebAssemblyCompileErrorStructure(), result.error()); Why would creating the exception throw an exception? 1455848 6 mark.lam 2018-08-31 14:01:41 -0700 (In reply to Saam Barati from comment #5) > Comment on attachment 348616 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=348616&action=review > > > Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp:51 > > + auto* error = JSWebAssemblyCompileError::create(exec, vm, structure->globalObject()->WebAssemblyCompileErrorStructure(), result.error()); > > Why would creating the exception throw an exception? See "static JSWebAssemblyCompileError* create(ExecState* exec, VM& vm, Structure* structure, JSValue message)" in JSWebAssemblyCompileError.h. It calls message.toWTFString(exec) which can throw. 1455869 7 saam 2018-08-31 14:54:39 -0700 (In reply to Mark Lam from comment #6) > (In reply to Saam Barati from comment #5) > > Comment on attachment 348616 [details] > > proposed patch. > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=348616&action=review > > > > > Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.cpp:51 > > > + auto* error = JSWebAssemblyCompileError::create(exec, vm, structure->globalObject()->WebAssemblyCompileErrorStructure(), result.error()); > > > > Why would creating the exception throw an exception? > > See "static JSWebAssemblyCompileError* create(ExecState* exec, VM& vm, > Structure* structure, JSValue message)" in JSWebAssemblyCompileError.h. It > calls message.toWTFString(exec) which can throw. Ok, makes sense. 1456369 8 realdawei 2018-09-04 10:55:31 -0700 Reopening to attach new patch. 1456370 9 348827 realdawei 2018-09-04 10:55:32 -0700 Created attachment 348827 Patch 1456403 10 348827 commit-queue 2018-09-04 11:53:54 -0700 Comment on attachment 348827 Patch Clearing flags on attachment: 348827 Committed r235624: <https://trac.webkit.org/changeset/235624> 1456404 11 commit-queue 2018-09-04 11:53:55 -0700 All reviewed patches have been landed. Closing bug. 348616 2018-08-31 00:15:19 -0700 2018-09-04 11:03:32 -0700 proposed patch. bug-189185.patch text/plain 3624 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzU1MzcpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE4LTA4LTMxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggZXhjZXB0aW9uIGNoZWNrIGFjY291bnRpbmcgaW4gY29uc3RydWN0 SlNXZWJBc3NlbWJseUNvbXBpbGVFcnJvcigpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg5MTg1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zOTc4 NjAwNz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHN0cmVzcy9yZWdyZXNzLTE4OTE4NS5qczogQWRkZWQuCisgICAgICAgIChuZXcuV2ViQXNzZW1i bHkuQ29tcGlsZUVycm9yLnZhbHVlT2YpOgorCiAyMDE4LTA4LTMwICBTYWFtIGJhcmF0aSAgPHNi YXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIENTRSBEYXRhVmlld0dldCogREZHIG5vZGVzCklu ZGV4OiBKU1Rlc3RzL3N0cmVzcy9yZWdyZXNzLTE4OTE4NS5qcwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rl c3RzL3N0cmVzcy9yZWdyZXNzLTE4OTE4NS5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0 cmVzcy9yZWdyZXNzLTE4OTE4NS5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDcgQEAKKy8v QCBydW5EZWZhdWx0CisvLyBUaGlzIHBhc3NlcyBpZiBpdCBkb2VzIG5vdCBjcmFzaC4KK25ldyBX ZWJBc3NlbWJseS5Db21waWxlRXJyb3IoeworICAgIHZhbHVlT2YoKSB7CisgICAgICAgIHRocm93 IG5ldyBFcnJvcigpOworICAgIH0KK30pOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShy ZXZpc2lvbiAyMzU0OTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDgtMzEgIE1hcmsgTGFtICA8bWFyay5s YW1AYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBleGNlcHRpb24gY2hlY2sgYWNjb3VudGluZyBp biBjb25zdHJ1Y3RKU1dlYkFzc2VtYmx5Q29tcGlsZUVycm9yKCkuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkxODUKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzM5Nzg2MDA3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFsc28gYWRkIGFuIGV4Y2VwdGlvbiBjaGVjayBpbiBKU1dlYkFzc2VtYmx5TW9k dWxlOjpjcmVhdGVTdHViKCkgc28gdGhhdCB3ZSBkb24ndAorICAgICAgICBpbmFkdmVydGVudGx5 IG92ZXJ3cml0ZSBhIHByZS1leGlzdGluZyBleGNlcHRpb24gKGlmIHByZXNlbnQpLgorCisgICAg ICAgICogd2FzbS9qcy9KU1dlYkFzc2VtYmx5TW9kdWxlLmNwcDoKKyAgICAgICAgKEpTQzo6SlNX ZWJBc3NlbWJseU1vZHVsZTo6Y3JlYXRlU3R1Yik6CisgICAgICAgICogd2FzbS9qcy9XZWJBc3Nl bWJseUNvbXBpbGVFcnJvckNvbnN0cnVjdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6Y29uc3RydWN0 SlNXZWJBc3NlbWJseUNvbXBpbGVFcnJvcik6CisKIDIwMTgtMDgtMjkgIE1hcmsgTGFtICA8bWFy ay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzb21lIG1pc3NpbmcgZXhjZXB0aW9uIGNo ZWNrcyBpbiBKU1JvcGVTdHJpbmc6OnJlc29sdmVSb3BlVG9BdG9taWNTdHJpbmcoKS4KSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL2pzL0pTV2ViQXNzZW1ibHlNb2R1bGUuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL2pzL0pTV2ViQXNzZW1ibHlN b2R1bGUuY3BwCShyZXZpc2lvbiAyMzU0OTApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2Fz bS9qcy9KU1dlYkFzc2VtYmx5TW9kdWxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDgsNyArNDgs OSBAQCBKU1dlYkFzc2VtYmx5TW9kdWxlKiBKU1dlYkFzc2VtYmx5TW9kdWxlCiB7CiAgICAgYXV0 byBzY29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOwogICAgIGlmICghcmVzdWx0Lmhhc192 YWx1ZSgpKSB7Ci0gICAgICAgIHRocm93RXhjZXB0aW9uKGV4ZWMsIHNjb3BlLCBKU1dlYkFzc2Vt Ymx5Q29tcGlsZUVycm9yOjpjcmVhdGUoZXhlYywgdm0sIHN0cnVjdHVyZS0+Z2xvYmFsT2JqZWN0 KCktPldlYkFzc2VtYmx5Q29tcGlsZUVycm9yU3RydWN0dXJlKCksIHJlc3VsdC5lcnJvcigpKSk7 CisgICAgICAgIGF1dG8qIGVycm9yID0gSlNXZWJBc3NlbWJseUNvbXBpbGVFcnJvcjo6Y3JlYXRl KGV4ZWMsIHZtLCBzdHJ1Y3R1cmUtPmdsb2JhbE9iamVjdCgpLT5XZWJBc3NlbWJseUNvbXBpbGVF cnJvclN0cnVjdHVyZSgpLCByZXN1bHQuZXJyb3IoKSk7CisgICAgICAgIFJFVFVSTl9JRl9FWENF UFRJT04oc2NvcGUsIG51bGxwdHIpOworICAgICAgICB0aHJvd0V4Y2VwdGlvbihleGVjLCBzY29w ZSwgZXJyb3IpOwogICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAgICB9CiAKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS93YXNtL2pzL1dlYkFzc2VtYmx5Q29tcGlsZUVycm9yQ29uc3RydWN0 b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL2pzL1dlYkFz c2VtYmx5Q29tcGlsZUVycm9yQ29uc3RydWN0b3IuY3BwCShyZXZpc2lvbiAyMzU0OTApCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9qcy9XZWJBc3NlbWJseUNvbXBpbGVFcnJvckNvbnN0 cnVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTEsNiArNTEsNyBAQCBzdGF0aWMgRW5jb2Rl ZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBjb25zCiAgICAgSlNWYWx1ZSBtZXNzYWdlID0gZXhlYy0+ YXJndW1lbnQoMCk7CiAgICAgYXV0byogc3RydWN0dXJlID0gSW50ZXJuYWxGdW5jdGlvbjo6Y3Jl YXRlU3ViY2xhc3NTdHJ1Y3R1cmUoZXhlYywgZXhlYy0+bmV3VGFyZ2V0KCksIGpzQ2FzdDxJbnRl cm5hbEZ1bmN0aW9uKj4oZXhlYy0+anNDYWxsZWUoKSktPmdsb2JhbE9iamVjdCh2bSktPldlYkFz c2VtYmx5Q29tcGlsZUVycm9yU3RydWN0dXJlKCkpOwogICAgIFJFVFVSTl9JRl9FWENFUFRJT04o c2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOworICAgIHNjb3BlLnJlbGVhc2UoKTsKICAgICByZXR1 cm4gSlNWYWx1ZTo6ZW5jb2RlKEpTV2ViQXNzZW1ibHlDb21waWxlRXJyb3I6OmNyZWF0ZShleGVj LCB2bSwgc3RydWN0dXJlLCBtZXNzYWdlKSk7CiB9CiAK 348827 2018-09-04 10:55:32 -0700 2018-09-04 11:53:54 -0700 Patch bug-189185-20180904105531.patch text/plain 987 realdawei U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NjE3CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDhlNzUyMzYzYjk5NmQ3YWEwMjM1OTI4MTMyYTZk MmRkNTNkYjE2ODAuLjU3N2YyNmNlMGQ2ZTE2OTNkODg2ZDk3MDQxNzg1M2IyYWY5ODc0MDMgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMTgtMDktMDQgIERhdmlkIEZlbnRvbiAgPGRhdmlkX2ZlbnRvbkBhcHBs ZS5jb20+CisKKyAgICAgICAgU2tpcCBUZXN0IG9uIDMyLWJpdCBwbGF0Zm9ybXMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODkxODUuCisKKyAgICAg ICAgVW5yZXZpZXdlZCB0ZXN0IGdhcmRlbmluZy4KKworICAgICAgICAqIHN0cmVzcy9yZWdyZXNz LTE4OTE4NS5qczoKKwogMjAxOC0wOS0wMyAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+ CiAKICAgICAgICAgVGhlIHdhdGNoZG9nIHNvbWV0aW1lcyBmYWlscyB0byB0ZXJtaW5hdGUgYSBz Y3JpcHQuCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9yZWdyZXNzLTE4OTE4NS5qcyBiL0pT VGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTg5MTg1LmpzCmluZGV4IGQ2N2Y5ZDQxYjIyN2UzN2ExMDZj NjI4ZTc2MjQzODI5YWM2YWExMjIuLmMwMTZlZmQyNjg2ODU4ZjUxOWQzNzMwZjZmMDVlMGQyZmRl NmRhNTkgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTg5MTg1LmpzCisrKyBi L0pTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTg5MTg1LmpzCkBAIC0xLDQgKzEsNSBAQAogLy9AIHJ1 bkRlZmF1bHQKKy8vQCBza2lwIGlmICRhcmNoaXRlY3R1cmUgPT0gIng4NiIKIC8vIFRoaXMgcGFz c2VzIGlmIGl0IGRvZXMgbm90IGNyYXNoLgogbmV3IFdlYkFzc2VtYmx5LkNvbXBpbGVFcnJvcih7 CiAgICAgdmFsdWVPZigpIHsK