189184 2018-08-30 23:25:24 -0700 Add missing exception check in arrayProtoFuncLastIndexOf(). 2018-08-31 01:40:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue ews-watchlist keith_miller msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1455582 0 mark.lam 2018-08-30 23:25:24 -0700 <rdar://problem/39785959> 1455586 1 348611 mark.lam 2018-08-30 23:31:22 -0700 Created attachment 348611 proposed patch. 1455588 2 348612 mark.lam 2018-08-30 23:48:26 -0700 Created attachment 348612 proposed patch. 1455608 3 348612 ysuzuki 2018-08-31 01:14:56 -0700 Comment on attachment 348612 proposed patch. r=me 1455612 4 348612 commit-queue 2018-08-31 01:40:43 -0700 Comment on attachment 348612 proposed patch. Clearing flags on attachment: 348612 Committed r235540: <https://trac.webkit.org/changeset/235540> 1455613 5 commit-queue 2018-08-31 01:40:44 -0700 All reviewed patches have been landed. Closing bug. 348611 2018-08-30 23:31:22 -0700 2018-08-30 23:48:26 -0700 proposed patch. bug-189184.patch text/plain 2362 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzU1MzcpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTA4LTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBBZGQgbWlzc2luZyBleGNlcHRpb24gY2hlY2sgaW4gYXJyYXlQcm90b0Z1 bmNMYXN0SW5kZXhPZigpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg5MTg0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zOTc4NTk1OT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9yZWdy ZXNzLTE4OTE4NC5qczogQWRkZWQuCisKIDIwMTgtMDgtMzAgIFNhYW0gYmFyYXRpICA8c2JhcmF0 aUBhcHBsZS5jb20+CiAKICAgICAgICAgQ1NFIERhdGFWaWV3R2V0KiBERkcgbm9kZXMKSW5kZXg6 IEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTg5MTg0LmpzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMv c3RyZXNzL3JlZ3Jlc3MtMTg5MTg0LmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNz L3JlZ3Jlc3MtMTg5MTg0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMiBAQAorLy8gVGhp cyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2VzIG5vdCBjcmFzaC4KK1snYScrMF0ubGFzdEluZGV4T2Yo J2EwJyk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNTQ5MSkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNCBAQAorMjAxOC0wOC0zMCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAg ICAgICAgQWRkIG1pc3NpbmcgZXhjZXB0aW9uIGNoZWNrIGluIGFycmF5UHJvdG9GdW5jTGFzdElu ZGV4T2YoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE4OTE4NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzk3ODU5NTk+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL0FycmF5UHJvdG90 eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6YXJyYXlQcm90b0Z1bmNMYXN0SW5kZXhPZik6CisKIDIw MTgtMDgtMjkgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBz b21lIG1pc3NpbmcgZXhjZXB0aW9uIGNoZWNrcyBpbiBKU1JvcGVTdHJpbmc6OnJlc29sdmVSb3Bl VG9BdG9taWNTdHJpbmcoKS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Fy cmF5UHJvdG90eXBlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9BcnJheVByb3RvdHlwZS5jcHAJKHJldmlzaW9uIDIzNTQ5MCkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MTIxNSw5ICsxMjE1LDEwIEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgYXJyYXlQcm90 b0YKICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZW5jb2RlZEpTVmFsdWUoKSk7 CiAgICAgICAgIGlmICghZSkKICAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICBpZiAoSlNW YWx1ZTo6c3RyaWN0RXF1YWwoZXhlYywgc2VhcmNoRWxlbWVudCwgZSkpCi0gICAgICAgICAgICBy ZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzTnVtYmVyKGluZGV4KSk7CisgICAgICAgIGJvb2wgaXNF cXVhbCA9IEpTVmFsdWU6OnN0cmljdEVxdWFsKGV4ZWMsIHNlYXJjaEVsZW1lbnQsIGUpOwogICAg ICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBlbmNvZGVkSlNWYWx1ZSgpKTsKKyAgICAg ICAgaWYgKGlzRXF1YWwpCisgICAgICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzTnVt YmVyKGluZGV4KSk7CiAgICAgfSB3aGlsZSAoaW5kZXgtLSk7CiAKICAgICByZXR1cm4gSlNWYWx1 ZTo6ZW5jb2RlKGpzTnVtYmVyKC0xKSk7Cg== 348612 2018-08-30 23:48:26 -0700 2018-08-31 01:40:43 -0700 proposed patch. bug-189184.patch text/plain 2378 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzU1MzcpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTA4LTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBBZGQgbWlzc2luZyBleGNlcHRpb24gY2hlY2sgaW4gYXJyYXlQcm90b0Z1 bmNMYXN0SW5kZXhPZigpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg5MTg0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zOTc4NTk1OT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9yZWdy ZXNzLTE4OTE4NC5qczogQWRkZWQuCisKIDIwMTgtMDgtMzAgIFNhYW0gYmFyYXRpICA8c2JhcmF0 aUBhcHBsZS5jb20+CiAKICAgICAgICAgQ1NFIERhdGFWaWV3R2V0KiBERkcgbm9kZXMKSW5kZXg6 IEpTVGVzdHMvc3RyZXNzL3JlZ3Jlc3MtMTg5MTg0LmpzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMv c3RyZXNzL3JlZ3Jlc3MtMTg5MTg0LmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNz L3JlZ3Jlc3MtMTg5MTg0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMyBAQAorLy9AIHJ1 bkRlZmF1bHQKKy8vIFRoaXMgdGVzdCBwYXNzZXMgaWYgaXQgZG9lcyBub3QgY3Jhc2guCitbJ2En KzBdLmxhc3RJbmRleE9mKCdhMCcpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZp c2lvbiAyMzU0OTEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDgtMzAgIE1hcmsgTGFtICA8bWFyay5sYW1A YXBwbGUuY29tPgorCisgICAgICAgIEFkZCBtaXNzaW5nIGV4Y2VwdGlvbiBjaGVjayBpbiBhcnJh eVByb3RvRnVuY0xhc3RJbmRleE9mKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODkxODQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM5Nzg1OTU5 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVu dGltZS9BcnJheVByb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OmFycmF5UHJvdG9GdW5jTGFz dEluZGV4T2YpOgorCiAyMDE4LTA4LTI5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4K IAogICAgICAgICBBZGQgc29tZSBtaXNzaW5nIGV4Y2VwdGlvbiBjaGVja3MgaW4gSlNSb3BlU3Ry aW5nOjpyZXNvbHZlUm9wZVRvQXRvbWljU3RyaW5nKCkuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwCShyZXZpc2lvbiAyMzU0OTAp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTEyMTUsOSArMTIxNSwxMCBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9T VF9DQUxMIGFycmF5UHJvdG9GCiAgICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGVu Y29kZWRKU1ZhbHVlKCkpOwogICAgICAgICBpZiAoIWUpCiAgICAgICAgICAgICBjb250aW51ZTsK LSAgICAgICAgaWYgKEpTVmFsdWU6OnN0cmljdEVxdWFsKGV4ZWMsIHNlYXJjaEVsZW1lbnQsIGUp KQotICAgICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc051bWJlcihpbmRleCkpOwor ICAgICAgICBib29sIGlzRXF1YWwgPSBKU1ZhbHVlOjpzdHJpY3RFcXVhbChleGVjLCBzZWFyY2hF bGVtZW50LCBlKTsKICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZW5jb2RlZEpT VmFsdWUoKSk7CisgICAgICAgIGlmIChpc0VxdWFsKQorICAgICAgICAgICAgcmV0dXJuIEpTVmFs dWU6OmVuY29kZShqc051bWJlcihpbmRleCkpOwogICAgIH0gd2hpbGUgKGluZGV4LS0pOwogCiAg ICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc051bWJlcigtMSkpOwo=