189149 2018-08-30 00:15:51 -0700 [ConnectionUnix] Shrink sizeof AttachmentInfo by reordering members 2018-08-30 07:03:25 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yoshiaki.jitsukawa webkit-unassigned commit-queue don.olmstead mcatanzaro webkit-bug-importer yoshiaki.jitsukawa ysuzuki zan oldest_to_newest 1455175 0 yoshiaki.jitsukawa 2018-08-30 00:15:51 -0700 Shrink sizeof AttachmentInfo by reordering members. It is not possible to pack AttachmentInfo up to attachmentMaxAmount(255) within messageMaxSize(4096 bytes). 1455177 1 348489 yoshiaki.jitsukawa 2018-08-30 00:26:11 -0700 Created attachment 348489 Patch 1455198 2 348489 mcatanzaro 2018-08-30 06:35:23 -0700 Comment on attachment 348489 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=348489&action=review > Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:93 > +static_assert(sizeof(MessageInfo) + sizeof(AttachmentInfo) * attachmentMaxAmount <= messageMaxSize, "messageMaxSize is too small."); Oh wow, good catch 1455202 3 348489 commit-queue 2018-08-30 07:01:56 -0700 Comment on attachment 348489 Patch Clearing flags on attachment: 348489 Committed r235499: <https://trac.webkit.org/changeset/235499> 1455203 4 commit-queue 2018-08-30 07:01:57 -0700 All reviewed patches have been landed. Closing bug. 1455204 5 webkit-bug-importer 2018-08-30 07:03:25 -0700 <rdar://problem/43884387> 348489 2018-08-30 00:26:11 -0700 2018-08-30 07:01:56 -0700 Patch bug-189149-20180830162609.patch text/plain 1744 yoshiaki.jitsukawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjM1NDkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQzY2NjNGE2Nzk3NTU3YTQw MWIxNjU5MGIzNGFmMzY4YmM0ZjdmMWUuLjNkY2NjY2QwZDQ2N2RlYzJiNTcxYmYxOGEwY2M5NjU2 MjFjYzA2OWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTgtMDgtMzAgIFlvc2hpYWtp IEppdHN1a2F3YSAgPHlvc2hpYWtpLmppdHN1a2F3YUBzb255LmNvbT4KKworICAgICAgICBbQ29u bmVjdGlvblVuaXhdIFNocmluayBzaXplb2YgQXR0YWNobWVudEluZm8gYnkgcmVvcmRlcmluZyBt ZW1iZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODkxNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZW9yZGVyIG1lbWJlcnMgdG8gc2hyaW5rIHRoZSBzaXplIG9mIEF0dGFjaG1lbnRJbmZvIHNvIHRo YXQKKyAgICAgICAgd2UgY2FuIGF0dGFjaCBtb3JlIGF0dGFjaG1lbnRzLiAKKworICAgICAgICAq IFBsYXRmb3JtL0lQQy91bml4L0Nvbm5lY3Rpb25Vbml4LmNwcDoKKwogMjAxOC0wOC0yOSAgQWxl eCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmVy dCBzb21lIG9mIHIyMzUzOTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBD L3VuaXgvQ29ubmVjdGlvblVuaXguY3BwIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvdW5p eC9Db25uZWN0aW9uVW5peC5jcHAKaW5kZXggM2M0NjM5NGUyZTNkMzQ3NTJiYmM2NmQxYTU1MjUy YWJiYzM3MDg1ZS4uOWMzODAwNDZkZGJhZjQ1ZjgyZWQ0ZDY5Zjg1YmEyZDkzZjY2OTVhNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvdW5peC9Db25uZWN0aW9uVW5peC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvdW5peC9Db25uZWN0aW9uVW5peC5j cHAKQEAgLTU5LDcgKzU5LDcgQEAKIG5hbWVzcGFjZSBJUEMgewogCiBzdGF0aWMgY29uc3Qgc2l6 ZV90IG1lc3NhZ2VNYXhTaXplID0gNDA5NjsKLXN0YXRpYyBjb25zdCBzaXplX3QgYXR0YWNobWVu dE1heEFtb3VudCA9IDI1NTsKK3N0YXRpYyBjb25zdCBzaXplX3QgYXR0YWNobWVudE1heEFtb3Vu dCA9IDI1NDsKIAogY2xhc3MgQXR0YWNobWVudEluZm8gewogICAgIFdURl9NQUtFX0ZBU1RfQUxM T0NBVEVEOwpAQCAtODYsMTAgKzg2LDEyIEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICAgICBBdHRh Y2htZW50OjpUeXBlIG1fdHlwZSB7IEF0dGFjaG1lbnQ6OlVuaW5pdGlhbGl6ZWQgfTsKLSAgICBz aXplX3QgbV9zaXplIHsgMCB9OwogICAgIGJvb2wgbV9pc051bGwgeyBmYWxzZSB9OworICAgIHNp emVfdCBtX3NpemUgeyAwIH07CiB9OwogCitzdGF0aWNfYXNzZXJ0KHNpemVvZihNZXNzYWdlSW5m bykgKyBzaXplb2YoQXR0YWNobWVudEluZm8pICogYXR0YWNobWVudE1heEFtb3VudCA8PSBtZXNz YWdlTWF4U2l6ZSwgIm1lc3NhZ2VNYXhTaXplIGlzIHRvbyBzbWFsbC4iKTsKKwogdm9pZCBDb25u ZWN0aW9uOjpwbGF0Zm9ybUluaXRpYWxpemUoSWRlbnRpZmllciBpZGVudGlmaWVyKQogewogICAg IG1fc29ja2V0RGVzY3JpcHRvciA9IGlkZW50aWZpZXI7Cg==